Re: [llvm-commits] [llvm] r43578 - /llvm/trunk/lib/VMCore/Verifier.cpp

2007-10-31 Thread Chris Lattner
On Oct 31, 2007, at 2:04 PM, Owen Anderson wrote: > Author: resistor > Date: Wed Oct 31 16:04:18 2007 > New Revision: 43578 > > URL: http://llvm.org/viewvc/llvm-project?rev=43578&view=rev > Log: > Add a preverifier pass to check that every basic block ends in a > terminator, so that we don't se

Re: [llvm-commits] [llvm] r43578 - /llvm/trunk/lib/VMCore/Verifier.cpp

2007-10-31 Thread Devang Patel
On Oct 31, 2007, at 2:30 PM, Anton Korobeynikov wrote: > >> Why can't you check this at the beginning of >> Verifier::visitBasicBlock() ? > I think due to this: > >> AU.addRequired(); > > DomTree crashes on invalid CFG. aha. ok. - Devang ___ llvm-commi

Re: [llvm-commits] [llvm] r43578 - /llvm/trunk/lib/VMCore/Verifier.cpp

2007-10-31 Thread Anton Korobeynikov
> Why can't you check this at the beginning of > Verifier::visitBasicBlock() ? I think due to this: >AU.addRequired(); DomTree crashes on invalid CFG. -- With best regards, Anton Korobeynikov. Faculty of Mathematics & Mechanics, Saint Petersburg State University. _

Re: [llvm-commits] [llvm] r43578 - /llvm/trunk/lib/VMCore/Verifier.cpp

2007-10-31 Thread Devang Patel
Why can't you check this at the beginning of Verifier::visitBasicBlock() ? - Devang // verifyBasicBlock - Verify that a basic block is well formed... // void Verifier::visitBasicBlock(BasicBlock &BB) { On Oct 31, 2007, at 2:04 PM, Owen Anderson wrote: > Author: resistor > Date: Wed Oct 31 16:0

[llvm-commits] [llvm] r43578 - /llvm/trunk/lib/VMCore/Verifier.cpp

2007-10-31 Thread Owen Anderson
Author: resistor Date: Wed Oct 31 16:04:18 2007 New Revision: 43578 URL: http://llvm.org/viewvc/llvm-project?rev=43578&view=rev Log: Add a preverifier pass to check that every basic block ends in a terminator, so that we don't segfault when verifying invalid code. Modified: llvm/trunk/lib/VM