Re: [llvm-commits] [llvm] r43918 - in /llvm/trunk/lib/Target/X86: X86RegisterInfo.cpp X86RegisterInfo.td

2007-11-09 Thread Dale Johannesen
On Nov 9, 2007, at 9:03 AM, Chris Lattner wrote: > On Nov 9, 2007, at 8:55 AM, Evan Cheng wrote: >> Frankly I don't think the issue is worth spending this much time on. >> Whatever works and maintainable is good. > > I'd prefer to use one switch statement form or the other. The > compiler should b

Re: [llvm-commits] [llvm] r43918 - in /llvm/trunk/lib/Target/X86: X86RegisterInfo.cpp X86RegisterInfo.td

2007-11-09 Thread Chris Lattner
On Nov 9, 2007, at 8:55 AM, Evan Cheng wrote: > Since I gave bad advice last time, how about one more advice? :-) > > Create a DenseMap mapping from target registers to dwarf numbers at > X86RegisterInfo ctor (or on demand the first time getDwarfRegNum is > called). So subsequent queries should b

Re: [llvm-commits] [llvm] r43918 - in /llvm/trunk/lib/Target/X86: X86RegisterInfo.cpp X86RegisterInfo.td

2007-11-09 Thread Evan Cheng
Since I gave bad advice last time, how about one more advice? :-) Create a DenseMap mapping from target registers to dwarf numbers at X86RegisterInfo ctor (or on demand the first time getDwarfRegNum is called). So subsequent queries should be nice and fast. Frankly I don't think the issue is

Re: [llvm-commits] [llvm] r43918 - in /llvm/trunk/lib/Target/X86: X86RegisterInfo.cpp X86RegisterInfo.td

2007-11-09 Thread Dale Johannesen
On Nov 8, 2007, at 10:05 PM, Chris Lattner wrote: >> URL: http://llvm.org/viewvc/llvm-project?rev=43918&view=rev >> Log: >> Rewrite Dwarf number handling per review comments. > > Hi Dale, > > I'm pretty uncomfortable with this, because it means that we're tying > down the register order. I tend

Re: [llvm-commits] [llvm] r43918 - in /llvm/trunk/lib/Target/X86: X86RegisterInfo.cpp X86RegisterInfo.td

2007-11-09 Thread Anton Korobeynikov
> Rewrite Dwarf number handling per review comments. Thanks, Dale! -- With best regards, Anton Korobeynikov. Faculty of Mathematics & Mechanics, Saint Petersburg State University. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.c

Re: [llvm-commits] [llvm] r43918 - in /llvm/trunk/lib/Target/X86: X86RegisterInfo.cpp X86RegisterInfo.td

2007-11-08 Thread Chris Lattner
> URL: http://llvm.org/viewvc/llvm-project?rev=43918&view=rev > Log: > Rewrite Dwarf number handling per review comments. Hi Dale, I'm pretty uncomfortable with this, because it means that we're tying down the register order. How about something like: if (Darwin32) { switch (RegNo) { c

[llvm-commits] [llvm] r43918 - in /llvm/trunk/lib/Target/X86: X86RegisterInfo.cpp X86RegisterInfo.td

2007-11-08 Thread Dale Johannesen
Author: johannes Date: Thu Nov 8 18:47:10 2007 New Revision: 43918 URL: http://llvm.org/viewvc/llvm-project?rev=43918&view=rev Log: Rewrite Dwarf number handling per review comments. Modified: llvm/trunk/lib/Target/X86/X86RegisterInfo.cpp llvm/trunk/lib/Target/X86/X86RegisterInfo.td Mo