Re: [llvm-commits] [llvm] r46108 - in /llvm/trunk: lib/Transforms/IPO/ArgumentPromotion.cpp test/Transforms/ArgumentPromotion/attrs.ll

2008-02-10 Thread Chris Lattner
On Feb 10, 2008, at 11:56 AM, Duncan Sands wrote: >>> you forgot about attributes on the function return value. >> >> I've lost the context for this, do you remember what this was about? > > I fixed it for you already :) Ahh, thanks :) :) -Chris ___ l

Re: [llvm-commits] [llvm] r46108 - in /llvm/trunk: lib/Transforms/IPO/ArgumentPromotion.cpp test/Transforms/ArgumentPromotion/attrs.ll

2008-02-10 Thread Duncan Sands
> > you forgot about attributes on the function return value. > > I've lost the context for this, do you remember what this was about? I fixed it for you already :) D. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mail

Re: [llvm-commits] [llvm] r46108 - in /llvm/trunk: lib/Transforms/IPO/ArgumentPromotion.cpp test/Transforms/ArgumentPromotion/attrs.ll

2008-02-10 Thread Chris Lattner
On Jan 17, 2008, at 1:45 AM, Duncan Sands wrote: > Hi Chris, > >> Fix arg promotion to propagate the correct attrs on the calls to >> promoted functions. This is important for varargs calls in >> particular. Thanks to duncan for providing a great testcase. > > you forgot about attributes on the

Re: [llvm-commits] [llvm] r46108 - in /llvm/trunk: lib/Transforms/IPO/ArgumentPromotion.cpp test/Transforms/ArgumentPromotion/attrs.ll

2008-01-17 Thread Duncan Sands
Hi Chris, > Fix arg promotion to propagate the correct attrs on the calls to > promoted functions. This is important for varargs calls in > particular. Thanks to duncan for providing a great testcase. you forgot about attributes on the function return value. Ciao, Duncan. ___

[llvm-commits] [llvm] r46108 - in /llvm/trunk: lib/Transforms/IPO/ArgumentPromotion.cpp test/Transforms/ArgumentPromotion/attrs.ll

2008-01-16 Thread Chris Lattner
Author: lattner Date: Wed Jan 16 19:17:03 2008 New Revision: 46108 URL: http://llvm.org/viewvc/llvm-project?rev=46108&view=rev Log: Fix arg promotion to propagate the correct attrs on the calls to promoted functions. This is important for varargs calls in particular. Thanks to duncan for provid