Re: [llvm-commits] [llvm] r46144 - in /llvm/trunk/lib/Target: PowerPC/PPCAsmPrinter.cpp X86/X86AsmPrinter.cpp

2008-01-18 Thread Chris Lattner
On Jan 18, 2008, at 10:19 AM, Dale Johannesen wrote: > On Jan 18, 2008, at 10:13 AM, Tanya Lattner wrote: >> Should the test/CodeGen/X86/aligned-comm.ll be un-XFAILED? Its now >> XPASSing. >> >> -Tanya > > I guess so; given the current state of llvm it is supposed to pass. > Longterm what should ha

Re: [llvm-commits] [llvm] r46144 - in /llvm/trunk/lib/Target: PowerPC/PPCAsmPrinter.cpp X86/X86AsmPrinter.cpp

2008-01-18 Thread Dale Johannesen
On Jan 18, 2008, at 10:13 AM, Tanya Lattner wrote: > Should the test/CodeGen/X86/aligned-comm.ll be un-XFAILED? Its now > XPASSing. > > -Tanya I guess so; given the current state of llvm it is supposed to pass. Longterm what should happen is that tentative definitions ("common") get represe

Re: [llvm-commits] [llvm] r46144 - in /llvm/trunk/lib/Target: PowerPC/PPCAsmPrinter.cpp X86/X86AsmPrinter.cpp

2008-01-18 Thread Tanya Lattner
Should the test/CodeGen/X86/aligned-comm.ll be un-XFAILED? Its now XPASSing. -Tanya On Jan 17, 2008, at 3:04 PM, Dale Johannesen wrote: > Author: johannes > Date: Thu Jan 17 17:04:07 2008 > New Revision: 46144 > > URL: http://llvm.org/viewvc/llvm-project?rev=46144&view=rev > Log: > Revert the

Re: [llvm-commits] [llvm] r46144 - in /llvm/trunk/lib/Target: PowerPC/PPCAsmPrinter.cpp X86/X86AsmPrinter.cpp

2008-01-17 Thread Evan Cheng
Please revert the ARM changes as well. I am assuming the bug is there as well. :-) Evan On Jan 17, 2008, at 3:04 PM, Dale Johannesen wrote: > Author: johannes > Date: Thu Jan 17 17:04:07 2008 > New Revision: 46144 > > URL: http://llvm.org/viewvc/llvm-project?rev=46144&view=rev > Log: > Revert

[llvm-commits] [llvm] r46144 - in /llvm/trunk/lib/Target: PowerPC/PPCAsmPrinter.cpp X86/X86AsmPrinter.cpp

2008-01-17 Thread Dale Johannesen
Author: johannes Date: Thu Jan 17 17:04:07 2008 New Revision: 46144 URL: http://llvm.org/viewvc/llvm-project?rev=46144&view=rev Log: Revert the part of 45848 that treated weak globals as weak globals rather than commons. While not wrong, this change tickled a latent bug in Darwin's strip, so reve