Re: [llvm-commits] updated patch for PR889

2007-11-28 Thread Chris Lattner
On Nov 28, 2007, at 12:55 PM, pawel kunio wrote: > Hello, > Here comes updated patch for PR889 with all the changes suggested by > Chris applied to the source. I was just wondering > whether the dynamic casts wont impose too much of burden > performance-wise compared to checking the SubClassID, >

Re: [llvm-commits] updated patch for PR889

2007-11-29 Thread Chris Lattner
On Nov 29, 2007, at 1:57 AM, pawel kunio wrote: > As to the tabs and 80 char limit, already applied. Thanks! > Regarding the > patch, I'd say I'd rather stick > to the assert(0 && "Unknown 'subtype' instruction in Value > destructor"); > The reason is two-fold, 1. Some of the Value inherited