Re: [LMMS-devel] EQ plugin

2014-11-30 Thread Dave French
I decided to open this as an issue, just to keep it in one place. have upload first concept artwork On 30 November 2014 at 15:41, Dave French wrote: > Give me a bit and i will post a screen shot of the ui im working on, you > will see that what you have described is what I am aiming for , + a h

Re: [LMMS-devel] EQ plugin

2014-11-30 Thread Dave French
Yes. That is the filter combo I was going for. I personally use a hp on every chanel when mixing down. Removing filters from the chain is no biggie if after testing it proves too many. Tbh my first go is like a prototype to see what works. Im expecting to be making many changes before I rewrite the

Re: [LMMS-devel] EQ plugin

2014-11-30 Thread Vesa
On 11/30/2014 05:41 PM, Dave French wrote: > Give me a bit and i will post a screen shot of the ui im working on, > you will see that what you have described is what I am aiming for , + > a hp at the beginning, and low pass at the end. So you want to do peak filters, low/high shelves, and addition

Re: [LMMS-devel] EQ plugin

2014-11-30 Thread Dave French
Give me a bit and i will post a screen shot of the ui im working on, you will see that what you have described is what I am aiming for , + a hp at the beginning, and low pass at the end. what I meant by different filters, was the ability to select different implementations of each type, because the

Re: [LMMS-devel] EQ plugin

2014-11-30 Thread Vesa
On 11/30/2014 03:41 PM, Dave French wrote: > My initial thoughts was to have selectable filter types per band so a > few different lp, bell, notch , shelf hp filters types, selectable by > the user, but im not sure that it benefits the user, as it can be more > of a distraction, I also feel using

Re: [LMMS-devel] EQ plugin

2014-11-30 Thread Dave French
Cheers Dizzy will take a look at this, this afternoon, sure has helped. I need a break from reading up about QT. Im glad you suggested that custom widget, because it has got me learning about QT, a skill that is probably essential if im to contribute more to lmms. My initial thoughts was to have s

Re: [LMMS-devel] EQ plugin

2014-11-30 Thread Vesa
On 11/30/2014 12:39 AM, Vesa wrote: > On 11/30/2014 12:24 AM, Dave French wrote: >> You want me pull to code into a class? > No, I can do that... Ok, it is now done (in master branch). BasicFilters.h now contains the class BiQuad, where ch_cnt_t is a typedef for int that signifies channel count.

Re: [LMMS-devel] EQ plugin

2014-11-29 Thread Vesa
On 11/30/2014 12:24 AM, Dave French wrote: > Parametric EQ would be cool. Especially if you develop a good UI for it. > I'm thinking maybe like a custom QWidget that lets you move the filter > points directly in the frequency response graph. > > You'll probably want to use biquads for the filters.

[LMMS-devel] EQ plugin

2014-11-29 Thread Dave French
Parametric EQ would be cool. Especially if you develop a good UI for it. I'm thinking maybe like a custom QWidget that lets you move the filter points directly in the frequency response graph. You'll probably want to use biquads for the filters. There's a good biquad implementation in basic_filter