Great! This is a valuable visual feedback feature!
On 15 Jan 2014 17:44, "Tobias Doerffel" wrote:
> 2014/1/15 Tobiasz Karoń
>
>> Would piano roll keys press when a pattern is played? Will they reflect
>> MIDI notes coming to the instrument no matter how (also from external MIDI
>> keyboard or se
On 15 January 2014 22:25, Tobias Doerffel wrote:
>> What about row highlighting? Is it required or if it is fine right now?
>
>
> I personally don't need it.
Ok. So I'll close this issue for now. If others may feel that this
could be included, then we'll reopen this one in future.
--
Gurjot Si
Neither I, but it could be considered eye-candy and made disableable (able
to disable, optional that is) in the preferences window.
On 15 Jan 2014 17:55, "Tobias Doerffel" wrote:
> 2014/1/15 Gurjot Singh
>
>> What about row highlighting? Is it required or if it is fine right now?
>>
>
> I perso
2014/1/15 Gurjot Singh
> What about row highlighting? Is it required or if it is fine right now?
>
I personally don't need it.
Toby
--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesse
On 15 January 2014 22:14, Tobias Doerffel wrote:
> Short answer: yes. I made a further rewrite of key press handling using the
> PianoModel so we should see visual feedback for all kind of note events in
> both instrument window and piano roll – if there are uncatched cases, we
> need to fix it.
2014/1/15 Tobiasz Karoń
> Would piano roll keys press when a pattern is played? Will they reflect
> MIDI notes coming to the instrument no matter how (also from external MIDI
> keyboard or sequencer)?
>
Short answer: yes. I made a further rewrite of key press handling using the
PianoModel so we s
Would piano roll keys press when a pattern is played? Will they reflect
MIDI notes coming to the instrument no matter how (also from external MIDI
keyboard or sequencer)?
On 15 Jan 2014 16:23, "Gurjot Singh" wrote:
> On 15 January 2014 06:52, Gurjot Singh wrote:
> >>
> >> Ok I sent a new pull re
On 15 January 2014 06:52, Gurjot Singh wrote:
>>
>> Ok I sent a new pull request.
>
> Thanks for accepting the patch. :)
The patch has been merged and that's great but do you think we should
implement the 'highlighting the entire row' feature too?
I mean the entire row already highlights when we
On 14 January 2014 22:57, Gurjot Singh wrote:
>> Nope sorry, there's something messed up with the old master branch. Please
>> make sure to rebase your work against stable-0.4 and send a pull request to
>> the stable-0.4 branch
>
> Ok I sent a new pull request.
Thanks for accepting the patch. :)
On 14 January 2014 22:51, Tobias Doerffel wrote:
> Nope sorry, there's something messed up with the old master branch. Please
> make sure to rebase your work against stable-0.4 and send a pull request to
> the stable-0.4 branch
Ok I sent a new pull request.
BTW how do I cancel the previous reques
2014/1/14 Gurjot Singh
> Did I really sent the pull request to the correct branch? :P
>
Nope sorry, there's something messed up with the old master branch. Please
make sure to rebase your work against stable-0.4 and send a pull request to
the stable-0.4 branch
Toby
-
On 14 January 2014 21:30, Tobias Doerffel wrote:
>
> Very cool! :-) Yes, send a pull request and I'll have a look at it.
>
Sent the pull request.
Did I really sent the pull request to the correct branch? :P
--
Gurjot Singh
Blog: http://bhattigurjot.wordpress.com
-
2014/1/14 Gurjot Singh
> I'm almost done with this patch. :)
> Now the key presses are visible in the Piano Roll by all the three methods.
> On the note of highlighting the row, I guess it is not really
> necessary since our mouse when held on the note editor area highlights
> the current row alr
On 12 January 2014 19:53, Tobias Doerffel wrote:
> You don't have to take care of key press events anymore at all - everything
> is in place already. In paintEvent() you have to retrieve the Piano model
> instance via
>
> pattern->instrumentTrack()->pianoModel()
>
> and retrieve the current key st
On 12 January 2014 19:53, Tobias Doerffel wrote:
> You don't have to take care of key press events anymore at all - everything
> is in place already. In paintEvent() you have to retrieve the Piano model
> instance via
>
> pattern->instrumentTrack()->pianoModel()
>
> and retrieve the current key st
You don't have to take care of key press events anymore at all - everything
is in place already. In paintEvent() you have to retrieve the Piano model
instance via
pattern->instrumentTrack()->pianoModel()
and retrieve the current key states via a yet to be implemented public
"isKeyPressed( int key
On 12 January 2014 19:41, Vesa wrote:
> Hmm. How are keypresses implemented in the instrument window?
The two functions are there it seems.
1.) keyPressEvent: This function recognises the keys pressed.
2.) mousePressEvent: This function includes the left click press to
determine the key presses.
Hi,
the PianoView class operates on the Piano (model) class where it looks up
the pressed keys. You can use the same model (retrieve it from the
InstrumentTrack a specific pattern belongs to) for rendering the keys in
the piano roll.
HTH
Toby
-
On 01/12/2014 03:38 PM, Gurjot Singh wrote:
> On 11 January 2014 12:55, Vesa wrote:
>> You should create a new issue for this on the github page. The images
>> for pressed-down piano roll keys are there, they're included with the
>> default theme, but the changing of the images hasn't been impleme
On 11 January 2014 12:55, Vesa wrote:
> You should create a new issue for this on the github page. The images
> for pressed-down piano roll keys are there, they're included with the
> default theme, but the changing of the images hasn't been implemented.
> I'd start by looking at src/gui/piano_rol
On 11 January 2014 15:30, Jonathan Aquilina wrote:
> forwarded the issue to toby for him to take a look at.
I've edited the issue a little bit to include the complete row
highlight when playing the keys in piano roll.
--
Gurjot Singh
Blog: http://bhattigurjot.wordpress.com
forwarded the issue to toby for him to take a look at.
On Sat, Jan 11, 2014 at 10:53 AM, Gurjot Singh wrote:
> On 11 January 2014 15:21, Jonathan Aquilina
> wrote:
> > If I am not mistaken TOBY please confirm but i think you have to be
> added to
> > the project Gurjot Also what is the name of
On 11 January 2014 15:21, Jonathan Aquilina wrote:
> If I am not mistaken TOBY please confirm but i think you have to be added to
> the project Gurjot Also what is the name of the issue.
Okay.
The issue is "Piano Roll Key Press".
--
Gurjot Singh
Blog: http://bhattigurjot.wordpress.com
---
If I am not mistaken TOBY please confirm but i think you have to be added
to the project Gurjot Also what is the name of the issue.
On Sat, Jan 11, 2014 at 9:41 AM, Gurjot Singh wrote:
> On 11 January 2014 14:05, Gurjot Singh wrote:
> >> You should create a new issue for this on the github page
On 11 January 2014 14:05, Gurjot Singh wrote:
>> You should create a new issue for this on the github page.
>
> Ok, I'll create one.
Done! It is saying that "No one is assigned".
@GitHub Admins, kindly assign this issue to me so that others should
be made aware.
--
Gurjot Singh
Blog: http://bh
On 11 January 2014 12:55, Vesa wrote:
> You should create a new issue for this on the github page.
Ok, I'll create one.
> The images
> for pressed-down piano roll keys are there, they're included with the
> default theme, but the changing of the images hasn't been implemented.
> I'd start by loo
On 01/11/2014 08:53 AM, Gurjot Singh wrote:
> Correct me wherever I'm wrong.
> While using Piano Roll, we can play the notes using either of the 3
> following methods.
> 1. From our computer Keyboard.
> 2. From MIDI Keyboard.
> 3. Directly using left mouse button.
>
> The notes are played but no vi
Correct me wherever I'm wrong.
While using Piano Roll, we can play the notes using either of the 3
following methods.
1. From our computer Keyboard.
2. From MIDI Keyboard.
3. Directly using left mouse button.
The notes are played but no visual information is displayed regarding
the key-presses unl
28 matches
Mail list logo
