Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-12 Thread Tobias Doerffel
2014/1/10 Vesa > Ok... how exactly do I submit the patch there? Prefered way: fork repository, commit your patch in your repository and send a pull request. The patch itself looks good! :-) Toby -- CenturyLink Cloud: T

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Jonathan Aquilina
I emailed toby at this point. I hope he will reply with a solution. On Fri, Jan 10, 2014 at 2:19 PM, Vesa wrote: > On 01/10/2014 03:17 PM, Jonathan Aquilina wrote: > > would you mind just copying and pasting the code in the issue you will > > create and then if need be who ever is going to impl

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Vesa
On 01/10/2014 03:17 PM, Jonathan Aquilina wrote: > would you mind just copying and pasting the code in the issue you will > create and then if need be who ever is going to implement that feature > can request that the author submit it. or even push it to the repo. > not sure how this might work it

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Jonathan Aquilina
would you mind just copying and pasting the code in the issue you will create and then if need be who ever is going to implement that feature can request that the author submit it. or even push it to the repo. not sure how this might work it is something i need to discuss with toby. On Fri, Jan

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Jonathan Aquilina
Hold on dont do anything. On Fri, Jan 10, 2014 at 2:06 PM, Vesa wrote: > On 01/10/2014 03:03 PM, Jonathan Aquilina wrote: > > you need to create a new issue and it will allow you to attach the patch > > > > No it won't... > > "Unfortunately we don't support that file type yet. Please use PNG, G

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Vesa
On 01/10/2014 03:03 PM, Jonathan Aquilina wrote: > you need to create a new issue and it will allow you to attach the patch > No it won't... "Unfortunately we don't support that file type yet. Please use PNG, GIF, or JPG." Should I take a screenshot of the patch ;D -

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Jonathan Aquilina
you need to create a new issue and it will allow you to attach the patch On Fri, Jan 10, 2014 at 2:00 PM, Vesa wrote: > On 01/10/2014 02:49 PM, Jonathan Aquilina wrote: > > Much appreciated :) > > Ok... how exactly do I submit the patch there? The site doesn't let me > attach a .patch file to t

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Vesa
On 01/10/2014 02:49 PM, Jonathan Aquilina wrote: > Much appreciated :) Ok... how exactly do I submit the patch there? The site doesn't let me attach a .patch file to the report, and if I just paste it there, the formatting gets all garbled and that's probably not good... -

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Jonathan Aquilina
Much appreciated :) On Fri, Jan 10, 2014 at 1:47 PM, Vesa wrote: > On 01/10/2014 02:45 PM, Jonathan Aquilina wrote: > > Can you file a bug here https://github.com/LMMS/lmms/issues?state=open > > and tag it as an enhancement/patch please. what happens when we send > > emails with patches they fa

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Vesa
On 01/10/2014 02:45 PM, Jonathan Aquilina wrote: > Can you file a bug here https://github.com/LMMS/lmms/issues?state=open > and tag it as an enhancement/patch please. what happens when we send > emails with patches they fall through the cracks and are not > trackable. If you can give a description

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Tobiasz KaroĊ„
Wow, I didn't even knew this was broken. Isn't it just playing back instead of importing? I think of importing as converting to another format suitable for work. On 10 Jan 2014 13:26, "Vesa" wrote: > Ok, this is my first time writing any serious C++ code, so if my coding > is totally horrible, t

Re: [LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Jonathan Aquilina
Can you file a bug here https://github.com/LMMS/lmms/issues?state=open and tag it as an enhancement/patch please. what happens when we send emails with patches they fall through the cracks and are not trackable. If you can give a description of what you are trying to achieve etc with this patch tha

[LMMS-devel] Fix import of 32-bit wav files

2014-01-10 Thread Vesa
Ok, this is my first time writing any serious C++ code, so if my coding is totally horrible, that's probably why... Anyway, I started browsing around the lmms source because I wanted to get a better grip on how this C++ stuff works, and I figured I'd try to fix the problem with importing 32-bit wa