Re: [LMMS-devel] LMMS VST: GUI fixes, better integration

2013-01-23 Thread Tobias Doerffel
Hi Mike, 2013/1/18 Mike Choi : > Here am I attaching new patch for better outlook of VST effect wrapper > window. Patch applied, thank you very much! > Also as I was investigating previous bug, it seem to happen when VST effect > is put directly non Master channels FxChain and its more common o

Re: [LMMS-devel] LMMS VST: GUI fixes, better integration

2013-01-21 Thread Mike Choi
Hi, It seems when duration of VstEffect constructor is prolonged (I have used usleep for some time), those VST effect crashes on main channel are gone, at least in my tests so far. I think its that some thread messages (I suppose IdSampleRateInformation / IdBufferSizeInformation with quite bit c

Re: [LMMS-devel] LMMS VST: GUI fixes, better integration

2013-01-16 Thread Mike Choi
Hi Toby oh well thanks, I will try to contribute as I will have time. I will try to focus on VST effect GUI and bug fixes for next patch. I am just in the middle of fixing bug, It seems that some VST effects (for example Tiny-Q VST) placed directly on FX mixer for some reason try to process audio

Re: [LMMS-devel] LMMS VST: GUI fixes, better integration

2013-01-16 Thread Tobias Doerffel
Hi Mike, thanks again for this good work! I applied your patch (as John said, smaller patches next time would be even better - especially for spotting regressions). If you plan to continue working on LMMS, I'd suggest to give you write access to the git repository so you can commit your changes d

Re: [LMMS-devel] LMMS VST: GUI fixes, better integration

2013-01-15 Thread Mike Choi
Hi not problem, if needed I can separate them as will have a time -Mike C. On Wed, Jan 16, 2013 at 4:42 AM, John Serafino wrote: > Looks awesome. Want! Just a note: patches seem to be preferred to be > submitted as many small patches instead of one big one. At least, I've seen > a few larger one

Re: [LMMS-devel] LMMS VST: GUI fixes, better integration

2013-01-15 Thread John Serafino
Looks awesome. Want! Just a note: patches seem to be preferred to be submitted as many small patches instead of one big one. At least, I've seen a few larger ones be requested to be broken up first. On Tue, Jan 15, 2013 at 9:30 PM, Mike Choi wrote: > Hello, > How about this one? Icons or their

Re: [LMMS-devel] LMMS VST: GUI fixes, better integration

2013-01-14 Thread Mike Choi
Hi, just lets move this below better subject :) -Mike On Tue, Jan 15, 2013 at 1:55 AM, Mike Choi wrote: > Hello, > > I have just submitted a new patch, which should bring following fixes or > improvements for LMMS VSTi and effect integration: > >- Added support for VST parameters control fo