Re: [lng-odp] [PATCH] configure.ac display target platform

2014-09-01 Thread Wiles, Roger Keith
On Sep 1, 2014, at 3:58 PM, Bill Fischofer wrote: > Tabs are semantically meaningful in make files (terrible design choice, but > that's the way it is). Need to be careful about rules for them because of > this. The rule body’s in Makefile’s must be tabbed for the first character of each li

Re: [lng-odp] [PATCH] configure.ac display target platform

2014-09-01 Thread Bill Fischofer
Tabs are semantically meaningful in make files (terrible design choice, but that's the way it is). Need to be careful about rules for them because of this. Bill On Mon, Sep 1, 2014 at 6:58 AM, Maxim Uvarov wrote: > On 08/29/2014 07:31 PM, Mike Holmes wrote: > >> Signed-off-by: Mike Holmes >>

Re: [lng-odp] [PATCH v4] Add-global_init-paramiters

2014-09-01 Thread Bill Fischofer
Let's discuss these scenarios during tomorrow's ODP calls. Could the various camps put together a brief summary of how they see this organized? That would be helpful in framing the discussion. Thanks. Bill On Mon, Sep 1, 2014 at 5:01 AM, Savolainen, Petri (NSN - FI/Espoo) < petri.savolai...@n

Re: [lng-odp] [arch design discussion] Packet meta data

2014-09-01 Thread Bill Fischofer
See comments inline On Mon, Sep 1, 2014 at 1:39 AM, Wiles, Roger Keith < keith.wi...@windriver.com> wrote: > > > I did not mean to imply the data needed to be contiguous or not, all I was > trying to suggest constraints around the design for ODP. If that was > unclear in my email then I am sorry a

Re: [lng-odp] [PATCH] configure.ac: fix indentation that slipped in

2014-09-01 Thread Maxim Uvarov
On 09/01/2014 11:46 PM, Anders Roxell wrote: Signed-off-by: Anders Roxell --- unsure why this commit 4b18b9fd607f23cf1cffb71fc7bae6738938a64b got pushed when it got review comments see [1] fixing the review comments and readding the removed newline. My mistake sorry. I applied it for review fou

[lng-odp] [PATCH] configure.ac: fix indentation that slipped in

2014-09-01 Thread Anders Roxell
Signed-off-by: Anders Roxell --- unsure why this commit 4b18b9fd607f23cf1cffb71fc7bae6738938a64b got pushed when it got review comments see [1] fixing the review comments and readding the removed newline. Cheers, Anders [1] http://lists.linaro.org/pipermail/lng-odp/2014-September/002899.html

Re: [lng-odp] [PATCH v2] bootstrap: add include m4 directory in bootstrap

2014-09-01 Thread Maxim Uvarov
Merged, thanks! Maxim. On 09/01/2014 05:19 PM, Anders Roxell wrote: On 2014-08-24 13:04, Gilad Ben-Yossef wrote: From: Gilad Ben-Yossef First time configure was failing due to missing Doxygen includes from m4/ directory. Include m4/ directory during bootstrap generation to get autoconf to cr

Re: [lng-odp] [PATCH v2] bootstrap: add include m4 directory in bootstrap

2014-09-01 Thread Anders Roxell
On 2014-08-24 13:04, Gilad Ben-Yossef wrote: > From: Gilad Ben-Yossef > > First time configure was failing due to missing Doxygen includes from > m4/ directory. > > Include m4/ directory during bootstrap generation to get autoconf > to create a correct configure script. > > As per Anders Roxell

[lng-odp] [Bug 149] ODP linux-generic timer error on Xgene

2014-09-01 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=149 --- Comment #31 from Santosh Shukla --- Created attachment 141 --> https://bugs.linaro.org/attachment.cgi?id=141&action=edit timer test application BE fix patch Ankit, Pl. test this patch and let me know your feedback. -- You are receiving this mai

Re: [lng-odp] [PATCH] configure.ac display target platform

2014-09-01 Thread Maxim Uvarov
On 08/29/2014 07:31 PM, Mike Holmes wrote: Signed-off-by: Mike Holmes --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index c9aac14..da109b7 100644 --- a/configure.ac +++ b/configure.ac @@ -170,7 +170,7 @@ AC_OUTPUT AC_MSG_RES

Re: [lng-odp] [PATCH v2] bootstrap: add include m4 directory in bootstrap

2014-09-01 Thread Maxim Uvarov
Anders, ping. Maxim. On 08/24/2014 02:04 PM, Gilad Ben-Yossef wrote: From: Gilad Ben-Yossef First time configure was failing due to missing Doxygen includes from m4/ directory. Include m4/ directory during bootstrap generation to get autoconf to create a correct configure script. As per And

[lng-odp] [PATCH 1/2] Shared memory reserve flag

2014-09-01 Thread Petri Savolainen
Add flags parameter to reserve call. * SW_ONLY: optimize memory usage when HW accelerators are not involved. * PROC: for communication with other (non-ODP) processes in the system * KERNEL: for communication with a kernel (OS) driver Signed-off-by: Petri Savolainen --- .../linux-generic/incl

[lng-odp] [PATCH 2/2] Shared memory flag default value

2014-09-01 Thread Petri Savolainen
Flags default value is zero (share memory within ODP, include HW accelerators). Signed-off-by: Petri Savolainen --- example/generator/odp_generator.c| 5 +++-- example/l2fwd/odp_l2fwd.c| 5 +++-- example/odp_example/odp_example.c| 2 +- example/packet/odp_pktio

Re: [lng-odp] [PATCH 2/2] odph_icmp: add ODPH_ prefix

2014-09-01 Thread Maxim Uvarov
My point is that defines are unrolled on preprocessor stage. While name spaces on link stage. So that if you do not change define value you can have several defines for that in different files. Gcc will not warn on that. Only if the same define will be defined with different name. Example: od

Re: [lng-odp] [PATCH v4] Add-global_init-paramiters

2014-09-01 Thread Savolainen, Petri (NSN - FI/Espoo)
> -Original Message- > From: ext Wiles, Roger Keith [mailto:keith.wi...@windriver.com] > Sent: Monday, September 01, 2014 11:27 AM > To: Savolainen, Petri (NSN - FI/Espoo) > Cc: ext Mike Holmes; lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH v4] Add-global_init-paramiters > >

Re: [lng-odp] [PATCH v4] Add-global_init-paramiters

2014-09-01 Thread Taras Kondratiuk
On 09/01/2014 11:26 AM, Wiles, Roger Keith wrote: On Sep 1, 2014, at 3:07 AM, Savolainen, Petri (NSN - FI/Espoo) wrote: diff --git a/platform/linux-generic/odp_init.c b/platform/linux- generic/odp_init.c index 5b7e192..f595def 100644 --- a/platform/linux-generic/odp_init.c +++ b/platform/lin

Re: [lng-odp] [PATCH v4] Add-global_init-paramiters

2014-09-01 Thread Taras Kondratiuk
On 08/29/2014 08:05 PM, Mike Holmes wrote: > diff --git a/platform/linux-dpdk/odp_init.c b/platform/linux- > dpdk/odp_platform.c > similarity index 50% > rename from platform/linux-dpdk/odp_init.c > rename to platform/linux-dpdk/odp_platform.c > index ecc2066..5a054f

Re: [lng-odp] ODP-DPDK multi queue support

2014-09-01 Thread Venkatesh Vivekanandan
On 28 August 2014 12:04, Santosh Shukla wrote: > No hw availability for this week, Next week I will have x86 boxes with > me so expect to see multi-queue update from me. Thanks. > > It is better if you can close this off when your setup is back. It takes hardly 10-15 min once you have the setup.

Re: [lng-odp] [PATCH v4] Add-global_init-paramiters

2014-09-01 Thread Wiles, Roger Keith
On Sep 1, 2014, at 3:07 AM, Savolainen, Petri (NSN - FI/Espoo) wrote: >> diff --git a/platform/linux-generic/odp_init.c b/platform/linux- >> generic/odp_init.c >> index 5b7e192..f595def 100644 >> --- a/platform/linux-generic/odp_init.c >> +++ b/platform/linux-generic/odp_init.c >> @@ -8,13 +8,1

Re: [lng-odp] [PATCH v4] Add-global_init-paramiters

2014-09-01 Thread Savolainen, Petri (NSN - FI/Espoo)
> diff --git a/platform/linux-generic/odp_init.c b/platform/linux- > generic/odp_init.c > index 5b7e192..f595def 100644 > --- a/platform/linux-generic/odp_init.c > +++ b/platform/linux-generic/odp_init.c > @@ -8,13 +8,18 @@ >  #include >  #include > > - > -int odp_init_global(void) > +int odp_ini

Re: [lng-odp] [PATCH v2] test/unit: add odp_buffer_test

2014-09-01 Thread Savolainen, Petri (NSN - FI/Espoo)
> -Original Message- > From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp- > boun...@lists.linaro.org] On Behalf Of ext Mike Holmes > Sent: Friday, August 29, 2014 5:41 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH v2] test/unit: add odp_buffer_test > > Signed-off-by: