Re: [lng-odp] Move Typedefs to a new Header File

2014-11-01 Thread Bala Manoharan
Hi, In the Current ODP design, we are having the typedef for different handles defined in the same header file. This causes a circular dependency between odp_buffer.h and odp_buffer_pool.h file as the buffer API uses pool handle and pool API uses buffer Handle. We would like to avoid this circular

Re: [lng-odp] [ODP/PATCH v1] ODP Buffer Segment Support API

2014-11-01 Thread Bala Manoharan
Hi, This patch will have to be modified as we have decided to move the segmentation support in packet header file. I will provide an updated patch for the same. Regards, Bala On 31 October 2014 20:24, Bill Fischofer wrote: > This patch does not apply to the current repository. Is there a revi

Re: [lng-odp] [PATCH v2 1/1] cunit : add tests for crypto APIs

2014-11-01 Thread Bala Manoharan
We should be able to modify the suite once we define the additional API in crypto to read the supported crypto operations in the underlying platform. The test suite could be written in such a way to run only the sync or async test cases for the specified platform based on the return from the query

Re: [lng-odp] [PATCH v2] add tests for queue

2014-11-01 Thread Maxim Uvarov
Hello Yan, few notes about sending patches. 1. pelase use 'git send-email' command. 2. If you have any changes from previouse patch. Just open generated patch and add you comments after "--". In that case when I do git am that lines will be skipped. 3. git commits usually look like: short subj

Re: [lng-odp] Move Typedefs to a new Header File

2014-11-01 Thread Bill Fischofer
In the case of odp_buffer.h and odp_buffer_pool.h I'm not sure why it wouldn't make sense to combine these into one file since they are so closely related. We have APIs in odp_buffer.h that take odp_buffer_pool_t arguments (e.g., odp_buffer_copy) and return odp_buffer_pool_t results (odp_buffer_po

Re: [lng-odp] Move Typedefs to a new Header File

2014-11-01 Thread Bill Fischofer
BTW, Bala, In looking at the implementation of these routines I've put the bulk of the info from the design doc into the .h file itself and it seems to be formatting well. To avoid duplication of effort, I suggest you focus on the classification implementation and let's sync up next week on finali