> On 24 October 2014 15:46, Mike Holmes wrote:
>
>> On data mismatch free the recently mallocked buffer.
>>
>> Signed-off-by: Mike Holmes
>> ---
>> test/api_test/odp_ring_test.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/test/api_test/odp_ring_test.c b/test/api_test/odp_ring_tes
On Tue, Nov 04, 2014 at 12:31:03AM +0800, Yan Songming wrote:
> From: "yan.songming"
>
> Add the cunit test for none sync queue. Test the base queue function.
>
> Signed-off-by: yan.songming
>
> ---
> Fix spelling problem and commend problem. Add term_local and term_global.
> Move cunit queue
On 2014-11-04 00:31, Yan Songming wrote:
> From: "yan.songming"
>
Say in subject something like this:
cunit/odp_queue: add queue test
Run checkpatch and fix the problems I will point out some of them and
other review comments.
In the C file change 4 space to 1 tab.
Be consistent either line va
Signed-off-by: Mike Holmes
---
exception_handling.dox | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exception_handling.dox b/exception_handling.dox
index fe693bc..03a9bbd 100644
--- a/exception_handling.dox
+++ b/exception_handling.dox
@@ -5,7 +5,7 @@
*/
/**
-@page exce
API headers should not include C std lib headers directly
Signed-off-by: Mike Holmes
---
v2:
remove endian.h it should be cleaned up during configuration / build
platform/linux-generic/include/api/odp_debug.h | 3 +--
platform/linux-generic/include/api/odp_std_types.h | 2 ++
2 files chang
ODP APIs are divided into two classes: Mandatory, which all conforming ODP
implementations are expected to provide, and Optional. The convention is
that Optional APIs must be present but calling them may simply result in an
ODP_FUNCTION_NOT_AVAILABLE return code. These are documented in the
assoc
On Mon, 3 Nov 2014 12:11:26 -0600 Bill Fischofer
wrote:
> ODP APIs are designed to be used *a la carte* by applications, as ODP is a
> framework, not a platform. So feel free to mix malloc() or your own memory
> management or other API calls in as needed.
>
> What ODP requires is the types spec
ping
On 30 October 2014 18:17, Mike Holmes wrote:
> tot is = i which cannot leave the for loop without being positive
> unless it exits entirely and never reaches the test statement.
> Or QUEUE_ROUNDS is #defined to 0 rather than (512*1024)
> Thus tot is always true and the else cannot execute
>
ping
On 24 October 2014 15:46, Mike Holmes wrote:
> On data mismatch free the recently mallocked buffer.
>
> Signed-off-by: Mike Holmes
> ---
> test/api_test/odp_ring_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/api_test/odp_ring_test.c b/test/api_test/odp_ring_test.c
>
ODP APIs are designed to be used *a la carte* by applications, as ODP is a
framework, not a platform. So feel free to mix malloc() or your own memory
management or other API calls in as needed.
What ODP requires is the types specified in its APIs, so for example the
only way to get an odp_buffer_
http://people.linaro.org/~mike.holmes/linux-generic-gcov-html/linux-generic/index.html
Yan it looks like there odp_buffer_t queue_sched_buf(odp_queue_t handle)
was not called in the test suite.
Also the internal void queue_lock(queue_entry_t *queue) was not called but
maybe odp_packet_io tests
This patch series updates the netmap support to the freshly released
netmap v11.1. It also tweakes the test application a bit, to be able to run
etwork performance tests, such as iperf. With the loopback mode TCP connections
fail, due to duplicate SYN packets.
Ciprian Barbu (2):
odp_pktio_netma
Signed-off-by: Ciprian Barbu
---
example/packet_netmap/odp_pktio_netmap.c | 12 --
platform/linux-netmap/README | 40 ++--
2 files changed, 43 insertions(+), 9 deletions(-)
diff --git a/example/packet_netmap/odp_pktio_netmap.c
b/example/packet_net
Signed-off-by: Ciprian Barbu
---
platform/linux-netmap/README | 22 +-
platform/linux-netmap/odp_packet_netmap.c | 7 +--
platform/linux-netmap/odp_packet_netmap.h | 4 ++--
3 files changed, 20 insertions(+), 13 deletions(-)
diff --git a/platform/linux-netm
Hi,
As demonstrated by odp/examples, libc memory allocation routines (malloc
and friends) aren't been used by ODP apps (unless for a very tight
temporary scope, usually in the control thread).
Application's data structures are allocated either using odp_buffer_pool
interface (e.g. odp_ipsec.c all
Are you doing ODP C++ class and need proper destroy functions on this
class delete?
odph_linux_pthread_create() and other odph_ are helper functions. You
can use them, but it's not part of
ODP API. So fill free to call odp API directly (i.e. do the same but add
your stl thing there).
BR,
Max
mike@fedora1:~/git/odp$ git am
~/incoming/lng-odp_PATCH_v3_add_tests_for_queue.mbox
Applying: add tests for queue
/home/mike/git/odp/.git/rebase-apply/patch:81: trailing whitespace.
/home/mike/git/odp/.git/rebase-apply/patch:85: trailing whitespace.
/home/mike/git/odp/.git/rebase-apply/patch:101:
From: "yan.songming"
Add the cunit test for none sync queue. Test the base queue function.
Signed-off-by: yan.songming
---
Fix spelling problem and commend problem. Add term_local and term_global.
Move cunit queue test to test_odp_queue_base for none syn queue.
---
test/cunit/Makefile.am
On 11/03/2014 03:02 PM, Shmulik Ladkani wrote:
On Mon, 03 Nov 2014 14:09:02 +0200 Taras Kondratiuk
wrote:
Won't it be simpler to add a new local initialization API in your
library instead of piggy-backing on ODP local init call?
Something like:
stl_odp_local_init()
{
odp_local_init();
A need to split out a clean API headers is being discussed again, so
pulling this thread up to remind what the previous attempt was.
On 07/08/2014 05:55 PM, Mike Holmes wrote:
> We discussed this on a hangout, here are the results as a way forward on
> this 1 month old topic.
>
>
> Attendees:
>
That'a a reasonable suggestion. The implementation can set errno to
indicate the specific reason for failure.
Bill
On Mon, Nov 3, 2014 at 9:30 AM, Gilad Ben Yossef wrote:
>
>
> A question regarding all the *_addr type functions – since they may
> require a mapping to be put in place for some
Hongbo,
I find it . And It do help me know how to add the commends.
Thanks.
yan.songm...@linaro.org
From: Hongbo Zhang
Date: 2014-11-03 17:46
To: yan.songm...@linaro.org
CC: maxim.uvarov; lng-odp
Subject: Re: Re: [lng-odp] [PATCH v2] add tests for queue
Yan,
Search this patch in you mail for e
On 2 November 2014 22:06, Bill Fischofer wrote:
> RFC version of patches for new buffer .h files. Includes all API changes
> from
> buffer design doc + extended notes. Do not merge until corresponding code
> changes are posted.
>
> Signed-off-by: Bill Fischofer
> ---
> platform/linux-generic/
On Mon, 3 Nov 2014 05:42:52 -0600 Bill Fischofer
wrote:
> The reality is I don't believe we have any actual uses of
> ODP_BUFFER_TYPE_RAW at this point.
Well... it's part of the API... don't make such assumptions ;-)
(although I might just be mis-using it. I'll post a follow-up question)
_
On Mon, 03 Nov 2014 14:09:02 +0200 Taras Kondratiuk
wrote:
> Won't it be simpler to add a new local initialization API in your
> library instead of piggy-backing on ODP local init call?
>
> Something like:
> stl_odp_local_init()
> {
> odp_local_init();
> stl_local_init(); /* Here you
On Mon, 3 Nov 2014 05:49:40 -0600 Bill Fischofer
wrote:
> This sounds like an interesting idea. Will you be able to join tomorrow's
> ODP call (uberconference.com/opendataplane at 15L00 UTC)? It might be
> interesting to discuss this idea there.
Sure. I'll try to join tomorrow's call.
Thanks,
On 11/03/2014 12:22 PM, Shmulik Ladkani wrote:
Hi Taras,
On Mon, 03 Nov 2014 12:00:33 +0200 Taras Kondratiuk
wrote:
Could you please elaborate it? What is a usecase?
Think of a library extending the ODP library.
Specifically, I was playing around creating a C++ STL compatible
allocator te
I've used that sort of construct in the past and have confirmed that it
solves the problem (in addition to producing cleaner-looking code).
Thank you!
Bill
On Mon, Nov 3, 2014 at 2:45 AM, Shmulik Ladkani
wrote:
> Hi Bill,
>
> On Sun, 2 Nov 2014 21:50:18 -0600 Bill Fischofer <
> bill.fischo...@
Make that 15:00 UTC (fingers still waking up)
Bill
On Mon, Nov 3, 2014 at 5:49 AM, Bill Fischofer
wrote:
> Hi Shmulik,
>
> This sounds like an interesting idea. Will you be able to join tomorrow's
> ODP call (uberconference.com/opendataplane at 15L00 UTC)? It might be
> interesting to discuss
Hi Shmulik,
This sounds like an interesting idea. Will you be able to join tomorrow's
ODP call (uberconference.com/opendataplane at 15L00 UTC)? It might be
interesting to discuss this idea there.
Thanks.
Bill
On Mon, Nov 3, 2014 at 4:32 AM, Shmulik Ladkani
wrote:
> On Mon, 3 Nov 2014 12:22:
OK, thanks. That certainly matches the step-by-step semantics Petri
proposed. We'll have to discuss what, if anything, more we need regarding
ORDERED queues post-v1.0 next year.
Bill
On Mon, Nov 3, 2014 at 3:03 AM, Gilad Ben Yossef wrote:
>
>
>
>
> What NPS does in HW is that each buffer you
The intent here is that they report their fixed size since RAW buffers are
just blocks without any structure. It's not the intent for static to imply
compile-time since the caller specifies the size of the buffer block being
used.
The reality is I don't believe we have any actual uses of
ODP_BUFF
If we move endian config to the build system, I'd think we'd also want to
move the 32-bit vs. 64-bit there as well. There are a lot of places in the
linux-generic code where uint64_t is used without qualification and that's
not going to work on 32-bit implementations.
On Mon, Nov 3, 2014 at 2:03
On Mon, 3 Nov 2014 12:22:25 +0200 Shmulik Ladkani
wrote:
> An 'odp_init_local_register' interface would allow one to do so, and
> it's pretty harmful as it exposes none of ODP's internals.
harmless is what I meant ;)
___
lng-odp mailing list
lng-odp@l
Hi Taras,
On Mon, 03 Nov 2014 12:00:33 +0200 Taras Kondratiuk
wrote:
> On 11/03/2014 11:50 AM, Shmulik Ladkani wrote:
> > I'd like to suggest the following addition to odp_init.h:
> >
> > diff --git a/platform/linux-generic/include/api/odp_init.h
> > b/platform/linux-generic/include/api/odp_ini
On Mon, Nov 3, 2014 at 12:00 PM, Taras Kondratiuk
wrote:
> On 11/03/2014 11:50 AM, Shmulik Ladkani wrote:
>>
>> Hi,
>>
>> I'd like to suggest the following addition to odp_init.h:
>>
>> diff --git a/platform/linux-generic/include/api/odp_init.h
>> b/platform/linux-generic/include/api/odp_init.h
>>
On 11/03/2014 11:50 AM, Shmulik Ladkani wrote:
Hi,
I'd like to suggest the following addition to odp_init.h:
diff --git a/platform/linux-generic/include/api/odp_init.h
b/platform/linux-generic/include/api/odp_init.h
index 8e018cbdba..9b75609fc7 100644
--- a/platform/linux-generic/include/api/o
Hi,
I'd like to suggest the following addition to odp_init.h:
diff --git a/platform/linux-generic/include/api/odp_init.h
b/platform/linux-generic/include/api/odp_init.h
index 8e018cbdba..9b75609fc7 100644
--- a/platform/linux-generic/include/api/odp_init.h
+++ b/platform/linux-generic/include/ap
Yan,
Search this patch in you mail for example:
[PATCH] Scheduler atomic and ordered definitions
On 3 November 2014 17:15, yan.songm...@linaro.org
wrote:
> Hi Maxim,
>
> Thanks for you advice.
>
> 2. If you have any changes from previouse patch. Just open generated
> patch and add you comments
Yan, for discussing patches, it is better to set your mail client to plain
text only mode.
On 3 November 2014 17:15, yan.songm...@linaro.org
wrote:
> Hi Maxim,
>
> Thanks for you advice.
>
> 2. If you have any changes from previouse patch. Just open generated
> patch and add you comments after
Hi Maxim,
Thanks for you advice.
2. If you have any changes from previouse patch. Just open generated
patch and add you comments after "--".
like this ?
>
> cunit queue test to test_odp_queue_base for none syn queue. <--
> this comments should be the same as the previouse p
What NPS does in HW is that each buffer you dequeue actually stays on the queue
(but is marked as consumed by the application) and you are given a "tag" for it.
When I want to queue the buffer to the next, I give the HW the tag I got, not
the buffer handle and what the HW does is only than ful
"ODP_BUFFER_TYPE_RAW
+ * This is the “basic” buffer type
+ * which simply consists of a single fixed-sized block of contiguous
+ * memory. Buffers of this type do not support user meta data and the
+ * only built-in meta data supported for this type of buffer are those
+ * that are statically comp
Hi Bill,
On Sun, 2 Nov 2014 21:50:18 -0600 Bill Fischofer
wrote:
> I'm working on code to implement the new buffer APIs and have the following
> internal function:
>
> static inline void *get_block(struct pool_entry_s *pool)
> {
> void volatile *oldhead;
> void volatile *newhead;
>
https://bugs.linaro.org/show_bug.cgi?id=805
--- Comment #2 from Weilong Chen ---
Yes, I ran on my d01 board.
The kernel version is 3.14.
--
You are receiving this mail because:
You are on the CC list for the bug.___
lng-odp mailing list
lng-odp@lists.
> -Original Message-
> From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
> boun...@lists.linaro.org] On Behalf Of ext Mike Holmes
> Sent: Friday, October 31, 2014 8:25 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [PATCH 1/2] fix including odp_std_types.h
>
> The public OD
46 matches
Mail list logo
