Re: [lng-odp] odp_packet_has_error return value

2015-04-09 Thread Zoltan Kiss
We can say then: * @retval non-zero packet has errors, implementation can optionally return a non-zero error code, STRICTLY FOR DEBUGGING PURPOSES I think that would clarify that you shouldn't use this non-zero value to anything else than saving it into your logs. But any ideas to make it

Re: [lng-odp] [PATCH 1/1 v1] examples: odp_ipsec: handle alloc_pkt_ctx failure

2015-04-09 Thread Robbie King (robking)
Reviewed-by: Robbie King robk...@cisco.com -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of alexandru.badici...@linaro.org Sent: Wednesday, April 08, 2015 2:28 AM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH 1/1 v1] examples: odp_ipsec:

Re: [lng-odp] [RFC] api: classification: Create PMR handle on its application

2015-04-09 Thread Bala Manoharan
On 9 April 2015 at 14:38, Taras Kondratiuk taras.kondrat...@linaro.org wrote: + mailing list that I've missed initially in the RFC. On 04/08/2015 10:25 PM, Rosenboim, Leonid wrote: Taras, I actually agree with you that a change in the API is justified that combines the in and out CoS

Re: [lng-odp] [RFC] api: classification: Create PMR handle on its application

2015-04-09 Thread Taras Kondratiuk
+ mailing list that I've missed initially in the RFC. On 04/08/2015 10:25 PM, Rosenboim, Leonid wrote: Taras, I actually agree with you that a change in the API is justified that combines the in and out CoS values are provided at the time of PMR creation, instead of using a separate function.

Re: [lng-odp] pktio optional parsing

2015-04-09 Thread Zoltan Kiss
On 08/04/15 18:36, Mike Holmes wrote: On 8 April 2015 at 13:02, Zoltan Kiss zoltan.k...@linaro.org mailto:zoltan.k...@linaro.org wrote: Hi, OVS has a major performance issue with pktio at the moment: pktio always does parsing, but OVS does it for itself as well, and it is

Re: [lng-odp] [API-NEXT PATCH] api: pktio: Clarify doc on default pool usage on odp_pktio_open

2015-04-09 Thread Mike Holmes
I think we should get this in api-next for inclusion in odp-1.1.0. It does have to go via api-next as Bill suggests because a doc change does change how the api is defined, it is just text but an introduced ambiguity could lead to incompatible implementations. We want users to be confident that

[lng-odp] [Bug 1398] limit odp_generator to cores at run time

2015-04-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1398 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Resolution|--- |INVALID

[lng-odp] [Bug 1441] ./configure CFLAGS=-DIPSEC_POLL_QUEUES does not compile

2015-04-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1441 --- Comment #2 from Mike Holmes mike.hol...@linaro.org --- (In reply to Alexandru Badicioiu from comment #1) This bug should not be fixed , it is obsoleted by https://cards.linaro.org/browse/LNG-872. The CARDS are not publicly visible. Triage

Re: [lng-odp] [PATCHv13 3/5] validation: move l2fwd from example to performance tests

2015-04-09 Thread Christophe Milard
Hi Maxim, I am not fully following what this patch does -I appologize for this- but I am a bit worried about the usage of scripts and other environment specific usage in the tests. I am trying to restructure the test/validation tree to enventually get one single directory per ODP API module and

Re: [lng-odp] odp_packet_has_error return value

2015-04-09 Thread Zoltan Kiss
On 09/04/15 16:11, Bill Fischofer wrote: I'm not sure what the benefit of the proposed hack would be, since you're returning an opaque value. Still, your app can print that number into the log, so if the developer looks up the particular platform implementation, he can get an idea what the

Re: [lng-odp] [PATCHv2] example: ODP classifier example

2015-04-09 Thread Bala
On Wednesday 08 April 2015 11:34 PM, Mike Holmes wrote: when not run as root ./odp_classifier -i eth0 odp_shared_memory.c:265:odp_shm_reserve(): packet_pool: No huge pages, fall back to normal pages, check: /proc/sys/vm/nr_hugepages. odp_packet_socket.c:438:mmap_pkt_socket():socket(SOCK_RAW):

[lng-odp] [Bug 1375] Packet IO tests pass ODP_PKTIO_INVALID to packet IO API

2015-04-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1375 --- Comment #1 from Stuart Haslam stuart.has...@linaro.org --- Yes I agree. ODP_PKTIO_INVALID is just one of many invalid handles that may be passed and we shouldn't force the implementation to explicitly check for it. -- You are receiving this mail

[lng-odp] [Bug 706] odp: l2fwd-dpdk port unable to spwan coremask specified number of threads

2015-04-09 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=706 Santosh Shukla santosh.shu...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

Re: [lng-odp] [PATCH 1/1 v1] examples: odp_ipsec: runtime select scheduled vs poll queues

2015-04-09 Thread Robbie King (robking)
Reviewed-by: Robbie King robk...@cisco.com -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of alexandru.badici...@linaro.org Sent: Wednesday, April 08, 2015 2:28 AM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH 1/1 v1] examples: odp_ipsec: