Assuming that entire api_test directory will be removed next.
Reviewed-by: Petri Savolainen petri.savolai...@nokia.com
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
Mike Holmes
Sent: Tuesday, April 14, 2015 11:00 PM
To:
On 21 April 2015 at 05:06, Nicolas Morey-Chaisemartin nmo...@kalray.eu
wrote:
Flush cache triggers atomic_add on some of the pool atomics which have
never been initialized if the pool hasn't been.
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
Subject needs to isolate the basic
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
doc/api_guide_lines.dox | 4
1 file changed, 4 insertions(+)
diff --git a/doc/api_guide_lines.dox b/doc/api_guide_lines.dox
index 2bc63a1..f26ce38 100644
--- a/doc/api_guide_lines.dox
+++ b/doc/api_guide_lines.dox
@@ -187,6 +187,10 @@
I have no problem with these changes however they appear unnecessary. To
the extent that the pool stats require initialization beyond the store
that's already done, I'd do this as part of the odp_pool_global_init()
routine. That way, like the pool locks, they are initialized only once
rather
On Tue, Apr 21, 2015 at 2:14 PM, Mike Holmes mike.hol...@linaro.org wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
test/validation/odp_pool.c | 25 +
1 file changed, 25 insertions(+)
diff --git
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/odp_pool.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/test/validation/odp_pool.c b/test/validation/odp_pool.c
index 1a518a0..c2f9a1b 100644
--- a/test/validation/odp_pool.c
+++
Looks good, however we should have some standards for why an API may be
deprecated and what should be done to document it. For example, an API may
be deprecated if it is superseded by another API that provides a more
complete function. Or it may be deprecated if there is agreement that it
is not
- Original Message -
From: Mike Holmes mike.hol...@linaro.org
To: Nicolas Morey-Chaisemartin nmo...@kalray.eu
Cc: lng-odp lng-odp@lists.linaro.org
Sent: Tuesday, 21 April, 2015 7:24:44 PM
Subject: Re: [lng-odp] [PATCH] pool: Do not flush cache of non-initialized
pools
On 21 April
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
platform/linux-generic/odp_pool.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/platform/linux-generic/odp_pool.c
b/platform/linux-generic/odp_pool.c
index bf49623..23cd503 100644
Flush cache triggers atomic_add on some of the pool atomics which have never
been initialized if the pool hasn't been.
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
platform/linux-generic/odp_pool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
On 20 April 2015 at 19:15, Mike Holmes mike.hol...@linaro.org wrote:
I think the current patch solves the bug, there are no longer failures to
terminate threads which is a bug in the implementation.
It sounds like there is a new lower priority bug to clean out the example
which throws up
On 21 April 2015 at 14:26, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 04/21/15 15:01, Bill Fischofer wrote:
Behavior is undefined if rules are ambiguous. Consider the following
rules:
protocol == UDP -- CoS A
port == 1234 -- CoS B
What happens if a UDP packet for port 1234 arrives?
On 21 April 2015 at 16:57, Maxim Uvarov maxim.uva...@linaro.org wrote:
Bala, one more comment. Please do parsing arguments before odp init.
About this code Mike found that it will be abort if you do not run it under
root due to
unable do raw socket operations.
pktio =
On 21 April 2015 at 18:15, Ola Liljedahl ola.liljed...@linaro.org wrote:
On 21 April 2015 at 14:26, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 04/21/15 15:01, Bill Fischofer wrote:
Behavior is undefined if rules are ambiguous. Consider the following
rules:
protocol == UDP -- CoS A
It seems to me all questions were answered, is there anything which
prevents applying this into master branch?
Petri?
On 10/04/15 16:52, Bill Fischofer wrote:
v4 changes:
- Removed RFC status, patch is now ready for API-NEXT
- Added implementation of approved APIs
- Added user metadata tests
Merged,
Maxim.
On 04/21/15 10:25, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Assuming that entire api_test directory will be removed next.
Reviewed-by: Petri Savolainen petri.savolai...@nokia.com
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf
UberConference Reminder___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
On 20/04/15 10:36, Ola Liljedahl wrote:
On 20 April 2015 at 11:12, Maxim Uvarov maxim.uva...@linaro.org
mailto:maxim.uva...@linaro.org wrote:
How that supposed to increase performance?
The code will be like:
if (parse_vlan)
do_parse_vlan
if (parse_ipv4)
On 04/21/2015 01:31 PM, Ola Liljedahl wrote:
On 17 April 2015 at 10:46, Nicolas Morey-Chaisemartin nmo...@kalray.eu
mailto:nmo...@kalray.eu wrote:
Hello every one,
I am currently working on porting the linux-generic implementation of
DPDK on Kalray architecture and slightly
On 21 April 2015 at 14:01, Nicolas Morey-Chaisemartin nmo...@kalray.eu
wrote:
On 04/21/2015 01:31 PM, Ola Liljedahl wrote:
On 17 April 2015 at 10:46, Nicolas Morey-Chaisemartin
nmo...@kalray.eunmo...@kalray.eu wrote:
Hello every one,
I am currently working on porting the linux-generic
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
Maxim Uvarov
Sent: Tuesday, April 21, 2015 1:39 PM
To: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCH API-NEXT 5/5] api: packet_io: added start
and stop
On 04/20/15 15:10, Petri
Behavior is undefined if rules are ambiguous. Consider the following rules:
protocol == UDP -- CoS A
port == 1234 -- CoS B
What happens if a UDP packet for port 1234 arrives? Answer: undefined.
The result may be either CoS A or CoS B.
A better rule set would be:
protocol == UDP -- CoS A
CoS
Reviewed-by: Zoltan Kiss zoltan.k...@linaro.org
On 20/04/15 13:10, Petri Savolainen wrote:
Application can indicate which packet parsing results it is
interested in (all, none or selected).
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/packet_flags.h | 26
On 21 April 2015 at 15:39, Bill Fischofer bill.fischo...@linaro.org wrote:
Looks good, however we should have some standards for why an API may be
deprecated and what should be done to document it. For example, an API may
be deprecated if it is superseded by another API that provides a more
Add test cases for APIs in the logical ODP THREAD grouping
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/.gitignore | 1 +
test/validation/Makefile.am | 4 +++-
test/validation/odp_thread.c | 41 +
3 files changed, 45
The init calls should be moved to odp_pool_init_global() and the stores
should be left unchanged here.
On Tue, Apr 21, 2015 at 3:59 AM, Nicolas Morey-Chaisemartin
nmo...@kalray.eu wrote:
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
platform/linux-generic/odp_pool.c | 26
One of the reasons why I was looking to use the rte_mbuf to represent
packet data rather than packets is that ODP has a richer set of packet
manipulation primitives than does DPDK, and this set will only grow over
time. Trying to overload the rte_mbuf to describe both the packet metadata
and the
The design doc says what I've been saying here. It's the application's
responsibility to ensure that the rule set specified is unambiguous.
On Tue, Apr 21, 2015 at 8:08 AM, Bala Manoharan bala.manoha...@linaro.org
wrote:
On 21 April 2015 at 18:15, Ola Liljedahl ola.liljed...@linaro.org wrote:
Code rules IMHO - the compiler will ensure we follow the rules.
Can we add test cases to prove the behavior across all platforms,
linux-generic being one of them, and thus the code is correct no matter
what is written anywhere else. Presumably the api documentation matches the
code but it should
The helpers need to be tested independently from the ODP API, create a
folder to contain helper tests, adding tests for process and thread
creation.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
configure.ac | 15 +
test/Makefile.am | 5 ++-
Actually, checkpatch requires balanced braces. If one arm of an if/else
requires braces, then checkpatch says the other should have braces even if
it's a single statement.
On Mon, Apr 13, 2015 at 4:18 PM, Ola Liljedahl ola.liljed...@linaro.org
wrote:
On 9 April 2015 at 19:39, Robbie King
I think the point is that decoding what the application has specified
likely costs about as much as just doing the parse to begin with if you're
doing this in SW, and HW probably doesn't have anything like this sort of
control. So what is the point here?
A lazy parser approach would seem to be
On 04/20/15 15:10, Petri Savolainen wrote:
Packet IO start and stop enable a controlled setup and
tear down phases.
Interface control sequence:
* odp_pktio_open() creates a pktio interface object
* potential interface configurations (classification, input queues, etc)
* odp_pktio_start()
On 20 April 2015 at 08:32, Ola Liljedahl ola.liljed...@linaro.org wrote:
Fixes https://bugs.linaro.org/show_bug.cgi?id=1450
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
Reviewed-by: Mike Holmes mike.hol...@linaro.org
---
(This document/code contribution attached is provided
On 17 April 2015 at 10:46, Nicolas Morey-Chaisemartin nmo...@kalray.eu
wrote:
Hello every one,
I am currently working on porting the linux-generic implementation of DPDK
on Kalray architecture and slightly pulling my hair out with all the
atomics.
Surely you mean ODP and not DPDK?
By
Bala, one more comment. Please do parsing arguments before odp init.
About this code Mike found that it will be abort if you do not run it
under root due to
unable do raw socket operations.
pktio = odp_pktio_open(dev, pool);
if (pktio == ODP_PKTIO_INVALID)
On 20 April 2015 at 21:49, Bill Fischofer bill.fischo...@linaro.org wrote:
Classification is a collaboration between the implementation and the
application. It is the application's responsibility to write unambiguous
classification rules and it is the implementation's job to perform the
On 21 April 2015 at 09:01, Bala Manoharan bala.manoha...@linaro.org wrote:
On 21 April 2015 at 16:57, Maxim Uvarov maxim.uva...@linaro.org wrote:
Bala, one more comment. Please do parsing arguments before odp init.
About this code Mike found that it will be abort if you do not run it
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
I'm updating IPC patch version to the latest ODP code here:
https://git.linaro.org/people/maxim.uvarov/odp.git odp_ipc_v4
And found that it will be good to add more parameters to pool_create().
For example I need to pass there flag
We discussed this during today's ODP public call. Petri has a proposed set
of API extensions to pktio to allow the application to tell the
implementation what it needs in terms of parsing. While this sounds
reasonable, my concern is that the application may not know as much as it
things it
40 matches
Mail list logo
