Re: [lng-odp] [API-NEXT PATCHv2] api: pktio: Clarify doc on default pool usage on odp_pktio_open

2015-04-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
-Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext Maxim Uvarov Sent: Friday, April 24, 2015 1:55 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCHv2] api: pktio: Clarify doc on default pool usage on odp_pktio_open

Re: [lng-odp] [API-NEXT PATCH v2] timer: Add missing platform handles to u64 conversion functions

2015-04-24 Thread Jerin Jacob
On Fri, Apr 24, 2015 at 11:46:53AM +0300, Maxim Uvarov wrote: Hi Jerin, you you only removed RFC and Petri added sign-off to that patch you should include it to patch without rfc. also v1..v2... should go after --- line in patch. In that case git am just skips that comment. Thanks for

Re: [lng-odp] [API-NEXT PATCHv2] api: pktio: Clarify doc on default pool usage on odp_pktio_open

2015-04-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
This is not a v2, since the original patch was already merged. Also my patches change the same lines, so need to rebase this after those are merged. -Petri -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext Bill Fischofer Sent: Thursday,

Re: [lng-odp] [PATCH] example: timer: remove global variables to share the data between workers

2015-04-24 Thread Maxim Uvarov
On 04/20/15 11:28, Jerin Jacob wrote: + /* Reserve memory for test_globals_t from shared mem */ + shm = odp_shm_reserve(shm_test_globals, sizeof(test_globals_t), + ODP_CACHE_LINE_SIZE, 0); if (ODP_SHM_INVALID == shm) return -1; + gbls =

Re: [lng-odp] [API-NEXT PATCHv2] api: pktio: Clarify doc on default pool usage on odp_pktio_open

2015-04-24 Thread Maxim Uvarov
On 04/24/15 14:04, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext Maxim Uvarov Sent: Friday, April 24, 2015 1:55 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCHv2] api:

Re: [lng-odp] [PATCHv4] example: ODP classifier example

2015-04-24 Thread Maxim Uvarov
Merged, Maxim. On 04/23/15 21:59, Mike Holmes wrote: On 23 April 2015 at 06:37, bala.manoha...@linaro.org mailto:bala.manoha...@linaro.org wrote: From: Balasubramanian Manoharan bala.manoha...@linaro.org mailto:bala.manoha...@linaro.org ODP Classifier example

Re: [lng-odp] [API-NEXT PATCH v2] timer: Add missing platform handles to u64 conversion functions

2015-04-24 Thread Maxim Uvarov
Hi Jerin, you you only removed RFC and Petri added sign-off to that patch you should include it to patch without rfc. also v1..v2... should go after --- line in patch. In that case git am just skips that comment. Patch merged to api-next. Thanks, Maxim. On 04/24/15 09:14, Jerin Jacob

Re: [lng-odp] [PATCH] example: timer: remove global variables to share the data between workers

2015-04-24 Thread Maxim Uvarov
On 04/24/15 12:19, Jerin Jacob wrote: On Fri, Apr 24, 2015 at 11:39:58AM +0300, Maxim Uvarov wrote: On 04/20/15 11:28, Jerin Jacob wrote: + /* Reserve memory for test_globals_t from shared mem */ + shm = odp_shm_reserve(shm_test_globals, sizeof(test_globals_t), +

Re: [lng-odp] [API-NEXT PATCH v2] timer: Add missing platform handles to u64 conversion functions

2015-04-24 Thread Mike Holmes
Hi Jerin Before this is merged with mainline I think we should have a linux-generic implementation and a test case for it. Do you have the cycles to add those to api-next so that this can be part of 1.2.0 ? I think tentatively that 1.2.0 will be in August at this point, although if we can start

Re: [lng-odp] [PATCH] example: timer: remove global variables to share the data between workers

2015-04-24 Thread Jerin Jacob
On Fri, Apr 24, 2015 at 11:39:58AM +0300, Maxim Uvarov wrote: On 04/20/15 11:28, Jerin Jacob wrote: +/* Reserve memory for test_globals_t from shared mem */ +shm = odp_shm_reserve(shm_test_globals, sizeof(test_globals_t), + ODP_CACHE_LINE_SIZE, 0); if

Re: [lng-odp] Atomics

2015-04-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl Sent: Thursday, April 23, 2015 8:40 PM To: Maxim Uvarov Cc: LNG ODP Mailman List Subject: Re: [lng-odp] Atomics On 22 April 2015 at 13:24, Maxim Uvarov maxim.uva...@linaro.orgmailto:maxim.uva...@linaro.org

Re: [lng-odp] [API-NEXT PATCH v2] timer: Add missing platform handles to u64 conversion functions

2015-04-24 Thread Mike Holmes
On 24 April 2015 at 08:31, Savolainen, Petri (Nokia - FI/Espoo) petri.savolai...@nokia.com wrote: These are trivial enough to get into v1.1. I was thinking that we freeze the v1.1 API next week, and then work on the missing implementation/validation code before labeling the official 1.1.0

[lng-odp] [PATCHv3 2/2] validation: tests for module odp_ver_abt_log_dbg

2015-04-24 Thread Christophe Milard
Created directory for module odp_ver_abt_log_dbg, populated with file odp_errno.c and odp_system.c which, despite its confusing name is not testing the system module but the sys* function of the odp_ver_abt_log_dbg module. Signed-off-by: Christophe Milard christophe.mil...@linaro.org --- same

[lng-odp] [PATCH 1/3] test: classification: add missing init of atomic variable

2015-04-24 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- test/validation/classification/odp_classification_tests.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/validation/classification/odp_classification_tests.c b/test/validation/classification/odp_classification_tests.c index

[lng-odp] [PATCH] linux-generic: timer: use plain buffers for timeouts

2015-04-24 Thread Ola Liljedahl
Use plain buffers for timeouts. Store the timeout header in the buffer data area. This simplifies re-use on other platforms where the event header cannot be arbitrarily defined. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under

[lng-odp] Threads Thread Safety

2015-04-24 Thread Nicolas Morey-Chaisemartin
Hi everyone, I'm currently trying to get all the ODP validation tests running on our MPPA platform and ran across an issue: It appears CUnit (2.1-3) is *not* thread safe ! It isn't a very big issue but it creates unexpected behaviour (and warnings in our simulators) in the odp_shm test for

[lng-odp] [PATCH 2/3] linux-generic: packet_io: init l2 and l3 cos table spinlocks

2015-04-24 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- platform/linux-generic/odp_packet_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/platform/linux-generic/odp_packet_io.c b/platform/linux-generic/odp_packet_io.c index cfe5b71..f16685d 100644 ---

[lng-odp] [PATCH 3/3] validation: synchronizers: fix init of custom barrier atomic

2015-04-24 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- test/validation/odp_synchronizers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/validation/odp_synchronizers.c b/test/validation/odp_synchronizers.c index edb6bf1..a9be1c5 100644 ---

[lng-odp] [PATCH 2/2] validation: init tests using common main

2015-04-24 Thread Christophe Milard
The 3 init tests (init, abort,log) now links with common/odp_cunit_common, as other tests. In main, ODP init is now performed via weak functions which are overloaded (to do nothing) by the 3 init tests. Signed-off-by: Christophe Milard christophe.mil...@linaro.org --- test/validation/Makefile.am

[lng-odp] [PATCH 1/2] validation: init src files in single directory

2015-04-24 Thread Christophe Milard
The 3 tests for initialisation still generate 3 executables, but their sources are simply gathered in a single directory called as the module itself, init. Signed-off-by: Christophe Milard christophe.mil...@linaro.org --- test/validation/Makefile.am | 6 +++--- test/validation/{

[lng-odp] [PATCH] api: time: force time defines as ULL to avoid computation overflows on 32bits systems

2015-04-24 Thread Nicolas Morey-Chaisemartin
For example the odp_timer validation tests computes 10 * ODP_TIME_SEC and stores it into an uint64_t, but the computation overflows on 32b systems and the test fails Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- include/odp/api/time.h | 6 +++--- 1 file changed, 3

Re: [lng-odp] [API-NEXT PATCH v2] timer: Add missing platform handles to u64 conversion functions

2015-04-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
These are trivial enough to get into v1.1. I was thinking that we freeze the v1.1 API next week, and then work on the missing implementation/validation code before labeling the official 1.1.0 release . -Petri From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext Mike Holmes

Re: [lng-odp] [API-NEXT PATCH v2] timer: Add missing platform handles to u64 conversion functions

2015-04-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
Also packet_user_area (metadata) and my pktio API changes are missing implementation. The delta between API 1.0 and 1.1 is pretty slim if those are left out also. -Petri From: ext Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Friday, April 24, 2015 3:45 PM To: Savolainen, Petri (Nokia -

Re: [lng-odp] [API-NEXT PATCH v2] timer: Add missing platform handles to u64 conversion functions

2015-04-24 Thread Bill Fischofer
The user metadata patch I submitted is complete. If you rename the APIs you just need to also rename the implementations and then that will be complete as well. On Fri, Apr 24, 2015 at 8:00 AM, Savolainen, Petri (Nokia - FI/Espoo) petri.savolai...@nokia.com wrote: Also packet_user_area

Re: [lng-odp] [PATCH 2/2] validation: init tests using common main

2015-04-24 Thread Mike Holmes
On 24 April 2015 at 08:54, Christophe Milard christophe.mil...@linaro.org wrote: The 3 init tests (init, abort,log) now links with common/odp_cunit_common, as other tests. In main, ODP init is now performed via weak functions which are overloaded (to do nothing) by the 3 init tests.

Re: [lng-odp] [API-NEXT PATCH v2] timer: Add missing platform handles to u64 conversion functions

2015-04-24 Thread Mike Holmes
On 24 April 2015 at 10:14, Bill Fischofer bill.fischo...@linaro.org wrote: The user metadata patch I submitted is complete. If you rename the APIs you just need to also rename the implementations and then that will be complete as well. We specifically need the packet parsing switch and

Re: [lng-odp] [PATCHv3 1/2] validation: rename executable to match modules

2015-04-24 Thread Mike Holmes
apply-and-build https://git.linaro.org/lng/check-odp.git- gives WARNING: braces {} are not necessary for single statement blocks #3328: FILE: test/validation/odp_scheduler.c:760: + if (odp_pool_destroy(pool) != 0) { + fprintf(stderr, error: failed to destroy pool\n); + } On 24 April 2015 at

Re: [lng-odp] [API-NEXT PATCHv4 0/6] Add packet user metadata support

2015-04-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: ext Ola Liljedahl [mailto:ola.liljed...@linaro.org] Sent: Thursday, April 23, 2015 8:29 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: ext Bill Fischofer; lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCHv4 0/6] Add packet user metadata support On 22 April 2015 at 15:01,

Re: [lng-odp] [PATCH v2 2/2] linux-generic: pool: fix initialization of odp_buffer_hdr ref_count

2015-04-24 Thread Nicolas Morey-Chaisemartin
All good now. Thanks! On 04/23/2015 10:53 PM, Bill Fischofer wrote: Both parts should be applied. On Thu, Apr 23, 2015 at 8:02 AM, Nicolas Morey-Chaisemartin nmo...@kalray.eu mailto:nmo...@kalray.eu wrote: Thanks. Is there a reason why you did not apply the first patch of the

Re: [lng-odp] [PATCH] validation: thread: add odp_thread sunnyday tests

2015-04-24 Thread Anders Roxell
On 2015-04-21 17:26, Mike Holmes wrote: Add test cases for APIs in the logical ODP THREAD grouping Signed-off-by: Mike Holmes mike.hol...@linaro.org Reviewed-by: Anders Roxell anders.rox...@linaro.org --- test/validation/.gitignore | 1 + test/validation/Makefile.am | 4 +++-

Re: [lng-odp] [API-NEXT PATCH v2] timer: Add missing platform handles to u64 conversion functions

2015-04-24 Thread Jerin Jacob
On Mon, Apr 20, 2015 at 04:22:15PM +0530, Jerin Jacob wrote: ping v1..v2 Removed RFC Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- include/odp/api/timer.h | 39 +++ 1 file changed, 39 insertions(+) diff --git

Re: [lng-odp] [PATCH] example: timer: remove global variables to share the data between workers

2015-04-24 Thread Jerin Jacob
On Mon, Apr 20, 2015 at 02:05:50PM +0530, Jerin Jacob wrote: ping Adding the the complete git commit log for the commit example: timer: remove global variables to share the data between workers. use the odp_shared_memory allocater instead to enable the timer example to run on