Packet IO interface level parameters are needed e.g. to
select input mode. User must select and use one input mode
(sched, poll or recv) per pktio interface.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
example/classifier/odp_classifier.c| 6 +++-
Application can indicate which packet parsing results it is
interested in (all or none).
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/packet_io.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/odp/api/packet_io.h
From: ext Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Tuesday, May 05, 2015 3:03 PM
To: Savolainen, Petri (Nokia - FI/Espoo)
Subject: Re: [lng-odp] [API-NEXT PATCH v3 1/4] api: packet: rename user_data to
user_area
diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h
index
On 5 May 2015 at 07:04, Christophe Milard christophe.mil...@linaro.org
wrote:
On 5 May 2015 at 11:15, Maxim Uvarov maxim.uva...@linaro.org wrote:
2 comments bellow
On 04/27/2015 11:53, Christophe Milard wrote:
Just the executables whose contents already matched a module have been
On Tue, May 5, 2015 at 2:24 AM, Nicolas Morey-Chaisemartin nmo...@kalray.eu
wrote:
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
test/validation/odp_queue.c| 1 +
test/validation/odp_schedule.c | 4 ++--
2 files
All handles are ODP types, no need to repeat that.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/packet_io.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/include/odp/api/packet_io.h
Reviewed-by: Robbie King robk...@cisco.com
v3:
* rebased
* removed two empty lines
v2:
* removed selected parse option
Petri Savolainen (5):
api: packet_io: change word instance to interface
api: packet_io: remove excess references to ODP
api: packet_io: added odp_pktio_param_t
Packet IO start and stop enable a controlled setup and
tear down phases.
Interface control sequence:
* odp_pktio_open() creates a pktio interface object
* potential interface configurations (classification, input queues, etc)
* odp_pktio_start() enables packet input/output
* receive / transmit
On 30/04/15 20:26, Mike Holmes wrote:
On 30 April 2015 at 08:16, Bill Fischofer bill.fischo...@linaro.org
mailto:bill.fischo...@linaro.org wrote:
You've articulated why we don't need API changes for this. Each
implementation is free to optimize its performance as it chooses
Patch “[lng-odp] [API-NEXT PATCH v3 4/5] api: packet_io: added parse mode” can
be left out from the series for now, if need to have a timeout on
parser/classifier configuration API. Lazy parsing is a workaround which won’t
help to optimize HW/FW parsers.
All other patches are needed, though.
This is on API todo list with high priority. We'll actually change from cpu IDs
to thread IDs while adding this mapping. So, application lists (per queue) a
set of thread IDs (into schedule group) that are available for the scheduler to
choose from. The default is all threads.
-Petri
From: Alexandru Badicioiu alexandru.badici...@linaro.org
v1 - fixed compile error due to -Wcast-align
Signed-off-by: Alexandru Badicioiu alexandru.badici...@linaro.org
---
helper/include/odp/helper/udp.h | 37 +
1 files changed, 13 insertions(+), 24
Given Zoltan's confirmation I would recommend that we defer the PktIO
changes until we can have a more complete discussion of what would be
useful/needed as a next-phase classification API (including specifying
parse needs) and rely on lazy parsing in SW to meet the immediate needs for
OVS
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/packet_io.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
index 89356a6..8e23630 100644
--- a/include/odp/api/packet_io.h
+++
Simplified the API by removing user_u64 option. User has now room
for a pointer (or upto intptr_t sized variable) and a
configurable sized user_area. Both can be used at the same time.
User has to use the user_area when more space than sizeof(intptr_t)
bytes is needed.
Signed-off-by: Petri
Type + union highlights the usage better than union + type. Less
packed structure is likely not an issue, since pools are few.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/pool.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Term area highlights better that the per packet user area
is fixed in size and position. E.g. odp_packet_data(),
odp_packet_seg_data() return pointers which are (likely)
modified during packet processing.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/packet.h
Moved comments into separate lines for better readability (more
chars per line).
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/pool.h | 66 ++
1 file changed, 34 insertions(+), 32 deletions(-)
diff --git
On 05/05/2015 14:20, Savolainen, Petri (Nokia - FI/Espoo) wrote:
*From:*ext Maxim Uvarov [mailto:maxim.uva...@linaro.org]
*Sent:* Monday, May 04, 2015 8:20 PM
*To:* Savolainen, Petri (Nokia - FI/Espoo)
*Cc:* lng-odp@lists.linaro.org
*Subject:* Re: Reverts in the repo ...
On 4 May 2015 at
Lets define this and publish it on the website as our procedure, this is
under review and is open for comments
ODP Release Process
https://docs.google.com/a/linaro.org/document/d/1jCWRW9yHbzNp8dmZ1X8ZNQB1YzKyZbipoYY101Uhkhg/edit?usp=drive_web
On 5 May 2015 at 07:20, Savolainen, Petri (Nokia
Just the executables whose contents already matched a module have been
renamed. Module names are taken from doxygens defgroup, with
the exepection of pktio, as of Maxims requirement.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/.gitignore
I don’t see a need for that. The purpose of the patch is easy to see, and
commits cannot get out-of-sync or out-of-order (there’s only one) .
-Petri
From: ext Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Tuesday, May 05, 2015 3:05 PM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: LNG
http://people.linaro.org/~mike.holmes/odp-api/html/release.html
When I paste this it works for me - not sure where it is going wrong does
http://people.linaro.org/~mike.holmes/odp-api/html work for you ? - if so
look at the Release Management tab.
On 4 May 2015 at 15:22, Bill Fischofer
On 5 May 2015 at 11:27, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 05/05/2015 14:20, Savolainen, Petri (Nokia - FI/Espoo) wrote:
*From:*ext Maxim Uvarov [mailto:maxim.uva...@linaro.org]
*Sent:* Monday, May 04, 2015 8:20 PM
*To:* Savolainen, Petri (Nokia - FI/Espoo)
*Cc:*
UberConference Reminder___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
OK sorry. The link point to version1.
On 5 May 2015 at 18:06, Christophe Milard christophe.mil...@linaro.org
wrote:
This patch
https://lists.linaro.org/pipermail/lng-odp/2015-April/011266.html has
been on the list since the 27/4, following a few comments from
Mike...Anyone willing to review
On 29 April 2015 at 04:34, bala.manoha...@linaro.org wrote:
From: Balasubramanian Manoharan bala.manoha...@linaro.org
This patch removes support for odp_pmr_create_range() function
in the classifier example application.
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
Same as version 4 but excluding the renaming of the pktio module,
which remains, for the time being, inconsistent with the doxygen
defgroup (as required by Maxim).
Christophe Milard (2):
validation: rename executable to match modules
validation: tests for module odp_ver_abt_log_dbg
Created directory for module odp_ver_abt_log_dbg, populated
with file odp_errno.c and odp_system.c which, despite its
confusing name is not testing the system module but the sys*
function of the odp_ver_abt_log_dbg module.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
Hello,
I saw in Christophe patch to rename odp_pktio test to odp_packet_io.
Christophe did that because doxygen generated document has packet_io
name for this chapter. I think that we need do rename in doxygen than
rename test to better patch all odp_pktio prefixes in the code.
Any thoughts
This patch
https://lists.linaro.org/pipermail/lng-odp/2015-April/011266.html has
been on the list since the 27/4, following a few comments from
Mike...Anyone willing to review it (v2)?
Thanks,
Christophe.
___
lng-odp mailing list
lng-odp@lists.linaro.org
On 5 May 2015 at 11:55, Maxim Uvarov maxim.uva...@linaro.org wrote:
Hello,
I saw in Christophe patch to rename odp_pktio test to odp_packet_io.
Christophe did that because doxygen generated document has packet_io name
for this chapter. I think that we need do rename in doxygen than rename
On 5 May 2015 at 11:49, Christophe Milard christophe.mil...@linaro.org
wrote:
Same as version 4 but excluding the renaming of the pktio module,
which remains, for the time being, inconsistent with the doxygen
defgroup (as required by Maxim).
Christophe Milard (2):
validation: rename
This should logically be two patches. The first part removes the
validation tests and the second removes the API definitions.
On Tue, May 5, 2015 at 5:23 AM, Petri Savolainen petri.savolai...@nokia.com
wrote:
Simplified the API by removing user_u64 option. User has now room
for a pointer (or
On Tue, May 5, 2015 at 8:11 AM, Petri Savolainen petri.savolai...@nokia.com
wrote:
All handles are ODP types, no need to repeat that.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
include/odp/api/packet_io.h | 32
Queue sched group is meant to specify which cores will receive events from
that queue. You would create the completion queue in a scheduler group
containing the target core.
Hope this helps,
Alex
On 4 May 2015 at 17:57, Ciprian Barbu ciprian.ba...@linaro.org wrote:
Hi,
I received this
But the mapping between odp_schedule_group_t to odp_cpumask_t for the cpu's
allowed to schedule is missing in the current spec.
/Jerin
From: lng-odp lng-odp-boun...@lists.linaro.org on behalf of Alexandru
Badicioiu alexandru.badici...@linaro.org
Sent: Tuesday, May 5, 2015 11:47 AM
To:
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
test/validation/odp_queue.c| 1 +
test/validation/odp_schedule.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/test/validation/odp_queue.c b/test/validation/odp_queue.c
index 5d47399..5123939 100644
---
Those who feel they need some background for the discussion can keep
reading.
This is more like a status mail. Mike and Stuart can stop reading here :-)
The meeting has two main goals:
-decide what to do with the test environment.
-decide where to place the helper tests (test/helpers vs
On Mon, May 4, 2015 at 10:19 PM, Bill Fischofer
bill.fischo...@linaro.org wrote:
This is a non-trivial problem because it's not obvious what the correct
answer is. While one can certainly engineer test cases where it's better to
schedule completions back to the same core (e.g., cache is already
odp_buffer_encode_handle initializes only the useful bits but not all of them
which causes error in valgrind:
==1192== Conditional jump or move depends on uninitialised value(s)
==1192==at 0x40CB01: odp_timeout_alloc (odp_timer.c:861)
==1192==by 0x402A2A: test_timeout_pool_alloc
2 comments bellow
On 04/27/2015 11:53, Christophe Milard wrote:
Just the executables whose contents already matched a module have been
renamed. Module names are taken from doxygens defgroup
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
v3/v4 delta: fixed odp_scheduler.c
On Tue, May 5, 2015 at 9:17 AM, Alexandru Badicioiu
alexandru.badici...@linaro.org wrote:
Queue sched group is meant to specify which cores will receive events from
that queue. You would create the completion queue in a scheduler group
containing the target core.
This is exactly what I had in
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
platform/linux-generic/odp_impl.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/platform/linux-generic/odp_impl.c
b/platform/linux-generic/odp_impl.c
index ca3224d..a182bc6 100644
---
Hi all,
I am going to set up odp test in vm in the Lava lab, but there are
some conditions still not so clear to me, so I'd like to start this
discussion, hope anyone involved in or familiar with related areas can
give some comments or suggestions.
1. For the vm guest, which kernel and rootfs
Moved comments into separate lines for better readability (more
chars per line).
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/pool.h | 66 ++
1 file changed, 34 insertions(+), 32 deletions(-)
diff --git
Type + union highlights the usage better than union + type. Less
packed structure is likely not an issue, since pools are few.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/pool.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Looks good.
Thanks,
Maxim.
On 05/05/2015 11:14, Nicolas Morey-Chaisemartin wrote:
odp_buffer_encode_handle initializes only the useful bits but not all of them
which causes error in valgrind:
==1192== Conditional jump or move depends on uninitialised value(s)
==1192==at 0x40CB01:
Simplified the API by removing user_u64 option. User has now room
for a pointer (or upto intptr_t sized variable) and a
configurable sized user_area. Both can be used at the same time.
User has to use the user_area when more space than sizeof(intptr_t)
bytes is needed.
Signed-off-by: Petri
Term area highlights better that the per packet user area
is fixed in size and position. E.g. odp_packet_data(),
odp_packet_seg_data() return pointers which are (likely)
modified during packet processing.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
---
include/odp/api/packet.h
On 04/27/2015 16:03, Stuart Haslam wrote:
@@ -53,6 +56,18 @@ struct pktio_entry {
char name[IFNAMSIZ];/** name of pktio provided to
pktio_open() */
odp_bool_t promisc; /** promiscuous mode state */
+ odph_ring_t *ipc_r;
On 5 May 2015 at 00:39, Santosh Shukla santosh.shu...@linaro.org wrote:
On 4 May 2015 at 02:15, Hongbo Zhang hongbo.zh...@linaro.org wrote:
On 1 May 2015 at 00:41, Santosh Shukla santosh.shu...@linaro.org wrote:
On 30 April 2015 at 09:18, Mike Holmes mike.hol...@linaro.org wrote:
Is this a
Maybe Anders can better reply to this, but I can throw in my two cents.
In general it's useful to look at the lng ci bundle stream:
https://validation.linaro.org/dashboard/streams/public/team/linaro/ci-linux-lng/bundles/
Take for example this job on ks2:
On Tue, May 5, 2015 at 1:45 PM, Ciprian Barbu ciprian.ba...@linaro.org wrote:
Maybe Anders can better reply to this, but I can throw in my two cents.
In general it's useful to look at the lng ci bundle stream:
On 5 May 2015 at 11:15, Maxim Uvarov maxim.uva...@linaro.org wrote:
2 comments bellow
On 04/27/2015 11:53, Christophe Milard wrote:
Just the executables whose contents already matched a module have been
renamed. Module names are taken from doxygens defgroup
Signed-off-by: Christophe
From: ext Maxim Uvarov [mailto:maxim.uva...@linaro.org]
Sent: Monday, May 04, 2015 8:20 PM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: lng-odp@lists.linaro.org
Subject: Re: Reverts in the repo ...
On 4 May 2015 at 13:40, Savolainen, Petri (Nokia - FI/Espoo)
56 matches
Mail list logo
