Re: [lng-odp] [API-NEXT PATCH] api: codespell: correct spelling

On Thu, Jun 4, 2015 at 12:18 PM, Mike Holmes wrote: > Signed-off-by: Mike Holmes > Reviewed-by: Bill Fischofer > --- > include/odp/api/crypto.h| 4 ++-- > include/odp/api/packet_io.h | 2 +- > include/odp/api/pool.h | 2 +- > include/odp/api/queue.h | 4 ++-- > 4 files changed,

Re: [lng-odp] [PATCH 1/2] codespell: fix spelling

On Thu, Jun 4, 2015 at 12:43 PM, Mike Holmes wrote: > Sorry there is no 2/2, I fumbled my git foo :( > > On 4 June 2015 at 13:42, Mike Holmes wrote: > >> Signed-off-by: Mike Holmes >> > Reviewed-by: Bill Fischofer > --- >> configure.ac| 2 +- >> doc/api_guide_lines.d

[lng-odp] [PATCHv3 8/8] validation: removing obsolete environment variable

These are no longer referenced and should not be used as they introduce platform dependency which should no longer occur in this platform agnostic part. Signed-off-by: Christophe Milard --- test/validation/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/validation/Makefile.

[lng-odp] [PATCHv3 3/8] validation: renaming in odp_pktio.c

Renaming of things which may be, one day, exported in a lib. This renaming is important, as it creates consistency between test symbols, which is needed if things get eventually exported in the lib. Also, tests are often created from other tests: Fixing the first exemples will help geting future te

[lng-odp] [PATCHv3 2/8] validation: own main in odp_pktio.c

Signed-off-by: Christophe Milard --- test/validation/Makefile.am | 2 ++ test/validation/odp_pktio.c | 15 +-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am index e1474aa..d4bbdb5 100644 --- a/test/validation

[lng-odp] [PATCHv3 7/8] validation: moving pktio plt specific to platform

The platform specific scripts for pktio are now moved from the validation to the platform side. Pktio tests are now initiated from the platform side. Signed-off-by: Christophe Milard --- configure.ac | 1 + platform/linux-generic/test/.gitignore

[lng-odp] [PATCHv3 5/8] validation: creating own dir and lib for pktio

Module pktio now gets its own directory and create its own lib (currentely only containing its executable) Startup scripting stuff is just moved to the pktio directory but remains untouched at this stage (test is still ran from validation side) Signed-off-by: Christophe Milard --- configure.ac

[lng-odp] [PATCHv3 4/8] validation: cosmetic fixes in odp_pktio.c

Preparing for the next patch where this file is moved and check-odp would yell if these things were still there. Signed-off-by: Christophe Milard Reviewed-by: Stuart Haslam --- test/validation/odp_pktio.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/test/val

[lng-odp] [PATCHv3 6/8] validation: changing build order

When tests will be ran from the platform side, they will use platform agnostic tests from the validation side: i.e. -the validation side must be build before the platform test side. And the platform agnostic tests uses ODP. The building order must therefore be as follows: 1) (i.e. ODP) 2) validat

[lng-odp] [PATCHv3 1/8] validation: preparing for main in tests

In odp_cunit_common.c, a macro, called MODULE_HAS_OWN_MAIN is used to tell whether to define a main or not. If MODULE_HAS_OWN_MAIN is defined, odp_cunit_common.c does not define any main, but offers odp_cunit_run(CU_SuiteInfo testsuites[]) to run the tests. Two libs are then built, one with MODULE_

[lng-odp] [PATCHv3 0/8] pktio test move to platform side

since v2: -history rewritten regarding PRE_LDADD -missing .gitignore added -correction for finding pktio_main in different cases -patch 8 added, removing obsolete test environment variables in validation -- This series of patches comes following the request from

Re: [lng-odp] [PATCH 1/2] codespell: fix spelling

Sorry there is no 2/2, I fumbled my git foo :( On 4 June 2015 at 13:42, Mike Holmes wrote: > Signed-off-by: Mike Holmes > --- > configure.ac| 2 +- > doc/api_guide_lines.dox | 4 ++-- > example/generator/odp_generator.c | 2 +- > example/ipsec/odp_ipsec_sa

[lng-odp] [PATCH 1/2] codespell: fix spelling

Signed-off-by: Mike Holmes --- configure.ac| 2 +- doc/api_guide_lines.dox | 4 ++-- example/generator/odp_generator.c | 2 +- example/ipsec/odp_ipsec_sa_db.h | 4 ++-- helper/include/odp/helper/ip.h | 2 +- helper/ring.c | 2 +-

[lng-odp] [API-NEXT PATCH] api: codespell: correct spelling

Signed-off-by: Mike Holmes --- include/odp/api/crypto.h| 4 ++-- include/odp/api/packet_io.h | 2 +- include/odp/api/pool.h | 2 +- include/odp/api/queue.h | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/odp/api/crypto.h b/include/odp/api/crypto.h ind

[lng-odp] [Bug 1441] ./configure CFLAGS=-DIPSEC_POLL_QUEUES does not compile

https://bugs.linaro.org/show_bug.cgi?id=1441 Mike Holmes changed: What|Removed |Added Resolution|--- |NON REPRODUCIBLE Status|UNCONFIRMED

[lng-odp] [Bug 1615] New: odp_timer fails in CI with Segmentation fault

https://bugs.linaro.org/show_bug.cgi?id=1615 Bug ID: 1615 Summary: odp_timer fails in CI with Segmentation fault Product: OpenDataPlane Version: 1.0.4 Hardware: Other OS: Linux Status: UNCONFIRMED Severity

Re: [lng-odp] [PATCHv3 0/2] checkpatch: turn on spelling checks

Merged. (Mike said that review was for both patches.) Thanks, Maxim. On 06/04/15 12:36, Maxim Uvarov wrote: v3: fix patch to dictionary.txt. (Sent patch for checkpatch.pl to kernel, when accepted we can merge it.) v2: 1) do not add codespell depandancy to configure.ac 2) simplify de

[lng-odp] [Bug 1548] Untested API parse_ipv6

https://bugs.linaro.org/show_bug.cgi?id=1548 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

[lng-odp] [Bug 1549] Untested API parse_tcp

https://bugs.linaro.org/show_bug.cgi?id=1549 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[lng-odp] [Bug 1609] helpers: odph_ipv4_udp_chksum is not tested

https://bugs.linaro.org/show_bug.cgi?id=1609 Mike Holmes changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org|mike.hol...@linaro.org Priority|Normal

[lng-odp] [Bug 1609] helpers: odph_ipv4_udp_chksum is not tested

https://bugs.linaro.org/show_bug.cgi?id=1609 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Priority|---

Re: [lng-odp] [PATCHv3 1/2] checkpatch: add spelling.txt

On 4 June 2015 at 05:36, Maxim Uvarov wrote: > Add linux kernel spelling.txt file to detect common typos. > > Signed-off-by: Maxim Uvarov > Reviewed-by: Mike Holmes > --- > scripts/spelling.txt | 1043 > ++ > 1 file changed, 1043 insertions(+)

Re: [lng-odp] [API-NEXT PATCH 2/2] packet_io: release unsent packets after odp_pktio_send()

On 04/06/15 10:22, Stuart Haslam wrote: On Wed, Jun 03, 2015 at 09:37:54PM +0200, Ola Liljedahl wrote: On 3 June 2015 at 20:42, Zoltan Kiss wrote: On that note it turned out this will be a lot bigger than I thought ... And I already have two questions: - what should we do if an assert over

Re: [lng-odp] [API-NEXT PATCH 2/3] api: cpumask: added default masks

> -Original Message- > From: ext Stuart Haslam [mailto:stuart.has...@linaro.org] > Sent: Thursday, June 04, 2015 4:10 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 2/3] api: cpumask: added default > masks > > On Wed,

Re: [lng-odp] [API-NEXT PATCH 2/3] api: cpumask: added default masks

On Wed, Jun 03, 2015 at 05:24:44PM +0300, Petri Savolainen wrote: > Added default cpumask functions for worker and control threads. > These will replace odph_linux_cpumask_default() helper. CPU masks > and IDs are system specific, API is generic. > > Signed-off-by: Petri Savolainen > --- > inclu

Re: [lng-odp] [PATCH] validation: queue: schedule parameters are not valid for poll type queue

Merged, Maxim. On 06/02/15 20:44, Mike Holmes wrote: I dont have any objections. On 2 June 2015 at 11:19, Maxim Uvarov > wrote: Patch looks good. Mike I think you don't have objections to apply it, right? Maxim. On 05/28/15 09:24, Jerin Jacob

Re: [lng-odp] [PATCH] scripts: add dist dependency to git_hash.sh

On 06/04/15 12:42, Nicolas Morey-Chaisemartin wrote: Thanks. I guess the ticket can be closed now. The issue with rebuilding from a dist tar.gz should probably be the topic of another issue in the bug tracker. Nicolas yes, closed it. thanks. Maxim. On 06/04/2015 11:05 AM, Maxim Uvarov wrot

Re: [lng-odp] [PATCH] checkpatch: do not warn on Camel case for printf PRIx macro

Merged, Maxim. On 06/02/15 22:23, Mike Holmes wrote: On 2 June 2015 at 11:03, Maxim Uvarov > wrote: Signed-off-by: Maxim Uvarov mailto:maxim.uva...@linaro.org>> Reviewed-by: Mike Holmes > --- scripts/checkpatch.p

Re: [lng-odp] [PATCH] checkpatch: remove warning about updating MAINTAINERS

Merged. On 06/02/15 22:38, Mike Holmes wrote: On 2 June 2015 at 07:22, Stuart Haslam > wrote: When a file is added, deleted or renamed checkpatch produces a warning about updating the MAINTAINERS file. Remove the warning as we don't have a MAINTAI

[lng-odp] [Bug 1603] regression: scripts/git_hash.sh: No such file or directory

https://bugs.linaro.org/show_bug.cgi?id=1603 Maxim Uvarov changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

Re: [lng-odp] [PATCH] scripts: add dist dependency to git_hash.sh

Thanks. I guess the ticket can be closed now. The issue with rebuilding from a dist tar.gz should probably be the topic of another issue in the bug tracker. Nicolas On 06/04/2015 11:05 AM, Maxim Uvarov wrote: > Merged. > > Tested that with: > ./scripts/builddeb > warnings disappear. > > Thanks,

[lng-odp] [PATCHv3 2/2] checkpatch: use codespell for odp

Turn on spelling checks with codespell tool. Tool can be installed with apt-get install codespell. Signed-off-by: Maxim Uvarov --- .checkpatch.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.checkpatch.conf b/.checkpatch.conf index 9076410..fbbb146 100644 --- a/.checkpatch.conf +++ b

[lng-odp] [PATCHv3 1/2] checkpatch: add spelling.txt

Add linux kernel spelling.txt file to detect common typos. Signed-off-by: Maxim Uvarov --- scripts/spelling.txt | 1043 ++ 1 file changed, 1043 insertions(+) create mode 100644 scripts/spelling.txt diff --git a/scripts/spelling.txt b/scripts/spel

[lng-odp] [PATCHv3 0/2] checkpatch: turn on spelling checks

v3: fix patch to dictionary.txt. (Sent patch for checkpatch.pl to kernel, when accepted we can merge it.) v2: 1) do not add codespell depandancy to configure.ac 2) simplify description that spelling.txt was taken from linux kernel. Maxim Uvarov (2): checkpatch: add spelling.txt check

Re: [lng-odp] [PATCHv2 2/2] checkpatch: use codespell for odp

On 06/03/15 12:59, Stuart Haslam wrote: On Wed, Jun 03, 2015 at 12:45:22PM +0300, Maxim Uvarov wrote: On 06/02/15 22:47, Mike Holmes wrote: I have a problem with this - I might have missed something. So I have codespell installed:- mike@mike-desktop:~/git/odp$ sudo apt-get install codespell

Re: [lng-odp] [API-NEXT PATCH 2/2] packet_io: release unsent packets after odp_pktio_send()

On Wed, Jun 03, 2015 at 09:37:54PM +0200, Ola Liljedahl wrote: > On 3 June 2015 at 20:42, Zoltan Kiss wrote: > > > On that note it turned out this will be a lot bigger than I thought ... > > And I already have two questions: > > > > - what should we do if an assert over odp_queue_enq fails? E.g.

Re: [lng-odp] [API-NEXT PATCH 2/2] packet_io: release unsent packets after odp_pktio_send()

On Wed, Jun 03, 2015 at 06:56:00PM +0100, Zoltan Kiss wrote: > > > On 03/06/15 18:00, Stuart Haslam wrote: > >On Wed, Jun 03, 2015 at 05:44:19PM +0100, Zoltan Kiss wrote: > >>And change the behaviour in linux-generic implementation, where it's > >>releasing > >>it during the call. > >> > >>Signe

Re: [lng-odp] [PATCH] scripts: add dist dependency to git_hash.sh

Merged. Tested that with: ./scripts/builddeb warnings disappear. Thanks, Maxim. On 06/03/15 11:28, Nicolas Morey-Chaisemartin wrote: This forces automake to also copy the git_hash.sh script when running make distcheck Address bug https://bugs.linaro.org/show_bug.cgi?id=1603 Signed-off-by: Ni

Re: [lng-odp] [PATCHv2 2/7] validation: own main in odp_pktio.c

On Wed, Jun 03, 2015 at 06:44:45PM +0200, Christophe Milard wrote: > Signed-off-by: Christophe Milard > --- > test/Makefile.inc | 7 ++- > test/validation/Makefile.am | 8 +++- > test/validation/odp_pktio.c | 15 +-- > 3 files changed, 22 insertions(+), 8 deletions

Re: [lng-odp] [PATCHv3] test: pktio_perf: add support for batch reception

Merged, Maxim. On 06/02/15 18:27, Stuart Haslam wrote: On Tue, Jun 02, 2015 at 04:57:45PM +0200, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin Reviewed-by: Stuart Haslam --- v3: * Fix help for rxbatch option test/performance/odp_pktio_perf.c | 77

Re: [lng-odp] [PATCH] validation: pktio: do lookup before create

On 06/03/15 19:53, Stuart Haslam wrote: On Wed, Jun 03, 2015 at 07:06:01PM +0300, Maxim Uvarov wrote: Use the right order in test: first lookup for pktio, if it's not exist - create it. Signed-off-by: Maxim Uvarov --- test/validation/odp_pktio.c | 4 ++-- 1 file changed, 2 insertions(+), 2