On 5 June 2015 at 18:22, Bill Fischofer <bill.fischo...@linaro.org> wrote:

> The linux-generic platform is indeed used as a "base class" however given
> this it would seem that the include order should be reversed so that
> $(WITH_PLATFORM) is first.  This would have the effect of allowing it to
> override any linux-generic include files of the same name.
>

I dont think it will work in that way, doxygen will just concatenate any
definitions it finds for the same thing rather than replace them I think.




>
> On Fri, Jun 5, 2015 at 3:14 PM, Mike Holmes <mike.hol...@linaro.org>
> wrote:
>
>> This works for linux-generic, but derived platforms such as odp-dpdk
>> depend on this link back to linux-generic becasue they inherit from it.
>> Having this in linux-generic makes it simpler for the derived works, but
>> I could also see the argument that it should be removed in linux-generic
>> and added back into to odp-dpdk, odp-KS2 and odp-netmap.
>>
>> I think I agree with this patch, but welcome others thoughts on how much
>> the reference code should include support it does not itsself need so that
>> it helps other platforms.
>>
>>
>>
>>
>>
>>
>>
>>
>> On 5 June 2015 at 08:22, Nicolas Morey-Chaisemartin <nmo...@kalray.eu>
>> wrote:
>>
>>> Signed-off-by: Nicolas Morey-Chaisemartin <nmo...@kalray.eu>
>>> ---
>>>  doc/doxygen.cfg | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/doc/doxygen.cfg b/doc/doxygen.cfg
>>> index 6283387..213a903 100644
>>> --- a/doc/doxygen.cfg
>>> +++ b/doc/doxygen.cfg
>>> @@ -13,7 +13,6 @@ WARN_NO_PARAMDOC = YES
>>>  INPUT = $(SRCDIR)/doc \
>>>         $(SRCDIR)/doc/users-guide \
>>>         $(SRCDIR)/include \
>>> -       $(SRCDIR)/platform/linux-generic/include/odp \
>>>         $(SRCDIR)/platform/$(WITH_PLATFORM)/include/odp \
>>>         $(SRCDIR)/helper/include
>>>  FILE_PATTERNS = *.h odp*.c *.dox
>>> _______________________________________________
>>> lng-odp mailing list
>>> lng-odp@lists.linaro.org
>>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>>
>>
>>
>>
>> --
>> Mike Holmes
>> Technical Manager - Linaro Networking Group
>> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
>>
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp
>>
>>
>


-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to