Re: [lng-odp] [API-NEXT PATCH v2 1/3] api: cpumask: added cpumask_setall

2015-06-08 Thread Christophe Milard
On 5 June 2015 at 12:48, Petri Savolainen wrote: > The call sets all possible CPUs in the mask. It's system specific which > CPUs are actually available to the application. > > Signed-off-by: Petri Savolainen > --- > include/odp/api/cpumask.h| 15 +-- > platform/linux-ge

Re: [lng-odp] [PATCH] validation: pktio: do not dequeue from scheduled queue

2015-06-08 Thread Maxim Uvarov
Merged, Maxim. On 06/09/15 07:53, Bala Manoharan wrote: Reviewed-by: Balasubramanian Manoharan > On 2 June 2015 at 20:16, Maxim Uvarov > wrote: packet i/o test can create 2 types of queues: scheduled and polled. Do not

[lng-odp] [Bug 1383] validation: pktio check for poll queue type

2015-06-08 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1383 Maxim Uvarov changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

Re: [lng-odp] [PATCH] validation: pktio: do not dequeue from scheduled queue

2015-06-08 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 2 June 2015 at 20:16, Maxim Uvarov wrote: > packet i/o test can create 2 types of queues: scheduled and > polled. Do not do dequeue from scheduled queue. > https://bugs.linaro.org/show_bug.cgi?id=1383 > > Signed-off-by: Maxim Uvarov > --- > test/valid

[lng-odp] Re: [PATCH] validation: pktio: do not dequeue from scheduled queue

2015-06-08 Thread Maxim Uvarov
Ping. Please review. Maxim. On 06/02/15 17:46, Maxim Uvarov wrote: packet i/o test can create 2 types of queues: scheduled and polled. Do not do dequeue from scheduled queue. https://bugs.linaro.org/show_bug.cgi?id=1383 Signed-off-by: Maxim Uvarov --- test/validation/odp_pktio.c | 3 ++- 1

[lng-odp] [PATCH v1] validation: timer: save expected expiration tick only on success

2015-06-08 Thread Jerin Jacob
otherwise "tt[i].tick" in "handle_tmo" will be a wrong value in case timer set failed due to ODP_TIMER_NOEVENT(failed to cancel the outstanding timer). some hardware timer implementations needs at least two ticks gap between "current tick" and "future tick" to cancel the outstanding active timer.

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

2015-06-08 Thread Mike Holmes
On 5 June 2015 at 08:22, Nicolas Morey-Chaisemartin wrote: > Signed-off-by: Nicolas Morey-Chaisemartin > Reviewed-by: Mike Holmes I think we should not impose something that is affecting others, derived platforms can of course add this back in if they need to for their documentation or make s

[lng-odp] [Bug 1615] odp_timer fails in CI with Segmentation fault

2015-06-08 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1615 --- Comment #1 from Mike Holmes --- Also happens on ARM Targets https://ci.linaro.org/job/odp-api-check/ARCH=arm64,GIT_BRANCH=api-next,label=docker-utopic-arm64/309/ -- You are receiving this mail because: You are on the CC list for the bug.

Re: [lng-odp] [PATCH] validation: timer: save expected expiration tick only on success

2015-06-08 Thread Ola Liljedahl
On 8 June 2015 at 17:29, Maxim Uvarov wrote: > Jerin, please include Ola's reviewed-by to updated patch. > Be careful with copy&paste as I copied a reviewed-by from Bill and changed the name (the text I could see) but I now see that somehow the mail URL still contains Bill's email! -- Ola > T

Re: [lng-odp] [PATCH] validation: timer: save expected expiration tick only on success

2015-06-08 Thread Maxim Uvarov
Jerin, please include Ola's reviewed-by to updated patch. Thanks, Maxim. On 06/08/15 18:24, Ola Liljedahl wrote: Approved with one comment below. On 5 June 2015 at 09:52, Jerin Jacob > wrote: otherwise "tt[i].tick" in "handle_tmo" will be a wrong va

Re: [lng-odp] [PATCH] validation: timer: save expected expiration tick only on success

2015-06-08 Thread Ola Liljedahl
Approved with one comment below. On 5 June 2015 at 09:52, Jerin Jacob wrote: > otherwise "tt[i].tick" in "handle_tmo" will be a wrong value > in case timer set failed due to > ODP_TIMER_NOEVENT(failed to cancel the outstanding timer). > > some hardware timer implementations needs at least two ti

Re: [lng-odp] [API-NEXT PATCH 2/2] packet_io: release unsent packets after odp_pktio_send()

2015-06-08 Thread Ola Liljedahl
On 4 June 2015 at 11:22, Stuart Haslam wrote: > On Wed, Jun 03, 2015 at 09:37:54PM +0200, Ola Liljedahl wrote: > > On 3 June 2015 at 20:42, Zoltan Kiss wrote: > > > > > On that note it turned out this will be a lot bigger than I thought ... > > > And I already have two questions: > > > > > > - w

Re: [lng-odp] [PATCHv3 0/8] pktio test move to platform side

2015-06-08 Thread Maxim Uvarov
On 8 June 2015 at 16:14, Christophe Milard wrote: > Hi Maxim, > I am a bit confused about the path in your mail, but I assume you are > trying to build out of tree and then run the pktio_run script. > I assume you did not try with patch V3 either... At least, when I do this, > I get: > > (after b

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

2015-06-08 Thread BenoƮt Ganne
The linux-generic platform is indeed used as a "base class" however given this it would seem that the include order should be reversed so that $(WITH_PLATFORM) is first. This would have the effect of allowing it to override any linux-generic include files of the same name. I dont think it will

Re: [lng-odp] [PATCHv3 0/8] pktio test move to platform side

2015-06-08 Thread Christophe Milard
Hi Maxim, I am a bit confused about the path in your mail, but I assume you are trying to build out of tree and then run the pktio_run script. I assume you did not try with patch V3 either... At least, when I do this, I get: (after building out of tree in /tmp/odp) erachmi@erachmi-VirtualBox:/tmp

Re: [lng-odp] [API-NEXT PATCH v3 0/9] Handle unsent packets

2015-06-08 Thread Zoltan Kiss
I've found where the problem is, I'll send a new version of this series, but first I would like some more reviews about the rest of the series. See my reply to the last patch. Zoli On 08/06/15 11:55, Maxim Uvarov wrote: On 06/05/15 22:19, Bill Fischofer wrote: This series applies and builds f

Re: [lng-odp] [API-NEXT PATCH v3 9/9] queue: handle return value of odp_queue_enq_multi()

2015-06-08 Thread Zoltan Kiss
On 05/06/15 18:51, Zoltan Kiss wrote: diff --git a/test/validation/odp_queue.c b/test/validation/odp_queue.c index f8c64f7..341b702 100644 --- a/test/validation/odp_queue.c +++ b/test/validation/odp_queue.c @@ -90,6 +90,12 @@ static void test_odp_queue_sunnyday(void) */ ret = o

Re: [lng-odp] Build issue

2015-06-08 Thread Bill Fischofer
I'm working with Maxim on this. It seems like the latest Ubuntu 14.10 service may have broken gcc. Investigating. On Mon, Jun 8, 2015 at 7:00 AM, Mike Holmes wrote: > CI appears to be failing only for the usual suspects > https://ci.linaro.org/view/odp-ci/job/odp-publish/ > > On 8 June 2015 a

Re: [lng-odp] Build issue

2015-06-08 Thread Mike Holmes
CI appears to be failing only for the usual suspects https://ci.linaro.org/view/odp-ci/job/odp-publish/ On 8 June 2015 at 07:14, Bill Fischofer wrote: > I'm seeing this this morning: > > bill@ubuntu:~/linaro$ git clone http://git.linaro.org/lng/odp.git odpbase > Cloning into 'odpbase'... > remot

Re: [lng-odp] [PATCHv3 0/8] pktio test move to platform side

2015-06-08 Thread Maxim Uvarov
We need that test case run also: mkidr /tmp/t11 cd /tmp/t11 ../../../...odp.git/configure --enable-test-vald --enable-test-perf --enable-test-cpp --enable-debug CFLAGS="-O0 -g" --enable-debug --enable-debug-print make cd /tmp/t11/test/validation/pktio ../../../../../odp.git/platform/linux

[lng-odp] Build issue

2015-06-08 Thread Bill Fischofer
I'm seeing this this morning: bill@ubuntu:~/linaro$ git clone http://git.linaro.org/lng/odp.git odpbase Cloning into 'odpbase'... remote: Counting objects: 9284, done. remote: Compressing objects: 100% (6884/6884), done. remote: Total 9284 (delta 6942), reused 2675 (delta 2081) Receiving objects:

[lng-odp] [ODP/RFC 2/2] example: egress classifier example

2015-06-08 Thread bala . manoharan
From: Balasubramanian Manoharan This is a vlan priority based L2 loopback application which creates multiple packet output queues for each vlan priority value and attaches them to the given pktio interface. The packets are enqueued into different packet output queues based on their vlan priority

[lng-odp] [ODP/RFC 1/2] linux-generic: egress classification implementation

2015-06-08 Thread bala . manoharan
From: Balasubramanian Manoharan This is linux-generic implementation of egress classification. This is a lock-less implementation for output packet scheduling, shaping and rate limitting. Multiple packet output queues with different priority values can be created and attached with pktio interfac

Re: [lng-odp] [API-NEXT PATCH v3 0/9] Handle unsent packets

2015-06-08 Thread Bill Fischofer
I'm running in a standard Ubuntu VM: bill@ubuntu:~/linaro$ ifconfig eth1 Link encap:Ethernet HWaddr 00:1c:42:77:a3:f0 inet addr:10.211.55.3 Bcast:10.211.55.255 Mask:255.255.255.0 inet6 addr: fdb2:2c26:f4e4:0:d9b0:4a97:17f8:b876/64 Scope:Global inet6 addr: fdb2

Re: [lng-odp] [API-NEXT PATCH v3 0/9] Handle unsent packets

2015-06-08 Thread Maxim Uvarov
On 06/05/15 22:19, Bill Fischofer wrote: This series applies and builds fine, however with check-odp I'm seeing consistent failures on the odp_pktio tests. I double checked and am seeing the same with the base odp.git code so not sure what changed (don't think these patches really changed anyt

Re: [lng-odp] [API-NEXT PATCH v3 0/9] Handle unsent packets

2015-06-08 Thread Maxim Uvarov
On 06/05/15 22:19, Bill Fischofer wrote: This series applies and builds fine, however with check-odp I'm seeing consistent failures on the odp_pktio tests. I double checked and am seeing the same with the base odp.git code so not sure what changed (don't think these patches really changed anyt

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

2015-06-08 Thread Nicolas Morey-Chaisemartin
What we did to avoid pointing into the linux-generic folder in the Makefiles is use symlinks to linux-generic sources. This way we keep the linux-generic files up-to-date when pulling but avoid build dependencies between platform folders. On 06/06/2015 12:22 AM, Bill Fischofer wrote: > The linux