Re: [lng-odp] RFC move the ring implementation into linux-generic

2015-06-12 Thread Maxim Uvarov
Egress also uses odp_ring. For odp_ring I do not see anything bad to have it in helper. So applications can reuse that software ring if needed. Which might be very useful in number of cases. If we put in inside implementation then obviously it will be hard to reuse it. Maxim. On 06/12/15

Re: [lng-odp] [PATCHv2 1/3] example: classifier: check sscanf return code

2015-06-12 Thread Maxim Uvarov
Merged, Thanks, Maxim. On 06/11/15 09:27, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- example/classifier/odp_classifier.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/example/classifier/odp_classifier.c

Re: [lng-odp] [PATCHv2 2/3] checkpatch: remove line length limit for examples and tests log functions

2015-06-12 Thread Maxim Uvarov
Merged, Maxim. On 06/11/15 09:27, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- scripts/checkpatch.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4bd7230..cee734a 100755 ---

[lng-odp] [PATCH] linux-generic: pool: remove double init

2015-06-12 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- platform/linux-generic/odp_pool.c | 1 - 1 file changed, 1 deletion(-) diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c index 35e79a0..c89012b 100644 --- a/platform/linux-generic/odp_pool.c +++

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-12 Thread Ola Liljedahl
On 10 June 2015 at 18:32, Bill Fischofer bill.fischo...@linaro.org wrote: The proposal I described during today's ARCH meeting is to add an explicit event type to buffers so that when buffers (of whatever flavor) are being used as events this field can be interrogated without needing to

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-12 Thread Alexandru Badicioiu
Completion events are now implementation's responsibility. Application does not provide any pool for completion events, only for output packet in case the crypto HW engine is able to allocate output packets. I think the whole completion event thing was misunderstood as a HW provided thing. I'm

Re: [lng-odp] Apply multiple filters using ODP Classifier API

2015-06-12 Thread Genís Riera Pérez
Hi Make, Bala. For me it's okay to add this discussion as part of the API DOC Classification, because I think sure this would be helpful for all users want to use the API, as well as all beginner developers. Especially point that a PMR match set is activated if all PMR in the set are matched (AND

Re: [lng-odp] [PATCHv2 3/3] example: use SCNx32/PRIx32 macro

2015-06-12 Thread Maxim Uvarov
Merged, Maxim. On 06/11/15 09:27, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- example/classifier/odp_classifier.c | 2 +- example/timer/odp_timer_test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [lng-odp] [PATCH] linux-generic: pool: remove double init

2015-06-12 Thread Bill Fischofer
Good catch. On Fri, Jun 12, 2015 at 4:44 AM, Nicolas Morey-Chaisemartin nmo...@kalray.eu wrote: Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu Reviewed-by: Bill Fischofer bill.fischo...@linaro.org --- platform/linux-generic/odp_pool.c | 1 - 1 file changed, 1 deletion(-)

[lng-odp] [API-NEXT PATCH] api: doc: doxygen grouping clean up

2015-06-12 Thread Petri Savolainen
Cleaned Doxygen documentation grouping. Corrected wrong groupings and created new groups when needed. Signed-off-by: Petri Savolainen petri.savolai...@nokia.com --- include/odp/api/buffer.h| 11 --- include/odp/api/config.h|

[lng-odp] [API-NEXT PATCH 1/4] api: thrmask: added thread mask

2015-06-12 Thread Petri Savolainen
Thread IDs and masks are used to control thread access to various resources. Linux generic implementation reuse cpumask implementation. Signed-off-by: Petri Savolainen petri.savolai...@nokia.com --- include/odp.h | 1 + include/odp/api/thrmask.h

[lng-odp] [API-NEXT PATCH 2/4] thread: updated thread mask handling

2015-06-12 Thread Petri Savolainen
Linux generic thread mask handling uses thrmask API. Added worker and control masks for easy implementation of functions returning those masks. Signed-off-by: Petri Savolainen petri.savolai...@nokia.com --- platform/linux-generic/include/odp_internal.h | 3 +- platform/linux-generic/odp_init.c

Re: [lng-odp] RFC move the ring implementation into linux-generic

2015-06-12 Thread Mike Holmes
On 12 June 2015 at 04:43, Maxim Uvarov maxim.uva...@linaro.org wrote: Egress also uses odp_ring. For odp_ring I do not see anything bad to have it in helper. So applications can reuse that software ring if needed. Which might be very useful in number of cases. If we put in inside

[lng-odp] [API-NEXT PATCH 4/4] thread: implemented thrmask_worker and control

2015-06-12 Thread Petri Savolainen
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com --- platform/linux-generic/odp_thread.c | 28 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/platform/linux-generic/odp_thread.c b/platform/linux-generic/odp_thread.c index 42afc5f..9905c78

[lng-odp] [API-NEXT PATCH 3/4] thread: implemented odp_thread_type

2015-06-12 Thread Petri Savolainen
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com --- platform/linux-generic/odp_thread.c | 5 + 1 file changed, 5 insertions(+) diff --git a/platform/linux-generic/odp_thread.c b/platform/linux-generic/odp_thread.c index 85ca047..42afc5f 100644 ---

Re: [lng-odp] [PATCH] doc: doxygen: improve release management description

2015-06-12 Thread Mike Holmes
Ping On 3 June 2015 at 13:23, Mike Holmes mike.hol...@linaro.org wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org --- doc/odp.dox | 7 --- doc/release.dox | 65 + 2 files changed, 65 insertions(+), 7 deletions(-)

[lng-odp] [PATCH] remove helper dependence on ODP internals

2015-06-12 Thread Mike Holmes
Remove the helpers dependence on internal implementation details, implementations should only have to implement the public API. Signed-off-by: Mike Holmes mike.hol...@linaro.org --- helper/linux.c | 32 ++--- helper/odph_debug.h| 93

Re: [lng-odp] [API-NEXT PATCH] api: doc: doxygen grouping clean up

2015-06-12 Thread Bill Fischofer
On Fri, Jun 12, 2015 at 7:54 AM, Petri Savolainen petri.savolai...@nokia.com wrote: Cleaned Doxygen documentation grouping. Corrected wrong groupings and created new groups when needed. Signed-off-by: Petri Savolainen petri.savolai...@nokia.com Reviewed-by: Bill Fischofer

Re: [lng-odp] [CHECK-ODP PATCH] display os details

2015-06-12 Thread Anders Roxell
On 2015-06-09 15:46, Mike Holmes wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org --- apply-and-build.sh | 2 ++ build.sh | 2 ++ helper/generic | 4 3 files changed, 8 insertions(+) diff --git a/apply-and-build.sh b/apply-and-build.sh index 5c30e8c..a02e446

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-12 Thread Bill Fischofer
This is for internal use of buffers as events, specifically in the case of crypto, which overloads events onto packets. Essentially a packet containing data is sent off for a crypto operation as is returned as a crypto completion event, whereupon it can resume its use as a packet. There were two

Re: [lng-odp] [PATCHv2] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-12 Thread Mike Holmes
On 10 June 2015 at 20:12, Bill Fischofer bill.fischo...@linaro.org wrote: Signed-off-by: Bill Fischofer bill.fischo...@linaro.org I am guessing we should add Reported-by: Christophe Milard christophe.mil...@linaro.org --- .../linux-generic/include/odp_buffer_inlines.h | 9 ++

Re: [lng-odp] [API-NEXT PATCH 1/4] api: thrmask: added thread mask

2015-06-12 Thread Bill Fischofer
For this series: Reviewed-and-tested-by: Bill Fischofer bill.fischo...@linaro.org On Fri, Jun 12, 2015 at 6:56 AM, Petri Savolainen petri.savolai...@nokia.com wrote: Thread IDs and masks are used to control thread access to various resources. Linux generic implementation reuse cpumask

Re: [lng-odp] RFC move the ring implementation into linux-generic

2015-06-12 Thread Ola Liljedahl
On 12 June 2015 at 14:58, Mike Holmes mike.hol...@linaro.org wrote: On 12 June 2015 at 04:43, Maxim Uvarov maxim.uva...@linaro.org wrote: Egress also uses odp_ring. For odp_ring I do not see anything bad to have it in helper. So applications can reuse that software ring if needed. Which

Re: [lng-odp] [API-NEXT PATCH] api: doc: doxygen grouping clean up

2015-06-12 Thread Mike Holmes
I dont object to better definitions, but this will ripple to the testing and bugzilla which follows these groupings in its own structure FYI - Changes are New Old ODP BUFFER ODP BUFFER ODP COMPILER / OPTIMIZATION ODP COMPILER / OPTIMIZATION ODP CLASSIFICATION ODP CLASSIFICATION ODP

Re: [lng-odp] [PATCHv2] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-12 Thread Bill Fischofer
Yes, of course. Sorry about that. On Fri, Jun 12, 2015 at 9:25 AM, Mike Holmes mike.hol...@linaro.org wrote: On 10 June 2015 at 20:12, Bill Fischofer bill.fischo...@linaro.org wrote: Signed-off-by: Bill Fischofer bill.fischo...@linaro.org I am guessing we should add Reported-by: