[lng-odp] [Bug 1696] Pool allow seg_len to be smaller than ODP_CONFIG_PACKET_SEG_LEN_MIN

2015-07-17 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1696 Bill Fischofer bill.fischo...@linaro.org changed: What|Removed |Added Ever confirmed|0 |1

Re: [lng-odp] [PATCH] linux-generic: pool: round up segment length to ODP_CONFIG_PACKET_SEG_LEN_MIN

2015-07-17 Thread Bill Fischofer
Nicolas opened this bug and assigned it to me and I see we cross-posted fix patches. My patch is at http://patches.opendataplane.org/patch/2298/ and is almost the same (I'm using = rather than which is slightly more efficient for the boundary case where seg_len == ODP_CONFIG_PACKET_SEG_LEN_MIN.

Re: [lng-odp] [PATCH] linux-generic: pool: round up segment length to ODP_CONFIG_PACKET_SEG_LEN_MIN

2015-07-17 Thread Maxim Uvarov
On 07/17/15 14:42, Bill Fischofer wrote: Nicolas opened this bug and assigned it to me and I see we cross-posted fix patches. My patch is at http://patches.opendataplane.org/patch/2298/ and is almost the same (I'm using = rather than which is slightly more efficient for the boundary case

Re: [lng-odp] [PATCH] linux-generic: pool: round up segment length to ODP_CONFIG_PACKET_SEG_LEN_MIN

2015-07-17 Thread Nicolas Morey-Chaisemartin
Because in my test is seg_len == ODP_CONFIG_PACKET_SEG_LEN_MIN, we have to test for seg_len SEG_LEN_MAX, while in Bill, we have our result directly. I agree Bill's solution is better :) Nicolas On 07/17/2015 02:31 PM, Maxim Uvarov wrote: On 07/17/15 14:42, Bill Fischofer wrote: Nicolas

[lng-odp] [PATCH] linux-generic: pool: use ODP_CONFIG_PACKET_SEG_LEN_MIN correctly

2015-07-17 Thread Bill Fischofer
Fix Bug https://bugs.linaro.org/show_bug.cgi?id=1696 Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- platform/linux-generic/odp_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c index

Re: [lng-odp] Receive only packets that match configured PMRs

2015-07-17 Thread Bill Fischofer
odp_cos_set_drop() should certainly be implemented. If it's not that should be reported as a bug against both the classifier and the test suite. On Fri, Jul 17, 2015 at 8:54 AM, Stuart Haslam stuart.has...@linaro.org wrote: Is it possible to configure the pktio and classifier such that the

Re: [lng-odp] [PATCH] example: ipsec: Fix context state race condition in

2015-07-17 Thread Steve Kordus (skordus)
Reviewed-by: Steve Kordus skor...@cisco.com -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of nikhil.agar...@freescale.com Sent: Wednesday, July 15, 2015 7:54 AM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH] example: ipsec: Fix context

Re: [lng-odp] Receive only packets that match configured PMRs

2015-07-17 Thread Bala Manoharan
Hi Stuart, Pls raise a bug for POOL_DROP implementation. I will implement drop policy. Regards, Bala On 17 July 2015 at 19:40, Bill Fischofer bill.fischo...@linaro.org wrote: odp_cos_set_drop() should certainly be implemented. If it's not that should be reported as a bug against both the

[lng-odp] arm compilation fail

2015-07-17 Thread Maxim Uvarov
in CI arm compilation fails. Looks like it came with gcc update. Any thought what happed with arm compiler? static inline int verify_pmr_ipsec_spi(uint8_t *pkt_addr ODP_UNUSED, odp_packet_hdr_t *pkt_hdr ODP_UNUSED, pmr_term_value_t *term_value

[lng-odp] Receive only packets that match configured PMRs

2015-07-17 Thread Stuart Haslam
Is it possible to configure the pktio and classifier such that the application receives *only* packets matching a defined set of PMRs? I tried something like this; pktio = odp_pktio_create(..); cos = odp_cos_create(MyCoS); q = odp_queue_create(MyQ, ODP_QUEUE_TYPE_SCHED, qparam);

[lng-odp] [Bug 1693] CPU frequency should be locked when it is used to calculate time

2015-07-17 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1693 --- Comment #1 from Mike Holmes mike.hol...@linaro.org --- *** Bug 1694 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

[lng-odp] [Bug 1694] CPU frequency should be locked when it is used to calculate time

2015-07-17 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1694 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[lng-odp] [Bug 1693] CPU frequency should be locked when it is used to calculate time

2015-07-17 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1693 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Ever confirmed|0 |1 CC|

Re: [lng-odp] arm compilation fail

2015-07-17 Thread Anders Roxell
On 17 July 2015 at 16:53, Anders Roxell anders.rox...@linaro.org wrote: On 17 July 2015 at 16:19, Maxim Uvarov maxim.uva...@linaro.org wrote: in CI arm compilation fails. Looks like it came with gcc update. Any thought what happed with arm compiler? It's not a new warning, it's a new

Re: [lng-odp] arm compilation fail

2015-07-17 Thread Benoît Ganne
in CI arm compilation fails. Looks like it came with gcc update. Any thought what happed with arm compiler? Based on gcc message, my guess is that it does not like casting from uint8_t* to uint32_t* because it could be a problem when you dereference the pointer. If your platform does not

Re: [lng-odp] arm compilation fail

2015-07-17 Thread Anders Roxell
On 17 July 2015 at 16:19, Maxim Uvarov maxim.uva...@linaro.org wrote: in CI arm compilation fails. Looks like it came with gcc update. Any thought what happed with arm compiler? It's not a new warning, it's a new commit... commit aac78e18e53ab8be17020216921f5e5d14c8b26e is the relevant one.

Re: [lng-odp] arm compilation fail

2015-07-17 Thread Maxim Uvarov
On 07/17/15 17:54, Benoît Ganne wrote: in CI arm compilation fails. Looks like it came with gcc update. Any thought what happed with arm compiler? Based on gcc message, my guess is that it does not like casting from uint8_t* to uint32_t* because it could be a problem when you dereference the

Re: [lng-odp] [PATCH] example: ipsec: Fix context state race condition in

2015-07-17 Thread Maxim Uvarov
Merged, Maxim. On 07/17/15 17:12, Steve Kordus (skordus) wrote: Reviewed-by: Steve Kordus skor...@cisco.com -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of nikhil.agar...@freescale.com Sent: Wednesday, July 15, 2015 7:54 AM To:

Re: [lng-odp] arm compilation fail

2015-07-17 Thread Anders Roxell
On 17 July 2015 at 17:09, Maxim Uvarov maxim.uva...@linaro.org wrote: On 07/17/15 17:54, Benoît Ganne wrote: in CI arm compilation fails. Looks like it came with gcc update. Any thought what happed with arm compiler? Based on gcc message, my guess is that it does not like casting from

Re: [lng-odp] arm compilation fail

2015-07-17 Thread Stuart Haslam
On Fri, Jul 17, 2015 at 04:53:51PM +0200, Anders Roxell wrote: On 17 July 2015 at 16:19, Maxim Uvarov maxim.uva...@linaro.org wrote: in CI arm compilation fails. Looks like it came with gcc update. Any thought what happed with arm compiler? It's not a new warning, it's a new commit...

Re: [lng-odp] arm compilation fail

2015-07-17 Thread Anders Roxell
On 17 July 2015 at 17:18, Stuart Haslam stuart.has...@linaro.org wrote: On Fri, Jul 17, 2015 at 04:53:51PM +0200, Anders Roxell wrote: On 17 July 2015 at 16:19, Maxim Uvarov maxim.uva...@linaro.org wrote: in CI arm compilation fails. Looks like it came with gcc update. Any thought what

[lng-odp] [PATCH] linux-generic: classification: fix support for ODP_PMR_IPSEC_SPI

2015-07-17 Thread Stuart Haslam
Use the packed helper structures to avoid alignment issues. Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- .../include/odp_classification_inlines.h | 29 -- 1 file changed, 21 insertions(+), 8 deletions(-) diff --git

Re: [lng-odp] Receive only packets that match configured PMRs

2015-07-17 Thread Stuart Haslam
On Fri, Jul 17, 2015 at 07:43:08PM +0530, Bala Manoharan wrote: Hi Stuart, Pls raise a bug for POOL_DROP implementation. I will implement drop policy. Regards, Bala Will do. I assume then that the intention is that you set a default CoS for the pktio, then set the drop policy for the

[lng-odp] [PATCH 1/2] linux-generic: pktio: rename loop and sock _init functions to _open

2015-07-17 Thread Nicolas Morey-Chaisemartin
Function names are now coherent with pktio_if_opts names Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- platform/linux-generic/pktio/loop.c | 4 ++-- platform/linux-generic/pktio/socket.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[lng-odp] [PATCH 2/2] linux-generic: pktio/sock: remove _pkt suffix for open and close functions

2015-07-17 Thread Nicolas Morey-Chaisemartin
Unifies the format for all pktio_if_ops_t functions Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- platform/linux-generic/pktio/socket.c | 8 platform/linux-generic/pktio/socket_mmap.c | 14 +++--- 2 files changed, 11 insertions(+), 11 deletions(-) diff

Re: [lng-odp] [PATCH] validation: scheduler: fix race condition in pause test

2015-07-17 Thread Maxim Uvarov
Merged, Maxim. On 07/16/15 17:26, Nicolas Morey-Chaisemartin wrote: Reviewed-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu On 07/16/2015 04:19 PM, Bill Fischofer wrote: Fix race condition reported by Bug https://bugs.linaro.org/show_bug.cgi?id=1234 Signed-off-by: Bill Fischofer

Re: [lng-odp] [PATCHv2 3/3] test: pktio: add tests for segmented packets

2015-07-17 Thread Nicolas Morey-Chaisemartin
On 07/16/2015 07:41 PM, Stuart Haslam wrote: On Thu, Jul 16, 2015 at 06:18:35PM +0200, Nicolas Morey-Chaisemartin wrote: On 07/16/2015 06:13 PM, Stuart Haslam wrote: On Wed, Jul 08, 2015 at 03:25:11PM +0200, Nicolas Morey-Chaisemartin wrote: +static void set_pool_len(odp_pool_param_t

[lng-odp] [Bug 1698] New: No support for CoS drop policies

2015-07-17 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1698 Bug ID: 1698 Summary: No support for CoS drop policies Product: OpenDataPlane Version: 1.1 Hardware: Other OS: Linux Status: UNCONFIRMED Severity: major

[lng-odp] [PATCH] validation: add missing include guards

2015-07-17 Thread Stuart Haslam
Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- test/validation/buffer/buffer.h | 5 + test/validation/classification/classification.h | 5 + test/validation/cpumask/cpumask.h | 5 + test/validation/crypto/crypto.h | 5 +

Re: [lng-odp] [PATCHv2 3/3] test: pktio: add tests for segmented packets

2015-07-17 Thread Maxim Uvarov
On 07/17/15 12:20, Nicolas Morey-Chaisemartin wrote: On 07/17/2015 11:15 AM, Stuart Haslam wrote: Yeah that's a bug, it should behave as per the text in config.h; /** * Minimum packet segment length * * This defines the minimum packet segment buffer length in bytes. The user * defined

Re: [lng-odp] [PATCH] m4: pthread: fix warning with Wextra

2015-07-17 Thread Maxim Uvarov
CC Anders. Looks like it's reasonable to upstream that change. Maxim. On 07/15/15 17:03, Nicolas Morey-Chaisemartin wrote: When adding both Wextra and Werror to CPPFLAGS, configure fails due to a warning during the pthread configuration phase: | #include pthread.h |

Re: [lng-odp] [PATCH] linux-generic: pktio: merge all pktio type structure into an anonymous union

2015-07-17 Thread Maxim Uvarov
Merged, Maxim. On 07/16/15 19:16, Stuart Haslam wrote: On Thu, Jul 16, 2015 at 02:38:11PM +0200, Nicolas Morey-Chaisemartin wrote: This reduces the pktio_entry struct from 1344B to 1280B Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu Reviewed-by: Stuart Haslam

Re: [lng-odp] [PATCHv2 3/3] test: pktio: add tests for segmented packets

2015-07-17 Thread Stuart Haslam
On Fri, Jul 17, 2015 at 10:57:30AM +0200, Nicolas Morey-Chaisemartin wrote: On 07/16/2015 07:41 PM, Stuart Haslam wrote: On Thu, Jul 16, 2015 at 06:18:35PM +0200, Nicolas Morey-Chaisemartin wrote: On 07/16/2015 06:13 PM, Stuart Haslam wrote: On Wed, Jul 08, 2015 at 03:25:11PM +0200,

Re: [lng-odp] [PATCH] linux-generic: pktio: remove unused include

2015-07-17 Thread Maxim Uvarov
Merged, Maxim. On 07/17/15 10:52, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- platform/linux-generic/odp_packet_io.c | 1 - 1 file changed, 1 deletion(-) diff --git a/platform/linux-generic/odp_packet_io.c

Re: [lng-odp] [PATCHv2 3/3] test: pktio: add tests for segmented packets

2015-07-17 Thread Nicolas Morey-Chaisemartin
On 07/17/2015 11:15 AM, Stuart Haslam wrote: Yeah that's a bug, it should behave as per the text in config.h; /** * Minimum packet segment length * * This defines the minimum packet segment buffer length in bytes. The user * defined segment length (seg_len in odp_pool_param_t) will

[lng-odp] [Bug 1693] New: CPU frequency should be locked when it is used to calculate time

2015-07-17 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1693 Bug ID: 1693 Summary: CPU frequency should be locked when it is used to calculate time Product: OpenDataPlane Version: 1.1 Hardware: Other OS: Linux

[lng-odp] [Bug 1696] New: Pool allow seg_len to be smaller than ODP_CONFIG_PACKET_SEG_LEN_MIN

2015-07-17 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1696 Bug ID: 1696 Summary: Pool allow seg_len to be smaller than ODP_CONFIG_PACKET_SEG_LEN_MIN Product: OpenDataPlane Version: 1.1 Hardware: Other OS: Linux

[lng-odp] [PATCH] linux-generic: pool: round up segment length to ODP_CONFIG_PACKET_SEG_LEN_MIN

2015-07-17 Thread Nicolas Morey-Chaisemartin
Fixes https://bugs.linaro.org/show_bug.cgi?id=1696 Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- platform/linux-generic/odp_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c index

[lng-odp] [Bug 1694] New: CPU frequency should be locked when it is used to calculate time

2015-07-17 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1694 Bug ID: 1694 Summary: CPU frequency should be locked when it is used to calculate time Product: OpenDataPlane Version: 1.1 Hardware: Other OS: Linux

Re: [lng-odp] [PATCHv2] test: do not use negative array index

2015-07-17 Thread Maxim Uvarov
Merged, Maxim. On 07/17/15 06:55, Bill Fischofer wrote: On Thursday, July 16, 2015, Maxim Uvarov maxim.uva...@linaro.org mailto:maxim.uva...@linaro.org wrote: odp_pktio_send() can return -1 error and that return code can be used as array index in code bellow. On error just

Re: [lng-odp] [PATCH] linux-generic: pool: round up segment length to ODP_CONFIG_PACKET_SEG_LEN_MIN

2015-07-17 Thread Stuart Haslam
On Fri, Jul 17, 2015 at 12:45:52PM +0200, Nicolas Morey-Chaisemartin wrote: Fixes https://bugs.linaro.org/show_bug.cgi?id=1696 Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu Reviewed-by: Stuart Haslam stuart.has...@linaro.org --- platform/linux-generic/odp_pool.c | 2 +- 1

[lng-odp] Preliminary Traffic Manager (Egress) API docs and slides

2015-07-17 Thread Mike Holmes
All Barry, Bill and I are working to get the patches out on the list, there still some details to address, but the docs are close now and a preliminary draft might help folks start to digest the new API. http://people.linaro.org/~mike.holmes/odp-api/html/group__odp__traffic__mngr.html#details

Re: [lng-odp] Receive only packets that match configured PMRs

2015-07-17 Thread Bala Manoharan
On 17 July 2015 at 20:56, Stuart Haslam stuart.has...@linaro.org wrote: On Fri, Jul 17, 2015 at 07:43:08PM +0530, Bala Manoharan wrote: Hi Stuart, Pls raise a bug for POOL_DROP implementation. I will implement drop policy. Regards, Bala Will do. I assume then that the

Re: [lng-odp] [API-NEXT PATCHv2 0/9] validation: add thrmask tests

2015-07-17 Thread Mike Holmes
make distcheck is failing for me make[2]: Entering directory '/home/mike/git/odp/opendataplane-1.1.0.0/_build/platform/linux-generic' CC odp_barrier.lo CC odp_buffer.lo CC odp_classification.lo In file included from ../../../platform/linux-generic/include/odp/queue.h:34:0,

[lng-odp] [PATCH] Configure: use stricter warnings

2015-07-17 Thread Mike Holmes
Signed-off-by: Mike Holmes mike.hol...@linaro.org --- Makefile.inc | 2 +- bootstrap| 2 +- configure.ac | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index fa3fac4..8158f37 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -1 +1 @@