Re: [lng-odp] [API-NEXT PATCH 5/5] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-29 Thread Ivan Khoronzhuk
On 29.07.15 17:24, Alexandru Badicioiu wrote: My understanding is that POLL type queues don't have any scheduling attributes, since their scheduler is the application itself. Atomic context is not really an event attribute - it's a queue attribute which enforces the scheduler to return an

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-29 Thread Krishna Garapati
May be we can create an other task for this?. Steve mentioned that this verbose is kind of urgent for the multi-node LAVA environment. Let me know your views. /Krishna On 29 July 2015 at 16:40, Stuart Haslam stuart.has...@linaro.org wrote: On Wed, Jul 29, 2015 at 05:13:40PM +0300, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCH 5/5] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-29 Thread Bill Fischofer
Ordering refers to what happens on subsequent enqs of events received from an ordered queue. An ordered queue is the same as a parallel queue in that the scheduler will dispatch events form it to multiple threads in parallel. However, when those threads subsequently enq their events the order in

Re: [lng-odp] [API-NEXT PATCH 5/5] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-29 Thread Ivan Khoronzhuk
Thanks Bill. All in order now. On 29.07.15 20:58, Bill Fischofer wrote: Ordering refers to what happens on subsequent enqs of events received from an ordered queue. An ordered queue is the same as a parallel queue in that the scheduler will dispatch events form it to multiple threads in

Re: [lng-odp] RFC - Application counters helpers

2015-07-29 Thread Bala Manoharan
Hi, Maybe we need additional API for initialising the counter to reset it to zero and also a need for decrementing the counter? IMO, we need to properly document the use-case of these counter API functions since these counters are thread-specific what will the different between using these APIs

Re: [lng-odp] [API-NEXT PATCH 5/5] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-29 Thread Alexandru Badicioiu
This change (having an ordered context per event) brings up (again) the question of how do we handle the case when a packet coming in from an ordered queue needs fragmentation before going to next processing stage. As related to this, how do we insert locally generated packets into an ordered

Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type

2015-07-29 Thread Nicolas Morey Chaisemartin
Could we not have an optional dependency to pcap? OpenSSL is required for API reasons, but as this is a non standard pktio, it seems a bit of a shame to force a dependency for this? Simply having a CONDITIONAL in configure/Makefile.am and adding conditionnaly the pcap.c file. Plus small ifdef

Re: [lng-odp] [Patch] validation: time: increase TOLERANCE range

2015-07-29 Thread Maxim Uvarov
Should we have #define CONFIG_TIMER_RESOLUTION in config.h? And relay on it's value. Maxim. On 07/28/15 18:23, Ivan Khoronzhuk wrote: Current test supposes that timer counter resolution is very close to 1ns. But that's not always true. The resoulution can be 8ns for instance, it's not always

Re: [lng-odp] [PATCH] doc: publish contributing and dependencies

2015-07-29 Thread Maxim Uvarov
Mike, I'm looking to generated html docs and it looks like it's better to put that pages under User guide section. Best regards, Maxim. On 07/23/15 21:15, Mike Holmes wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org --- doc/doxygen.cfg | 2 +- doc/odp.dox | 9 + 2

Re: [lng-odp] [Patch] validation: time: increase TOLERANCE range

2015-07-29 Thread Ivan Khoronzhuk
On 29.07.15 14:34, Maxim Uvarov wrote: Should we have #define CONFIG_TIMER_RESOLUTION in config.h? And relay on it's value. Maxim. Maybe. In case of CPU freq this is inversely proportional to odp_sys_cpu_hz(), and can be determined. But in case of using real timer there is no API to get

Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type

2015-07-29 Thread Maxim Uvarov
On 07/28/15 20:54, Stuart Haslam wrote: Create a new pktio type that allows for reading from and writing to a pcap capture file. This is intended to be used as a simple way of injecting test packets into an application for functional testing and can be used as it is with some of the existing

Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type

2015-07-29 Thread Nicolas Morey Chaisemartin
- Original Message - From: Maxim Uvarov maxim.uva...@linaro.org To: lng-odp@lists.linaro.org Sent: Wednesday, 29 July, 2015 11:58:59 AM Subject: Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type On 07/29/15 10:03, Nicolas Morey Chaisemartin wrote: Could we not

Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type

2015-07-29 Thread Stuart Haslam
On Wed, Jul 29, 2015 at 01:23:20PM +0300, Maxim Uvarov wrote: On 07/28/15 20:54, Stuart Haslam wrote: Create a new pktio type that allows for reading from and writing to a pcap capture file. This is intended to be used as a simple way of injecting test packets into an application for

Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type

2015-07-29 Thread Maxim Uvarov
On 07/29/15 14:00, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 01:23:20PM +0300, Maxim Uvarov wrote: On 07/28/15 20:54, Stuart Haslam wrote: Create a new pktio type that allows for reading from and writing to a pcap capture file. This is intended to be used as a simple way of injecting test

Re: [lng-odp] [API-NEXT PATCH] api: spelling fixes

2015-07-29 Thread Maxim Uvarov
Applied, Maxim. On 07/29/15 00:02, Bill Fischofer wrote: On Tue, Jul 28, 2015 at 2:17 PM, Mike Holmes mike.hol...@linaro.org mailto:mike.hol...@linaro.org wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org mailto:mike.hol...@linaro.org Reviewed-by: Bill Fischofer

Re: [lng-odp] [Patch] validation: time: increase TOLERANCE range

2015-07-29 Thread Bill Fischofer
Agreed. An ODP implementation should be for a platform, not for a specific model within a platform family. Another reason why config.h needs to be converted from #defines to APIs. On Wed, Jul 29, 2015 at 6:46 AM, Ivan Khoronzhuk ivan.khoronz...@linaro.org wrote: On 29.07.15 14:42, Ivan

Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type

2015-07-29 Thread Stuart Haslam
On Tue, Jul 28, 2015 at 03:43:29PM -0400, Mike Holmes wrote: I like it. Do we need a facility to compare output in some way to ensure correct operation - even if it is just to test this interface and is not a bigger part of regression ? Maybe the test suite checks that pcap-diff [1] (or

[lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-29 Thread Balakrishna.Garapati
corrected alignment issues Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- example/generator/odp_generator.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index

Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type

2015-07-29 Thread Mike Holmes
On 29 July 2015 at 06:47, Nicolas Morey Chaisemartin nmo...@kalray.eu wrote: - Original Message - From: Maxim Uvarov maxim.uva...@linaro.org To: lng-odp@lists.linaro.org Sent: Wednesday, 29 July, 2015 11:58:59 AM Subject: Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap

Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type

2015-07-29 Thread Maxim Uvarov
On 07/29/15 10:03, Nicolas Morey Chaisemartin wrote: Could we not have an optional dependency to pcap? OpenSSL is required for API reasons, but as this is a non standard pktio, it seems a bit of a shame to force a dependency for this? Nicolas, just to clarify. I think that libpcap exist

Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type

2015-07-29 Thread Stuart Haslam
On Wed, Jul 29, 2015 at 12:58:59PM +0300, Maxim Uvarov wrote: On 07/29/15 10:03, Nicolas Morey Chaisemartin wrote: Could we not have an optional dependency to pcap? OpenSSL is required for API reasons, but as this is a non standard pktio, it seems a bit of a shame to force a dependency for

Re: [lng-odp] [API-NEXT PATCH 5/5] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-29 Thread Bill Fischofer
Yes, this is why I wanted to discuss this further since the question of how you handle fragmentation and reassembly is one of the key grey areas in the current spec. These are practical use cases of the more general question of how to you insert and delete events into an existing order sequence

Re: [lng-odp] [RFC PATCH] linux-generc: pktio: add pcap pktio type

2015-07-29 Thread Stuart Haslam
On Wed, Jul 29, 2015 at 02:14:06PM +0300, Maxim Uvarov wrote: On 07/29/15 14:00, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 01:23:20PM +0300, Maxim Uvarov wrote: On 07/28/15 20:54, Stuart Haslam wrote: Create a new pktio type that allows for reading from and writing to a pcap capture file.

Re: [lng-odp] [Patch] validation: time: increase TOLERANCE range

2015-07-29 Thread Ivan Khoronzhuk
On 29.07.15 14:42, Ivan Khoronzhuk wrote: On 29.07.15 14:34, Maxim Uvarov wrote: Should we have #define CONFIG_TIMER_RESOLUTION in config.h? And relay on it's value. Maxim. Maybe. In case of CPU freq this is inversely proportional to odp_sys_cpu_hz(), and can be determined. But in case

Re: [lng-odp] [API-NEXT PATCH 2/5] linux-generic: schedule: implement scheduler groups

2015-07-29 Thread Stuart Haslam
On Tue, Jul 28, 2015 at 08:56:53PM -0500, Bill Fischofer wrote: Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/config.h | 5 + .../include/odp/plat/schedule_types.h | 4 + platform/linux-generic/odp_schedule.c

Re: [lng-odp] [PATCH 00/13] validation: use macro _CU_TEST_INFO() in all tests

2015-07-29 Thread Stuart Haslam
On Mon, Jul 27, 2015 at 02:43:42PM +0200, Christophe Milard wrote: This is another step in getting the test environment more homogeneous. The usage of this macro guaranties that the test name (string in C_unit) will always match the function name. This is needed as the C_unit strings will be

Re: [lng-odp] [Patch] validation: time: increase TOLERANCE range

2015-07-29 Thread Ivan Khoronzhuk
On 29.07.15 14:47, Bill Fischofer wrote: Agreed. An ODP implementation should be for a platform, not for a specific model within a platform family. Another reason why config.h needs to be converted from #defines to APIs. There is a little more sense under it. Each CPU, theoretically, (no

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-29 Thread Stuart Haslam
On Wed, Jul 29, 2015 at 01:12:23PM +0200, Balakrishna.Garapati wrote: corrected alignment issues This should go beneath the --- line so that it doesn't end up in the commit log. Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- example/generator/odp_generator.c | 13

Re: [lng-odp] [PATCH] doc: publish contributing and dependencies

2015-07-29 Thread Mike Holmes
On 29 July 2015 at 07:51, Maxim Uvarov maxim.uva...@linaro.org wrote: Mike, I'm looking to generated html docs and it looks like it's better to put that pages under User guide section. There are two levels of information, the basic requirements and a human walk though. The contributing and

[lng-odp] [Bug 1722] New: CID 99100: BUFFER_SIZE_WARNING: /example/classifier/odp_classifier.c

2015-07-29 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1722 Bug ID: 1722 Summary: CID 99100: BUFFER_SIZE_WARNING: /example/classifier/odp_classifier.c Product: OpenDataPlane Version: 1.2 Hardware: Other OS: Linux

Re: [lng-odp] [PATCH] doc: publish contributing and dependencies

2015-07-29 Thread Maxim Uvarov
On 07/29/15 15:22, Mike Holmes wrote: On 29 July 2015 at 07:51, Maxim Uvarov maxim.uva...@linaro.org mailto:maxim.uva...@linaro.org wrote: Mike, I'm looking to generated html docs and it looks like it's better to put that pages under User guide section. There are two levels of

Re: [lng-odp] [PATCHv3 00/20] validation: populating libraries

2015-07-29 Thread Maxim Uvarov
Merged, Maxim. On 07/28/15 13:36, Stuart Haslam wrote: On Mon, Jul 27, 2015 at 07:38:32PM +0200, Christophe Milard wrote: Since v2: fix spell typo and rebased Since v1: added the 3 first patches to work around the problem of using filename errno.h locally and populated errno lib. Also

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-29 Thread Maxim Uvarov
On 07/29/15 16:02, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 03:54:51PM +0300, Maxim Uvarov wrote: On 07/29/15 15:21, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 01:12:23PM +0200, Balakrishna.Garapati wrote: corrected alignment issues This should go beneath the --- line so that it

Re: [lng-odp] [API-NEXT PATCH 2/5] linux-generic: schedule: implement scheduler groups

2015-07-29 Thread Bill Fischofer
Thanks for the comments. On Wed, Jul 29, 2015 at 6:53 AM, Stuart Haslam stuart.has...@linaro.org wrote: On Tue, Jul 28, 2015 at 08:56:53PM -0500, Bill Fischofer wrote: Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/config.h | 5 +

Re: [lng-odp] [Patch] validation: time: increase TOLERANCE range

2015-07-29 Thread Mike Holmes
On 29 July 2015 at 08:17, Ivan Khoronzhuk ivan.khoronz...@linaro.org wrote: On 29.07.15 14:47, Bill Fischofer wrote: Agreed. An ODP implementation should be for a platform, not for a specific model within a platform family. Another reason why config.h needs to be converted from #defines

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-29 Thread Maxim Uvarov
On 07/29/15 15:21, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 01:12:23PM +0200, Balakrishna.Garapati wrote: corrected alignment issues This should go beneath the --- line so that it doesn't end up in the commit log. Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org ---

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-29 Thread Stuart Haslam
On Wed, Jul 29, 2015 at 03:54:51PM +0300, Maxim Uvarov wrote: On 07/29/15 15:21, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 01:12:23PM +0200, Balakrishna.Garapati wrote: corrected alignment issues This should go beneath the --- line so that it doesn't end up in the commit log.

Re: [lng-odp] [PATCH] doc: publish contributing and dependencies

2015-07-29 Thread Mike Holmes
On 29 July 2015 at 08:52, Maxim Uvarov maxim.uva...@linaro.org wrote: On 07/29/15 15:22, Mike Holmes wrote: On 29 July 2015 at 07:51, Maxim Uvarov maxim.uva...@linaro.org mailto: maxim.uva...@linaro.org wrote: Mike, I'm looking to generated html docs and it looks like it's better

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-29 Thread Stuart Haslam
On Wed, Jul 29, 2015 at 05:13:40PM +0300, Maxim Uvarov wrote: On 07/29/15 16:43, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 04:10:06PM +0300, Maxim Uvarov wrote: On 07/29/15 16:02, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 03:54:51PM +0300, Maxim Uvarov wrote: On 07/29/15 15:21, Stuart

[lng-odp] [PATCHv3] example:generator:printing verbose output

2015-07-29 Thread Balakrishna.Garapati
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- Added fflush example/generator/odp_generator.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index d6ec758..bdee222

[lng-odp] [PATCH] validation: synchronizers: use number of workers instead of threads

2015-07-29 Thread Maxim Uvarov
Use number of workers to not deadlock on barrier. Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- test/validation/synchronizers/synchronizers.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/validation/synchronizers/synchronizers.c

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-29 Thread Maxim Uvarov
On 07/29/15 16:43, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 04:10:06PM +0300, Maxim Uvarov wrote: On 07/29/15 16:02, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 03:54:51PM +0300, Maxim Uvarov wrote: On 07/29/15 15:21, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 01:12:23PM +0200,

Re: [lng-odp] [Patch] validation: time: increase TOLERANCE range

2015-07-29 Thread Mike Holmes
On 29 July 2015 at 08:17, Ivan Khoronzhuk ivan.khoronz...@linaro.org wrote: On 29.07.15 14:47, Bill Fischofer wrote: Agreed. An ODP implementation should be for a platform, not for a specific model within a platform family. Another reason why config.h needs to be converted from #defines

Re: [lng-odp] [Patch] validation: time: increase TOLERANCE range

2015-07-29 Thread Ivan Khoronzhuk
Mike, On 29.07.15 15:27, Mike Holmes wrote: On 29 July 2015 at 08:17, Ivan Khoronzhuk ivan.khoronz...@linaro.org mailto:ivan.khoronz...@linaro.org wrote: On 29.07.15 14:47, Bill Fischofer wrote: Agreed. An ODP implementation should be for a platform, not for a specific

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-29 Thread Stuart Haslam
On Wed, Jul 29, 2015 at 04:10:06PM +0300, Maxim Uvarov wrote: On 07/29/15 16:02, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 03:54:51PM +0300, Maxim Uvarov wrote: On 07/29/15 15:21, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 01:12:23PM +0200, Balakrishna.Garapati wrote: corrected alignment

Re: [lng-odp] [API-NEXT PATCH 5/5] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-29 Thread Alexandru Badicioiu
My understanding is that POLL type queues don't have any scheduling attributes, since their scheduler is the application itself. Atomic context is not really an event attribute - it's a queue attribute which enforces the scheduler to return an event from the queue only when no other event from the