Re: [lng-odp] RFC - Application counters helpers

2015-07-30 Thread Bala Manoharan
Hi, Yes. The above use-case makes sense. Also we need to document explicit limitation that these variables should be created before starting the worker threads and that dynamic creation of variables should be avoided. Regards, Bala On 30 July 2015 at 13:29, Alexandru Badicioiu

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto IPSec extension

2015-07-30 Thread Alexandru Badicioiu
On 30 July 2015 at 13:50, Stuart Haslam stuart.has...@linaro.org wrote: On Wed, Jul 22, 2015 at 11:26:03AM +0300, alexandru.badici...@linaro.org wrote: From: Alexandru Badicioiu alexandru.badici...@linaro.org This patch adds IPSec protocol processing capabilities to crypto sesssions.

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto IPSec extension

2015-07-30 Thread Jerin Jacob
On Wed, Jul 22, 2015 at 11:26:03AM +0300, alexandru.badici...@linaro.org wrote: From: Alexandru Badicioiu alexandru.badici...@linaro.org This patch adds IPSec protocol processing capabilities to crypto sesssions. Implementations which have these capabilities in hardware crypto engines can

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto IPSec extension

2015-07-30 Thread Jacob, Jerin
From: Alexandru Badicioiu alexandru.badici...@linaro.org Sent: Thursday, July 30, 2015 6:44 PM To: Jacob, Jerin Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto IPSec extension On 30 July 2015 at 16:00, Jerin Jacob

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto IPSec extension

2015-07-30 Thread Stuart Haslam
On Thu, Jul 30, 2015 at 02:42:08PM +0300, Alexandru Badicioiu wrote: On 30 July 2015 at 13:50, Stuart Haslam stuart.has...@linaro.org wrote: On Wed, Jul 22, 2015 at 11:26:03AM +0300, alexandru.badici...@linaro.org wrote: From: Alexandru Badicioiu alexandru.badici...@linaro.org This

[lng-odp] [PATCH] example: classifier: fix buffer size warning

2015-07-30 Thread Balasubramanian Manoharan
Fixes: https://bugs.linaro.org/show_bug.cgi?id=1722 Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org --- example/classifier/odp_classifier.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/example/classifier/odp_classifier.c

Re: [lng-odp] [PATCHv3] example:generator:printing verbose output

2015-07-30 Thread Maxim Uvarov
Merged, Maxim. On 07/30/15 13:55, Stuart Haslam wrote: On Wed, Jul 29, 2015 at 04:25:41PM +0200, Balakrishna.Garapati wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org Reviewed-by: Stuart Haslam stuart.has...@linaro.org --- Added fflush

[lng-odp] [Bug 1546] Untested API verify_pmr_udp_dport

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1546 --- Comment #1 from Bala Manoharan bala.manoha...@linaro.org --- patch submitted: https://patches.linaro.org/51699/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

[lng-odp] [Bug 1541] Untested API verify_pmr_packet_len

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1541 --- Comment #1 from Bala Manoharan bala.manoha...@linaro.org --- patch submitted: https://patches.linaro.org/51699/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

[lng-odp] [Bug 1675] CID 98149: CID 98148: CID 98147: Integer handling issues

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1675 Bala Manoharan bala.manoha...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

Re: [lng-odp] [PATCH] validation: cpumask: fixed typo

2015-07-30 Thread Maxim Uvarov
Merged, Maxim. On 07/28/15 14:46, Stuart Haslam wrote: On Tue, Jul 28, 2015 at 01:41:54PM +0200, Christophe Milard wrote: Signed-off-by: Christophe Milard christophe.mil...@linaro.org Reviewed-by: Stuart Haslam stuart.has...@linaro.org --- test/validation/cpumask/cpumask.c | 2 +- 1 file

[lng-odp] [Bug 1544] Untested API verify_pmr_tcp_sport

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1544 --- Comment #1 from Bala Manoharan bala.manoha...@linaro.org --- patch submitted: https://patches.linaro.org/51699/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

[lng-odp] [Bug 1722] CID 99100: BUFFER_SIZE_WARNING: /example/classifier/odp_classifier.c

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1722 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever

[lng-odp] [Bug 1722] CID 99100: BUFFER_SIZE_WARNING: /example/classifier/odp_classifier.c

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1722 --- Comment #1 from Bala Manoharan bala.manoha...@linaro.org --- patch submitted: https://patches.linaro.org/51700/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

Re: [lng-odp] [PATCH 3/3] linux-generic: pktio: handle transmit errors correctly

2015-07-30 Thread Maxim Uvarov
Sturart, test case looks like valuable. Do you plan to update that patch? I think it's better to have test case in separate commit. Maxim. On 04/02/15 14:07, Stuart Haslam wrote: The linux-generic pktio implementations don't correctly handle socket errors which occur while sending packets via

[lng-odp] [Bug 1542] Untested API verify_pmr_ip_proto

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1542 --- Comment #1 from Bala Manoharan bala.manoha...@linaro.org --- patch submitted: https://patches.linaro.org/51699/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

[lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

2015-07-30 Thread Balasubramanian Manoharan
Additional test suite is added to classification validation suite to test individual PMRs. This suite will test the defined PMRs by configuring pktio separately for every test case. Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org --- helper/include/odp/helper/tcp.h

Re: [lng-odp] [PATCH] validation: creation of the test superlib

2015-07-30 Thread Maxim Uvarov
On 07/29/15 17:28, Christophe Milard wrote: libodptests.la contains all platform agnostic test functions and symbols defined odptests.h (from all modules) It is meant to be used by ODP devloppers to pick up the tests they need (and disgard others) during the devlopment process on their platform.

[lng-odp] [Bug 1545] Untested API verify_pmr_tcp_dport

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1545 --- Comment #1 from Bala Manoharan bala.manoha...@linaro.org --- patch submitted: https://patches.linaro.org/51699/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

Re: [lng-odp] Pull request: validation last modules from platform side

2015-07-30 Thread Ivan Khoronzhuk
Hi Christophe, Could you please clarify how to build validation tests from platform side. As I see all tests stop to build only because i do: --- a/test/Makefile.am +++ b/test/Makefile.am @@ -1,5 +1,5 @@ SUBDIRS = api_test performance miscellaneous if cunit_support -SUBDIRS += validation

[lng-odp] [API-NEXT PATCHv3 5/6] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/schedule.h | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/include/odp/api/schedule.h b/include/odp/api/schedule.h index 95fc8df..0ab91e4 100644 ---

[lng-odp] [API-NEXT PATCHv3 6/6] linux-generic: schedule: implement odp_schedule_release_ordered()

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- platform/linux-generic/odp_queue.c | 169 + 1 file changed, 152 insertions(+), 17 deletions(-) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-generic/odp_queue.c index

[lng-odp] [Bug 1693] CPU frequency should be locked when it is used to calculate time

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1693 --- Comment #2 from Hongbo Zhang hongbo.zh...@linaro.org --- As discussed with Stuart, he suggested this can be solved outside ODP, eg lock frequency before launch it, if so no patch is needed for this. -- You are receiving this mail because: You are

Re: [lng-odp] [API-NEXT PATCH 2/5] linux-generic: schedule: implement scheduler groups

2015-07-30 Thread Mario Torrecillas Rodriguez
The problem with using count as a way of determining whether the slot is unallocated or not is that count keeps the current number of threads in the group. If a group is created with no threads in it (which is allowed by the implementation as far as I can see), then no thread will be able to

Re: [lng-odp] [PATCH] example:generator:option to supply core mask

2015-07-30 Thread Krishna Garapati
just for the info, This patch only enables and sets the cpu masks correctly. Still working on the patch to fix the PING mode to run on the supplied cpu mask instead of hard coded cpu0. On 30 July 2015 at 10:02, Balakrishna.Garapati balakrishna.garap...@linaro.org wrote: Signed-off-by:

[lng-odp] [PATCH] example:generator:option to supply core mask

2015-07-30 Thread Balakrishna.Garapati
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- This patch also includes changes to enable the option to support number of workers. example/generator/odp_generator.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git

[lng-odp] [Bug 1615] odp_timer fails in CI with Segmentation fault

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1615 Maxim Uvarov maxim.uva...@linaro.org changed: What|Removed |Added CC||maxim.uva...@linaro.org

[lng-odp] [Bug 1547] Untested API copy_md_to_packet

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1547 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org

[lng-odp] [Bug 1365] Lock-up following sendmmsg failure

2015-07-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1365 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever

[lng-odp] [PATCHv2] validation: creation of the test superlib

2015-07-30 Thread Christophe Milard
libodptests.la contains all platform agnostic test functions and symbols defined odptests.h (from all modules) It is meant to be used by ODP devloppers to pick up the tests they need (and disgard others) during the devlopment process on their platform. Signed-off-by: Christophe Milard

[lng-odp] [PATCH] doc: publish contributing text

2015-07-30 Thread Mike Holmes
Signed-off-by: Mike Holmes mike.hol...@linaro.org --- This drops the DEPENDENCIES so I have submitted it as a new patch and changed the subject. doc/doxygen.cfg | 2 +- doc/odp.dox | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/doxygen.cfg b/doc/doxygen.cfg index

[lng-odp] [API-NEXT PATCHv3 3/6] linux-generic: schedule: implement scheduler groups

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/config.h | 5 + .../include/odp/plat/schedule_types.h | 4 + platform/linux-generic/odp_schedule.c | 158 + platform/linux-generic/odp_thread.c

[lng-odp] [API-NEXT PATCHv3 4/6] linux-generic: queue: implement ordered queues

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- .../linux-generic/include/odp_buffer_internal.h| 5 + .../linux-generic/include/odp_queue_internal.h | 4 + .../linux-generic/include/odp_schedule_internal.h | 2 +- platform/linux-generic/odp_pool.c | 3

[lng-odp] [API-NEXT PATCHv3 0/6] Scheduler API Enhancements

2015-07-30 Thread Bill Fischofer
Changes in v3 - Refine API for odp_schedule_release_ordered() and implement it - Numerous bug fixes and cleanup -- Changes in v2 - Incorporate Stuart's review comments - Add odp_schedule_group_count() API to return the count of threads belonging to a schedule group -- This patch series

[lng-odp] [API-NEXT PATCHv3 1/6] api: schedule: additional scheduler group functions

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/schedule.h | 55 ++ 1 file changed, 55 insertions(+) diff --git a/include/odp/api/schedule.h b/include/odp/api/schedule.h index 36e52cd..95fc8df 100644 ---

[lng-odp] [API-NEXT PATCHv3 2/6] validation: schedule: initialize queue and pool parameters

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- test/validation/scheduler/scheduler.c | 4 1 file changed, 4 insertions(+) diff --git a/test/validation/scheduler/scheduler.c b/test/validation/scheduler/scheduler.c index fe03ab7..bbe829e 100644 ---

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto IPSec extension

2015-07-30 Thread Stuart Haslam
On Wed, Jul 22, 2015 at 11:26:03AM +0300, alexandru.badici...@linaro.org wrote: From: Alexandru Badicioiu alexandru.badici...@linaro.org This patch adds IPSec protocol processing capabilities to crypto sesssions. Implementations which have these capabilities in hardware crypto engines can

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-30 Thread Stuart Haslam
Forget that, I didn't notice he had sent a v3. Stuart. On 30 July 2015 at 11:51, Stuart Haslam stuart.has...@linaro.org wrote: On Thu, Jul 30, 2015 at 11:56:42AM +0300, Maxim Uvarov wrote: On 07/29/15 17:40, Stuart Haslam wrote: I mentioned that (in an off-list mail) to Krishna but said I

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-30 Thread Stuart Haslam
On Thu, Jul 30, 2015 at 11:56:42AM +0300, Maxim Uvarov wrote: On 07/29/15 17:40, Stuart Haslam wrote: I mentioned that (in an off-list mail) to Krishna but said I thought it could be changed later, as it's complicated slightly by the different modes you can be running in and I figured it's not

[lng-odp] [API-NEXT PATCHv2 0/5] Scheduler API Enhancements

2015-07-30 Thread Bill Fischofer
Changes in v2 - Incorporate Stuart's review comments - Add odp_schedule_group_count() API to return the count of threads belonging to a schedule group -- This patch series implements (most of) Petri's latest scheduler changes. Major changes include: 1. Implement scheduler groups, including

[lng-odp] [API-NEXT PATCHv2 2/5] validation: schedule: initialize queue and pool parameters

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- test/validation/scheduler/scheduler.c | 4 1 file changed, 4 insertions(+) diff --git a/test/validation/scheduler/scheduler.c b/test/validation/scheduler/scheduler.c index fe03ab7..bbe829e 100644 ---

[lng-odp] [API-NEXT PATCHv2 1/5] api: schedule: additional scheduler group functions

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/schedule.h | 55 ++ 1 file changed, 55 insertions(+) diff --git a/include/odp/api/schedule.h b/include/odp/api/schedule.h index 36e52cd..95fc8df 100644 ---

[lng-odp] [API-NEXT PATCHv2 3/5] linux-generic: schedule: implement scheduler groups

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/config.h | 5 + .../include/odp/plat/schedule_types.h | 4 + platform/linux-generic/odp_schedule.c | 158 + platform/linux-generic/odp_thread.c

[lng-odp] [API-NEXT PATCHv2 4/5] linux-generic: queue: implement ordered queues

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- .../linux-generic/include/odp_buffer_internal.h| 5 + .../linux-generic/include/odp_queue_internal.h | 4 + .../linux-generic/include/odp_schedule_internal.h | 7 + platform/linux-generic/odp_pool.c | 3

[lng-odp] [API-NEXT PATCHv2 5/5] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-30 Thread Bill Fischofer
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/schedule.h | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/include/odp/api/schedule.h b/include/odp/api/schedule.h index 95fc8df..0c3d8ba 100644 ---

Re: [lng-odp] [API-NEXT PATCH 2/5] linux-generic: schedule: implement scheduler groups

2015-07-30 Thread Bill Fischofer
I've fixed these in v2. Also added is the new API odp_schedule_group_count() that gives the number of threads belonging to a schedule group. On Thu, Jul 30, 2015 at 1:12 AM, Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com wrote: The problem with using count as a way of

[lng-odp] [PATCHv1] example:generator:option to supply core mask

2015-07-30 Thread Balakrishna.Garapati
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- Fixed cpu_mask for PING mode. The mask is set to what is actually supplied. example/generator/odp_generator.c | 51 ++- 1 file changed, 39 insertions(+), 12 deletions(-) diff --git

Re: [lng-odp] [PATCHv3] example:generator:printing verbose output

2015-07-30 Thread Stuart Haslam
On Wed, Jul 29, 2015 at 04:25:41PM +0200, Balakrishna.Garapati wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org Reviewed-by: Stuart Haslam stuart.has...@linaro.org --- Added fflush example/generator/odp_generator.c | 14 +- 1 file changed, 13

Re: [lng-odp] [PATCHv1] example:generator:option to supply core mask

2015-07-30 Thread Krishna Garapati
Ignore this patch. Pushing another one with PATCHv2. On 30 July 2015 at 12:54, Balakrishna.Garapati balakrishna.garap...@linaro.org wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- Fixed cpu_mask for PING mode. The mask is set to what is actually supplied.

Re: [lng-odp] [PATCH] example:generator:option to supply core mask

2015-07-30 Thread Stuart Haslam
On Thu, Jul 30, 2015 at 10:02:46AM +0200, Balakrishna.Garapati wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- This patch also includes changes to enable the option to support number of workers. example/generator/odp_generator.c | 35

[lng-odp] [PATCHv2] example:generator:option to supply core mask

2015-07-30 Thread Balakrishna.Garapati
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- Fixed cpu_mask for PING mode. The mask is set to what is actually supplied. example/generator/odp_generator.c | 51 ++- 1 file changed, 39 insertions(+), 12 deletions(-) diff --git

Re: [lng-odp] [PATCH] example:generator:option to supply core mask

2015-07-30 Thread Krishna Garapati
I agree. I can make the changes. On 30 July 2015 at 12:58, Stuart Haslam stuart.has...@linaro.org wrote: On Thu, Jul 30, 2015 at 10:02:46AM +0200, Balakrishna.Garapati wrote: Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- This patch also includes changes to

Re: [lng-odp] [PATCHv2] example:generator:printing verbose output

2015-07-30 Thread Maxim Uvarov
On 07/29/15 17:40, Stuart Haslam wrote: I mentioned that (in an off-list mail) to Krishna but said I thought it could be changed later, as it's complicated slightly by the different modes you can be running in and I figured it's not worth delaying this change over. It's questionable though. Ok,

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto IPSec extension

2015-07-30 Thread Maxim Uvarov
On 07/30/15 12:04, Alexandru Badicioiu wrote: Ping. Alex, Mike replayed to you to fix minor fixes. Maxim. On 22 July 2015 at 11:26, alexandru.badici...@linaro.org mailto:alexandru.badici...@linaro.org wrote: From: Alexandru Badicioiu alexandru.badici...@linaro.org

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto IPSec extension

2015-07-30 Thread Alexandru Badicioiu
Hi Maxim, I noticed that but I wanted to know if there are some other comments more oriented to the functionality this patch proposes. Thanks, Alex On 30 July 2015 at 12:21, Maxim Uvarov maxim.uva...@linaro.org wrote: On 07/30/15 12:04, Alexandru Badicioiu wrote: Ping. Alex, Mike replayed

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto IPSec extension

2015-07-30 Thread Alexandru Badicioiu
Ping. On 22 July 2015 at 11:26, alexandru.badici...@linaro.org wrote: From: Alexandru Badicioiu alexandru.badici...@linaro.org This patch adds IPSec protocol processing capabilities to crypto sesssions. Implementations which have these capabilities in hardware crypto engines can use the

[lng-odp] [PATCHv3] example:generator:option to supply core mask

2015-07-30 Thread Balakrishna.Garapati
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org --- changed the command line argument conventions. example/generator/odp_generator.c | 57 ++- 1 file changed, 39 insertions(+), 18 deletions(-) diff --git a/example/generator/odp_generator.c