Re: [lng-odp] [API-NEXT PATCHv3 6/6] linux-generic: schedule: implement odp_schedule_release_ordered()

2015-07-31 Thread Maxim Uvarov
On 07/31/15 05:41, Bill Fischofer wrote: Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- platform/linux-generic/odp_queue.c | 169 + 1 file changed, 152 insertions(+), 17 deletions(-) diff --git a/platform/linux-generic/odp_queue.c

Re: [lng-odp] [API-NEXT PATCHv3 0/6] Scheduler API Enhancements

2015-07-31 Thread Maxim Uvarov
On 07/31/15 05:41, Bill Fischofer wrote: ERROR: do not initialise globals to 0 or NULL #139: FILE: platform/linux-generic/odp_schedule.c:638: + = 0; which makes no sense as this initialization seems necessary. What is that line? Compiler will take care about

Re: [lng-odp] [API-NEXT PATCHv3 5/6] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-31 Thread Bala Manoharan
On 31 July 2015 at 17:48, Bill Fischofer bill.fischo...@linaro.org wrote: On Fri, Jul 31, 2015 at 1:38 AM, Bala Manoharan bala.manoha...@linaro.org wrote: Hi, Comments inline... On 31 July 2015 at 08:11, Bill Fischofer bill.fischo...@linaro.org wrote: Signed-off-by: Bill Fischofer

Re: [lng-odp] [API-NEXT PATCHv3 5/6] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-31 Thread Bill Fischofer
On Fri, Jul 31, 2015 at 8:17 AM, Bala Manoharan bala.manoha...@linaro.org wrote: On 31 July 2015 at 20:03, Bill Fischofer bill.fischo...@linaro.org wrote: On Fri, Jul 31, 2015 at 6:52 AM, Bala Manoharan bala.manoha...@linaro.org wrote: On 31 July 2015 at 17:48, Bill Fischofer

Re: [lng-odp] [PATCH] linux-generic: move cpumask common functions to separate file

2015-07-31 Thread Christophe Milard
Hi, There is another aspect of this which is a bit unfortunate: In the validation, what is regarded as common regarding cpumask is what is common to both cpumasks and threadmask. The file test/validation/common/mask_common.c contains tests that are common to both threadmask and cpumask. In the

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

2015-07-31 Thread Christophe Milard
I am sorry, as this is not well documented yet (I am currentely working on the documentation), but this patch does not respect the naming convention for test function, test-suite... Possibly you started your work on this before my modification went in... Anyway here follows the naming convention

Re: [lng-odp] [API-NEXT PATCHv3 1/6] api: schedule: additional scheduler group functions

2015-07-31 Thread Maxim Uvarov
On 07/31/15 05:41, Bill Fischofer wrote: Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/schedule.h | 55 ++ 1 file changed, 55 insertions(+) diff --git a/include/odp/api/schedule.h b/include/odp/api/schedule.h index

Re: [lng-odp] [API-NEXT PATCHv3 5/6] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-31 Thread Bala Manoharan
On 31 July 2015 at 20:03, Bill Fischofer bill.fischo...@linaro.org wrote: On Fri, Jul 31, 2015 at 6:52 AM, Bala Manoharan bala.manoha...@linaro.org wrote: On 31 July 2015 at 17:48, Bill Fischofer bill.fischo...@linaro.org wrote: On Fri, Jul 31, 2015 at 1:38 AM, Bala Manoharan

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

2015-07-31 Thread Bala Manoharan
Hi Christophe, Thanks for pointing this out :) I had started this work before the naming conventions were mandated. I will follow the naming conventions followed here before my final patch is out. I will update these changes along with review comments I get ;) Regards, Bala On 31 July 2015 at

Re: [lng-odp] [API-NEXT PATCHv3 5/6] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-31 Thread Bill Fischofer
On Fri, Jul 31, 2015 at 1:38 AM, Bala Manoharan bala.manoha...@linaro.org wrote: Hi, Comments inline... On 31 July 2015 at 08:11, Bill Fischofer bill.fischo...@linaro.org wrote: Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/schedule.h | 38

[lng-odp] [PATCH] validation: update README files

2015-07-31 Thread Christophe Milard
Signed-off-by: Christophe Milard christophe.mil...@linaro.org --- test/README| 8 +--- test/validation/README | 50 ++ 2 files changed, 51 insertions(+), 7 deletions(-) create mode 100644 test/validation/README diff --git

Re: [lng-odp] [PATCH] validation: synchronizers: use number of workers instead of threads

2015-07-31 Thread Maxim Uvarov
Please review. That patch is needed for dpdk. Maxim. On 07/29/15 17:09, Maxim Uvarov wrote: Use number of workers to not deadlock on barrier. Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- test/validation/synchronizers/synchronizers.c | 8 +--- 1 file changed, 5 insertions(+),

Re: [lng-odp] [API-NEXT PATCHv3 5/6] api: schedule: revised definition of odp_schedule_release_ordered

2015-07-31 Thread Bala Manoharan
Hi, Comments inline... On 31 July 2015 at 08:11, Bill Fischofer bill.fischo...@linaro.org wrote: Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- include/odp/api/schedule.h | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff

Re: [lng-odp] [PATCH] doc: publish contributing text

2015-07-31 Thread Maxim Uvarov
Merged, that should be patch v2 :) Maxim. On 07/30/15 21:06, Mike Holmes wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org --- This drops the DEPENDENCIES so I have submitted it as a new patch and changed the subject. doc/doxygen.cfg | 2 +- doc/odp.dox | 4 2 files

[lng-odp] [PATCH] linux-generic: move cpumask common functions to separate file

2015-07-31 Thread Maxim Uvarov
Move functions which iterates with bit mask and more likely will not be accelerated by hw to odp_cpumask_common.c. And odp_cpumask.c will have only platform specific functions. That patch should simplify portability to other platfroms when odp_cpumask_common.c will be inherit from linux generic.

Re: [lng-odp] [PATCH] doc: publish contributing text

2015-07-31 Thread Mike Holmes
On 31 July 2015 at 05:19, Maxim Uvarov maxim.uva...@linaro.org wrote: Merged, that should be patch v2 :) I debated that but it had to have a new subject and contained only 1/2 the content Maxim. On 07/30/15 21:06, Mike Holmes wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org