Re: [lng-odp] [PATCHv3 0/3] Remove basic pktio sock and support segmented packet

Any feedback on this? It does not apply anymore since test suite function are not static anymore. I've an updated version ready if there are no comments. Nicolas On 07/20/2015 04:16 PM, Nicolas Morey-Chaisemartin wrote: > Change since v2: > Only 2 tests suites instead of 3. > Because ODP_CONFI

Re: [lng-odp] [PATCHv3 0/3] Remove basic pktio sock and support segmented packet

Stuart, can you please check if your comments fixed for test case version. Maxim. On 08/03/15 10:52, Nicolas Morey-Chaisemartin wrote: Any feedback on this? It does not apply anymore since test suite function are not static anymore. I've an updated version ready if there are no comments. Nico

Re: [lng-odp] [PATCHv3 0/3] Remove basic pktio sock and support segmented packet

Stuart, can you please check if your comments fixed for test case? Maxim. On 08/03/15 10:52, Nicolas Morey-Chaisemartin wrote: Any feedback on this? It does not apply anymore since test suite function are not static anymore. I've an updated version ready if there are no comments. Nicolas On

[lng-odp] [PATCH] example:generator:move verbose from worker to control

Signed-off-by: Balakrishna.Garapati --- Moved verbose output logic from worker to control thread example/generator/odp_generator.c | 53 +++ 1 file changed, 42 insertions(+), 11 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/

[lng-odp] [Bug 1693] CPU frequency should be locked when it is used to calculate time

https://bugs.linaro.org/show_bug.cgi?id=1693 Hongbo Zhang changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|---

Re: [lng-odp] [API-NEXT PATCHv5 8/9] api: queue: document ordered chain enq support

As defined here, the odp_queue_enq_multi() is the complete split, and the sequence is as specified in the list. Let's discuss this during today's Arch call. Do you have a proposed API for doing what you'd like? On Mon, Aug 3, 2015 at 1:46 AM, Alexandru Badicioiu < alexandru.badici...@linaro.or

[lng-odp] [PATCH] linux-generic: move git_hash.sh under linux-generic directory

git_hash.sh is used to generate version string. Each platform should have it's own version of that script. Signed-off-by: Maxim Uvarov --- configure.ac| 2 +- platform/Makefile.inc | 2 +- {scripts => platform/linux-ge

Re: [lng-odp] [API-NEXT PATCHv5 8/9] api: queue: document ordered chain enq support

Shouldn't be possible to insert in an ordered flow just with odp_queue_enq()? Using odp_queue_enq_multi() only is somehow restrictive. I think ordering information should be contained in the event itself rather than which index in events[] array occupies. Alex On 3 August 2015 at 14:21, Bill Fisc

Re: [lng-odp] [API-NEXT PATCHv5 8/9] api: queue: document ordered chain enq support

I tried coming up with some syntax that would describe this, but was unsuccessful. The issue is that order is a property of the source queue and these split elements have no originating queue since the application is creating them. If your HW supports this feature it might be easier to model it af

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

Hi, Bala On 30.07.15 18:20, Balasubramanian Manoharan wrote: Additional test suite is added to classification validation suite to test individual PMRs. This suite will test the defined PMRs by configuring pktio separately for every test case. Signed-off-by: Balasubramanian Manoharan --- hel

Re: [lng-odp] [PATCH] linux-generic: move git_hash.sh under linux-generic directory

On 3 August 2015 at 07:35, Maxim Uvarov wrote: > git_hash.sh is used to generate version string. Each platform > should have it's own version of that script. > > Signed-off-by: Maxim Uvarov > I think that this patch makes it easier for all platforms to co exist with the same upper level code a

[lng-odp] [PATCH] linux-generic: remove checkpatch errors

Signed-off-by: Nicolas Morey-Chaisemartin --- This is a big one ! The idea is to remove almost all checkpatch warnings/errors from the linux-generic code so later patches don't have to fix the original formatting issues. From what I could remember, the only error lefts are linked to scans in od

Re: [lng-odp] [PATCH] linux-generic: move git_hash.sh under linux-generic directory

On 3 August 2015 at 13:35, Maxim Uvarov wrote: > git_hash.sh is used to generate version string. Each platform > should have it's own version of that script. I don't think we need to move the files isn't it enough to just do: diff --git a/scripts/git_hash.sh b/scripts/git_hash.sh index c9f1faf..

Re: [lng-odp] [PATCH] linux-generic: move git_hash.sh under linux-generic directory

On 08/03/15 15:52, Anders Roxell wrote: On 3 August 2015 at 13:35, Maxim Uvarov wrote: git_hash.sh is used to generate version string. Each platform should have it's own version of that script. I don't think we need to move the files isn't it enough to just do: diff --git a/scripts/git_hash.s

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

Hi, On 3 August 2015 at 17:52, Ivan Khoronzhuk wrote: > > Hi, Bala > > On 30.07.15 18:20, Balasubramanian Manoharan wrote: > >> Additional test suite is added to classification validation suite to test >> individual PMRs. This suite will test the defined PMRs by configuring >> pktio separately f

[lng-odp] [Bug 1735] New: loopback_mtu_get & loopback_promisc_mode_set reported as not called in validation

https://bugs.linaro.org/show_bug.cgi?id=1735 Bug ID: 1735 Summary: loopback_mtu_get & loopback_promisc_mode_set reported as not called in validation Product: OpenDataPlane Version: 1.2 Hardware: Other OS: Li

[lng-odp] [PATCH] helper: fix installation path for includes

Install path was broken when helper installation moved out of the platform side as they were install in the top includedir and not $(includedir)/odp/helper Signed-off-by: Nicolas Morey-Chaisemartin --- helper/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/helpe

[lng-odp] [PATCH 2/2] test: inherit TESTS_ENVIRONMENT from test/Makefile.inc

This defines an empty TESTS_ENVIRONMENT in the test/Makefile.inc so that all file that includes it can use += to add more settings. This way, platform can add their own TESTS_ENVIRONMENT settings in the platform/@platform@/Makefile.inc. Signed-off-by: Nicolas Morey-Chaisemartin --- test/Makefil

[lng-odp] [PATCH 1/2] test: inherit AUTOMAKE_OPTIONS from test/Makefile.inc

This defines an empty AUTOMAKE_OPTIONS in the test/Makefile.inc so that all file that includes it can use += to add more options. This way, platform can add their own AUTOMAKE_OPTIONS options in the platform/@platform@/Makefile.inc. Signed-off-by: Nicolas Morey-Chaisemartin --- test/Makefile.i

[lng-odp] ODP Website changes

I made some changes based on feedback received. Please review at your convenience. There are more changes in the pipeline but they will require review and approval. -- Sincerely, Marshall Guillory Technical Program Enabler, Agile Coach, Scrum master Networking (LNG) and Platform (LAB, QAS, SYS

Re: [lng-odp] ODP Website changes

For me window with tag description looks ugly. I think it's not needed at all. Maxim. On 08/03/15 17:06, Marshall Guillory wrote: I made some changes based on feedback received. Please review at your convenience. There are more changes in the pipeline but they will require review and approv

[lng-odp] [PATCH] performance: l2fwd: fix race condition between thread init and stat counter

Wait for all worker thread to have configured their statistics structure within their argument before dereferencing them. Signed-off-by: Nicolas Morey-Chaisemartin --- test/performance/odp_l2fwd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/test/performance/odp_l2fwd.c b/test/perfo

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

As a proposition, we had talk some time ago about, You moved packet creation to common classification file. Maybe it's time to assign correct src/dst MAC address, taken from pktio? In separate patch. -- Regards, Ivan Khoronzhuk ___ lng-odp mailing list

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

On 3 August 2015 at 21:23, Ivan Khoronzhuk wrote: > As a proposition, we had talk some time ago about, > You moved packet creation to common classification file. > Maybe it's time to assign correct src/dst MAC address, taken from pktio? > In separate patch. Yes. I agree we need to correct them.

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

One more issue On 30.07.15 18:20, Balasubramanian Manoharan wrote: Additional test suite is added to classification validation suite to test individual PMRs. This suite will test the defined PMRs by configuring pktio separately for every test case. Signed-off-by: Balasubramanian Manoharan ---

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

On 3 August 2015 at 21:44, Ivan Khoronzhuk wrote: > One more issue > > On 30.07.15 18:20, Balasubramanian Manoharan wrote: > >> Additional test suite is added to classification validation suite to test >> individual PMRs. This suite will test the defined PMRs by configuring >> pktio separately fo

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

I don’t think this has to be API-NEXT, it does touch a helper but that is not the API from odp/include On 3 August 2015 at 12:24, Bala Manoharan wrote: > > > On 3 August 2015 at 21:44, Ivan Khoronzhuk > wrote: > >> One more issue >> >> On 30.07.15 18:20, Balasubramanian Manoharan wrote: >> >>>

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

On 03.08.15 19:24, Bala Manoharan wrote: On 3 August 2015 at 21:44, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote: One more issue On 30.07.15 18:20, Balasubramanian Manoharan wrote: Additional test suite is added to classification validation suite to tes

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

On 3 August 2015 at 22:01, Ivan Khoronzhuk wrote: > > > On 03.08.15 19:24, Bala Manoharan wrote: > >> >> >> On 3 August 2015 at 21:44, Ivan Khoronzhuk > > wrote: >> >> One more issue >> >> On 30.07.15 18:20, Balasubramanian Manoharan wrote: >> >>

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

Bala, ... what in case of TCP? Incorrect seq num? Looks like a coding error. TCP should be added using a boolean flag. Incorrect seq num is tested in the ASSERT function after receiving the packet. Seq num is used to check whether the

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

On 3 August 2015 at 22:16, Ivan Khoronzhuk wrote: > Bala, > > ... > > >> >> what in case of TCP? Incorrect seq num? >> >> Looks like a coding error. TCP should be added using a boolean >> flag. >> >> Incorrect seq num is tested in the ASSERT function after >>

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

Bala, On 03.08.15 19:51, Bala Manoharan wrote: On 3 August 2015 at 22:16, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote: Bala, ... what in case of TCP? Incorrect seq num? Looks like a coding error. TCP should be added using a

Re: [lng-odp] [PATCH] validation: synchronizers: use number of workers instead of threads

I'm not sure I get the entire context of why it deadlocks on barrier, but otherwise it seems OK, and it fixes the problem in the ODP-DPDK unit tests. Tested-by: Zoltan Kiss Let me know when it gets applied so I can pull it. On 29/07/15 15:09, Maxim Uvarov wrote: Use number of workers to not

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

Ivan, On 3 August 2015 at 22:33, Ivan Khoronzhuk wrote: > Bala, > > On 03.08.15 19:51, Bala Manoharan wrote: > >> >> >> On 3 August 2015 at 22:16, Ivan Khoronzhuk > > wrote: >> >> Bala, >> >> ... >> >> >> >> what in case of TCP

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

Bala, On 03.08.15 20:16, Bala Manoharan wrote: Ivan, On 3 August 2015 at 22:33, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote: Bala, On 03.08.15 19:51, Bala Manoharan wrote: On 3 August 2015 at 22:16, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

Ivan, On 3 August 2015 at 22:58, Ivan Khoronzhuk wrote: > Bala, > > On 03.08.15 20:16, Bala Manoharan wrote: > >> Ivan, >> >> On 3 August 2015 at 22:33, Ivan Khoronzhuk > > wrote: >> >> Bala, >> >> On 03.08.15 19:51, Bala Manoharan wrote: >> >> >> >>

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

Bala, On 03.08.15 20:49, Bala Manoharan wrote: Ivan, On 3 August 2015 at 22:58, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote: Bala, On 03.08.15 20:16, Bala Manoharan wrote: Ivan, On 3 August 2015 at 22:33, Ivan Khoronzhuk mailto:ivan.khoronz...@l

Re: [lng-odp] [API-NEXT] validation: classification: added additional suite to test individual PMRs

On 3 August 2015 at 23:31, Ivan Khoronzhuk wrote: > Bala, > > On 03.08.15 20:49, Bala Manoharan wrote: > >> Ivan, >> >> On 3 August 2015 at 22:58, Ivan Khoronzhuk > > wrote: >> >> Bala, >> >> On 03.08.15 20:16, Bala Manoharan wrote: >> >> Ivan, >

Re: [lng-odp] [PATCH] linux-generic: Makefile.am: fix basename conflicts

On 2015-07-23 12:34, Maxim Uvarov wrote: > I think that patch is not correct. Disagree this patch does fix the warning. > Main problem that odp source for > linux-generic has to be arch independent. I think we agreed that we wanted linux-generic to be optimised for timers, thats why it looks th

[lng-odp] [API-NEXT PATCHv6 00/11] Scheduler API Enhancements

Changes in v6 - Add the new APIs odp_schedule_order_copy(), odp_schedule_order_sustain(), and odp_order_sustain_set() to define and implement order copying and the sustain attribute. An event that sustains order does not satisfy ordering when enqueued, permitting multiple events to share the

[lng-odp] [API-NEXT PATCHv6 01/11] api: schedule: additional scheduler group functions

Signed-off-by: Bill Fischofer --- include/odp/api/schedule.h | 55 ++ 1 file changed, 55 insertions(+) diff --git a/include/odp/api/schedule.h b/include/odp/api/schedule.h index 36e52cd..95fc8df 100644 --- a/include/odp/api/schedule.h +++ b/include/odp

[lng-odp] [API-NEXT PATCHv6 02/11] validation: schedule: initialize queue and pool parameters

Signed-off-by: Bill Fischofer --- test/validation/scheduler/scheduler.c | 4 1 file changed, 4 insertions(+) diff --git a/test/validation/scheduler/scheduler.c b/test/validation/scheduler/scheduler.c index fe03ab7..bbe829e 100644 --- a/test/validation/scheduler/scheduler.c +++ b/test/valid

[lng-odp] [API-NEXT PATCHv6 03/11] linux-generic: schedule: implement scheduler groups

Signed-off-by: Bill Fischofer --- include/odp/api/config.h | 5 + .../include/odp/plat/schedule_types.h | 4 + platform/linux-generic/odp_schedule.c | 156 + platform/linux-generic/odp_thread.c| 25 +++-

[lng-odp] [API-NEXT PATCHv6 05/11] api: schedule: revised definition of odp_schedule_release_ordered

Signed-off-by: Bill Fischofer --- include/odp/api/schedule.h | 38 -- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/include/odp/api/schedule.h b/include/odp/api/schedule.h index 95fc8df..0ab91e4 100644 --- a/include/odp/api/schedule.h +++ b/in

[lng-odp] [API-NEXT PATCHv6 04/11] linux-generic: queue: implement ordered queues

Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_buffer_internal.h| 5 + .../linux-generic/include/odp_queue_internal.h | 4 + .../linux-generic/include/odp_schedule_internal.h | 2 +- platform/linux-generic/odp_pool.c | 3 + platform/linux-generic

[lng-odp] [API-NEXT PATCHv6 07/11] linux-generic: schedule: implement odp_schedule_prefetch()

Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_schedule.c | 5 + 1 file changed, 5 insertions(+) diff --git a/platform/linux-generic/odp_schedule.c b/platform/linux-generic/odp_schedule.c index d595375..4d594a0 100644 --- a/platform/linux-generic/odp_schedule.c +++ b/platform/

[lng-odp] [API-NEXT PATCHv6 06/11] linux-generic: schedule: implement odp_schedule_release_ordered()

Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_queue.c | 169 + 1 file changed, 152 insertions(+), 17 deletions(-) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-generic/odp_queue.c index 4d0e1b4..a2460e7 100644 --- a/platform/

[lng-odp] [API-NEXT PATCHv6 08/11] api: queue: document ordered chain enq support

Signed-off-by: Bill Fischofer --- include/odp/api/queue.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/odp/api/queue.h b/include/odp/api/queue.h index ce04eb4..5a6dbc0 100644 --- a/include/odp/api/queue.h +++ b/include/odp/api/queue.h @@ -173,6 +173,29 @@ i

[lng-odp] [API-NEXT PATCHv6 10/11] api: schedule: add APIs for order copying and sustaining

Signed-off-by: Bill Fischofer --- include/odp/api/schedule.h | 51 ++ 1 file changed, 51 insertions(+) diff --git a/include/odp/api/schedule.h b/include/odp/api/schedule.h index 0ab91e4..af860c4 100644 --- a/include/odp/api/schedule.h +++ b/include/odp

[lng-odp] [API-NEXT PATCHv6 09/11] linux-generic: queue: add ordered chain enq support

Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_buffer_internal.h| 4 + platform/linux-generic/odp_queue.c | 151 +++-- 2 files changed, 115 insertions(+), 40 deletions(-) diff --git a/platform/linux-generic/include/odp_buffer_internal.h b/p

[lng-odp] [API-NEXT PATCHv6 11/11] linux-generic: schedule: implement order copying and sustaining

Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_buffer_internal.h| 1 + platform/linux-generic/odp_queue.c | 43 +++--- platform/linux-generic/odp_schedule.c | 24 3 files changed, 62 insertions(+), 6 deletions(-) dif