Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/pktio/socket_mmap.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/platform/linux-generic/pktio/socket_mmap.c
b/platform/linux-generic/pktio/socket_mmap.c
index 7d42678..2e55672
Merged,
Thanks,
Maxim.
On 08/19/15 15:57, Stuart Haslam wrote:
On Wed, Aug 19, 2015 at 01:12:44PM +0200, Balakrishna.Garapati wrote:
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org
Reviewed-by: Stuart Haslam stuart.has...@linaro.org
(needed a 3way merge to apply)
---
Hi,
As stated in the patch log entry, the main use case for recursive lock is
porting legacy code on top of ODP. It’s not feasible to modify large legacy
projects to not use recursive locking when it’s widely used and expected by the
programming model.
For example, FreeBSD uses recursive
On Wed, Aug 19, 2015 at 02:06:34PM +0300, Ivan Khoronzhuk wrote:
Hi, Stuart
On 19.08.15 12:50, Stuart Haslam wrote:
On Sat, Aug 08, 2015 at 01:28:09AM +0300, Ivan Khoronzhuk wrote:
The time API were changed from *_cycles* to *_tick*, so use
appropriate names.
Signed-off-by: Ivan
On Wed, Aug 19, 2015 at 01:12:44PM +0200, Balakrishna.Garapati wrote:
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org
Reviewed-by: Stuart Haslam stuart.has...@linaro.org
(needed a 3way merge to apply)
---
v8: Ignore this patch as the chnages were not included by mistake.
Hi,
As I mentioned in the call, I'd like to avoid confusion between time and timer
(timer tick). In minimum, the API documentation should not refer to timer.
Also could term 'tick' be removed altogether and just use 'time'?
Something like this:
uint64_t odp_time(void);
uint64_t
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/pktio/pktio.c | 119 ++
1 file changed, 119 insertions(+)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
index ebe34fa..d43c25e 100644
---
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
include/odp/api/packet_io_stats.h | 77 ++
platform/linux-generic/include/odp/packet_io.h | 1 +
2 files changed, 78 insertions(+)
create mode 100644 include/odp/api/packet_io_stats.h
diff --git
v3: update test case according to Stuarts review comments.
v2: return -1 and set odp_errno on send/receive on stopped pktio. Adjust test
accordingly.
--
odp_pktio_start() and odp_pktio_stop() API function uses to control pktio
inside worker or to start/stop pktio from control thread.
On Wed, Jul 29, 2015 at 01:09:30PM +0100, Stuart Haslam wrote:
On Mon, Jul 27, 2015 at 02:43:42PM +0200, Christophe Milard wrote:
This is another step in getting the test environment more homogeneous.
The usage of this macro guaranties that the test name (string in C_unit)
will always match
Hi Ivan,
On 19 August 2015 at 15:02, Ivan Khoronzhuk ivan.khoronz...@linaro.org
wrote:
Hi Bala,
just several comments I forgot to mention.
On 19.08.15 08:45, Bala Manoharan wrote:
Ivan,
On 18 August 2015 at 22:39, Ivan Khoronzhuk ivan.khoronz...@linaro.org
If pktio in state stop return 0, which means no packets was
received but that pktio is good to be sheduled next time.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
After open pktio remains stopped. Inside worker thread (after all
configuration done it should be started.) In that patch I just start
it everywhere to keep original logic and be easy for review. Putting
it inside worker threads will require thread arguments change and
understanding logic of
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
.../linux-generic/include/odp_packet_io_internal.h | 6
platform/linux-generic/odp_packet_io.c | 34 ++
2 files changed, 40 insertions(+)
diff --git
The odp_format tool is not infallible, in this case it is better to omit
the macro from formatting
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
platform/linux-generic/include/odp_buffer_internal.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
The odp_format tool uses clang-format and this definition generates
output that matches the odp checkpatch rules
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
.clang-format | 11 +++
1 file changed, 11 insertions(+)
create mode 100644 .clang-format
diff --git a/.clang-format
This odp_format script applies source file formatting to match the ODP
checkpatch style
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
scripts/odp_format | 31 +++
1 file changed, 31 insertions(+)
create mode 100755 scripts/odp_format
diff --git
On 19.08.15 17:12, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Hi,
As I mentioned in the call, I'd like to avoid confusion between time and timer (timer
tick). In minimum, the API documentation should not refer to timer. Also
could term 'tick' be removed altogether and just use 'time'?
+
On 19.08.15 17:49, Ivan Khoronzhuk wrote:
On 19.08.15 17:12, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Hi,
As I mentioned in the call, I'd like to avoid confusion between time and timer (timer
tick). In minimum, the API documentation should not refer to timer. Also
could term 'tick'
Uh..., that needs rebase.
Maxim.
On 08/19/15 16:43, Stuart Haslam wrote:
On Wed, Jul 29, 2015 at 01:09:30PM +0100, Stuart Haslam wrote:
On Mon, Jul 27, 2015 at 02:43:42PM +0200, Christophe Milard wrote:
This is another step in getting the test environment more homogeneous.
The usage of this
I like this, however some suggested improvements inline:
On Wed, Aug 19, 2015 at 4:10 AM, Nicolas Morey-Chaisemartin
nmo...@kalray.eu wrote:
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
test/validation/packet/packet.c | 40
++--
1 file
Is clang-format intended to be used as a convenience or as something that
is a standard part of ODP? I have no problem with offering it as a
convenience to help submitters in creating clean patches, but what's the
point of having a style guide if code is going to be run through a
formatter? That
On 19 August 2015 at 13:26, Bill Fischofer bill.fischo...@linaro.org wrote:
Is clang-format intended to be used as a convenience or as something that is
a standard part of ODP?
I don’t see it as mandatory, just to help those who find their
favourite editor does not play well with checkpatch
The RSS Hash is the output of the Toepliz Hash function. It is used by
masking some number of low-order bits of this function to get the RSS Index
used. As such 32-bits is more than sufficient since it is essentially maps
to the number of processing cores. A 32-bit hash supports 4 billion
Ok, then I don't see any need to protect existing code that's already
checkpatch clean.
On Wednesday, August 19, 2015, Mike Holmes mike.hol...@linaro.org wrote:
On 19 August 2015 at 13:26, Bill Fischofer bill.fischo...@linaro.org
javascript:; wrote:
Is clang-format intended to be used as a
It's the responsibility of each patch submitter to ensure that the
submission is checkpatch clean. If we're doing a one-off scrub of the
existing code then any anomalies can be dealt with via one-off manual edits
so that the cleanup patches are clean. From then on normal patch processes
should
On Fri, Aug 14, 2015 at 1:42 PM, Zoltan Kiss zoltan.k...@linaro.org wrote:
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
test/validation/packet/packet.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
On 19 August 2015 at 15:09, Bill Fischofer bill.fischo...@linaro.org wrote:
Ok, then I don't see any need to protect existing code that's already
checkpatch clean.
It is needed when we run this to clean up the existing problems - seen
here
On 19.08.15 12:49, Stuart Haslam wrote:
On Sat, Aug 08, 2015 at 01:28:08AM +0300, Ivan Khoronzhuk wrote:
The word cycle is left from old API time names. The cycle is
ambiguous word, especially when it can be used for other purposes.
So better to use tick word or just t symbol.
Signed-off-by:
Fixed all the comments in PATCHv8.
On 19 August 2015 at 11:49, Stuart Haslam stuart.has...@linaro.org wrote:
On Wed, Aug 12, 2015 at 10:55:12AM +0200, Balakrishna.Garapati wrote:
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org
---
validate cpumask from parse_args and
Hi, Stuart
On 19.08.15 12:50, Stuart Haslam wrote:
On Sat, Aug 08, 2015 at 01:28:09AM +0300, Ivan Khoronzhuk wrote:
The time API were changed from *_cycles* to *_tick*, so use
appropriate names.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org
---
v8: Ignore this patch as the chnages were not included by mistake.
v9: moved optional args from MANDATORY to OPTIONAL options
fixed the comment section core mask to CPU maski.
example/generator/odp_generator.c | 80
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
include/odp/api/packet_io.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
index e00d011..8169372 100644
--- a/include/odp/api/packet_io.h
+++
On Fri, Aug 14, 2015 at 02:03:03PM +0300, Maxim Uvarov wrote:
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/pktio/pktio.c | 114
++
1 file changed, 114 insertions(+)
diff --git a/test/validation/pktio/pktio.c
Hi Bala,
just several comments I forgot to mention.
On 19.08.15 08:45, Bala Manoharan wrote:
Ivan,
On 18 August 2015 at 22:39, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
post test review.
I've tested. It works for me. (except UDP/TCP src, as
On Wed, Aug 12, 2015 at 10:55:12AM +0200, Balakrishna.Garapati wrote:
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org
---
validate cpumask from parse_args and exit with a message
example/generator/odp_generator.c | 72
---
1 file
On Tue, Aug 18, 2015 at 05:39:59PM +0200, Krishna Garapati wrote:
Stuart, you have reviewed the old patch. please look at the PATCHv7
http://patches.opendataplane.org/patch/2723/;
Oops missed that, a couple of minor comments still apply so I'll reply to
that patch.
--
Stuart.
On Sat, Aug 08, 2015 at 01:28:09AM +0300, Ivan Khoronzhuk wrote:
The time API were changed from *_cycles* to *_tick*, so use
appropriate names.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
platform/linux-generic/arch/linux/odp_time.c | 2 +-
On Sat, Aug 08, 2015 at 01:28:08AM +0300, Ivan Khoronzhuk wrote:
The word cycle is left from old API time names. The cycle is
ambiguous word, especially when it can be used for other purposes.
So better to use tick word or just t symbol.
Signed-off-by: Ivan Khoronzhuk
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
test/validation/packet/packet.c | 40 ++--
1 file changed, 30 insertions(+), 10 deletions(-)
diff --git a/test/validation/packet/packet.c b/test/validation/packet/packet.c
index 99a6745..d6dd3eb
40 matches
Mail list logo
