Re: [lng-odp] [Patch] validation: scheduler: increase time check

The time waiting is of dubious value (and portability) in a system with dedicated worker threads. What else are they planning to do? Is that the best design for the application? There are valid common uses for ODP_SCHED_WAIT and ODP_SCHED_NO_WAIT. Everything else is questionable. Periodic process

Re: [lng-odp] [API-NEXT PATCH v4 09/10] linux-generic: cpumask: add API odp_cpumask_available()

Perhaps odp_cpumask_max() might be a little less of a mouthful? On Thu, Sep 3, 2015 at 9:02 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: ext hongbo.zh...@freescale.com > > [mailto:hongbo.zh...@freescale.com] > > Sent: T

Re: [lng-odp] [API-NEXT PATCHv2 0/4] classification API name change

I thought I had responded already. But just in case: Reviewed-by: Bill Fischofer On Thu, Sep 3, 2015 at 10:58 AM, Bala Manoharan wrote: > Ping. > > On 25 August 2015 at 19:45, Maxim Uvarov wrote: > > No more comments, reviews? > > > > Maxim. > > > > On 08/11/15 15:10, Balasubramanian Manohar

Re: [lng-odp] [PATCHv3] linux-generic: general: add odp_forward_typedefs to resolve clang issue

Merged, Maxim. On 09/03/15 21:59, Bill Fischofer wrote: With the addition of ordered queues, there is a circular typedef relationship between odp_queue_internal.h and odp_buffer_internal.h. The standard forward declaration technique that GCC accepts is strictly not acceptable to C99 and is flagg

[lng-odp] [NEXT PATCHv2] linux-generic: fix forward declarations for queue and buf

Fix: In file included from odp_classification.c:15: In file included from ./include/odp_packet_io_internal.h:23: In file included from ./include/odp_classification_datamodel.h:27: ./include/odp_queue_internal.h:92:3: error: redefinition of typedef 'queue_entry_t' is a C11 feature [-Werror,-Wtypede

[lng-odp] [PATCH] linux-generic: fix forward declarations for queue and buf

Fix: In file included from odp_classification.c:15: In file included from ./include/odp_packet_io_internal.h:23: In file included from ./include/odp_classification_datamodel.h:27: ./include/odp_queue_internal.h:92:3: error: redefinition of typedef 'queue_entry_t' is a C11 feature [-Werror,-Wtypede

Re: [lng-odp] [PATCHv3] linux-generic: general: add odp_forward_typedefs to resolve clang issue

The comments in the file say that. I'd assume each commit message as this file grows would describe the specific reason for its changes. On Thu, Sep 3, 2015 at 2:14 PM, Mike Holmes wrote: > > > On 3 September 2015 at 14:59, Bill Fischofer > wrote: > >> With the addition of ordered queues, ther

Re: [lng-odp] [PATCHv3] linux-generic: general: add odp_forward_typedefs to resolve clang issue

On 3 September 2015 at 14:59, Bill Fischofer wrote: > With the addition of ordered queues, there is a circular typedef > relationship between odp_queue_internal.h and odp_buffer_internal.h. > The standard forward declaration technique that GCC accepts is strictly > not acceptable to C99 and is fl

[lng-odp] [PATCHv3] linux-generic: general: add odp_forward_typedefs to resolve clang issue

With the addition of ordered queues, there is a circular typedef relationship between odp_queue_internal.h and odp_buffer_internal.h. The standard forward declaration technique that GCC accepts is strictly not acceptable to C99 and is flagged by clang. The solution is to create a common header file

Re: [lng-odp] [PATCH] linux-generic: general: add odp_forward_typedefs to resolve clang issues

On 3 September 2015 at 14:23, Bill Fischofer wrote: > With the addition of ordered queues, there is a circular typedef > relationship between odp_queue_internal.h and odp_buffer_internal.h. > The standard forward declaration technique that GCC accepts is strictly > not acceptable to C99 and is fl

[lng-odp] [PATCHv2] linux-generic: general: add odp_forward_typedefs to resolve clang issues

With the addition of ordered queues, there is a circular typedef relationship between odp_queue_internal.h and odp_buffer_internal.h. The standard forward declaration technique that GCC accepts is strictly not acceptable to C99 and is flagged by clang. The solution is to create a common header file

[lng-odp] [PATCH] linux-generic: general: add odp_forward_typedefs to resolve clang issues

With the addition of ordered queues, there is a circular typedef relationship between odp_queue_internal.h and odp_buffer_internal.h. The standard forward declaration technique that GCC accepts is strictly not acceptable to C99 and is flagged by clang. The solution is to create a common header file

[lng-odp] [Bug 1787] libcrypto.a: No such file or directory

https://bugs.linaro.org/show_bug.cgi?id=1787 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

Re: [lng-odp] [PATCHv2 6/8] linux-generic: queue: correct handling of reorder completion

The send of B2 will finish up by repeating the order resolution logic to see if further progress can be made. So it propagates down the list until we can't resolve any more. At that point its up to the next guy to take over when they start resolving their own order. On Thu, Sep 3, 2015 at 12:28

Re: [lng-odp] [PATCHv2 6/8] linux-generic: queue: correct handling of reorder completion

> From: "Bill Fischofer" > To: "Nicolas Morey-Chaisemartin" > Cc: "LNG ODP Mailman List" , "Maxim Uvarov" > > Sent: Thursday, 3 September, 2015 6:19:52 PM > Subject: Re: [lng-odp] [PATCHv2 6/8] linux-generic: queue: correct handling > of reorder completion > On Thu, Sep 3, 2015 at 11:05 AM, Nic

Re: [lng-odp] [API-NEXT PATCH v2 0/2] Recursive locks

Looks good, however tests/validation/syncrhonizers/synchronizers.c should also be updated to add validation tests for these new APIs. On Thu, Sep 3, 2015 at 7:01 AM, Petri Savolainen wrote: > > v2: > - changed spinlock and write lock recursion counters from int to > uint32_t type > > Petri

Re: [lng-odp] [PATCHv2 0/8] Critical Bug Fixes for ODP v1.3

Run tests now and that version looks good. Merged. Reviewed-and-Tested-by: Maxim Uvarov On 09/03/15 18:16, Bill Fischofer wrote: Changes in v2: - Add missing return to check in odp_queue_destroy() - Fix race condition involving ordered locks -- This patch addresses critical bugs blocking th

Re: [lng-odp] [PATCHv2 6/8] linux-generic: queue: correct handling of reorder completion

On Thu, Sep 3, 2015 at 11:05 AM, Nicolas Morey-Chaisemartin < nmo...@kalray.eu> wrote: > > > On 09/03/2015 05:16 PM, Bill Fischofer wrote: > > @@ -910,23 +897,28 @@ int release_order(queue_entry_t *origin_qe, > uint64_t order, > > order_release(origin_qe, 1); > > > > /*

Re: [lng-odp] [PATCH] validation: renaming module libs

On 09/03/2015 06:12 PM, Christophe Milard wrote: > Renaming module libs in /test/validation/. Module test libs are > renamed from lib.la to libodpmodule.la. > This is done to avoid libname clashes, such as libcrypto, which seems to > confuse libtool, and should therefore fix bug ID 1787. > > Sign

[lng-odp] [PATCH] validation: renaming module libs

Renaming module libs in /test/validation/. Module test libs are renamed from lib.la to libodpmodule.la. This is done to avoid libname clashes, such as libcrypto, which seems to confuse libtool, and should therefore fix bug ID 1787. Signed-off-by: Christophe Milard --- test/validation/buffer/Make

[lng-odp] [Bug 1365] Lock-up following sendmmsg failure

https://bugs.linaro.org/show_bug.cgi?id=1365 Mike Holmes changed: What|Removed |Added Assignee|maxim.uva...@linaro.org |stuart.has...@linaro.org -- You are receiving t

[lng-odp] [Bug 1449] odp_timer_test core dump

https://bugs.linaro.org/show_bug.cgi?id=1449 Mike Holmes changed: What|Removed |Added Assignee|ola.liljed...@linaro.org|ivan.khoronz...@linaro.org --- Comment #7 from M

Re: [lng-odp] [PATCHv2 6/8] linux-generic: queue: correct handling of reorder completion

On 09/03/2015 05:16 PM, Bill Fischofer wrote: > @@ -910,23 +897,28 @@ int release_order(queue_entry_t *origin_qe, uint64_t > order, > order_release(origin_qe, 1); > > /* Check if this release allows us to unblock waiters. > - * Note that we can only pro

[lng-odp] [Bug 1457] odp_timer: data race

https://bugs.linaro.org/show_bug.cgi?id=1457 Mike Holmes changed: What|Removed |Added Assignee|ola.liljed...@linaro.org|ivan.khoronz...@linaro.org --- Comment #3 from M

Re: [lng-odp] [API-NEXT PATCHv2 0/4] classification API name change

Ping. On 25 August 2015 at 19:45, Maxim Uvarov wrote: > No more comments, reviews? > > Maxim. > > On 08/11/15 15:10, Balasubramanian Manoharan wrote: >> >> Changes in v2: Adds bug link in the patch description >> >> 1. This patch series renames the classification APIs for ODP consistency >> odp_c

[lng-odp] [Bug 1711] Rename APIs for consistency with ODP naming standard

https://bugs.linaro.org/show_bug.cgi?id=1711 --- Comment #5 from Mike Holmes --- v2 http://patches.opendataplane.org/patch/2715/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp mailing list lng-odp@lists.linaro

[lng-odp] [Bug 1746] checkpatch.pl generates warning on ODP long function

https://bugs.linaro.org/show_bug.cgi?id=1746 Mike Holmes changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org|mike.hol...@linaro.org -- You are receiving thi

[lng-odp] [Bug 1752] timer test: Number of timeouts delivered/received too late: 0

https://bugs.linaro.org/show_bug.cgi?id=1752 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[lng-odp] [Bug 1752] timer test: Number of timeouts delivered/received too late: 0

https://bugs.linaro.org/show_bug.cgi?id=1752 --- Comment #1 from Mike Holmes --- 6 stale timeout(s) after odp_timer_free() Is this just a case that the system was busy and indeed timers were stale and the test should not call it a failure. -- You are receiving this mail because: You are the as

[lng-odp] [Bug 1787] libcrypto.a: No such file or directory

https://bugs.linaro.org/show_bug.cgi?id=1787 Mike Holmes changed: What|Removed |Added Assignee|anders.rox...@linaro.org|christophe.mil...@linaro.or |

Re: [lng-odp] [odp-lng] [Patch v3 1/3] api: time: unbind CPU cycles from time API

Petri, On 03.09.15 16:13, Ivan Khoronzhuk wrote: On 03.09.15 15:29, Savolainen, Petri (Nokia - FI/Espoo) wrote: There are many example apps that actually want to measure execution time in CPU cycles, not in nsec. Time API and CPU (cycle) API updates are linked together. Real CPU cycle cases

Re: [lng-odp] [API-NEXT PATCH v4 08/10] linux-generic: sysinfo: add API to get current CPU frequency

On 11.08.15 10:33, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang Previous CPU frequency API is adapted to return max frequency, now new APIs are added for getting the current CPU frequency. odp_cpu_id_hz(int id) returns frequency of the CPU specified by parameter id, while odp_cpu_hz()

[lng-odp] [PATCHv2 0/8] Critical Bug Fixes for ODP v1.3

Changes in v2: - Add missing return to check in odp_queue_destroy() - Fix race condition involving ordered locks -- This patch addresses critical bugs blocking the release of ODP v1.3 and resolves Bug https://bugs.linaro.org/show_bug.cgi?id=1790 With this patch applied, all scheduler tests now pa

[lng-odp] [PATCHv2 8/8] validation: schedule: add coverage for new scheduler APIs

Add validation test coverage for the following APIs: odp_schedule_prefetch() odp_schedule_group_destroy() odp_schedule_order_lock_init() odp_schedule_order_lock() odp_schedule_order_unlock() Signed-off-by: Bill Fischofer --- test/validation/scheduler/scheduler.c | 138 +++

[lng-odp] [Bug 1790] Critical scheduling issues blocking release of ODP v1.3

https://bugs.linaro.org/show_bug.cgi?id=1790 --- Comment #3 from Bill Fischofer --- v2 posted at patch series starting http://patches.opendataplane.org/patch/2945/ to fix omission noted by Maxim and race condition reported by Nicolas. -- You are receiving this mail because: You are on the CC li

[lng-odp] [PATCHv2 5/8] linux-generic: queue: prevent lookup of destroyed queues

odp_queue_lookup() should not be able to find queues in the transient state QUEUE_STATUS_DESTOYED Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_queue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-generi

[lng-odp] [PATCHv2 6/8] linux-generic: queue: correct handling of reorder completion

Fix a race condition that could cause events to be stuck in an ordered queue's reorder queue. Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_queue_internal.h | 36 platform/linux-generic/odp_queue.c | 48 +- 2 files change

[lng-odp] [PATCHv2 7/8] linux-generic: schedule: fix race condition in ordered locks

Correct race condition that arises due to attempt to permit ordered locks to be reusable. For now, ordered locks can only be used once per scheduled event. Signed-off-by: Bill Fischofer --- platform/linux-generic/include/odp_queue_internal.h | 6 +- platform/linux-generic/odp_queue.c

[lng-odp] [PATCHv2 4/8] linux-generic: queue: add destroy check for ordered queues

Ensure that the reorder queue associated with ordered queues is empty as part of odp_queue_destroy() processing Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_queue.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-gene

[lng-odp] [PATCHv2 3/8] linux-generic: schedule: streamline handling of event deq processing

Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_schedule.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/odp_schedule.c b/platform/linux-generic/odp_schedule.c index a88ba4d..c6619e5 100644 --- a/platform/linux-generic/odp_schedule.c

[lng-odp] [PATCHv2 1/8] linux-generic: schedule: correct schedule group handling

Correct the range check on odp_schedule_group_destroy() and the associated handling of scheduler group names. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_schedule.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_schedule.c b

[lng-odp] [PATCHv2 2/8] linux-generic: schedule: correct scheduling for ordered queues

Ordered queues must be rescheduled before caching context locally to avoid contaminating the scheduler poll queues with false ordering info. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_schedule.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/platform/

Re: [lng-odp] [PATCH] validation: remove MAX_WORKERS

On Thu, Sep 03, 2015 at 05:26:58PM +0300, Maxim Uvarov wrote: > ODP has api to request available number of workers. Now > no need limit that inside application. > > Signed-off-by: Maxim Uvarov > --- > if that is good then we can do the same thing for examples. > > Best regards, > Maxim. > >

Re: [lng-odp] [API-NEXT PATCH v4 10/10] validation: add test for new per_CPU system APIs

On 11.08.15 10:54, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang This patch adds test for the newly introduced per-CPU system APIs: new per-CPU APIs: odp_cpu_id_hz_max(), odp_cpu_id_model_str() abd new crurrent frequency APIs: odp_cpu_hz(), odp_cpu_id_hz() abd -> and. Signed-off-b

Re: [lng-odp] [API-NEXT PATCH v4 10/10] validation: add test for new per_CPU system APIs

On 11.08.15 10:54, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang This patch adds test for the newly introduced per-CPU system APIs: new per-CPU APIs: odp_cpu_id_hz_max(), odp_cpu_id_model_str() abd new crurrent frequency APIs: odp_cpu_hz(), odp_cpu_id_hz() abd? Signed-off-by: Hong

Re: [lng-odp] [API-NEXT PATCH v4 05/10] linux-generic: sysinfo: clarify the API for max CPU frequency

Hi, Hongbo On 11.08.15 10:33, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang Currently the API to get CPU frequency is vague, it needs to be clarified whether max or current frequency is returned, and now most use cases want to get max capacity of CPU in fact, so this patch makes it clea

[lng-odp] [PATCH] validation: remove MAX_WORKERS

ODP has api to request available number of workers. Now no need limit that inside application. Signed-off-by: Maxim Uvarov --- if that is good then we can do the same thing for examples. Best regards, Maxim. test/validation/common/odp_cunit_common.c | 7 ++-- test/validation/common/od

Re: [lng-odp] [API-NEXT PATCH v4 09/10] linux-generic: cpumask: add API odp_cpumask_available()

> -Original Message- > From: ext hongbo.zh...@freescale.com > [mailto:hongbo.zh...@freescale.com] > Sent: Tuesday, August 11, 2015 10:34 AM > To: lng-odp@lists.linaro.org > Cc: mike.hol...@linaro.org; stuart.has...@arm.com; Savolainen, Petri > (Nokia - FI/Espoo); petri.savolai...@linaro.o

Re: [lng-odp] [API-NEXT PATCH v4 05/10] linux-generic: sysinfo: clarify the API for max CPU frequency

> -Original Message- > From: ext hongbo.zh...@freescale.com > [mailto:hongbo.zh...@freescale.com] > Sent: Tuesday, August 11, 2015 10:34 AM > To: lng-odp@lists.linaro.org > Cc: mike.hol...@linaro.org; stuart.has...@arm.com; Savolainen, Petri > (Nokia - FI/Espoo); petri.savolai...@linaro.o

Re: [lng-odp] [API-NEXT PATCH v8 0/3] Hash flow series

Merged to api-next. Maxim. On 08/29/15 04:42, Bill Fischofer wrote: For this series: Reviewed-and-tested-by: Bill Fischofer > On Fri, Aug 28, 2015 at 6:05 AM, Zoltan Kiss > wrote: API definition, linux-generic implementat

Re: [lng-odp] [API-NEXT PATCH v4 04/10] linux-generic: sysinfo: move CPU model API to cpu.h

> --- a/include/odp/api/cpu.h > +++ b/include/odp/api/cpu.h > @@ -51,6 +51,13 @@ int odp_cpu_count(void); > uint64_t odp_cpu_hz(void); > > /** > + * CPU model name > + * > + * @return Pointer to CPU model name string > + */ > +const char *odp_cpu_model_str(void); > + > +/** > * @} > */ >

Re: [lng-odp] [API-NEXT PATCH v4 03/10] linux-generic: sysinfo: move CPU HZ API to cpu.h

> -Original Message- > From: ext hongbo.zh...@freescale.com > [mailto:hongbo.zh...@freescale.com] > Sent: Tuesday, August 11, 2015 10:34 AM > To: lng-odp@lists.linaro.org > Cc: mike.hol...@linaro.org; stuart.has...@arm.com; Savolainen, Petri > (Nokia - FI/Espoo); petri.savolai...@linaro.o

Re: [lng-odp] [API-NEXT PATCH v4 00/10] linux-generic: sysinfo: CPU frequency API clean up

Is this the latest version of the patch set ? Generic comments: 1) All patches which touch api files (03/10 and others) should be labeled with "api:", instead of "linux-generic" 2) I think the naming convention would be cleaner for "per cpu" functions, if "_id" is at the end of each function na

Re: [lng-odp] [odp-lng] [Patch v3 1/3] api: time: unbind CPU cycles from time API

On 03.09.15 15:29, Savolainen, Petri (Nokia - FI/Espoo) wrote: There are many example apps that actually want to measure execution time in CPU cycles, not in nsec. Time API and CPU (cycle) API updates are linked together. Real CPU cycle cases must not converted to use time API, but to use a

Re: [lng-odp] RFC: New time API

On 03.09.15 14:32, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: ext Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Thursday, September 03, 2015 1:29 AM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] RFC: Ne

Re: [lng-odp] [API-NEXT PATCHv2] api: pktio description of doxygen group

Merged, Maxim. On 09/03/15 15:48, Nicolas Morey-Chaisemartin wrote: On 09/03/2015 02:47 PM, Maxim Uvarov wrote: On 09/01/15 17:14, Nicolas Morey-Chaisemartin wrote: Otherwise looks good. will fix on apply. Can I set you review-by then? Maxim. Yes. Nicolas ___

Re: [lng-odp] [API-NEXT PATCHv2] api: pktio description of doxygen group

On 09/03/2015 02:47 PM, Maxim Uvarov wrote: > On 09/01/15 17:14, Nicolas Morey-Chaisemartin wrote: >> Otherwise looks good. > will fix on apply. Can I set you review-by then? > > Maxim. Yes. Nicolas ___ lng-odp mailing list lng-odp@lists.linaro.org htt

Re: [lng-odp] [API-NEXT PATCHv2] api: pktio description of doxygen group

On 09/01/15 17:14, Nicolas Morey-Chaisemartin wrote: Otherwise looks good. will fix on apply. Can I set you review-by then? Maxim. ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH] validation: pktio: don't mix scheduler wait time and ns in start_stop test

Merged, Maxim. On 09/03/15 01:41, Ivan Khoronzhuk wrote: On 02.09.15 12:35, Nicolas Morey-Chaisemartin wrote: The odp_scheduler() requires time value in its own ticks, so pass scheduler wait time instead of ns. Signed-off-by: Nicolas Morey-Chaisemartin --- Reviewed-by: Ivan Khoronzhuk

Re: [lng-odp] [PATCH] validation: pktio: revert wait time to msec

Merged, Maxim. On 09/03/15 01:45, Ivan Khoronzhuk wrote: On 02.09.15 12:12, Nicolas Morey-Chaisemartin wrote: When fixing the wait time passed to schedule by using odp_schedule_wait_time in patch: commit 0bd245638dd0 ("validation: pktio: don't mix scheduler wait time and ns") wait time wa

Re: [lng-odp] Issue with libtool

Can we migrate this thread to https://bugs.linaro.org/show_bug.cgi?id=1787, I think Christoph is looking. On 3 September 2015 at 08:23, Stuart Haslam wrote: > On Wed, Sep 02, 2015 at 09:57:34AM +0200, Nicolas Morey-Chaisemartin wrote: > > Hi, > > > > Since all tests were moved to Library I have

Re: [lng-odp] [odp-lng] [Patch v3 1/3] api: time: unbind CPU cycles from time API

There are many example apps that actually want to measure execution time in CPU cycles, not in nsec. Time API and CPU (cycle) API updates are linked together. Real CPU cycle cases must not converted to use time API, but to use a new odp_cpu_cycle() count API first. Then what is left should be a

Re: [lng-odp] Issue with libtool

On Wed, Sep 02, 2015 at 09:57:34AM +0200, Nicolas Morey-Chaisemartin wrote: > Hi, > > Since all tests were moved to Library I have been hitting the same bug over > and over in the build system. > Often when I pull master and try to rebuild from a pre existing build, I have > this error: > libtoo

Re: [lng-odp] [PATCH 7/7] validation: schedule: add coverage for new scheduler APIs

I increased my core count from 2 to 4 and I can see it too. Investigating. I suspect it's a bug in the test. On Thu, Sep 3, 2015 at 7:09 AM, Mike Holmes wrote: > Confirmed, I see that too > > On 3 September 2015 at 07:57, Nicolas Morey-Chaisemartin > wrote: > >> Sure. >> I have a basic Fedora

Re: [lng-odp] [PATCH 4/7] linux-generic: queue: add destroy check for ordered queues

please also pull changes for master. I see rejects on applying that patches. Maxim. On 09/03/15 14:57, Bill Fischofer wrote: Yes, good catch. I'll post a v2 to address that. On Thu, Sep 3, 2015 at 12:23 AM, Maxim Uvarov > wrote: On 09/03/15 03:07, Bill Fi

Re: [lng-odp] [PATCH 7/7] validation: schedule: add coverage for new scheduler APIs

Confirmed, I see that too On 3 September 2015 at 07:57, Nicolas Morey-Chaisemartin wrote: > Sure. > I have a basic Fedora 22 (no special kernel setup as NO_HZ or such) > Dual Socket x Quad core > > I checked out the repo master commit and applied your 7 patches. > > Built using this command: > .

[lng-odp] [API-NEXT PATCH v2 1/2] api: spinlock_recursive: added recursive spinlock

Applications can use recursive spinlocks to avoid deadlock from single thread acquiring the same lock multiple times. Recursive locks are used in legacy applications. ODP version of recursive spinlock enable porting of those applications. Signed-off-by: Petri Savolainen --- include/odp.h

[lng-odp] [API-NEXT PATCH v2 2/2] api: rwlock_recursive: added recursive rwlock

Added recursive read-write lock. It allows threads to read lock or write lock the rwlock multiple times without deadlocking. Mixing read and write lock operations is not supported. ODP version of recursive rwlock enables porting legacy applications, which use these kind of locks. Signed-off-by: P

[lng-odp] [API-NEXT PATCH v2 0/2] Recursive locks

v2: - changed spinlock and write lock recursion counters from int to uint32_t type Petri Savolainen (2): api: spinlock_recursive: added recursive spinlock api: rwlock_recursive: added recursive rwlock include/odp.h | 2 + include/odp/api/rwlock_re

Re: [lng-odp] [PATCH 4/7] linux-generic: queue: add destroy check for ordered queues

Yes, good catch. I'll post a v2 to address that. On Thu, Sep 3, 2015 at 12:23 AM, Maxim Uvarov wrote: > On 09/03/15 03:07, Bill Fischofer wrote: > >> Ensure that the reorder queue associated with ordered queues is empty >> as part of odp_queue_destroy() processing >> >> Signed-off-by: Bill Fisc

Re: [lng-odp] [PATCH 7/7] validation: schedule: add coverage for new scheduler APIs

Sure. I have a basic Fedora 22 (no special kernel setup as NO_HZ or such) Dual Socket x Quad core I checked out the repo master commit and applied your 7 patches. Built using this command: ./bootstrap && ./configure --enable-cunit-support --enable-test-vald --enable-test-cpp --enable-test-help

Re: [lng-odp] [PATCH 7/7] validation: schedule: add coverage for new scheduler APIs

Can you share more details about your setup? Number of threads, etc.? Thanks. On Thu, Sep 3, 2015 at 4:28 AM, Nicolas Morey-Chaisemartin wrote: > I still have errors once in a while after applying this series > Test: scheduler_test_multi_mq_mt_prio_o ...FAILED > 1. scheduler.c:427 - bctx

Re: [lng-odp] RFC: New time API

> -Original Message- > From: ext Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] > Sent: Thursday, September 03, 2015 1:29 AM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] RFC: New time API > > Hi, Petri > > We have to look at it proce

Re: [lng-odp] [PATCH 0/7] Critical Bug Fixes for ODP v1.3

On 09/03/15 13:47, Nicolas Morey-Chaisemartin wrote: On 09/03/2015 08:37 AM, Maxim Uvarov wrote: On 09/03/15 09:29, Nicolas Morey-Chaisemartin wrote: Just a question a bit beside the point: What is the policy about API-NEXT? I was very surprised to see that the api-next branch was merged to m

Re: [lng-odp] [PATCH 0/7] Critical Bug Fixes for ODP v1.3

On 09/03/2015 08:37 AM, Maxim Uvarov wrote: > On 09/03/15 09:29, Nicolas Morey-Chaisemartin wrote: >> Just a question a bit beside the point: >> What is the policy about API-NEXT? >> >> I was very surprised to see that the api-next branch was merged to master >> just a few commits before the rel

Re: [lng-odp] RFC: New time API

One correction, that also makes me worry a little. On 03.09.15 01:29, Ivan Khoronzhuk wrote: Hi, Petri We have to look at it proceeding from performance, platform portability and simplicity If you want to split on hi-res time and low-res they must have separate functions and be not under one

Re: [lng-odp] [PATCH 7/7] validation: schedule: add coverage for new scheduler APIs

I still have errors once in a while after applying this series Test: scheduler_test_multi_mq_mt_prio_o ...FAILED 1. scheduler.c:427 - bctx->sequence == qctx->lock_sequence 2. scheduler.c:427 - bctx->sequence == qctx->lock_sequence 3. scheduler.c:427 - bctx->sequence == qctx->lock_s

[lng-odp] [RFC Patch] example: timer: move cycles/ns table to validation tests

The linux-generic implements timers supposing that timers are based on CPU cycle counter. It's not always true and timer API can have nothing common with CPU cycles. Thus timer test shouldn't print here conversion cycles/ns table for time API. Signed-off-by: Ivan Khoronzhuk --- I'm not sure abou