[lng-odp] [API-NEXT PATCHv3 0/4] api: packet reference count support

v3: In linux-generic implementation: - ref counters bit uses to create reference packet handle; - atomic ref counter used to keep owner of packet segments; Maxim Uvarov (4): api: packet reference count support linux-generic: packet reference count support linix-generic:

[lng-odp] [API-NEXT PATCHv3 3/4] linix-generic: _odp_pri account 64 bits

_odp_pri returns uint64_t value but actually accounts only 32 bit. In my case that lead to return the same value for printed packets with additional handle bits. Signed-off-by: Maxim Uvarov --- platform/linux-generic/include/odp/plat/strong_types.h | 2 +- 1 file

Re: [lng-odp] [PATCH v2 0/2] Fix ODP_SCHED_NO_WAIT case for odp_schedule_wait_time

Maxim, On 16.09.15 11:05, Maxim Uvarov wrote: On 09/15/15 18:03, Ivan Khoronzhuk wrote: ping are you planning v3 with removed CU_ASSERT(wait_time > 0) ? Maxim. Not here. It will be removed along with ODP-190 implementation. On 10.09.15 19:18, Ivan Khoronzhuk wrote: These patches

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

Petri, On 16.09.15 10:02, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 5:07 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp]

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

> -Original Message- > From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] > Sent: Wednesday, September 16, 2015 11:19 AM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix > potential

[lng-odp] [PATCH 0/4] add ability to mark tests as inactive

This series adds the ability to skip individual test cases either at compile time or conditionally at run time. There's no functional change since none of the existing tests use this facility. There are a few checkpatch warnings about camel case due to the names of CUnit structure elements, but

[lng-odp] [PATCH 3/4] doc: implementers-guide: update names of test module libraries

The name of the libraries generated by the test modules were recently changed from lib.la to libtest.la Signed-off-by: Stuart Haslam --- doc/implementers-guide/implementers-guide.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

On 16.09.15 10:02, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 5:07 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH

[lng-odp] [API-NEXT PATCHv3 1/4] api: packet reference count support

Add api for packet reference count support. Which is useful in case: - multicast support - TCP retransmission - traffic generator Introduced new call: newpkt = odp_packet_create_ref(pkt) which creates reference to original packet, but handles for reference packet and original are different.

Re: [lng-odp] [PATCH] validation: synchronizers: support a single worker

Merged, Maxim. On 09/12/15 03:18, Bill Fischofer wrote: On Thu, Sep 10, 2015 at 3:33 AM, Nicolas Morey-Chaisemartin > wrote: Ping? On 08/26/2015 04:06 PM, Nicolas Morey-Chaisemartin wrote: > no_barrier and no_lock tests are expected

Re: [lng-odp] [API NEXT PATCH v5 08/17] api: sysinfo: revise odp_cpu_hz() to return current frequency

This patch does not change the API. It changes implementation and should be named linux-generic: sysinfo: revise odp_cpu_hz() to return current frequency -Petri > -Original Message- > From: EXT hongbo.zh...@freescale.com > [mailto:hongbo.zh...@freescale.com] > Sent: Tuesday,

Re: [lng-odp] [API NEXT PATCH v5 03/17] api: sysinfo: move CPU model API to cpu.h

Ivan, or did you mean another thing that, I changed api name in this patch, but update all the calling functions in later separate patches, so after applying this patch while the following patches are not applied, there must be build error at this stage, but this has to happen for convenience of

[lng-odp] [API-NEXT PATCHv3 2/4] linux-generic: packet reference count support

Signed-off-by: Maxim Uvarov --- .../linux-generic/include/odp_buffer_internal.h| 8 ++- .../linux-generic/include/odp_packet_internal.h| 18 ++ platform/linux-generic/odp_packet.c| 65 -- 3 files changed, 85 insertions(+),

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

On 16.09.15 10:52, Ivan Khoronzhuk wrote: On 16.09.15 10:02, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Tuesday, September 15, 2015 5:07 PM To: Savolainen, Petri (Nokia - FI/Espoo);

[lng-odp] [API-NEXT PATCHv3 4/4] validation: packet: test packet reference count

Signed-off-by: Maxim Uvarov --- test/validation/packet/packet.c | 36 test/validation/packet/packet.h | 1 + 2 files changed, 37 insertions(+) diff --git a/test/validation/packet/packet.c b/test/validation/packet/packet.c index

Re: [lng-odp] [PATCH] checkpatch: allow comparison to NULL

Merged, Maxim. On 09/16/15 05:34, Bill Fischofer wrote: On Tue, Sep 15, 2015 at 7:01 AM, Petri Savolainen > wrote: Allow comparison to NULL since ODP API calls may return NULL and test applications should be able to

Re: [lng-odp] [PATCH v2 0/2] Fix ODP_SCHED_NO_WAIT case for odp_schedule_wait_time

On 09/16/15 11:07, Ivan Khoronzhuk wrote: Maxim, On 16.09.15 11:05, Maxim Uvarov wrote: On 09/15/15 18:03, Ivan Khoronzhuk wrote: ping are you planning v3 with removed CU_ASSERT(wait_time > 0) ? Maxim. Not here. It will be removed along with ODP-190 implementation. ok, will merge

Re: [lng-odp] [API NEXT PATCH v5 00/17] api: sysinfo: CPU frequency API clean up

Hi, As Ivan pointed out, build must not be broken on any patch. It's good practice to do one API change per patch, but when renaming an API function also the code using that function must be updated in the same patch. So, patches 3 and 14, ... should be combined, as well as 4 and 15,

Re: [lng-odp] [API NEXT PATCH v5 03/17] api: sysinfo: move CPU model API to cpu.h

Ivan, Which kind of built error? In fact, when validation codes are enabled, there was already an build error exist in the test/validation/crypto code, this error isn't introduced by my patches, if you compile validation without my patches, you'll see this error again. I didn't spend time to

Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix potential overflow for burst_gap

> -Original Message- > From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] > Sent: Tuesday, September 15, 2015 5:07 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH v2 5/5] performance: odp_pktio_perf: fix > potential

[lng-odp] [PATCH 1/4] validation: add ability to mark tests inactive

Add the ability for individual test cases to be marked as inactive, either unconditionally or based on the result of a check function which is called at test init time. Inactive tests are registered with CUnit and are reported as inactive in test reports without being executed. All uses of

Re: [lng-odp] [PATCH v2 0/2] Fix ODP_SCHED_NO_WAIT case for odp_schedule_wait_time

On 09/15/15 18:03, Ivan Khoronzhuk wrote: ping are you planning v3 with removed CU_ASSERT(wait_time > 0) ? Maxim. On 10.09.15 19:18, Ivan Khoronzhuk wrote: These patches corrects ODP_SCHED_NO_WAIT corner case when scheduler time has resolution more then 1ns. Since v2: - linux-generic:

Re: [lng-odp] [PATCH] api: split documentation from definitions

I'd do this in api-next branch to avoid conflicts between api-next and master. Api-next is currently modifying config.h. See another comment under, otherwise OK. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > EXT Mike Holmes > Sent:

Re: [lng-odp] [PATCH v2 0/2] Fix ODP_SCHED_NO_WAIT case for odp_schedule_wait_time

Merged, Thanks, Maxim. On 09/10/15 19:18, Ivan Khoronzhuk wrote: These patches corrects ODP_SCHED_NO_WAIT corner case when scheduler time has resolution more then 1ns. Since v2: - linux-generic: odp_schedule: fix odp_schdule_wait_time Correct commit message - validation: schedule: don't

[lng-odp] [PATCH 2/4] validation: add odp_cunit_update() to modify registered tests

Add an odp_cunit_update() function to allow some attributes of previously registered tests to be modified, such as whether it's active or not. Previously, registering and running tests was done in a single step; odp_cunit_run(testsuites); But this is now split; odp_cunit_register(testsuites);

[lng-odp] [PATCH 4/4] doc: implementers-guide: update section on skipping tests

Update sections describing how a specific platform may skip tests by marking them as inactive. Signed-off-by: Stuart Haslam --- doc/implementers-guide/implementers-guide.adoc | 58 +- 1 file changed, 48 insertions(+), 10 deletions(-) diff --git

[lng-odp] [PATCH] validation: pktio: don't call CU_FAIL() from init

The CU_* macros can't be used from initialisation functions. Signed-off-by: Stuart Haslam --- test/validation/pktio/pktio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index

[lng-odp] [API-NEXT PATCHv3 5/5] api: schedule: revise definition of ordered locks

Revise the definition of odp_schedule_order_lock() and odp_schedule_order_unlock(). These APIs now take as an argument the index value of the ordered lock within the current context to be locked or unlocked. Because the API is changed, this patch also updates the linux-generic implementation of

Re: [lng-odp] [PATCH v2 3/5] linux-generic: odp_time: reutrn 0 if t2 = t1 instead of MAX for diff

Petri, What about this fix? It's similar to to CPU API. On 11.09.15 13:04, Ivan Khoronzhuk wrote: It's better to describe by example: cur = 15; start = 15; diff = 2; while (odp_time_cycles_diff(start, cur) < diff) { cur = odp_time_cycles(); } This example has to work. It's possible

[lng-odp] [API-NEXT PATCHv3 3/5] api: schedule: add lock_count to odp_schedule_param_t

The lock_count is used to specify the number of ordered locks to be available for an ordered queue at odp_queue_create() time. Signed-off-by: Bill Fischofer --- include/odp/api/schedule_types.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [lng-odp] [API NEXT PATCH v5 00/17] api: sysinfo: CPU frequency API clean up

On 16 September 2015 at 17:42, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Hi, > > > As Ivan pointed out, build must not be broken on any patch. It's good > practice to do one API change per patch, but when renaming an API function > also the code using that

[lng-odp] [API-NEXT PATCHv3 0/5] Revised Ordered Lock APIs

Changes in v3: - Change types of lock_count and lock indices from uint32_t to unsigned --- Changes in v2: - Incorporate Petri review comments --- Revise the ordered lock APIs per recent ARCH discussions. Ordered locks are now specified via the new lock_count parameter within the

[lng-odp] [API-NEXT PATCHv3 1/5] api: config: add config option for max ordered locks per queue

Specify implementation-defined maximum number of ordered locks that are available per ordered queue. Signed-off-by: Bill Fischofer --- include/odp/api/config.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/odp/api/config.h b/include/odp/api/config.h

Re: [lng-odp] [PATCH v2 3/5] linux-generic: odp_time: reutrn 0 if t2 = t1 instead of MAX for diff

On 16.09.15 14:39, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Wednesday, September 16, 2015 1:47 PM To: lng-odp@lists.linaro.org; Savolainen, Petri (Nokia - FI/Espoo) Subject: Re: [lng-odp]

Re: [lng-odp] [API NEXT PATCH v5 08/17] api: sysinfo: revise odp_cpu_hz() to return current frequency

On 16 September 2015 at 17:21, Savolainen, Petri (Nokia - FI/Espoo) wrote: > This patch does not change the API. It changes implementation and should be > named > > > linux-generic: sysinfo: revise odp_cpu_hz() to return current frequency > OK > > -Petri > > >>

Re: [lng-odp] [PATCH v2 3/5] linux-generic: odp_time: reutrn 0 if t2 = t1 instead of MAX for diff

On 16.09.15 13:23, Ivan Khoronzhuk wrote: Petri, What about this fix? It's similar to to CPU API. On 11.09.15 13:04, Ivan Khoronzhuk wrote: It's better to describe by example: cur = 15; start = 15; diff = 2; while (odp_time_cycles_diff(start, cur) < diff) { cur = odp_time_cycles(); }

[lng-odp] [API-NEXT PATCHv3 4/5] api: schedule: remove odp_schedule_order_lock_init() API

Remove deprecated API. This has been superseded by the lock_count parameter passed to odp_queue_create(). Signed-off-by: Bill Fischofer --- include/odp/api/schedule.h| 18 -- test/validation/scheduler/scheduler.c | 6 -- 2 files

Re: [lng-odp] [API-NEXT PATCH 5/5] api: schedule: revise definition of ordered locks

OK. I've posted v3 with these changes. On Wed, Sep 16, 2015 at 6:11 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Hi, > > > > I think still that since we need to prepare only for few locks per queue > (32k should be more than enough) and types should reflect

Re: [lng-odp] [PATCH] api: tm: add api definitions for egress traffic manager

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > ext Mike Holmes > Sent: Monday, August 24, 2015 11:12 PM > To: bala.manoha...@linaro.org; lng-odp@lists.linaro.org > Cc: Barry Spinney > Subject: [lng-odp] [PATCH] api: tm: add api definitions

Re: [lng-odp] [API-NEXT PATCHv3 0/5] Revised Ordered Lock APIs

Reviewed-by: Petri Savolainen Just clean the documentation in patch 3 during merge. + /** Lock group */ + unsigned lock_count; /**< Ordered lock count for this queue */ Should be like this: + /** Ordered lock count for this queue */ + unsigned

Re: [lng-odp] [API-NEXT PATCHv3 3/5] api: schedule: add lock_count to odp_schedule_param_t

> + /** Lock group */ > + unsigned lock_count; /**< Ordered lock count for this queue */ From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Wednesday, September 16, 2015 4:40 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp]

Re: [lng-odp] [API-NEXT PATCHv3 3/5] api: schedule: add lock_count to odp_schedule_param_t

I don't see where the double documentation is that you refer to. On Wed, Sep 16, 2015 at 8:35 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > > EXT Bill

Re: [lng-odp] [PATCH] test: l2fwd: fill correct source ethernet address

On Tue, Sep 15, 2015 at 10:09:12AM +0300, Matias Elo wrote: > When running l2fwd in a VM using SR-IOV the host may drop > packets if the source MAC address is not the same as that > of the VF NIC. Modify test application so that the source > MAC address is always filled correctly. > Patch looks

Re: [lng-odp] [PATCH 3/4] doc: implementers-guide: update names of test module libraries

On 2015-09-16 10:42, Stuart Haslam wrote: > The name of the libraries generated by the test modules were recently > changed from lib.la to libtest.la > > Signed-off-by: Stuart Haslam Reviewed-by: Christophe Milard > --- >

Re: [lng-odp] [PATCH 1/4] validation: add ability to mark tests inactive

On 2015-09-16 10:42, Stuart Haslam wrote: > Add the ability for individual test cases to be marked as inactive, > either unconditionally or based on the result of a check function which > is called at test init time. Inactive tests are registered with CUnit > and are reported as inactive in test

Re: [lng-odp] [PATCH 2/4] validation: add odp_cunit_update() to modify registered tests

On 2015-09-16 10:42, Stuart Haslam wrote: > Add an odp_cunit_update() function to allow some attributes of previously > registered tests to be modified, such as whether it's active or not. > > Previously, registering and running tests was done in a single step; > > odp_cunit_run(testsuites); >

Re: [lng-odp] [PATCH 4/4] doc: implementers-guide: update section on skipping tests

On 2015-09-16 10:42, Stuart Haslam wrote: > Update sections describing how a specific platform may skip tests by > marking them as inactive. > > Signed-off-by: Stuart Haslam > --- > doc/implementers-guide/implementers-guide.adoc | 58 > +- > 1

Re: [lng-odp] [PATCH 0/4] add ability to mark tests as inactive

On 2015-09-16 10:41, Stuart Haslam wrote: > This series adds the ability to skip individual test cases either at > compile time or conditionally at run time. There's no functional change > since none of the existing tests use this facility. > > There are a few checkpatch warnings about camel case

Re: [lng-odp] [PATCH 2/4] validation: add odp_cunit_update() to modify registered tests

On 16 September 2015 at 18:07, Stuart Haslam wrote: > On Wed, Sep 16, 2015 at 05:03:38PM +0200, Christophe Milard wrote: > > On 2015-09-16 10:42, Stuart Haslam wrote: > > > Add an odp_cunit_update() function to allow some attributes of > previously > > > registered

Re: [lng-odp] [PATCH 2/4] validation: add odp_cunit_update() to modify registered tests

On Wed, Sep 16, 2015 at 05:03:38PM +0200, Christophe Milard wrote: > On 2015-09-16 10:42, Stuart Haslam wrote: > > Add an odp_cunit_update() function to allow some attributes of previously > > registered tests to be modified, such as whether it's active or not. > > > > Previously, registering and

[lng-odp] [API-NEXT PATCH v2] api: split documentation from definitions

Defines in config.h should be defined by the platform appropriately and then possibly be exposed by APIs. Start the clean up process by moving the API Doxygen documentation away from the per platform definition. Signed-off-by: Mike Holmes --- include/odp/api/config.h

[lng-odp] [API-NEXT] linux-generic: makefile: fix distcheck failure

Fixes https://bugs.linaro.org/show_bug.cgi?id=1813 make distcheck results in ../../../platform/linux-generic/include/odp_buffer_internal.h:33:33: fatal error: odp_config_internal.h: No such file or director Signed-off-by: Mike Holmes ---

[lng-odp] [PATCH] linux-generic: makefile: fix distcheck failure

Fixes https://bugs.linaro.org/show_bug.cgi?id=1813 make distcheck results in ../../../platform/linux-generic/include/odp_buffer_internal.h:33:33: fatal error: odp_config_internal.h: No such file or director Signed-off-by: Mike Holmes ---

[lng-odp] [Bug 1813] API-NEXT make distcheck fails

https://bugs.linaro.org/show_bug.cgi?id=1813 --- Comment #1 from Mike Holmes --- Patch sent http://patches.opendataplane.org/patch/3101/ -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp

[lng-odp] [Bug 1813] New: API-NEXT make distcheck fails

https://bugs.linaro.org/show_bug.cgi?id=1813 Bug ID: 1813 Summary: API-NEXT make distcheck fails Product: OpenDataPlane - linux- generic reference Version: 1.3 Hardware: Other OS: Linux Status: UNCONFIRMED

Re: [lng-odp] [API-NEXT] linux-generic: makefile: fix distcheck failure

On Wed, Sep 16, 2015 at 2:48 PM, Mike Holmes wrote: > Fixes https://bugs.linaro.org/show_bug.cgi?id=1813 > > make distcheck results in > ../../../platform/linux-generic/include/odp_buffer_internal.h:33:33: > fatal error: odp_config_internal.h: No such file or director > >

[lng-odp] [Bug 1813] API-NEXT make distcheck fails

https://bugs.linaro.org/show_bug.cgi?id=1813 Mike Holmes changed: What|Removed |Added Assignee|anders.rox...@linaro.org|mike.hol...@linaro.org

Re: [lng-odp] [PATCH 4/4] doc: implementers-guide: update section on skipping tests

On Wed, Sep 16, 2015 at 05:19:28PM +0200, Christophe Milard wrote: > On 2015-09-16 10:42, Stuart Haslam wrote: > > Update sections describing how a specific platform may skip tests by > > marking them as inactive. > > > > Signed-off-by: Stuart Haslam > > --- > >