From: Grigore Ion
odph_ipv4_csum_update should be used to update the checksum inside a pkt,
as it is used in all the other examples and tests different from
classification. Thus the prototype of the function should return void,
because the intention was to update a value not to return something.
Maxim Uvarov has posted comments on this change.
Change subject: debian/control: fix build-depends
..
Patch Set 2:
Merged, thanks!
Maxim.
--
To view, visit https://review.linaro.org/7928
To unsubscribe, visit https://review.
Good catch. The classifier can be completely bypassed only if there are no
classification rules (default or PMRs) in effect. Presumably the
classifier itself can contain fastpath processing if only a default CoS is
in effect.
On Fri, Sep 18, 2015 at 5:25 AM, Bala Manoharan
wrote:
> In this cas
In this case the packet will not be dispatched to the default CoS in
the scenario when the application configures only the default CoS and
not the PMRs.
Is this the expected behaviour? in case not then
pktio_cls_enabled_set() should be configured in the
odp_pktio_default_cos_set() function also.
Skip packet_classifier function as long as there's no pmr
set for an pktio interface.
Signed-off-by: Petri Savolainen
---
platform/linux-generic/include/odp_packet_io_internal.h | 10 ++
platform/linux-generic/odp_classification.c | 2 ++
platform/linux-generic/odp_packet_io
Merged,
Maxim.
On 09/17/15 16:44, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Reviewed-by: Petri Savolainen
Previously I checked all patches and found only the issue in patch 5/5, which
is now fixed. There's no comments about v3, but I guess that's the only change.
-Original Message--
Hello Hongbo,
can you please update patch series for top of api-next?
Check arm compilation:
odp_system_info.c:193:41: error: unused parameter 'id'
[-Werror=unused-parameter]
static uint64_t arch_cpu_hz_current(int id)
And x86 with all tests turned on:
./configure --enable-test-vald --en
