[lng-odp] [API-NEXT 0/2] Add functions to free multiple packets/buffers at once

As a lot of ODP calls allows the user to receive/poll/send multiple packets at once, I think it makes sense to provide a call to free a bunch of packets/buffers at the same time. Although implementation may be a simple loop, it leaves space for many performance optimizations. It might also

[lng-odp] [PATCH 1/3] linux-generic: pktio: added mac_addr_get_fd

Added a common method for fetching interface MAC address from packet socket. Use common method in socket and socket_mmap. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_socket.h | 5 +++ platform/linux-generic/pktio/socket.c | 36

[lng-odp] [API-NEXT 1/2] api: buffer: add function to free multiple buffers at once

Signed-off-by: Nicolas Morey-Chaisemartin --- include/odp/api/buffer.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/odp/api/buffer.h b/include/odp/api/buffer.h index aea273f..ce13237 100644 --- a/include/odp/api/buffer.h +++ b/include/odp/api/buffer.h

[lng-odp] [API-NEXT 2/2] api: packet: add function to free multiple packets at once

Signed-off-by: Nicolas Morey-Chaisemartin --- include/odp/api/packet.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/odp/api/packet.h b/include/odp/api/packet.h index 5d46b7b..a73be01 100644 --- a/include/odp/api/packet.h +++

Re: [lng-odp] [API-NEXT 2/2] api: packet: add function to free multiple packets at once

On 29 September 2015 at 13:48, Nicolas Morey-Chaisemartin wrote: > Signed-off-by: Nicolas Morey-Chaisemartin > --- > include/odp/api/packet.h | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/include/odp/api/packet.h

[lng-odp] [API-NEXTv2 0/7] Add functions to free multiple packets/buffers at once

As a lot of ODP calls allows the user to receive/poll/send multiple packets at once, I think it makes sense to provide a call to free a bunch of packets/buffers at the same time. Although implementation may be a simple loop, it leaves space for many performance optimizations. v2: * Fix

[lng-odp] [PATCH 3/3] DEPENDENCIES: add netmap pktio install instructions

Added netmap pktio installation instructions. Signed-off-by: Matias Elo --- DEPENDENCIES | 79 +--- 1 file changed, 76 insertions(+), 3 deletions(-) diff --git a/DEPENDENCIES b/DEPENDENCIES index 852beeb..41ed993

[lng-odp] [PATCH 0/3] netmap pktio

Added new netmap pktio interface type which operates in the same manner as the existing socket io interfaces. The code is based on the odp-netmap branch. Netmap pktio uses the same socket helper functions as the existing socket pktio types. Due to this a common mac_addr_get_fd function was added.

Re: [lng-odp] [API-NEXT 2/2] api: packet: add function to free multiple packets at once

On 09/29/2015 01:04 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >> EXT Nicolas Morey-Chaisemartin >> Sent: Tuesday, September 29, 2015 11:43 AM >> To: Bala Manoharan >> Cc: LNG ODP Mailman

Re: [lng-odp] [API-NEXT 2/2] api: packet: add function to free multiple packets at once

> -Original Message- > From: EXT Nicolas Morey-Chaisemartin [mailto:nmo...@kalray.eu] > Sent: Tuesday, September 29, 2015 3:23 PM > To: Savolainen, Petri (Nokia - FI/Espoo); Bala Manoharan > Cc: LNG ODP Mailman List > Subject: Re: [lng-odp] [API-NEXT 2/2] api: packet: add function to

Re: [lng-odp] [API-NEXT 1/2] api: buffer: add function to free multiple buffers at once

On Tue, Sep 29, 2015 at 3:18 AM, Nicolas Morey-Chaisemartin < nmo...@kalray.eu> wrote: > Signed-off-by: Nicolas Morey-Chaisemartin > --- > include/odp/api/buffer.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/include/odp/api/buffer.h

Re: [lng-odp] [API-NEXT 1/2] api: buffer: add function to free multiple buffers at once

On 09/29/15 16:06, Bill Fischofer wrote: On Tue, Sep 29, 2015 at 3:18 AM, Nicolas Morey-Chaisemartin > wrote: Signed-off-by: Nicolas Morey-Chaisemartin > --- include/odp/api/buffer.h | 10

Re: [lng-odp] [API NEXT PATCH v6 00/14] api: sysinfo: CPU frequency API clean up

On 09/26/15 17:16, Mike Holmes wrote: Hongbo, Try the exact CI docker environment which is linked at the bottom of http://www.opendataplane.org/testing/ It has to pass clean there with the check-odp scripts to be acceptable. Let me know if the docs are not good enough. I do not see any

Re: [lng-odp] [PATCH 2/3] linux-generic: pktio: add netmap pktio support

On 09/29/15 09:57, Nicolas Morey-Chaisemartin wrote: --- a/platform/linux-generic/include/odp_packet_io_internal.h >+++ b/platform/linux-generic/include/odp_packet_io_internal.h >@@ -20,6 +20,7 @@ extern "C" { > > #include > #include >+#include > #include > #include > #include >@@

Re: [lng-odp] [PATCH 2/3] linux-generic: pktio: add netmap pktio support

They are already inside an union. Patch just doesn't include those lines. -Matias > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim > Uvarov > Sent: Tuesday, September 29, 2015 12:56 PM > To: lng-odp@lists.linaro.org > Subject: Re:

Re: [lng-odp] [API-NEXT 2/2] api: packet: add function to free multiple packets at once

On 09/29/2015 10:40 AM, Bala Manoharan wrote: > On 29 September 2015 at 13:48, Nicolas Morey-Chaisemartin > wrote: >> Signed-off-by: Nicolas Morey-Chaisemartin >> --- >> include/odp/api/packet.h | 11 +++ >> 1 file changed, 11 insertions(+) >> >>

Re: [lng-odp] [PATCH 2/3] linux-generic: pktio: add netmap pktio support

On 09/29/15 09:57, Nicolas Morey-Chaisemartin wrote: --- a/platform/linux-generic/pktio/socket.c >+++ b/platform/linux-generic/pktio/socket.c >@@ -91,6 +91,7 @@ int sendmmsg(int fd, struct mmsghdr *vmessages, unsigned int vlen, int flags) > /** > * ODP_PACKET_SOCKET_MMSG: > *

Re: [lng-odp] [PATCH 2/3] linux-generic: pktio: add netmap pktio support

On 09/29/15 09:57, Nicolas Morey-Chaisemartin wrote: +#else /* ODP_NETMAP == 0 */ >+ >+/* >+ * Dummy function to enable ODP build without netmap support >+ */ >+static int netmap_open(odp_pktio_t id ODP_UNUSED, >+ pktio_entry_t *pktio_entry ODP_UNUSED, >+ const

Re: [lng-odp] [API-NEXT 2/2] api: packet: add function to free multiple packets at once

On 09/29/15 14:04, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Nicolas Morey-Chaisemartin Sent: Tuesday, September 29, 2015 11:43 AM To: Bala Manoharan Cc: LNG ODP Mailman List Subject: Re:

Re: [lng-odp] [PATCH 2/3] linux-generic: pktio: add netmap pktio support

I think now we need to use prefixes name for pktio and avoid exports. The same as Stuart did for pcap. For netmap it will be something like: netmap:eth0 Maxim. On 09/29/15 09:57, Nicolas Morey-Chaisemartin wrote: On 09/29/2015 08:28 AM, Matias Elo wrote: Added new netmap pktio interface

Re: [lng-odp] [PATCH 2/3] linux-generic: pktio: add netmap pktio support

Will be fixed in V2, thanks. -Matias > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim > Uvarov > Sent: Tuesday, September 29, 2015 1:02 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH 2/3] linux-generic: pktio: add

Re: [lng-odp] [API-NEXT 2/2] api: packet: add function to free multiple packets at once

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > EXT Nicolas Morey-Chaisemartin > Sent: Tuesday, September 29, 2015 11:43 AM > To: Bala Manoharan > Cc: LNG ODP Mailman List > Subject: Re: [lng-odp] [API-NEXT 2/2] api: packet: add function to

Re: [lng-odp] [API-NEXT 2/2] api: packet: add function to free multiple packets at once

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > EXT Maxim Uvarov > Sent: Tuesday, September 29, 2015 2:34 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT 2/2] api: packet: add function to free > multiple packets at once >

[lng-odp] [API-NEXTv2 6/7] linux-generic: packet: add implementation for packet alloc/free multi

Signed-off-by: Nicolas Morey-Chaisemartin --- platform/linux-generic/odp_packet.c | 28 1 file changed, 28 insertions(+) diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 209a6e6..5a1e870 100644 ---

[lng-odp] [API-NEXTv2 5/7] validation: buffer: add tests for buffer alloc/free multi functions

Signed-off-by: Nicolas Morey-Chaisemartin --- test/validation/buffer/buffer.c | 82 + test/validation/buffer/buffer.h | 2 + 2 files changed, 84 insertions(+) diff --git a/test/validation/buffer/buffer.c

[lng-odp] [API-NEXTv2 7/7] validation: packet: add tests for packet alloc/free multi functions

Signed-off-by: Nicolas Morey-Chaisemartin --- test/validation/packet/packet.c | 48 + test/validation/packet/packet.h | 1 + 2 files changed, 49 insertions(+) diff --git a/test/validation/packet/packet.c

[lng-odp] [Bug 1823] Segfault in API-NEXT ../../../test/validation/classification/classification_main

https://bugs.linaro.org/show_bug.cgi?id=1823 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1

[lng-odp] [API-NEXTv2 3/7] linux-generic: pool: add buffer_alloc_multi function

For the moment just a simple wrapper around buffer_alloc to be used by odp_buffer_alloc_multi and odp_packet_alloc_multi Signed-off-by: Nicolas Morey-Chaisemartin --- platform/linux-generic/include/odp_buffer_internal.h | 2 ++ platform/linux-generic/odp_pool.c

Re: [lng-odp] [API-NEXTv2 2/7] api: packet: add functions to alloc/free multiple packets at once

On Tue, Sep 29, 2015 at 9:15 AM, Nicolas Morey-Chaisemartin < nmo...@kalray.eu> wrote: > Signed-off-by: Nicolas Morey-Chaisemartin > --- > include/odp/api/packet.h | 28 > 1 file changed, 28 insertions(+) > > diff --git a/include/odp/api/packet.h

[lng-odp] [API-NEXTv2 4/7] linux-generic: pool: add implementation for buffer alloc/free multi

Signed-off-by: Nicolas Morey-Chaisemartin --- platform/linux-generic/odp_pool.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c index 9036147..d4f6f14 100644 ---

[lng-odp] [API-NEXTv2 2/7] api: packet: add functions to alloc/free multiple packets at once

Signed-off-by: Nicolas Morey-Chaisemartin --- include/odp/api/packet.h | 28 1 file changed, 28 insertions(+) diff --git a/include/odp/api/packet.h b/include/odp/api/packet.h index 5d46b7b..c220329 100644 --- a/include/odp/api/packet.h +++

[lng-odp] [API-NEXTv2 1/7] api: buffer: add functions to alloc/free multiple buffers at once

Signed-off-by: Nicolas Morey-Chaisemartin --- include/odp/api/buffer.h | 25 + 1 file changed, 25 insertions(+) diff --git a/include/odp/api/buffer.h b/include/odp/api/buffer.h index aea273f..ec53ce8 100644 --- a/include/odp/api/buffer.h +++

[lng-odp] [Bug 1823] New: Segfault in API-NEXT ../../../test/validation/classification/classification_main

https://bugs.linaro.org/show_bug.cgi?id=1823 Bug ID: 1823 Summary: Segfault in API-NEXT ../../../test/validation/classification/classification _main Product: OpenDataPlane - linux- generic reference Version: 1.3

[lng-odp] [Bug 1823] Segfault in API-NEXT ../../../test/validation/classification/classification_main

https://bugs.linaro.org/show_bug.cgi?id=1823 Mike Holmes changed: What|Removed |Added Version|1.3 |api-next -- You are

Re: [lng-odp] [API-NEXTv2 2/7] api: packet: add functions to alloc/free multiple packets at once

On 09/29/2015 04:34 PM, Bill Fischofer wrote: > > > On Tue, Sep 29, 2015 at 9:15 AM, Nicolas Morey-Chaisemartin > wrote: > > Signed-off-by: Nicolas Morey-Chaisemartin > > --- >

Re: [lng-odp] [API-NEXTv2 1/7] api: buffer: add functions to alloc/free multiple buffers at once

On 09/29/2015 04:31 PM, Bill Fischofer wrote: > > > On Tue, Sep 29, 2015 at 9:15 AM, Nicolas Morey-Chaisemartin > wrote: > > Signed-off-by: Nicolas Morey-Chaisemartin > > --- >

Re: [lng-odp] [API-NEXTv2 2/7] api: packet: add functions to alloc/free multiple packets at once

Hi, I am not sure whether we need this call for alloc multiple packets at once. The reason being in a high speed data plane system the packets which are allocated and not processed will result in holding up of pool space which will result in dropping of the incoming packets if the pool space is