Re: [lng-odp] [API-NEXT PATCH v2] validation: pktio: test odp_pktio_print()

On 11/02/2015 16:10, Elo, Matias (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim Uvarov Sent: Monday, November 02, 2015 2:44 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCH v2]

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: queue: yield trying to obtain multiple locks

Interesting suggestion. I'll take a look at that and send a v3 for Carl to try. On Mon, Nov 2, 2015 at 8:14 AM, Nicolas Morey-Chaisemartin wrote: > > > On 10/30/2015 09:33 PM, Bill Fischofer wrote: > > To avoid deadlock, especially on a single core, force an explicit > >

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #7 from Carl Wallen --- Sure. However, I only tested that the deadlock issue got solved, I did NOT verify event ordering. -- You are receiving this mail because: You are on the CC list for the

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: queue: yield trying to obtain multiple locks

Reviewed-by: Carl Wallen -Original Message- From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Friday, October 30, 2015 10:33 PM To: lng-odp@lists.linaro.org; Wallen, Carl (Nokia - FI/Espoo) Cc: Bill Fischofer

Re: [lng-odp] [API-NEXT PATCH] linux-generic: sysinfo: update dummy function to pass validation

Just forgot to mention. I've added several patches some time ago to linux kernel to present SMBIOS tables to userspace via sysfs. Currently this sysfs entries are used by dmidecode util to retrieve system h/w information. For ARM64 it's planned to support UEFI in the future and these tables are

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: queue: yield trying to obtain multiple locks

On 10/30/2015 09:33 PM, Bill Fischofer wrote: > To avoid deadlock, especially on a single core, force an explicit > yield while not holding either lock when attempting to acquire multiple > locks for ordered queue processing. Also handle enqueues to self as in > this case the origin and target

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #6 from Bill Fischofer --- Thanks, Carl. Can you please add your review to that patch? -- You are receiving this mail because: You are on the CC list for the bug.___

Re: [lng-odp] [API-NEXT PATCH v2] validation: pktio: test odp_pktio_print()

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim > Uvarov > Sent: Monday, November 02, 2015 2:44 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v2] validation: pktio: test > odp_pktio_print() > > On

[lng-odp] [PATCH v2 2/3] doc: images: add resource_management.msc for users-guide

Signed-off-by: Mike Holmes --- DEPENDENCIES | 5 + configure.ac | 10 + doc/images/Makefile.am | 13 +-- doc/images/resource_management.msc | 45 ++ 4 files

Re: [lng-odp] [PATCH] linux-generic: pktio: print out the name of pktio used

On 11/02/2015 20:31, Zoltan Kiss wrote: Hi, Yes, it makes sense to add it there as well, but I think that ODP_DBG printout should stay as well. So you don't have to modify your app while debugging if you only want to know which pktio were used. I'm not sure which one you meant: move it there

[lng-odp] [API-NEXT PATCH] linux-generic: queue: use locking hierarchy for ordered queueing

Enqueueing to ordered queues requires two locks (source and target queues). Since any queue can be either source or target, queues do not have a natural locking hierarchy. Create one by using the address of the qentry as the lock order. This addresses the aspect of Bug

[lng-odp] [API-NEXT PATCHv2] linux-generic: queue: use locking hierarchy for ordered queueing

Enqueueing to ordered queues requires two locks (source and target queues). Since any queue can be either source or target, queues do not have a natural locking hierarchy. Create one by using the address of the qentry as the lock order. This addresses the aspect of Bug

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #9 from Bill Fischofer --- v2 of patch posted at http://patches.opendataplane.org/patch/3583/ -- You are receiving this mail because: You are on the CC list for the

Re: [lng-odp] [PATCH] linux-generic: pktio: print out the name of pktio used

On 02/11/15 10:54, Stuart Haslam wrote: diff --git a/platform/linux-generic/pktio/loop.c b/platform/linux-generic/pktio/loop.c >index 0d8dadd..8efa611 100644 >--- a/platform/linux-generic/pktio/loop.c >+++ b/platform/linux-generic/pktio/loop.c >@@ -109,6 +109,7 @@ static int

[lng-odp] [PATCH v2 3/3] doc: users-guide convert to asciidoc

Signed-off-by: Mike Holmes --- v2: clarified workers vs control as per Maxims comment configure.ac | 1 + doc/Makefile.am | 2 +- doc/users-guide/Makefile.am | 10 + doc/users-guide/guide.dox| 14 --

Re: [lng-odp] [PATCH] linux-generic: pktio: print out the name of pktio used

Hi, On 02/11/15 10:25, Maxim Uvarov wrote: diff --git a/platform/linux-generic/include/odp_packet_io_internal.h b/platform/linux-generic/include/odp_packet_io_internal.h index 4745bd5..4432cfc 100644 --- a/platform/linux-generic/include/odp_packet_io_internal.h +++

[lng-odp] [PATCH v2 1/3] doc: images: add svg for user-guide

Signed-off-by: Mike Holmes --- DEPENDENCIES | 9 +- configure.ac | 11 + doc/Makefile.am | 4 +- doc/images/.gitignore | 2 + doc/images/Makefile.am| 33 +++ doc/images/atomic_queue.svg | 302

Re: [lng-odp] [API-NEXT PATCH 1/2] api: version: added implementation name str

This method of identifying ODP version using API is useful for finding the implementation version while executing the binary. IMO we need to additionally define a method to identify the version of the compiled binary statically. We can add a "#define Version " inside the implementation file so

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #5 from Carl Wallen --- >> Do you see the same behavior when running on multiple CPUs? Yes, the issue was seen both when running on a single core and on multiple cores. The submitted patch v2

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: queue: yield trying to obtain multiple locks

I applied that on api-next and still see fails: $while true; do ./test/validation/scheduler/scheduler_main 2>&1 |grep FAIL; done Test: scheduler_test_mq_mt_prio_o ...FAILED Test: scheduler_test_multi_mq_mt_prio_o ...FAILED Test: scheduler_test_multi_mq_mt_prio_o ...FAILED Test:

Re: [lng-odp] [PATCH] linux-generic: pktio: print out the name of pktio used

Hi, Yes, it makes sense to add it there as well, but I think that ODP_DBG printout should stay as well. So you don't have to modify your app while debugging if you only want to know which pktio were used. I'm not sure which one you meant: move it there or keep it both? Zoli On 02/11/15

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #8 from Bill Fischofer --- Patch superseded by http://patches.opendataplane.org/patch/3582/ Thanks to Nicolas for the suggested simplification. Carl: Can you please test/review this patch. It should also solve

Re: [lng-odp] [API-NEXT PATCH] linux-generic: sysinfo: update dummy function to pass validation

I should clarify in my previous mails, I used sys fs instead of proc of sometimes. On x86 the max freq is acquired from /proc/cpuinfo, on my ARM platform, this file exists too, but no freq info included there. This file should always exist, whatever freq-scaling is turned on or not, so max freq

Re: [lng-odp] [API-NEXT PATCH] linux-generic: sysinfo: update dummy function to pass validation

Advantage of acquiring max freq from /sys/devices/system/cpu*/cpufreq/ is it's much easier, but this requires freq-scaling should be turned on. what's more, this sysfs is identical for all platforms, if we use if on ARM, we should use it on the other platforms too. Upstream max freq into

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: queue: yield trying to obtain multiple locks

Debug says that order of that two packets is wrong: Test: scheduler_test_mq_mt_prio_o ...bctx 64 seq 63 bctx 63 seq 64 On 10/30/2015 23:33, Bill Fischofer wrote: To avoid deadlock, especially on a single core, force an explicit yield while not holding either lock when attempting to acquire

Re: [lng-odp] [PATCH] example/ipsec: Increase ip_data_len for Tunnel mode

Merged, good bugfix. Maxim. On 10/30/2015 17:30, akhil.go...@freescale.com wrote: From: Akhil Goyal In case of tunnel mode, while moving the ip_data- number of bytes to be moved should be original ip_data_len plus ip_header_len. Currently, ip_data pointer is

Re: [lng-odp] [PATCH] linux-generic: pktio: print out the name of pktio used

I added the odp_pktio_print() function while thinking just this use case. Comments below. -Matias > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Zoltan > Kiss > Sent: Friday, October 30, 2015 8:38 PM > To: lng-odp@lists.linaro.org >

Re: [lng-odp] [PATCH] linux-generic: pktio: print out the name of pktio used

Please add that to odp_pktio_print() call in api-next. Maxim. On 10/30/2015 21:38, Zoltan Kiss wrote: For debug purposes, otherwise it's not trivial to figure out which pktio was successful. Signed-off-by: Zoltan Kiss diff --git

Re: [lng-odp] [PATCH 1/8] add jhash function

Ping! Does somebody still reviewing that patches? Maxim. On 09/20/2015 17:04, rujiacs wrote: Signed-off-by: rujiacs --- helper/include/odp/helper/hash_jhash.h | 420 + 1 file changed, 420 insertions(+) create mode 100644

Re: [lng-odp] [PATCH] linux-generic: pktio: print out the name of pktio used

On 11/02/2015 13:22, Elo, Matias (Nokia - FI/Espoo) wrote: I added the odp_pktio_print() function while thinking just this use case. Comments below. -Matias -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Zoltan Kiss Sent: Friday, October

Re: [lng-odp] [API-NEXT PATCH] linux-generic: sysinfo: update dummy function to pass validation

Doesn’t device tree provide that value? Maxim. On 11/02/2015 12:07, Hongbo Zhang wrote: Advantage of acquiring max freq from /sys/devices/system/cpu*/cpufreq/ is it's much easier, but this requires freq-scaling should be turned on. what's more, this sysfs is identical for all platforms, if we

Re: [lng-odp] [PATCH 3/3] doc: users-guide convert to asciidoc

On 10/22/2015 22:56, Mike Holmes wrote: Signed-off-by: Mike Holmes --- configure.ac | 1 + doc/Makefile.am | 2 +- doc/users-guide/Makefile.am | 10 + doc/users-guide/guide.dox| 14 --

[lng-odp] please review ML patches

Gentlemen, in mailing list we have bunch of patches without any comments. I'm not sure if somebody reviewed that patches or it's just silence. Please add your Reviewed-by: tag if you did patches review. Thank you, Maxim. ___ lng-odp mailing list

Re: [lng-odp] [API-NEXT PATCH] linux-generic: sysinfo: update dummy function to pass validation

Device tree has node for CPU that contains clock-frequency. (ePAPR v1.1) But it can be used only if cpufreq is off. And it also doesn't guarantee that frequency of the CPU was not changed by the kernel in some place. By a big account it can be changed only by cpufreq, so maybe used, I think.

Re: [lng-odp] [PATCH] linux-generic: pktio: print out the name of pktio used

On Fri, Oct 30, 2015 at 06:38:14PM +, Zoltan Kiss wrote: > For debug purposes, otherwise it's not trivial to figure out which pktio was > successful. > > Signed-off-by: Zoltan Kiss > > diff --git a/platform/linux-generic/include/odp_packet_io_internal.h >

[lng-odp] [Bug 1449] odp_timer_test core dump

https://bugs.linaro.org/show_bug.cgi?id=1449 --- Comment #12 from Ivan Khoronzhuk --- As were said previously we shouldn't set period less than resolution. It's incorrect and makes example to work in it's own time. The actual resolution of timer is not 1ns it's much

[lng-odp] [API-NEXT PATCH 1/2] api: version: added implementation name str

Refined version API documentation and added implementation name string that can be used to identify the underlying implementation at run time. Signed-off-by: Petri Savolainen --- include/odp/api/version.h | 47 ++- 1 file

[lng-odp] [API-NEXT PATCH 2/2] linux-generic: version: implemented impl name str

Implemented implementation name string and call it from validation test common. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_version.c | 6 ++ test/validation/common/odp_cunit_common.c | 1 + 2 files changed, 7 insertions(+) diff --git

[lng-odp] [API-NEXT PATCH v2] validation: pktio: test odp_pktio_print()

Signed-off-by: Matias Elo --- v2: - No need for a separate odp_pktio_print() test (Maxim Uvarov) test/validation/pktio/pktio.c | 4 1 file changed, 4 insertions(+) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index 6320b77..ff62b3c

Re: [lng-odp] [PATCH 3/3] doc: users-guide convert to asciidoc

On 2 November 2015 at 04:51, Maxim Uvarov wrote: > On 10/22/2015 22:56, Mike Holmes wrote: > >> Signed-off-by: Mike Holmes >> --- >> configure.ac | 1 + >> doc/Makefile.am | 2 +- >>

Re: [lng-odp] [API-NEXT PATCH v2] validation: pktio: test odp_pktio_print()

On 11/02/2015 15:16, Matias Elo wrote: Signed-off-by: Matias Elo --- v2: - No need for a separate odp_pktio_print() test (Maxim Uvarov) test/validation/pktio/pktio.c | 4 1 file changed, 4 insertions(+) diff --git a/test/validation/pktio/pktio.c