Re: [lng-odp] [PATCH] linux-generic: odp_timer: abort if tick is lost

2015-11-06 Thread Bill Fischofer
A reportable statistic for this situation would be appropriate, but this certainly should not result in an abort. Ticks can be lost for all sorts of reasons and should be considered unusual but hardly fatal conditions. Aborts are reserved for serious internal errors or detected inconsistencies tha

Re: [lng-odp] [PATCH 1/2] linux-generic: odp_cpumask.c: assert on ODP_CPUMASK_SIZE

2015-11-06 Thread Mike Holmes
On 29 October 2015 at 10:18, Anders Roxell wrote: > The API definition of a CPU mask must not be incompatible with the > platform it is implemented on > > Signed-off-by: Anders Roxell > For the series I dont think ODP should limit the maximum number of threads, it could be greater than the num

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-06 Thread Bala Manoharan
Hi Petri, Why don't we add this hash parameter to CoS so that when the packet arrives to a CoS it can be distributed based on the hash algorithm to a number of queues. Also if a system does not support Classification this hashing can be attached to the default CoS and in systems supporting Classif

Re: [lng-odp] [API-NEXT PATCHv4 0/5] helper: add table module

2015-11-06 Thread Mike Holmes
Hi Huanggaoyang I may have missed a post from you that fixes this already, but you may want to try this on your GIT_URL DOXYGEN_HTML=1 GIT_BRANCH=next ./build.sh or try it against the patch you created as Anders suggested (safest since this will apply it to a fresh upstream copy and your repo m

[lng-odp] [PATCH] doc: improve asciidoc presentation

2015-11-06 Thread Mike Holmes
Signed-off-by: Mike Holmes --- doc/implementers-guide/Makefile.am | 2 +- doc/users-guide/Makefile.am| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/implementers-guide/Makefile.am b/doc/implementers-guide/Makefile.am index 25437d3..f973823 100644 --- a/doc/impl

Re: [lng-odp] New distcheck information added to the OpenDataPlane webpage + other updates

2015-11-06 Thread Maxim Uvarov
Needed to drop netmap and KS2 from that table also. Maxim. On 11/06/2015 17:59, Marshall Guillory wrote: New testing status information is now available: http://www.opendataplane.org/testing/ Also, we have modified the downloads table. http://www.opendataplane.org/downloads/ ODP roadmap wa

[lng-odp] New distcheck information added to the OpenDataPlane webpage + other updates

2015-11-06 Thread Marshall Guillory
New testing status information is now available: http://www.opendataplane.org/testing/ Also, we have modified the downloads table. http://www.opendataplane.org/downloads/ ODP roadmap was updated to account for the v1.4 release. Next sync on Monday with JIRA. http://www.opendataplane.org/opendatap

[lng-odp] Runtime inlining

2015-11-06 Thread Zoltan Kiss
Hi, We have a packaging/linking/optimization problem at LNG, I hope you guys can give us some advice on that. (Cc'ing ODP list in case someone want to add something) We have OpenDataPlane (ODP), an API stretching between userspace applications and hardware SDKs. It's defined in the form of C h

Re: [lng-odp] [PATCH] linux-generic: odp_timer: abort if tick is lost

2015-11-06 Thread Ivan Khoronzhuk
On 31.10.15 00:56, Ivan Khoronzhuk wrote: No need to continue test example if tick is lost. It means that actual timer resolution is worse than expected. The default timer resolution is set 10ms, that is equal to jiffy on most systems. The default resolution is set bearing in mind that on a CPU r

Re: [lng-odp] [API-NEXT PATCH v7 0/6] api: time: unbind CPU cycles from time API

2015-11-06 Thread Ivan Khoronzhuk
On 06.11.15 14:57, Savolainen, Petri (Nokia - FI/Espoo) wrote: Order of @param t1 and t2 (documentation) should be also swapped. But can be done in another patch after this is merged. Reviewed-by: Petri Savolainen +/** + * Compare two times + * + * @param t1First time + * @param t2

[lng-odp] [API-NEXT PATCH v8 3/6] api: time: unbind CPU cycles from time API

2015-11-06 Thread Ivan Khoronzhuk
Current time API supposes that frequency of counter is equal to CPU frequency. But that's not always true, for instance, in case if no access to CPU cycle counter, another hi-resolution timer can be used, and it`s rate can be different from CPU rate. There is no big difference in which cycles to me

Re: [lng-odp] [API-NEXT PATCH v7 0/6] api: time: unbind CPU cycles from time API

2015-11-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
Order of @param t1 and t2 (documentation) should be also swapped. But can be done in another patch after this is merged. Reviewed-by: Petri Savolainen +/** + * Compare two times + * + * @param t1First time + * @param t2Second time + * + * @retval <0 if t2 < t1, >0 if t1 = t2, 1 if t2

[lng-odp] [API-NEXT PATCH 5/5] api: pktio: added direct send to pktio output queue

2015-11-06 Thread Petri Savolainen
Added odp_pktio_send_queue for direct packet send to a pktio output queue. Signed-off-by: Petri Savolainen --- include/odp/api/packet_io.h | 42 ++ 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/include/odp/api/packet_io.h b/include/odp/api

[lng-odp] [API-NEXT PATCH 4/5] api: pktio: added multiple pktio output queues

2015-11-06 Thread Petri Savolainen
Added output queue configuration parameters and functions for setting up multiple output queues. Added also odp_pktio_output_queues to query the number of queues. Signed-off-by: Petri Savolainen --- include/odp/api/packet_io.h | 57 + 1 file changed, 5

[lng-odp] [API-NEXT PATCH 3/5] api: pktio: added direct queue receive

2015-11-06 Thread Petri Savolainen
Added odp_pktio_recv_queue for direct packet receive from pktio input hash queues. Signed-off-by: Petri Savolainen --- include/odp/api/packet_io.h | 36 +++- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/include/odp/api/packet_io.h b/include/odp/a

[lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-06 Thread Petri Savolainen
Added input queue configuration parameters and functions to setup multiple input queue and hashing. Added also odp_pktio_input_queues to query the number of queues and queue handles. Direct receive does not use queue handles, but indexes. Signed-off-by: Petri Savolainen --- include/odp/api/packe

[lng-odp] [API-NEXT PATCH 1/5] api: pktio: added pktio capability struct

2015-11-06 Thread Petri Savolainen
Added capability structure and a function to query it. Capability limits are used for advanced pktio configuration, like configuration of multiple input/output queues. Signed-off-by: Petri Savolainen --- include/odp/api/packet_io.h | 23 +++ 1 file changed, 23 insertions(+)

[lng-odp] [API-NEXT PATCH 0/5] *** Multi-queue packet io APIs ***

2015-11-06 Thread Petri Savolainen
This patch set adds APIs for multi-queue packet IO. It does not remove or modify existing API calls, so that multi-queue can be verified first with couple of apps and implementations. Single queue APIs (e.g. odp_pktio_inq_setdef()) should be removed once everything is ported to use the new API (p

Re: [lng-odp] [PATCH] linux-generic: netmap: replace nm_dispatch() helper

2015-11-06 Thread Elo, Matias (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim > Uvarov > Sent: Friday, November 06, 2015 1:40 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH] linux-generic: netmap: replace nm_dispatch() > helper > > On 11/06/2015 1

Re: [lng-odp] [PATCH] linux-generic: netmap: replace nm_dispatch() helper

2015-11-06 Thread Maxim Uvarov
On 11/06/2015 13:56, Matias Elo wrote: Implement nm_dispatch() functionality in ODP code to optimize performance and enable future feature additions. Signed-off-by: Matias Elo --- platform/linux-generic/pktio/netmap.c | 94 +++ 1 file changed, 61 insertions(+)

Re: [lng-odp] [API-NEXT PATCH v3] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread Maxim Uvarov
Merged, Maxim. On 11/06/2015 14:11, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang In the default dummy function systemcpu(), only cpu_hz[0] and model_str[0] are set to dummy values, then in the validation code if iterate each CPU, cores other than core 0 report failure, this patchs pad

Re: [lng-odp] [API-NEXT PATCH 1/2] api: version: added implementation name str

2015-11-06 Thread Maxim Uvarov
Merged, Maxim. On 11/05/2015 12:11, Savolainen, Petri (Nokia - FI/Espoo) wrote: Ping. A standard way for application to check which implementation it's running on. -Petri -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Savolainen, Petri (No

Re: [lng-odp] [API-NEXT PATCH 1/2] api: version: added implementation name str

2015-11-06 Thread Maxim Uvarov
Merged to api-next. Maxim. On 11/05/2015 12:11, Savolainen, Petri (Nokia - FI/Espoo) wrote: Ping. A standard way for application to check which implementation it's running on. -Petri -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Savolain

[lng-odp] [API-NEXT PATCH v3] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread hongbo.zhang
From: Hongbo Zhang In the default dummy function systemcpu(), only cpu_hz[0] and model_str[0] are set to dummy values, then in the validation code if iterate each CPU, cores other than core 0 report failure, this patchs pad all the arrays to default values to pass validation. For bug: https://bu

Re: [lng-odp] [API-NEXT PATCH v2] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread Ivan Khoronzhuk
On 06.11.15 13:00, Maxim Uvarov wrote: On 11/06/2015 13:54, Ivan Khoronzhuk wrote: On 06.11.15 12:44, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang In the default dummy function systemcpu(), only cpu_hz[0] and model_str[0] are set to dummy values, then in the validation code if ite

Re: [lng-odp] [API-NEXT PATCHv1] helper: table: fix the ci warning

2015-11-06 Thread Maxim Uvarov
Merged it to next. Maxim. On 11/06/2015 10:59, huanggaoyang wrote: Signed-off-by: huanggaoyang --- helper/Makefile.am | 5 - helper/test/Makefile.am | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/helper/Makefile.am b/helper/Makefile.am index 196d887..e72507e

Re: [lng-odp] [API-NEXT PATCH v2] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread Maxim Uvarov
On 11/06/2015 13:54, Ivan Khoronzhuk wrote: On 06.11.15 12:44, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang In the default dummy function systemcpu(), only cpu_hz[0] and model_str[0] are set to dummy values, then in the validation code if iterate each CPU, cores other than core 0 r

Re: [lng-odp] [API-NEXT PATCH v2] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread Hongbo Zhang
On 6 November 2015 at 18:54, Ivan Khoronzhuk wrote: > > > On 06.11.15 12:44, hongbo.zh...@freescale.com wrote: >> >> From: Hongbo Zhang >> >> In the default dummy function systemcpu(), only cpu_hz[0] and model_str[0] >> are set to dummy values, then in the validation code if iterate each CPU, >>

Re: [lng-odp] [API-NEXT PATCH v2] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread Hongbo Zhang
On 6 November 2015 at 18:54, Maxim Uvarov wrote: > On 11/06/2015 13:44, hongbo.zh...@freescale.com wrote: >> >> From: Hongbo Zhang >> >> In the default dummy function systemcpu(), only cpu_hz[0] and model_str[0] >> are set to dummy values, then in the validation code if iterate each CPU, >> cores

[lng-odp] [PATCH] linux-generic: netmap: replace nm_dispatch() helper

2015-11-06 Thread Matias Elo
Implement nm_dispatch() functionality in ODP code to optimize performance and enable future feature additions. Signed-off-by: Matias Elo --- platform/linux-generic/pktio/netmap.c | 94 +++ 1 file changed, 61 insertions(+), 33 deletions(-) diff --git a/platform/li

Re: [lng-odp] [API-NEXT PATCH v2] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread Ivan Khoronzhuk
On 06.11.15 12:44, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang In the default dummy function systemcpu(), only cpu_hz[0] and model_str[0] are set to dummy values, then in the validation code if iterate each CPU, cores other than core 0 report failure, this patchs pad all the arrays t

Re: [lng-odp] [API-NEXT PATCH v2] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread Maxim Uvarov
On 11/06/2015 13:44, hongbo.zh...@freescale.com wrote: From: Hongbo Zhang In the default dummy function systemcpu(), only cpu_hz[0] and model_str[0] are set to dummy values, then in the validation code if iterate each CPU, cores other than core 0 report failure, this patchs pad all the arrays t

[lng-odp] [API-NEXT PATCH v2] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread hongbo.zhang
From: Hongbo Zhang In the default dummy function systemcpu(), only cpu_hz[0] and model_str[0] are set to dummy values, then in the validation code if iterate each CPU, cores other than core 0 report failure, this patchs pad all the arrays to default values to pass validation. For bug: https://bu

Re: [lng-odp] [API-NEXT PATCH] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread Hongbo Zhang
Done. On 6 November 2015 at 18:06, Maxim Uvarov wrote: > On 11/06/2015 12:49, Hongbo Zhang wrote: >> >> On 5 November 2015 at 18:29, Maxim Uvarov wrote: >>> >>> Hello Hongbo, >>> >>> are you looking to Ivan's solutions? >>> >>> If will take time then please do: >>> 1. Open bug for that issue des

Re: [lng-odp] [temp PATCH] linux-generic: odp_time: don't use cpu cycle API to get time

2015-11-06 Thread Ivan Khoronzhuk
I will send this patch when series with cycles -> time API will be applied. So, only dependency for freq_max is cpu cycles emulation when arch is not added. Any way cpu_max_freq is not correct it doesn't correspond to the maximum freq of CPU. It's got once at init as current freq and then represe

Re: [lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-06 Thread Nicolas Morey-Chaisemartin
Ok. I have a patch series added check like for things like start when started, send when pktio is RONLY or config changes when pktio is started. As soon as your patch go through, I'll rebase and post. On 11/06/2015 09:51 AM, Maxim Uvarov wrote: > On 11/06/2015 11:45, Nicolas Morey-Chaisemartin wr

[lng-odp] [temp PATCH] linux-generic: odp_time: don't use cpu cycle API to get time

2015-11-06 Thread Ivan Khoronzhuk
This will be looking like this patch. It allows to get rid of cpu_freq_max ... a little. But temp freq actually breaks CPU cycle API that emulates number of cpu cycles are base on cpu_hz_maxbut any way it's not correct... The linux-generic time API implementation shouldn't depend on cpu cycle

Re: [lng-odp] [API-NEXT PATCH] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread Maxim Uvarov
On 11/06/2015 12:49, Hongbo Zhang wrote: On 5 November 2015 at 18:29, Maxim Uvarov wrote: Hello Hongbo, are you looking to Ivan's solutions? If will take time then please do: 1. Open bug for that issue describing problem and possible solutions. 2. Add ODP_DBG("") with description and bug bug

Re: [lng-odp] [API-NEXT PATCH] linux-generic: sysinfo: update dummy function to pass validation

2015-11-06 Thread Hongbo Zhang
On 5 November 2015 at 18:29, Maxim Uvarov wrote: > Hello Hongbo, > > are you looking to Ivan's solutions? > > If will take time then please do: > 1. Open bug for that issue describing problem and possible solutions. > 2. Add ODP_DBG("") with description and bug bug link, that dummy files are > use

Re: [lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-06 Thread Maxim Uvarov
On 11/06/2015 11:45, Nicolas Morey-Chaisemartin wrote: On a side note, what is the expected behavior when stopping a stopped interface or starting a started one? Current api does not say anything about it except first sentence. I think we should prevent double stop and double start and refin

Re: [lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-06 Thread Nicolas Morey-Chaisemartin
On a side note, what is the expected behavior when stopping a stopped interface or starting a started one? On 11/05/2015 04:58 PM, Maxim Uvarov wrote: > According to API odp_pktio_close() can be called only for stopped > pktio. So in odp_pktio_term_global try to stop it first then > call close. A

Re: [lng-odp] [PATCHv2] linux-generic: check return codes in odp_pktio_term_global

2015-11-06 Thread Nicolas Morey-Chaisemartin
Reviewed-by: Nicolas Morey-Chaisemartin On 11/05/2015 04:58 PM, Maxim Uvarov wrote: > According to API odp_pktio_close() can be called only for stopped > pktio. So in odp_pktio_term_global try to stop it first then > call close. Also check all returns codes. > https://bugs.linaro.org/show_bug.cgi

[lng-odp] [API-NEXTv2 4/4] example: ipsec: add support for HMAC-SHA-256-128

2015-11-06 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- example/ipsec/odp_ipsec.c| 2 +- example/ipsec/odp_ipsec_misc.h | 8 ++-- example/ipsec/odp_ipsec_sa_db.c | 4 example/ipsec/odp_ipsec_stream.c | 3 ++- 4 files changed, 13 insertions(+), 4 deletions(-) diff --git a/example/ipsec/

[lng-odp] [API-NEXTv2 2/4] api: crypto: add HMAC-SHA-256-128 support

2015-11-06 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- include/odp/api/crypto.h | 2 + .../linux-generic/include/odp_crypto_internal.h| 4 + platform/linux-generic/odp_crypto.c| 89 ++ 3 files changed, 95 insertions(+) diff --git a/inclu

[lng-odp] [API-NEXTv2 3/4] validation: crypto: add test for HMAC-SHA-256-128

2015-11-06 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- test/validation/crypto/crypto.h | 1 + test/validation/crypto/odp_crypto_test_inp.c | 37 +++ test/validation/crypto/test_vectors.h| 44 test/validation/crypto/test_vectors_len.h

[lng-odp] [API-NEXTv2 1/4] crypto: move enums from platform types to odp and rename to fit the API format

2015-11-06 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- example/ipsec/odp_ipsec_cache.c| 2 +- example/ipsec/odp_ipsec_cache.h| 4 +- example/ipsec/odp_ipsec_misc.h | 4 +- include/odp/api/crypto.h | 140 ++-

[lng-odp] [API-NEXTv2 0/4] Add HMAC-SHA-256-128 support

2015-11-06 Thread Nicolas Morey-Chaisemartin
The first patch is a cleanup suggested by Petri. All the crypto enums are moved from linux-generic back to ODP API, and renamed (odp__t) Following patches add support for the new HMAC function, then a validation test and finally support in odp-ipsec v2: Correct test vectors to match the ones fro

[lng-odp] [API-NEXT PATCHv1] helper: table: fix the ci warning

2015-11-06 Thread huanggaoyang
Signed-off-by: huanggaoyang --- helper/Makefile.am | 5 - helper/test/Makefile.am | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/helper/Makefile.am b/helper/Makefile.am index 196d887..e72507e 100644 --- a/helper/Makefile.am +++ b/helper/Makefile.am @@ -22,7 +22,10

[lng-odp] [API-NEXT PATCHv1] helper:fix the CI warning/error

2015-11-06 Thread huanggaoyang
this is a patch based on the latest next Branch. sorry to destroy the long time 'zero warnings' record of the CI and thank you all again, for kindly showing me how to do the pre-commit check huanggaoyang (1): helper: table: fix the ci warning helper/Makefile.am | 5 - helper/test/Make