[lng-odp] [API-NEXT PATCH 0/6] Ordered Queue Bug Fixes

2015-11-08 Thread Bill Fischofer
This series cleans up the implementation of ordered queues and fixes Bug https://bugs.linaro.org/show_bug.cgi?id=1879 Bill Fischofer (6): linux-generic: schedule: move ordered lock routines to odp_schedule.c linux-generic: queue: add utility functions for restructure linux-generic: queue: ad

[lng-odp] [API-NEXT PATCH 1/6] linux-generic: schedule: move ordered lock routines to odp_schedule.c

2015-11-08 Thread Bill Fischofer
Move the odp_schedule_order_lock() and odp_schedule_order_unlock() routines from odp_queue.c to odp_schedule.c Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_queue.c| 31 platform/linux-generic/odp_schedule.c | 39 +++

[lng-odp] [API-NEXT PATCH 2/6] linux-generic: queue: add utility functions for restructure

2015-11-08 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_queue_internal.h | 44 ++ platform/linux-generic/odp_queue.c | 7 2 files changed, 51 insertions(+) diff --git a/platform/linux-generic/include/odp_queue_internal.h b/platform/linux-gen

[lng-odp] [API-NEXT PATCH 3/6] linux-generic: queue: add ordered_queue_enq() routine - part 1

2015-11-08 Thread Bill Fischofer
Add the new ordered_queue_enq() internal routine. This is done in two parts to make the diffs easier to follow. Part 1 adds the new routine while Part 2 replaces queue_enq() to use it. Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_queue_internal.h | 2 + platform/linux-ge

[lng-odp] [API-NEXT PATCH 4/6] linux-generic: queue: add ordered_queue_enq() routine - part 2

2015-11-08 Thread Bill Fischofer
Restructure queue_enq() to streamline it while using the new ordered_queue_enq() routine to handle ordered queues. This change is made in two parts to make the diffs easier to follow. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_queue.c | 134 -

[lng-odp] [API-NEXT PATCH 5/6] linux-generic: queue: streamline reorder_deq() routine

2015-11-08 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_queue_internal.h | 16 ++--- platform/linux-generic/odp_queue.c | 27 ++ 2 files changed, 19 insertions(+), 24 deletions(-) diff --git a/platform/linux-generic/include/odp_queue_intern

[lng-odp] [API-NEXT PATCH 6/6] linux-generic: queue: streamline and correct release_order() routine

2015-11-08 Thread Bill Fischofer
Resolve the corner case of releasing order for an order that still has events on the reorder queue. This also allows the reorder_complete() routine to be streamlined. This patch resolves Bug https://bugs.linaro.org/show_bug.cgi?id=1879 Signed-off-by: Bill Fischofer --- .../linux-generic/include

[lng-odp] [API-NEXT PATCHv2 0/6] Ordered Queue Bug Fixes

2015-11-08 Thread Bill Fischofer
Changes for v2 -- Remove unused routine get_sched_sync() as part of part 1 of of this series This series cleans up the implementation of ordered queues and fixes Bug https://bugs.linaro.org/show_bug.cgi?id=1879 Bill Fischofer (6): linux-generic: schedule: move ordered lock routines to odp_sched

[lng-odp] [API-NEXT PATCHv2 2/6] linux-generic: queue: add utility functions for restructure

2015-11-08 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_queue_internal.h | 44 ++ platform/linux-generic/odp_queue.c | 7 2 files changed, 51 insertions(+) diff --git a/platform/linux-generic/include/odp_queue_internal.h b/platform/linux-gen

[lng-odp] [API-NEXT PATCHv2 1/6] linux-generic: schedule: move ordered lock routines to odp_schedule.c

2015-11-08 Thread Bill Fischofer
Move the odp_schedule_order_lock() and odp_schedule_order_unlock() routines from odp_queue.c to odp_schedule.c Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_queue.c| 31 platform/linux-generic/odp_schedule.c | 45 ++- 2

[lng-odp] [API-NEXT PATCHv2 3/6] linux-generic: queue: add ordered_queue_enq() routine - part 1

2015-11-08 Thread Bill Fischofer
Add the new ordered_queue_enq() internal routine. This is done in two parts to make the diffs easier to follow. Part 1 adds the new routine while Part 2 replaces queue_enq() to use it. Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_queue_internal.h | 2 + platform/linux-ge

[lng-odp] [API-NEXT PATCHv2 4/6] linux-generic: queue: add ordered_queue_enq() routine - part 2

2015-11-08 Thread Bill Fischofer
Restructure queue_enq() to streamline it while using the new ordered_queue_enq() routine to handle ordered queues. This change is made in two parts to make the diffs easier to follow. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_queue.c | 134 -

[lng-odp] [API-NEXT PATCHv2 5/6] linux-generic: queue: streamline reorder_deq() routine

2015-11-08 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_queue_internal.h | 16 ++--- platform/linux-generic/odp_queue.c | 27 ++ 2 files changed, 19 insertions(+), 24 deletions(-) diff --git a/platform/linux-generic/include/odp_queue_intern

[lng-odp] [API-NEXT PATCHv2 6/6] linux-generic: queue: streamline and correct release_order() routine

2015-11-08 Thread Bill Fischofer
Resolve the corner case of releasing order for an order that still has events on the reorder queue. This also allows the reorder_complete() routine to be streamlined. This patch resolves Bug https://bugs.linaro.org/show_bug.cgi?id=1879 Signed-off-by: Bill Fischofer --- .../linux-generic/include

[lng-odp] [Bug 1879] Ordered queues occasionally not restoring order properly

2015-11-08 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1879 --- Comment #11 from Bill Fischofer --- Patch series http://patches.opendataplane.org/patch/3661/ through http://patches.opendataplane.org/patch/3666/ posted to fully resolve this bug. -- You are receiving this mail because: You are on the CC list fo

Re: [lng-odp] [PATCH] linux-generic: queue: split queue_enq implementations for regular and ordered queues

2015-11-08 Thread Bill Fischofer
This patch is superseded by patch series http://patches.opendataplane.org/patch/3661/ through http://patches.opendataplane.org/patch/3666/ that resolves Bug https://bugs.linaro.org/show_bug.cgi?id=1879 As part of the restructuring to resolve that patch, ordered queue processing is now handled in a

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-08 Thread Bill Fischofer
On Fri, Nov 6, 2015 at 6:33 AM, Petri Savolainen wrote: > Added input queue configuration parameters and functions > to setup multiple input queue and hashing. Added also > odp_pktio_input_queues to query the number of queues > and queue handles. Direct receive does not use queue > handles, but i

Re: [lng-odp] [API-NEXT PATCH 3/5] api: pktio: added direct queue receive

2015-11-08 Thread Bill Fischofer
On Fri, Nov 6, 2015 at 6:33 AM, Petri Savolainen wrote: > Added odp_pktio_recv_queue for direct packet receive from pktio input > hash queues. > > Signed-off-by: Petri Savolainen > --- > include/odp/api/packet_io.h | 36 +++- > 1 file changed, 31 insertions(+), 5

Re: [lng-odp] [API-NEXT PATCH 2/5] api: pktio: added multiple pktio input queues

2015-11-08 Thread Bill Fischofer
I agree. It's not clear from these definitions how or why packets are spread to input queues or gathered from output queues. What is the use case behind these APIs? It seems we can either do a direct send or recv to a single pktio queue, which gives the same behavior as today's direct send/recv

Re: [lng-odp] [PATCH] doc: improve asciidoc presentation

2015-11-08 Thread Bill Fischofer
Shouldn't these be tagged --subject-prefix="NEXT PATCH" to make it clear which branch it's intended for? Other than that, looks fine. On Fri, Nov 6, 2015 at 9:46 AM, Mike Holmes wrote: > Signed-off-by: Mike Holmes > Reviewed-and-tested-by: Bill Fischofer > --- doc/implementers-guide/Mak

[lng-odp] [API-NEXT PATCH 0/3] retrieve queue information

2015-11-08 Thread Carl Wallen
New api function: odp_queue_info() to retrieve queue name, type and params. Carl Wallen (3): api: queue: add odp_queue_info() function to retrieve queue information linux-generic: queue: add odp_queue_info() function validation: queue: api validation tests for odp_queue_info() include/

[lng-odp] [API-NEXT PATCH 1/3] api: queue: add odp_queue_info() function to retrieve queue information

2015-11-08 Thread Carl Wallen
Add odp_queue_info() along with odp_queue_info_t to retrieve queue name, type and parameters. Signed-off-by: Carl Wallen --- include/odp/api/queue.h | 24 1 file changed, 24 insertions(+) diff --git a/include/odp/api/queue.h b/include/odp/api/queue.h index df2a4c9..3ee6

[lng-odp] [API-NEXT PATCH 2/3] linux-generic: queue: add odp_queue_info() function

2015-11-08 Thread Carl Wallen
Retrieve queue name and params. Signed-off-by: Carl Wallen --- platform/linux-generic/odp_queue.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-generic/odp_queue.c index 1c15e17..90e8972 100644 ---

[lng-odp] [API-NEXT PATCH 3/3] validation: queue: api validation tests for odp_queue_info()

2015-11-08 Thread Carl Wallen
Verify the functionality of the queue api function odp_queue_info() for different queue types. Signed-off-by: Carl Wallen --- test/validation/queue/queue.c | 57 +++ test/validation/queue/queue.h | 1 + 2 files changed, 58 insertions(+) diff --git a/test