Re: [lng-odp] [PATCH] helper: test: add odp_table to .gitignore file

On Tue, Nov 24, 2015 at 8:44 AM, Maxim Uvarov wrote: > On 11/24/2015 02:10, Bill Fischofer wrote: > >> Ping. This trivial update still needs to be merged. >> > That was applied, might be I did not respond on that. > > I can see that now. Thanks. > Maxim. > >> >> On

Re: [lng-odp] [API-NEXT PATCHv12 0/3] Egress Traffic Manager

On Tuesday, November 24, 2015, Mike Holmes wrote: > > > On 24 November 2015 at 15:29, Bill Fischofer > wrote: > >> >> >> On Tuesday, November 24, 2015, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCHv12 0/3] Egress Traffic Manager

On 24 November 2015 at 15:29, Bill Fischofer wrote: > > > On Tuesday, November 24, 2015, Maxim Uvarov > wrote: > >> On 11/24/2015 21:31, Anders Roxell wrote: >> >>> On 2015-11-24 17:26, Maxim Uvarov wrote: >>> Merged! Patches

[lng-odp] Fwd: [lng-ci] Build failed in Jenkins: ODP tool check » api-next,m32_on_64,docker-utopic #263

api-next is broken with the TM commit 98e272e :2015-11-17 - linux-generic: tm: implement traffic manager -- Forwarded message -- From: Date: 24 November 2015 at 13:05 Subject: [lng-ci] Build failed in Jenkins: ODP tool check »

Re: [lng-odp] [API-NEXT PATCHv12 0/3] Egress Traffic Manager

On 2015-11-24 17:26, Maxim Uvarov wrote: > Merged! > > Patches were long time in the list for review, passed all validations tests > and all comments which > we got are fixed. I can see a number of problems by putting these patches in. 1. The author is not correctly set! It Should be Barry and

Re: [lng-odp] [API-NEXT PATCHv12 0/3] Egress Traffic Manager

On 11/24/2015 21:31, Anders Roxell wrote: On 2015-11-24 17:26, Maxim Uvarov wrote: Merged! Patches were long time in the list for review, passed all validations tests and all comments which we got are fixed. I can see a number of problems by putting these patches in. Good finding but

Re: [lng-odp] [API-NEXT PATCH v4 1/3] api: pool: add packet user area initializer for pool creation parameters

On 24/11/15 09:24, Savolainen, Petri (Nokia - FI/Espoo) wrote: diff --git a/include/odp/api/packet.h b/include/odp/api/packet.h index 3a454b5..f5d2142 100644 --- a/include/odp/api/packet.h +++ b/include/odp/api/packet.h @@ -73,6 +73,9 @@ extern "C" { *

Re: [lng-odp] [API-NEXT PATCH v4 1/3] api: pool: add packet user area initializer for pool creation parameters

> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Monday, November 23, 2015 7:11 PM > To: Savolainen, Petri (Nokia - FI/Espoo); EXT Maxim Uvarov; lng- > o...@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v4 1/3] api: pool: add packet user >

Re: [lng-odp] [PATCH v2] remove hard platform links

Reviewed-by: Nicolas Morey-Chaisemartin On 11/17/2015 10:40 PM, Mike Holmes wrote: > Signed-off-by: Mike Holmes > --- > example/Makefile.inc | 1 - > helper/Makefile.am | 1 - > test/Makefile.inc| 1 - > 3 files changed, 3 deletions(-) > > diff

Re: [lng-odp] [API-NEXT PATCHv2 2/5] linux-generic: internal header file changes to support odp_cls_cos_pool_set() api

I ran the ./apply-and-build.sh script in check_odp, which, among other things, tests whether the patch series is properly organized such that the result is buildable and the validation tests pass after each part is applied sequentially (necessary for biscectabilty of a patch series). It reports

Re: [lng-odp] PKTIN queues and polling

Multi queue may/will solve this in the long term but this is a current bug in the master branch. I don't by which miracle it has been working but the validation test should not work. I suggest that we comment out the _poll tests from pktio (to be put back later when it makes sense for

Re: [lng-odp] PKTIN queues and polling

The multi-queue pktio API has started the process for cleaner pktio queue definition. The goal is to remove ODP_QUEUE_TYPE_PKTIN queue type. Either application polls directly the interface queues or receives events through _POLL or _SCHED queues (which are well defined). Please review the

Re: [lng-odp] [API-NEXT PATCHv2 2/5] linux-generic: internal header file changes to support odp_cls_cos_pool_set() api

Hi Bill, As you have noted above, when all the 5 patches are applied together they will compile fine but patch 2 depends on patch 3 and it does not compile in parts as of now. I would like to get review on the patches in this setup and before upstreaming I will merge these patches to make sure

Re: [lng-odp] [API-NEXT PATCH] api: init: allow implementation to use private ways for its own configuration

Could anyone review this? Petri? On 18/11/15 16:22, Zoltan Kiss wrote: This could help the existing configuration methods to be used if the application prefers that. The platform_params should always supersede that though. Signed-off-by: Zoltan Kiss diff --git

Re: [lng-odp] [API-NEXT PATCHv12 0/3] Egress Traffic Manager

Merged! Patches were long time in the list for review, passed all validations tests and all comments which we got are fixed. Best regards, Maxim. On 11/18/2015 03:16, Bill Fischofer wrote: Changes in v12 - Refactor to enable serial apply-and-build Changes in v11 - Squash Parts 2 and 3 to

Re: [lng-odp] [PATCHv3 1/3] validation: ability to specify test install directory

On 2015-11-24 13:34, Stuart Haslam wrote: > Previously if a build had been configured with validation tests enabled > (--enable-test-vald) a subsequent "make install" would install the test > binaries and scripts into /usr/local/bin without any way of separating > them from the rest of the

[lng-odp] [API-NEXT PATCHv4 1/5] linux-generic: sockets: implement pktio statistics counters

Signed-off-by: Maxim Uvarov --- platform/linux-generic/Makefile.am | 2 + .../linux-generic/include/odp_packet_io_internal.h | 11 ++ platform/linux-generic/include/odp_packet_socket.h | 6 + platform/linux-generic/odp_packet_io.c | 53

[lng-odp] [PATCHv3 2/3] linux-generic: validation: add run-test script for post install testing

Add a run-test script that replicates some of the "make check" functionality without depending on a whole load of Makefile gubbins. This makes it easier to perform on-target testing following a cross-build (as we want to do in CI) and gives a simple way to verify that all the required components

[lng-odp] [PATCHv3 3/3] Makefile.am: run tests during distcheck

The distcheck target is intended to ensure that a built distribution will actually work. As part of the process it runs "make check" and "make installcheck", but these don't actually do much useful testing without the appropriate flags having been passed during configure. Signed-off-by: Stuart

Re: [lng-odp] [PATCH] doc/implementers-guide: fix broken doxygen build from tarball

Merged, Maxim. On 11/21/2015 23:25, Anders Roxell wrote: make[2]: Entering directory '/media/data/src/tmp/opendataplane-1.4.1.0.git45.g79c0b7e/doc/implementers-guide' make[2]: *** No rule to make target 'implementers-guide.adoc', needed by '../../doc/output/implementers-guide.html'.

Re: [lng-odp] [PATCH] doc: users-guide: move EXTRA_DIST down to its makefile

Merged, Maxim. On 11/23/2015 23:48, Anders Roxell wrote: Signed-off-by: Anders Roxell --- doc/Makefile.am | 3 +-- doc/users-guide/Makefile.am | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/Makefile.am b/doc/Makefile.am

[lng-odp] [API-NEXT PATCHv4 0/5] pktio statistics counters

v4: - fix Stuarts and Mikes comments. v3: - fix netmap (ethtool = 1); v2: - try to use ethtool for statistics counters if not fall back to sysfs. ( virtual veth devices do not support sysfs, netmap does not support sysfs.) - fix Stuarts comments for validation test suite. Maxim

[lng-odp] [API-NEXT PATCHv4 5/5] validation: implement pktio statistics counters

Signed-off-by: Maxim Uvarov --- test/validation/pktio/pktio.c | 163 ++ 1 file changed, 163 insertions(+) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index 0a6592c..8903039 100644 ---

[lng-odp] [API-NEXT PATCHv4 2/5] linux-generic: pktio loop: implement statistics counters

Signed-off-by: Maxim Uvarov --- platform/linux-generic/pktio/loop.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/pktio/loop.c b/platform/linux-generic/pktio/loop.c index 44da917..ac79f81

[lng-odp] [API-NEXT PATCHv4 3/5] linux-generic: pcap: implement pktio statistics counters

Signed-off-by: Maxim Uvarov --- platform/linux-generic/pktio/pcap.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/pktio/pcap.c b/platform/linux-generic/pktio/pcap.c index 94b506d..ebcf2c8 100644

[lng-odp] [API-NEXT PATCHv4 4/5] linux-generic: pktio netmap: implement statistics counters

Signed-off-by: Maxim Uvarov --- platform/linux-generic/pktio/netmap.c | 8 1 file changed, 8 insertions(+) diff --git a/platform/linux-generic/pktio/netmap.c b/platform/linux-generic/pktio/netmap.c index 20a144d..1986ba2 100644 ---

[lng-odp] [PATCHv3 1/3] validation: ability to specify test install directory

Previously if a build had been configured with validation tests enabled (--enable-test-vald) a subsequent "make install" would install the test binaries and scripts into /usr/local/bin without any way of separating them from the rest of the installed artefacts. This patch changes the default

Re: [lng-odp] [PATCH v2] remove hard platform links

Merged, Maxim. On 11/24/2015 13:53, Nicolas Morey-Chaisemartin wrote: Reviewed-by: Nicolas Morey-Chaisemartin On 11/17/2015 10:40 PM, Mike Holmes wrote: Signed-off-by: Mike Holmes --- example/Makefile.inc | 1 - helper/Makefile.am | 1 -

Re: [lng-odp] [API-NEXT PATCHv2 0/4] AES125-GCM support

Ping On 11/17/2015 04:43 PM, Nicolas Morey-Chaisemartin wrote: > I have prepared a serie to validate md5_check and sha265_check but as they > will conflict with this serie, i'll wait for it to get in first. > > Nicolas > > On 11/16/2015 02:07 PM, Nicolas Morey-Chaisemartin wrote: >> This patch

[lng-odp] [RFC] api: queue: remove ODP_QUEUE_TYPE_PKTIN

Type to use is now ODP_QUEUE_TYPE_POLL or ODP_QUEUE_TYPE_SCHED depending on the pktio it will be associated to. These queues behave as normal queues until they are associated to a pktio using odp_pktio_inq_setdef and will behave as standard queues after a call to odp_pktio_inq_remdef