[lng-odp] ODP v1.5.0.0 was released

Greetings, just tagged new v1.5.0.0 point release. New API for buffer, cpu, crypto, packet, queue and time. Also from now we can build rpm packages. Project change log now will be maintained in root directory CHANGELOG file instead of previously used debian specific. There are bunch of

[lng-odp] [PATCHv3] update version number from v1.4.1.0 to v1.5.0.0

From: Mike Holmes Signed-off-by: Mike Holmes Reviewed-by: Anders Roxell Signed-off-by: Maxim Uvarov --- -added docs changes Maxim. CHANGELOG | 45

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

> 在 2015年11月30日，下午11:04，Maxim Uvarov 写道： > > On 11/30/2015 11:18, HePeng wrote: >> Hi, Maxim, >> How is everything going, about the ring? > > > Hello Peng, > > We need to take a look it it's possible to rewrite your hash implementation > to odp queues api instead of

[lng-odp] [PATCH v2 1/3] Revert "update version number from v1.4.1.0 to v1.5.0.0"

This reverts commit 8cb80afde4a9e00cfea4bed5ecf721d6577793c4. Adding the RPM packaging requires a change to the way change logs are recorded for a release. Signed-off-by: Mike Holmes Reviewed-by: Anders Roxell --- include/odp/api/version.h |

[lng-odp] [PATCH v2 3/3] update version number from v1.4.1.0 to v1.5.0.0

Signed-off-by: Mike Holmes Reviewed-by: Anders Roxell --- CHANGELOG | 34 ++ include/odp/api/version.h | 4 ++-- pkg/debian/changelog | 5 + pkg/rpm/odp.spec | 2 ++ 4 files

[lng-odp] [PATCH v2 2/3] CHANGELOG: initial revision

With the addition of an RPM package to the existing debian package we need to have a single change log for the ODP API and the linux-generic implementation. The debian and RPM change logs then just list packaging changes. Create an initial copy of the old debian log. Signed-off-by: Mike Holmes

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Monday, November 30, 2015 8:13 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user > area init > > > > On

Re: [lng-odp] [API-NEXT PATCH v3 6/7] api: time: make odp_local_time to be monotonic wall time

On 01.12.15 09:38, Savolainen, Petri (Nokia - FI/Espoo) wrote: Why not just have one patch for API ... include/odp/api/time.h| 3 +- ... and move everything else in another patch(es). The old implementation and usage of the API is still functionally correct after

Re: [lng-odp] [API-NEXT PATCH v3 7/7] validation: time: align tests with current time API

On 01.12.15 09:56, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Monday, November 30, 2015 4:47 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT

Re: [lng-odp] [PATCH 3/3] update version number from v1.4.1.0 to v1.5.0.0

On 1 December 2015 at 15:58, Mike Holmes wrote: > > > On 1 December 2015 at 08:45, Maxim Uvarov wrote: >> >> On 11/30/2015 23:43, Mike Holmes wrote: >>> >>> Signed-off-by: Mike Holmes >>> --- >>> CHANGELOG

[lng-odp] [API-NEXT PATCH v4 7/9] linux-generic: align with new wall time API

The local time API supposes the time source is wall time. So correct linux-generic implementation. Signed-off-by: Ivan Khoronzhuk --- platform/linux-generic/include/odp_internal.h | 2 + platform/linux-generic/odp_schedule.c | 9 ++--

Re: [lng-odp] [PATCH 3/3] update version number from v1.4.1.0 to v1.5.0.0

On 1 December 2015 at 09:48, Bill Fischofer wrote: > Shouldn't the update log also mention the improved documentation as well? > Absolutely, part of this restructure is to allow a place for a human generated change log. During 1.6 I expect merged API-NEXT changes to

[lng-odp] [API-NEXT PATCH v5 1/9] validation: time: don't assign int directly to odp_time_t

Under opaque type can be structure that cannot be used with direct values, So, use conversion functions to get time_t to avoid build issues. Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[lng-odp] [API-NEXT PATCH v5 9/9] validation: time: align tests with current time API

Add test for odp_time_sum, odp_time_cmp, odp_time_to_u64 APIs. Sophisticate a little tests for odp_time_diff, odp_time_local_from_ns, odp_time_local_to_ns APIs. Check time on monotony. Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 228

[lng-odp] [API-NEXT PATCH v5 5/9] performance: sched: use ODP time API instead of clock_gettime

The time API can be used instead of Posix clock_gettime as more accurate and OS independent. Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_scheduling.c | 37 + 1 file changed, 9 insertions(+), 28 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v5 0/9] api: time: update local time to be monotonic

This series is intended to modify time API to be used as monotonic wall time in order to simplify time API usage and create prerequisites for adding global time API. Since v3: - "api: time: make odp_local_time to be monotonic wall time" splitted on; "linux-generic: align with new wall time

[lng-odp] [API-NEXT PATCH v5 2/9] test: performance: pktio: don't use direct arithmetic operations with odp_time_t

It was missed while unbinding cycles from time API names. Correct is as it prevents for adding structure under odp_time_t. Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_pktio_perf.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v5 4/9] linux-generic: odp_time: don't use cpu cycle API to get time

The linux-generic time API implementation shouldn't depend on cpu cycle API wich is not stable enough to measure time period due to dynamic frequency scaling. Signed-off-by: Ivan Khoronzhuk --- platform/linux-generic/Makefile.am | 1 -

[lng-odp] [API-NEXT PATCH v5 3/9] linux-generic: schedule: use schedule time in ns

In the schedule_loop the wait time is passed in units of scheduler time. At this moment there is no difference between wait time and odp_time, but in case if odp_time is smth different from uint64_t, it cannot be directly passed as uint64_t. So better to pass scheduler time as ns and convert them

[lng-odp] [API-NEXT PATCH v5 6/9] api: time: make odp_local_time to be monotonic wall time

It's more convenient the local time to be a monotonic wall time. That means time starts from 0 and not wraps. It allows to use local time in similar manner as it's supposed to be used with global time and the 64-bit timer is enough to guarantee it. Signed-off-by: Ivan Khoronzhuk

[lng-odp] [API-NEXT PATCH v5 8/9] test/example: use local time API as wall time

The local time API is supposed to behave like wall time now, so correct it in examples and tests. Signed-off-by: Ivan Khoronzhuk --- example/generator/odp_generator.c | 10 +- test/performance/odp_pktio_perf.c | 26 --

[lng-odp] [API-NEXT PATCH v5 7/9] linux-generic: align with new wall time API

The local time API supposes the time source is wall time. So correct linux-generic implementation. Signed-off-by: Ivan Khoronzhuk --- platform/linux-generic/include/odp_internal.h | 2 + platform/linux-generic/odp_schedule.c | 9 ++--

Re: [lng-odp] [API-NEXT PATCH v3 0/7] api: time: update local time to be monotonic

Petri, please review v5. On 23.11.15 23:20, Ivan Khoronzhuk wrote: This series is intended to modify time API to be used as monotonic wall time in order to simplify time API usage and create prerequisites for adding global time API. Since v2: - removed patch changing type of ODP_TIME_* - added

[lng-odp] [PATCH] linux-generic: schedule: set sched_local.pool correctly

This corrects bug https://bugs.linaro.org/show_bug.cgi?id=1921 Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_schedule.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/platform/linux-generic/odp_schedule.c b/platform/linux-generic/odp_schedule.c

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

On 05.11.15 13:20, huanggaoyang wrote: Signed-off-by: huanggaoyang --- helper/hashtable.c | 346 helper/odph_hashtable.h | 42 ++ helper/odph_list_internal.h | 85 +++ 3 files changed, 473

Re: [lng-odp] [PATCHv4 3/5] helper: table: add impl of lineartable

On 05.11.15 13:20, huanggaoyang wrote: Signed-off-by: huanggaoyang --- helper/lineartable.c | 210 ++ helper/odph_lineartable.h | 41 + 2 files changed, 251 insertions(+) create mode 100644

Re: [lng-odp] [PATCHv4 3/5] helper: table: add impl of lineartable

On 12/01/2015 15:25, Ivan Khoronzhuk wrote: --- /dev/null +++ b/helper/odph_lineartable.h @@ -0,0 +1,41 @@ +/* Copyright (c) 2015, Linaro Limited + * All rights reserved. + * + * SPDX-License-Identifier: BSD-3-Clause + */ + +/** + * @file + * + * ODP Linear Table + */ + +#ifndef

[lng-odp] [Bug 1921] New: sched_local.pool not set

https://bugs.linaro.org/show_bug.cgi?id=1921 Bug ID: 1921 Summary: sched_local.pool not set Product: OpenDataPlane - linux- generic reference Version: api-next Hardware: Other OS: Linux Status: UNCONFIRMED

Re: [lng-odp] [RFC] api: queue: remove ODP_QUEUE_TYPE_PKTIN

Otherwise reasonable change, but I was thinking to keep normal queue functionality with these queues, also when connected to packet input. So, I would not change function pointer on the fly, but mark the (default) packet input queue so that the dequeue operation calls pktio recv when the queue

Re: [lng-odp] [API-NEXT PATCH] api: init: allow implementation to use private ways for its own configuration

On 01/12/15 08:38, Savolainen, Petri (Nokia - FI/Espoo) wrote: // Fill defaults (from config file) // max_cpu = 64, max_mhz = 1000 (on this SoC) plat_xyz_config_init_params(_config); Again, I strongly oppose this way. It doesn't make any sense. Any decent applications should get the

Re: [lng-odp] [PATCHv4 3/5] helper: table: add impl of lineartable

On 01.12.15 14:41, Maxim Uvarov wrote: On 12/01/2015 15:25, Ivan Khoronzhuk wrote: --- /dev/null +++ b/helper/odph_lineartable.h @@ -0,0 +1,41 @@ +/* Copyright (c) 2015, Linaro Limited + * All rights reserved. + * + * SPDX-License-Identifier: BSD-3-Clause + */ + +/** + * @file + * + * ODP

Re: [lng-odp] [PATCH 3/3] update version number from v1.4.1.0 to v1.5.0.0

Shouldn't the update log also mention the improved documentation as well? On Tue, Dec 1, 2015 at 7:58 AM, Mike Holmes wrote: > > > On 1 December 2015 at 08:45, Maxim Uvarov wrote: > >> On 11/30/2015 23:43, Mike Holmes wrote: >> >>>

Re: [lng-odp] [API-NEXT PATCH 1/2] validation: synchronizers: add missing rwlock read lock functional test

Merged both. Maxim. On 10/29/2015 21:34, Bill Fischofer wrote: rwlock functional tests test for write locks, however they should also test for read locks. Signed-off-by: Bill Fischofer --- test/validation/synchronizers/synchronizers.c | 13 + 1 file

[lng-odp] [API-NEXT PATCH v4 0/9] api: time: update local time to be monotonic

This series is intended to modify time API to be used as monotonic wall time in order to simplify time API usage and create prerequisites for adding global time API. Since v3: - "api: time: make odp_local_time to be monotonic wall time" splitted on; "linux-generic: align with new wall time

[lng-odp] [API-NEXT PATCH v4 2/9] test: performance: pktio: don't use direct arithmetic operations with odp_time_t

It was missed while unbinding cycles from time API names. Correct is as it prevents for adding structure under odp_time_t. Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_pktio_perf.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v4 4/9] linux-generic: odp_time: don't use cpu cycle API to get time

The linux-generic time API implementation shouldn't depend on cpu cycle API wich is not stable enough to measure time period due to dynamic frequency scaling. Signed-off-by: Ivan Khoronzhuk --- platform/linux-generic/Makefile.am | 1 -

[lng-odp] [API-NEXT PATCH v4 3/9] linux-generic: schedule: use schedule time in ns

In the schedule_loop the wait time is passed in units of scheduler time. At this moment there is no difference between wait time and odp_time, but in case if odp_time is smth different from uint64_t, it cannot be directly passed as uint64_t. So better to pass scheduler time as ns and convert them

[lng-odp] [API-NEXT PATCH v4 8/9] test/example: use local time API as wall time

The local time API is supposed to behave like wall time now, so correct it in examples and tests. Signed-off-by: Ivan Khoronzhuk --- example/generator/odp_generator.c | 10 +- test/performance/odp_pktio_perf.c | 26 --

[lng-odp] [API-NEXT PATCH v4 5/9] performance: sched: use ODP time API instead of clock_gettime

The time API can be used instead of Posix clock_gettime as more accurate and OS independent. Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_scheduling.c | 37 + 1 file changed, 9 insertions(+), 28 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v4 6/9] api: time: make odp_local_time to be monotonic wall time

It's more convenient the local time to be a monotonic wall time. That means time starts from 0 and not wraps. It allows to use local time in similar manner as it's supposed to be used with global time and the 64-bit timer is enough to guarantee it. Signed-off-by: Ivan Khoronzhuk

Re: [lng-odp] [API-NEXT PATCH] linux-generic: tm: use intermediate casts to avoid strict warnings

Merged, Maxim. On 12/01/2015 00:41, Bill Fischofer wrote: Macros would probably be a good idea, however I wanted to get this fix in now and let Alex and/or Barry recommend further code restructure based on their more thorough analysis. This isn't the first time M32_ON_64 issues have been

[lng-odp] [API-NEXT PATCH v4 1/9] validation: time: don't assign int directly to odp_time_t

Under opaque type can be structure that cannot be used with direct values, So, use conversion functions to get time_t to avoid build issues. Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[lng-odp] [Bug 1921] sched_local.pool not set

https://bugs.linaro.org/show_bug.cgi?id=1921 --- Comment #1 from Bill Fischofer --- Patch http://patches.opendataplane.org/patch/3980/ submitted to correct this bug. -- You are receiving this mail because: You are on the CC list for the

Re: [lng-odp] [PATCH] linux-generic: schedule: set sched_local.pool correctly

I don't think there is any guarantee that all buffer returned by queue_deq_multi come from the same pool. So this should probably be updated when we copy an event out of the local cache at the beginning of schedule() Nicolas On 12/01/2015 02:14 PM, Bill Fischofer wrote: > This corrects bug

Re: [lng-odp] [PATCH] linux-generic: schedule: set sched_local.pool correctly

At least in the linux-generic implementation, we force max_deq to be 1 since we want consecutive events from an ordered queue to be dispatched to separate threads. There's no advantage to batching things as is done in parallel queues since if Thread A has events 1, 2,3, 4 while Thread B has

[lng-odp] [PATCH 0/2] helper: strong types support

For helpers it's also reasonable to have strong types support. Using basing linux-generic implementation for it. Maxim Uvarov (2): helper: strong types support helper: unbind hash from platform strong types helper/Makefile.am | 1 +

[lng-odp] [PATCH 2/2] helper: unbind hash from platform strong types

Signed-off-by: Maxim Uvarov --- helper/include/odp/helper/table.h | 5 - helper/odph_hashtable.h | 2 -- helper/odph_lineartable.h | 1 - 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/helper/include/odp/helper/table.h

[lng-odp] [PATCH 1/2] helper: strong types support

Add strong types support for helpers the same as we have for linux-generic. That should be useful for complex algorithms where type check is needed. Signed-off-by: Maxim Uvarov --- helper/Makefile.am | 1 + helper/include/odp/helper/strong_types.h

Re: [lng-odp] [PATCH 3/3] update version number from v1.4.1.0 to v1.5.0.0

On 11/30/2015 23:43, Mike Holmes wrote: Signed-off-by: Mike Holmes --- CHANGELOG | 34 ++ include/odp/api/version.h | 4 ++-- pkg/debian/changelog | 5 + pkg/rpm/odp.spec | 2 ++ 4 files changed,

Re: [lng-odp] [PATCH 3/3] update version number from v1.4.1.0 to v1.5.0.0

On 1 December 2015 at 08:45, Maxim Uvarov wrote: > On 11/30/2015 23:43, Mike Holmes wrote: > >> Signed-off-by: Mike Holmes >> --- >> CHANGELOG | 34 ++ >> include/odp/api/version.h | 4 ++-- >>

[lng-odp] [Bug 1921] sched_local.pool not set

https://bugs.linaro.org/show_bug.cgi?id=1921 Bill Fischofer changed: What|Removed |Added Ever confirmed|0 |1

Re: [lng-odp] [API-NEXT PATCH] api: pool: redefine packet user area init

On 01/12/15 08:29, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] Sent: Monday, November 30, 2015 8:13 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT PATCH]

Re: [lng-odp] [PATCH 0/2] helper: strong types support

Tested-by: Ivan Khoronzhuk On 01.12.15 15:27, Maxim Uvarov wrote: For helpers it's also reasonable to have strong types support. Using basing linux-generic implementation for it. Maxim Uvarov (2): helper: strong types support helper: unbind hash from platform