Ping. This patch needs a review as it fixes critical bug
https://bugs.linaro.org/show_bug.cgi?id=1930 that is breaking CI for
api-next.
Thanks.
On Wed, Dec 2, 2015 at 3:56 PM, Bill Fischofer
wrote:
> Change the internal hash_name_and_kind() function to eliminate the use
> of architecture-speci
On Thu, Dec 3, 2015 at 5:22 AM, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
>
> Couple of small things still, with those fixed:
>
> Reviewed-by: Petri Savolainen
>
>
>
>
> > -Original Message-
> > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Beh
Fixes Bug 1905 - CID 154167:
Calling strncpy with a maximum size argument of ODP_TABLE_NAME_LEN
bytes on destination array tbl->name of size ODP_TABLE_NAME_LEN bytes
might leave the destination string unterminated if the copied string is
also of the maximum size ODP_TABLE_NAME_LEN.
Make the copy
On 03/12/15 09:52, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Why? Why do you need to access the packet, when it's not yet a packet
(at init time)? You'll get handle after the packet is received (when it's
a packet).
I think I've explained it several times why this whole thing is
necessary,
In case if smth bad was happened and events are not received,
it's better finish than looping forever.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/scheduler/scheduler.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/test/validation/scheduler/scheduler.c
b/
https://bugs.linaro.org/show_bug.cgi?id=1905
Mike Holmes changed:
What|Removed |Added
Assignee|lng-odp@lists.linaro.org|mike.hol...@linaro.org
--
You are receiving thi
Merged,
Maxim.
On 12/02/2015 15:25, Ivan Khoronzhuk wrote:
On 02.12.15 14:05, Bill Fischofer wrote:
Change CU_ASSERT order to avoid side effect issues identified by
Coverity
Signed-off-by: Bill Fischofer
Reviewed-by: Ivan Khoronzhuk
---
test/validation/queue/queue.c | 3 ++-
1 file
https://bugs.linaro.org/show_bug.cgi?id=1833
Bala Manoharan changed:
What|Removed |Added
Depends on||1698
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1698
Bala Manoharan changed:
What|Removed |Added
Blocks||1541
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1541
Bala Manoharan changed:
What|Removed |Added
Depends on||1698
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1698
Bala Manoharan changed:
What|Removed |Added
Blocks||1834
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1698
Bala Manoharan changed:
What|Removed |Added
Blocks||1833
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1834
Bala Manoharan changed:
What|Removed |Added
Depends on||1698
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1698
Bala Manoharan changed:
What|Removed |Added
Blocks||1832
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1832
Bala Manoharan changed:
What|Removed |Added
Depends on||1698
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1698
Bala Manoharan changed:
What|Removed |Added
Blocks||1831
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1831
Bala Manoharan changed:
What|Removed |Added
Depends on||1698
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1698
Bala Manoharan changed:
What|Removed |Added
Blocks||1829
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1829
Bala Manoharan changed:
What|Removed |Added
Depends on||1698
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1827
Bala Manoharan changed:
What|Removed |Added
Depends on||1698
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1698
Bala Manoharan changed:
What|Removed |Added
Blocks||1826
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1698
Bala Manoharan changed:
What|Removed |Added
Blocks||1827
Referenced Bugs:
https://bugs.linaro.o
https://bugs.linaro.org/show_bug.cgi?id=1826
Bala Manoharan changed:
What|Removed |Added
Depends on||1698
Referenced Bugs:
https://bugs.linaro.o
On 03/12/15 15:02, Savolainen, Petri (Nokia - FI/Espoo) wrote:
-Original Message-
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
Zoltan Kiss
Sent: Thursday, December 03, 2015 4:30 PM
To: Nicolas Morey-Chaisemartin; lng-odp@lists.linaro.org
Subject: Re: [lng-
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Zoltan Kiss
> Sent: Thursday, December 03, 2015 4:30 PM
> To: Nicolas Morey-Chaisemartin; lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [API-NEXTv6 1/7] api: buffer: add functions to
> al
On Thu, Dec 3, 2015 at 8:30 AM, Zoltan Kiss wrote:
> Hi,
>
> I know it's a late cry, but I've found two problems while implementing
> this for ODP-DPDK, and the apply for odp_packet_alloc_multi() as well. See
> inline:
>
> On 28/10/15 15:31, Nicolas Morey-Chaisemartin wrote:
>
>> Signed-off-by: N
A documentation patch to that effect would be good. I'll submit one.
On Thu, Dec 3, 2015 at 8:27 AM, Zoltan Kiss wrote:
>
>
> On 03/12/15 13:38, Bill Fischofer wrote:
>
>> odp_packet_alloc() includes an explicit check that the pool is of packet
>> type, however odp_buffer_alloc() does not. At
Looks good. Feedback to the surveyor: it's OpenDataPlane, not Open Data
Plane. I notice that they have the spacing around OpenDaylight correct.
On Thu, Dec 3, 2015 at 8:39 AM, Bob Monkman wrote:
> All,
>
> Here is the official posting of the presentation at OPNFV
> Summit site…
All,
Here is the official posting of the presentation at OPNFV
Summit site...
http://events.linuxfoundation.org/sites/events/files/slides/OPNFV%20survey%20results%20presentation-%20R%20Roseboro_0.pdf
Regards,
Bob
Robert (Bob) Monkman
Enterprise Segment Marketing Manager
150 Rose
Hi,
I know it's a late cry, but I've found two problems while implementing
this for ODP-DPDK, and the apply for odp_packet_alloc_multi() as well.
See inline:
On 28/10/15 15:31, Nicolas Morey-Chaisemartin wrote:
Signed-off-by: Nicolas Morey-Chaisemartin
Reviewed-by: Petri Savolainen
---
i
https://bugs.linaro.org/show_bug.cgi?id=1698
--- Comment #4 from Bala Manoharan ---
v4 patch submitted: https://patches.linaro.org/57874/
API review complete.
Waiting for review of implementation, validation and exampl
--
You are receiving this mail because:
You are on the CC list for the bug.
On 03/12/15 13:38, Bill Fischofer wrote:
odp_packet_alloc() includes an explicit check that the pool is of packet
type, however odp_buffer_alloc() does not. At least in linux-generic
they all use common structures so odp_buffer_alloc() will work with any
pool type. We could make that stricter
Entire patch set:
Reviewed-by: Petri Savolainen
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Ivan Khoronzhuk
> Sent: Thursday, December 03, 2015 2:49 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCH v6] 0/9] api
> >>
> >> Both local and global timestamp calls can directly return a global HW
> counter value (zeroed at ODP init) when it's defined like this.
> >>
> >> If user really needs thread life time, we can add
> odp_thread_life_time() API call for that.
> >>
> >>
> >> -Petri
> >>
> >
> > Is it supposed
It does miss it apparently - just shows you we still need a human eye
mike@mike-desktop:~/git/odp$ git format-patch -1 a775afd
0001-helper-table-add-impl-of-hashtable.patch
mike@mike-desktop:~/git/odp$ ./scripts/checkpatch.pl
0001-helper-table-add-impl-of-hashtable.patch
total: 0 errors, 0 warning
odp_packet_alloc() includes an explicit check that the pool is of packet
type, however odp_buffer_alloc() does not. At least in linux-generic they
all use common structures so odp_buffer_alloc() will work with any pool
type. We could make that stricter either by adding explicit checks for
pool ty
Hi,
A quick question: should odp_buffer_alloc() work with
non-ODP_POOL_BUFFER pools? ODP-DPDK implementation works with packet
ones as well, but I think it doesn't make too much sense. Probably we
should mention it on the API definition that the pool should be of
ODP_POOL_BUFFER type
___
On 05.11.15 13:20, huanggaoyang wrote:
Signed-off-by: huanggaoyang
---
helper/lineartable.c | 210 ++
helper/odph_lineartable.h | 41 +
2 files changed, 251 insertions(+)
create mode 100644 helper/lineartable.c
create mode 100644
On 05.11.15 13:20, huanggaoyang wrote:
Signed-off-by: huanggaoyang
---
helper/hashtable.c | 346
helper/odph_hashtable.h | 42 ++
helper/odph_list_internal.h | 85 +++
3 files changed, 473 insertions(+)
create mode
It's in master already but I wonder how checkpatch missed it.
On 05.11.15 13:20, huanggaoyang wrote:
Signed-off-by: huanggaoyang
---
helper/hashtable.c | 346
helper/odph_hashtable.h | 42 ++
helper/odph_list_internal.h | 85 ++
Signed-off-by: Ivan Khoronzhuk
---
platform/linux-generic/odp_init.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/platform/linux-generic/odp_init.c
b/platform/linux-generic/odp_init.c
index 5e19d86..087bfdf 100644
--- a/platform/linux-generic/odp_init.c
+++ b/platform/
The local time API is supposed to behave like wall time now,
so correct it in examples and tests.
Signed-off-by: Ivan Khoronzhuk
---
example/generator/odp_generator.c | 10 +-
test/performance/odp_pktio_perf.c | 26 --
test/validation/pktio/pktio.c | 21 ++
Add test for odp_time_sum, odp_time_cmp, odp_time_to_u64 APIs.
Sophisticate a little tests for odp_time_diff, odp_time_local_from_ns,
odp_time_local_to_ns APIs. Check time on monotony.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/time/time.c | 228 +++---
The local time API supposes the time source is wall time.
So correct linux-generic implementation.
Signed-off-by: Ivan Khoronzhuk
---
platform/linux-generic/include/odp_internal.h | 2 +
platform/linux-generic/odp_init.c | 4 ++
platform/linux-generic/odp_schedule.c | 9 ++
It's more convenient the local time to be a monotonic wall time.
That means time starts from 0 and not wraps. It allows to use local
time in similar manner as it's supposed to be used with global time
and the 64-bit timer is enough to guarantee it.
Signed-off-by: Ivan Khoronzhuk
---
include/odp/
The time API can be used instead of Posix clock_gettime as more
accurate and OS independent.
Signed-off-by: Ivan Khoronzhuk
---
test/performance/odp_scheduling.c | 37 +
1 file changed, 9 insertions(+), 28 deletions(-)
diff --git a/test/performance/odp_schedu
The linux-generic time API implementation shouldn't depend on cpu
cycle API wich is not stable enough to measure time period due to
dynamic frequency scaling.
Signed-off-by: Ivan Khoronzhuk
---
platform/linux-generic/Makefile.am | 1 -
.../linux-generic/include/odp/plat/time_typ
In the schedule_loop the wait time is passed in units of scheduler
time. At this moment there is no difference between wait time and
odp_time, but in case if odp_time is smth different from uint64_t,
it cannot be directly passed as uint64_t. So better to pass scheduler
time as ns and convert them b
It was missed while unbinding cycles from time API names.
Correct is as it prevents for adding structure under odp_time_t.
Signed-off-by: Ivan Khoronzhuk
---
test/performance/odp_pktio_perf.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/test/performance/odp_pktio_p
Under opaque type can be structure that cannot be used with direct
values, So, use conversion functions to get time_t to avoid build
issues.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/time/time.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/validation/time
This series is intended to modify time API to be used as monotonic wall
time in order to simplify time API usage and create prerequisites for
adding global time API.
Since v5
linux-generic: align with new wall time API
- deleted _odp prefix for local functions
- avoided modulo operation
- used c
On Tue, Nov 24, 2015 at 04:10:44PM +0300, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov
> ---
> platform/linux-generic/Makefile.am | 2 +
> .../linux-generic/include/odp_packet_io_internal.h | 11 ++
> platform/linux-generic/include/odp_packet_socket.h | 6 +
> platform/l
On 03.12.15 14:10, Ivan Khoronzhuk wrote:
On 02.12.15 14:07, Savolainen, Petri (Nokia - FI/Espoo) wrote:
-Original Message-
From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org]
Sent: Wednesday, December 02, 2015 1:56 PM
To: Savolainen, Petri (Nokia - FI/Espoo); LNG ODP Ma
On 02.12.15 14:07, Savolainen, Petri (Nokia - FI/Espoo) wrote:
-Original Message-
From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org]
Sent: Wednesday, December 02, 2015 1:56 PM
To: Savolainen, Petri (Nokia - FI/Espoo); LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT P
Timer API requires event types instead of buffer types.
This patch corrects it.
Signed-off-by: Ivan Khoronzhuk
---
platform/linux-generic/include/odp/timer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/platform/linux-generic/include/odp/timer.h
b/platform/linux-generic/i
No need to include all headers in hashtable and lineartable.
rwlock and shared_memory is enough. It allows to see which odp
parts are used.
Signed-off-by: Ivan Khoronzhuk
---
helper/hashtable.c | 3 ++-
helper/lineartable.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git
Couple of small things still, with those fixed:
Reviewed-by: Petri Savolainen
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Balasubramanian Manoharan
> Sent: Thursday, December 03, 2015 12:46 PM
> To: lng-odp@lists.linaro.org
> Subj
I have sent V4 correcting the issues pointed above.
Regards,
Bala
On 3 December 2015 at 14:49, Savolainen, Petri (Nokia - FI/Espoo)
wrote:
>
>
>> -Original Message-
>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
>> Balasubramanian Manoharan
>> Sent: Thursday,
Adds packet pool to CoS using odp_cls_cos_pool_set() api.
Signed-off-by: Balasubramanian Manoharan
---
example/classifier/odp_classifier.c | 125 +++-
1 file changed, 96 insertions(+), 29 deletions(-)
diff --git a/example/classifier/odp_classifier.c
b/example/cl
Adds support for configuring packet pool to a class-of-service.
linux-generic packet parser is enhanced to parse a packet directly from
a memory location rather than from odp_packet_t.
packet receive code is modified to run packet classifier directly from
the stream so that the packet can be alloc
Assigns a packet pool to CoS using odp_cls_cos_pool_set() api.
Signed-off-by: Balasubramanian Manoharan
---
.../classification/odp_classification_test_pmr.c | 279 +
.../classification/odp_classification_tests.c | 139 ++
.../classification/odp_classification_t
odp_cls_cos_pool_set() api is used to configure packet pool to CoS.
The packets arriving at the CoS is allocated from the configured pool
Signed-off-by: Balasubramanian Manoharan
---
v4: Adds detailed api description
v3: Test Cases added to test pools associated with CoS
v2: Incorporates review
https://bugs.linaro.org/show_bug.cgi?id=1830
--- Comment #2 from Bala Manoharan ---
*** Bug 1543 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.___
lng-odp mailing list
lng-od
https://bugs.linaro.org/show_bug.cgi?id=1543
Bala Manoharan changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Status|IN_PROGRESS
https://bugs.linaro.org/show_bug.cgi?id=1830
--- Comment #1 from Bala Manoharan ---
v1 submitted: https://patches.linaro.org/57869/
--
You are receiving this mail because:
You are on the CC list for the bug.___
lng-odp mailing list
lng-odp@lists.linar
fixes: https://bugs.linaro.org/show_bug.cgi?id=1830
Signed-off-by: Balasubramanian Manoharan
---
.../classification/odp_classification_common.c | 4 +-
.../classification/odp_classification_test_pmr.c | 85 ++
2 files changed, 87 insertions(+), 2 deletions(-)
diff --g
> > Why? Why do you need to access the packet, when it's not yet a packet
> (at init time)? You'll get handle after the packet is received (when it's
> a packet).
>
> I think I've explained it several times why this whole thing is
> necessary, but let me try again: OVS needs to store the packet ha
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Balasubramanian Manoharan
> Sent: Thursday, December 03, 2015 10:17 AM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT/PATCHv3 1/4] api: classification: add
> odp_cls_cos_pool_s
https://bugs.linaro.org/show_bug.cgi?id=1698
--- Comment #3 from Bala Manoharan ---
V3 patch submitted: https://patches.linaro.org/57862/
--
You are receiving this mail because:
You are on the CC list for the bug.___
lng-odp mailing list
lng-odp@lists
Adds support for configuring packet pool to a class-of-service.
linux-generic packet parser is enhanced to parse a packet directly from
a memory location rather than from odp_packet_t.
packet receive code is modified to run packet classifier directly from
the stream so that the packet can be alloc
Assigns a packet pool to CoS using odp_cls_cos_pool_set() api.
Signed-off-by: Balasubramanian Manoharan
---
.../classification/odp_classification_test_pmr.c | 279 +
.../classification/odp_classification_tests.c | 139 ++
.../classification/odp_classification_t
Adds packet pool to CoS using odp_cls_cos_pool_set() api.
Signed-off-by: Balasubramanian Manoharan
---
example/classifier/odp_classifier.c | 125 +++-
1 file changed, 96 insertions(+), 29 deletions(-)
diff --git a/example/classifier/odp_classifier.c
b/example/cl
odp_cls_cos_pool_set() api is used to configure packet pool to CoS.
The packets arriving at the CoS is allocated from the configured pool
Signed-off-by: Balasubramanian Manoharan
---
v3: Test Cases added to test pools associated with CoS
v2: Incorporates review comments from Stuart
include/odp/
73 matches
Mail list logo
