Re: [lng-odp] [API-NEXT PATCH v3] api: atomic: added atomic_lock_free_u64

ping. > -Original Message- > From: Savolainen, Petri (Nokia - FI/Espoo) > Sent: Thursday, November 26, 2015 10:56 AM > To: lng-odp@lists.linaro.org > Subject: RE: [lng-odp] [API-NEXT PATCH v3] api: atomic: added > atomic_lock_free_u64 > > ping. > > > -Original Message- > > From:

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

Bill, hash_tbl_entry is now uintptr_t, which is 64 bits on a 64 bit build and 32 bits on a 32 bit build. These shifts and all other lines that expect that hash_tbl_entry (pointer size) is 64 bits should be updated also. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun

Re: [lng-odp] [PATCHv3] helper : Fix UDP checksum computation

On 07.12.2015 18:43, ion.grig...@freescale.com wrote: > From: Grigore Ion > > This patch fixes the following problems: > - checksum computation for LE platforms > - checksum is computed in the CPU endianness. The returned result > must be converted to the BE ordering when it is used to update > t

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

Hi Maxim, I implement a new version of cuckoo hash based on the ODP buffer/pool. As I’ve mentioned earlier, the use of ring in cuckoo hash is like to the use of a container, e.g. a queue in C++ STL. In current ODP implementation, I found that the ODP queue is implemented mor

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

./build-all.sh for me insists that crc32w isn't supported on ARM, despite the fact that the patch removes those references. So it looks like the check-odp stuff is still flagging errors with the broken api-next rather than testing the patch that fixes these. It's confusing trying to see what chec

Re: [lng-odp] [PATCH] queue: fix memory corruption in reorder_enq()

At present reorder_enq() is the only routine that takes advantage of that relationship. As to your other question, reorder_tail exists because the reorder queue is a queue, however elements on it are sorted by order rather than arrival time. The tail is used because dequeues can dequeue multiple e

Re: [lng-odp] [PATCH] queue: fix memory corruption in reorder_enq()

On 07/12/15 17:54, Bill Fischofer wrote: BTW, this is why you see in the linux-generic version of odp_buffer_internal.h the comment: /* Common buffer header */ struct odp_buffer_hdr_t { struct odp_buffer_hdr_t *next; /* next buf in a list--keep 1st */ Since you've split this file for li

Re: [lng-odp] [PATCH] queue: fix memory corruption in reorder_enq()

On 07/12/15 17:52, Bill Fischofer wrote: You're seeing this because in linux-dpdk the next field of the odp_buffer_hdr_t is not at offset 0. In linux-generic next is at offset zero so this code is slightly more efficient. So this change really should be in the linux-dpdk version of this code

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

On 12/07/2015 20:14, Bill Fischofer wrote: v1 should not have that problem. What error do you get when trying that? check-odp with M32_ON_64 works fine for me. export GIT_ODP=/opt/Linaro/odp2.git export CLEANUP=1 export GIT_BRANCH=`(cd $GIT_ODP; git symbolic-ref HEAD | cut -d / -f 3)` ./build

Re: [lng-odp] [PATCH] doc: userguide: add application programming section

v2 posted. Thanks. On Mon, Dec 7, 2015 at 11:42 AM, Mike Holmes wrote: > > > On 6 December 2015 at 21:33, Bill Fischofer > wrote: > >> Continue the refinement of the user guide, > > This relative comment won't mean much in the git log in future > > Maybe > Reformatted to standard asciidoc styl

[lng-odp] [PATCHv2] doc: userguide: add application programming section

Continue the refinement of the user guide, completing the reformatting to standard asciidoc style and expanding the ODP Applicaition Programming section, including a reorganized and expanded discussion of ODP queues. Signed-off-by: Bill Fischofer --- doc/users-guide/users-guide.adoc | 451 ++

Re: [lng-odp] [PATCH] queue: fix memory corruption in reorder_enq()

BTW, this is why you see in the linux-generic version of odp_buffer_internal.h the comment: /* Common buffer header */ struct odp_buffer_hdr_t { struct odp_buffer_hdr_t *next; /* next buf in a list--keep 1st */ Since you've split this file for linux-dpdk to be consistent you should also spl

Re: [lng-odp] [PATCH] queue: fix memory corruption in reorder_enq()

You're seeing this because in linux-dpdk the next field of the odp_buffer_hdr_t is not at offset 0. In linux-generic next is at offset zero so this code is slightly more efficient. So this change really should be in the linux-dpdk version of this code rather than linux-generic. However the perfo

Re: [lng-odp] [PATCH] doc: userguide: add application programming section

On 6 December 2015 at 21:33, Bill Fischofer wrote: > Continue the refinement of the user guide, This relative comment won't mean much in the git log in future Maybe Reformatted to standard asciidoc style Expanded the ODP Application Programming section Reorganized and expanded the discussion of

Re: [lng-odp] [PATCH] queue: fix memory corruption in reorder_enq()

Maxim, Bill, please check this ASAP, and if feasible commit it to master, it blocks ODP-DPDK upgrade to 1.5 Zoli On 07/12/15 17:33, Zoltan Kiss wrote: reorder_prev is set to the address of the pointer origin_qe->s.reorder_head, which is wrong. If the linked list was empty, that won't be correc

[lng-odp] [PATCH] queue: fix memory corruption in reorder_enq()

reorder_prev is set to the address of the pointer origin_qe->s.reorder_head, which is wrong. If the linked list was empty, that won't be corrected, and reorder_prev->next points to the adjacent queue entry's status field. If that entry is used, that queue's metadata will be corrupted. This was foun

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

v1 should not have that problem. What error do you get when trying that? check-odp with M32_ON_64 works fine for me. On Mon, Dec 7, 2015 at 9:01 AM, Maxim Uvarov wrote: > shift still is not fixed: > > odp_name_table.c:186:4: error: right shift count >= width of type [-Werror] > if ((hash_t

Re: [lng-odp] Fwd: [lng-ci] Build failed in Jenkins: ODP tool check » api-next,m32_on_64,docker-utopic #263

Also, Petri, what level of the code did you get that diagnostic from? The flagged line in the current code is line 383, not 570, and reads: hash_tbl_entry = (hash_tbl_entry_t)(uintptr_t)name_tbl_entry; On Mon, Dec 7, 2015 at 10:58 AM, Bill Fischofer wrote: > Ok, I'm confused. Maxim reports

Re: [lng-odp] Fwd: [lng-ci] Build failed in Jenkins: ODP tool check » api-next,m32_on_64,docker-utopic #263

Ok, I'm confused. Maxim reports that changing that typedef to uintptr_t fails in 32-bit environments. I just changed it back to uint64_t and verified that check-odp build.sh with M32_ON_64=1 compiles and verifies successfully for me. A uint64_t should be a 64-bit quantity regardless of whether t

Re: [lng-odp] [PATCHv1] helper:test: Fix UDP checksum computation

The comparison is done in the CPU endianness. Thanks, Grig -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Monday, December 07, 2015 5:06 PM To: Grigore Ion-B17953 ; lng-odp@lists.linaro.org Cc: Maxim Uvarov Subject: Re: [PATCHv1] helper:test: Fix UDP check

Re: [lng-odp] [PATCH] doc: build users and implementers guide in the build tree instead of the source tree

Sorry, hit send before finished, but you get the idea. The Images makefile is greatly simplified in this way. On 7 December 2015 at 10:56, Mike Holmes wrote: > I played with this a little and picking up on a suggestion by Anders we > can generally clean up all the doc make files, the im > > the

Re: [lng-odp] [PATCH] doc: build users and implementers guide in the build tree instead of the source tree

I played with this a little and picking up on a suggestion by Anders we can generally clean up all the doc make files, the im the user guide one for instance can use the suffix rules .adoc.html: asciidoc -a imagesdir=$(top_src_dir)/doc/images -b html5 -a icons -a toc2 -a max-width=55em --out-fi

Re: [lng-odp] [PATCHv1] helper:test: Fix UDP checksum computation

Done. Patch v3 Grig -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim Uvarov Sent: Monday, December 07, 2015 4:50 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCHv1] helper:test: Fix UDP checksum computation I tried to say in pre

[lng-odp] [PATCHv3] helper : Fix UDP checksum computation

From: Grigore Ion This patch fixes the following problems: - checksum computation for LE platforms - checksum is computed in the CPU endianness. The returned result must be converted to the BE ordering when it is used to update the UDP checksum in a packet. - checksum computation for packets havi

Re: [lng-odp] [API-NEXT/PATCH] fix: build fix in arm platform

Merged with rename to: linux-generic: packet: _odp_parse_common: arm build fix Maxim. On 12/07/2015 15:40, Balasubramanian Manoharan wrote: Fixes arm build failure due to wrong typecast of 'const' variable Signed-off-by: Balasubramanian Manoharan Reviewed-by: Maxim Uvarov --- platform/linu

Re: [lng-odp] [PATCHv1] helper:test: Fix UDP checksum computation

On 07.12.2015 17:29, ion.grig...@freescale.com wrote: > From: Grigore Ion > > The UDP checksum is computed in the CPU endianness. The returned result > must be converted to the BE ordering when it is used to update the UDP > checksum in a packet. > > Signed-off-by: Grigore Ion > --- > v1: > Fix

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

shift still is not fixed: odp_name_table.c:186:4: error: right shift count >= width of type [-Werror] if ((hash_tbl_entry >> 48) == 0x7FFF) ^ odp_name_table.c:188:4: error: right shift count >= width of type [-Werror] else if ((hash_tbl_entry >> 48) == 0) On 12/07/2015 14:09, Bill F

Re: [lng-odp] [PATCHv1] helper:test: Fix UDP checksum computation

I tried to say in previous message to merge that chunk to previous patch. So it will be 1 patch which fixes both tests and validation. Just to avoid PASS->FAILED->PASS test sequence doing bisecting. Maxim. On 12/07/2015 17:29, ion.grig...@freescale.com wrote: From: Grigore Ion The UDP check

Re: [lng-odp] [PATCHv2] helper : Fix UDP checksum computation

Hi, I just sent the patch. Thanks, Grig -Original Message- From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Monday, December 07, 2015 3:52 PM To: Grigore Ion-B17953 ; lng-odp@lists.linaro.org Cc: Grigore Sebastian-SGRIGOR1 Subject: Re: [lng-odp] [PATCHv2] helper : Fix UDP chec

[lng-odp] [PATCHv1] helper:test: Fix UDP checksum computation

From: Grigore Ion The UDP checksum is computed in the CPU endianness. The returned result must be converted to the BE ordering when it is used to update the UDP checksum in a packet. Signed-off-by: Grigore Ion --- v1: Fix UDP checksum computation helper/test/odp_chksum.c | 4 ++-- 1 file chan

[lng-odp] [PATCH] linux-generic: socket: set up __odp_errno on ioctl failures

Also debug output enhanced. Signed-off-by: Ilya Maximets --- platform/linux-generic/pktio/socket.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/platform/linux-generic/pktio/socket.c b/platform/linux-generic/pktio/socket.c index 5f5e0ae..ef2e031 100644 --

[lng-odp] [Bug 1832] Untested internal API verify_pmr_ipv6_saddr

https://bugs.linaro.org/show_bug.cgi?id=1832 Bug 1832 depends on bug 1698, which changed state. Bug 1698 Summary: No support for CoS drop policies https://bugs.linaro.org/show_bug.cgi?id=1698 What|Removed |Added --

[lng-odp] [Bug 1834] Untested internal API verify_pmr_dmac

https://bugs.linaro.org/show_bug.cgi?id=1834 Bug 1834 depends on bug 1698, which changed state. Bug 1698 Summary: No support for CoS drop policies https://bugs.linaro.org/show_bug.cgi?id=1698 What|Removed |Added --

[lng-odp] [Bug 1826] Untested internal APIs verify_pmr_eth_type_0

https://bugs.linaro.org/show_bug.cgi?id=1826 Bug 1826 depends on bug 1698, which changed state. Bug 1698 Summary: No support for CoS drop policies https://bugs.linaro.org/show_bug.cgi?id=1698 What|Removed |Added --

[lng-odp] [Bug 1829] Untested internal API verify_pmr_ipsec_spi

https://bugs.linaro.org/show_bug.cgi?id=1829 Bug 1829 depends on bug 1698, which changed state. Bug 1698 Summary: No support for CoS drop policies https://bugs.linaro.org/show_bug.cgi?id=1698 What|Removed |Added --

[lng-odp] [Bug 1831] Untested internal API verify_pmr_ipv6_daddr

https://bugs.linaro.org/show_bug.cgi?id=1831 Bug 1831 depends on bug 1698, which changed state. Bug 1698 Summary: No support for CoS drop policies https://bugs.linaro.org/show_bug.cgi?id=1698 What|Removed |Added --

[lng-odp] [Bug 1698] No support for CoS drop policies

https://bugs.linaro.org/show_bug.cgi?id=1698 Bala Manoharan changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[lng-odp] [Bug 1827] Untested internal API verify_pmr_eth_type_x

https://bugs.linaro.org/show_bug.cgi?id=1827 Bug 1827 depends on bug 1698, which changed state. Bug 1698 Summary: No support for CoS drop policies https://bugs.linaro.org/show_bug.cgi?id=1698 What|Removed |Added --

[lng-odp] [Bug 1833] Untested internal API verify_pmr_ld_vni

https://bugs.linaro.org/show_bug.cgi?id=1833 Bug 1833 depends on bug 1698, which changed state. Bug 1698 Summary: No support for CoS drop policies https://bugs.linaro.org/show_bug.cgi?id=1698 What|Removed |Added --

[lng-odp] [Bug 1541] Untested API verify_pmr_packet_len

https://bugs.linaro.org/show_bug.cgi?id=1541 Bug 1541 depends on bug 1698, which changed state. Bug 1698 Summary: No support for CoS drop policies https://bugs.linaro.org/show_bug.cgi?id=1698 What|Removed |Added --

[lng-odp] [Bug 1698] No support for CoS drop policies

https://bugs.linaro.org/show_bug.cgi?id=1698 --- Comment #5 from Bala Manoharan --- commit 8cf523f1f5b7280386f6c4c4d2bf9a68619aef1c Author: Balasubramanian Manoharan Date: Thu Dec 3 16:16:03 2015 +0530 api: classification: add odp_cls_cos_pool_set() api odp_cls_cos_pool_set() api is

Re: [lng-odp] [PATCHv2] helper : Fix UDP checksum computation

On 12/07/2015 16:35, Ion Grigore wrote: Hi Maxim, I noticed you merged this patch and then you reverted it because the validation test fails. The problem is in the test not in the patch. odp_checksum.c from line 192 udp->chksum = odp_cpu_to_be_16(odph_ipv4_udp_chksum(test_packet));

Re: [lng-odp] [PATCHv2] helper : Fix UDP checksum computation

Hi Maxim, I noticed you merged this patch and then you reverted it because the validation test fails. The problem is in the test not in the patch. odp_checksum.c from line 192 udp->chksum = odp_cpu_to_be_16(odph_ipv4_udp_chksum(test_packet)); if (udp->chksum == 0)

[lng-odp] [PATCH] api: classification: alignment correction of function definition

Adds additional space before function definition Signed-off-by: Balasubramanian Manoharan --- include/odp/api/classification.h | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/include/odp/api/classification.h b/include/odp/api/classif

[lng-odp] [API-NEXT/PATCH] fix: build fix in arm platform

Fixes arm build failure due to wrong typecast of 'const' variable Signed-off-by: Balasubramanian Manoharan Reviewed-by: Maxim Uvarov --- platform/linux-generic/odp_packet.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/platform/linux-generic/odp_packet

Re: [lng-odp] [PATCH] doc: guides: embed icons and images in html

Merged, Maxim. On 12/05/2015 05:24, Bill Fischofer wrote: On Fri, Dec 4, 2015 at 2:46 PM, Mike Holmes > wrote: The icons in the generated guide have a system dependent location. If the system used to view the docs does not have asciidoc installed no

Re: [lng-odp] [PATCH] validation: scheduler: use fail timeout when waiting on events in chaos

Sorry, replayed to wrong email window. But I caught that bug only after applying that patch. On previous patch it tools said that everything is ok. That patch is applied. Maxim. On 12/07/2015 14:37, Bill Fischofer wrote: That test makes no references to odp_chksum, so I'm not sure what the in

Re: [lng-odp] [PATCH] validation: scheduler: use fail timeout when waiting on events in chaos

That test makes no references to odp_chksum, so I'm not sure what the intersect is here. On Mon, Dec 7, 2015 at 5:34 AM, Maxim Uvarov wrote: > make[3]: Entering directory `/opt/Linaro/odp2.git/helper/test' > FAIL: odp_chksum > > > At the same time you need update test for that function. > > Maxi

Re: [lng-odp] [PATCH] validation: scheduler: use fail timeout when waiting on events in chaos

make[3]: Entering directory `/opt/Linaro/odp2.git/helper/test' FAIL: odp_chksum At the same time you need update test for that function. Maxim. On 12/04/2015 18:49, Bill Fischofer wrote: On Thu, Dec 3, 2015 at 10:37 AM, Ivan Khoronzhuk mailto:ivan.khoronz...@linaro.org>> wrote: In ca

Re: [lng-odp] [PATCH] helper: fix strncpy in table support

Merged, Maxim. On 12/04/2015 18:35, Bill Fischofer wrote: On Thu, Dec 3, 2015 at 12:49 PM, Mike Holmes > wrote: Fixes Bug 1905 - CID 154167: Calling strncpy with a maximum size argument of ODP_TABLE_NAME_LEN bytes on destination array tbl->name of

Re: [lng-odp] Fwd: [lng-ci] Build failed in Jenkins: ODP tool check » api-next,m32_on_64,docker-utopic #263

Thanks. v2 of patch submitted to correct this. On Mon, Dec 7, 2015 at 2:08 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > opendataplane 1.4.1.0.git208.g9823032 > > Library version:104:1:0 > > archx86 >

[lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

Change the internal hash_name_and_kind() function to eliminate the use of architecture-specific hash instructions. This eliminates build issues surrounding ARM variants. Future optimizations will use the arch directory consistent with other ODP modules. Signed-off-by: Bill Fischofer --- platform

Re: [lng-odp] [PATCHv2] helper : Fix UDP checksum computation

Merged, Maxim. On 12/04/2015 18:20, Bill Fischofer wrote: On Thu, Oct 22, 2015 at 7:02 AM, > wrote: From: Grigore Ion mailto:ion.grig...@freescale.com>> This patch fixes the following problems: - checksum computation for LE platforms - check

Re: [lng-odp] [PATCHv2 3/3] linux-generic: pktio: add test for tap pktio

On 07.12.2015 13:01, Stuart Haslam wrote: > On Wed, Dec 02, 2015 at 04:13:25PM +0300, Ilya Maximets wrote: >> Signed-off-by: Ilya Maximets >> --- >> platform/linux-generic/test/Makefile.am | 1 + >> platform/linux-generic/test/pktio/Makefile.am | 3 +- >> platform/linux-generic/test

[lng-odp] [PATCHv3 2/3] linux-generic: pktio: add tap pktio type

Creates a new pktio type that allows for creating and sending/receiving packets through TAP interface. It is intended for use as a simple conventional communication method between applications that use kernel network stack (ping, ssh, iperf, etc.) and ODP applications for the purpose of functional

[lng-odp] [PATCHv3 3/3] linux-generic: pktio: add test for tap pktio

Signed-off-by: Ilya Maximets --- platform/linux-generic/test/Makefile.am | 1 + platform/linux-generic/test/pktio/Makefile.am | 3 +- platform/linux-generic/test/pktio/pktio_run_tap | 114 3 files changed, 117 insertions(+), 1 deletion(-) create mode 100755

[lng-odp] [PATCHv3 0/3] TAP pktio

Creates a new pktio type that allows for creating and sending/receiving packets through TAP interface. Detailed description in commit-message of patch "[PATCHv3 2/3] linux-generic: pktio: add tap pktio type". Changelog: Version 3: * return 77 (TEST_SKIPPED) if user is not root. (Stuart Ha

[lng-odp] [PATCHv3 1/3] validation: pktio: initialize mac addresses for all packets

For the purpose of testing of real-world interfaces the packet's content should be valid or kernel will throw them away. Signed-off-by: Ilya Maximets --- test/validation/pktio/pktio.c | 46 --- 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a

Re: [lng-odp] [PATCHv2] validation:pktio : Fix UDP checksum computation

Merged, Maxim. On 12/04/2015 18:17, Bill Fischofer wrote: On Thu, Oct 22, 2015 at 8:55 AM, > wrote: From: Grigore Ion mailto:ion.grig...@freescale.com>> The UDP checksum is computed in the CPU endianness. The returned result must be converte

Re: [lng-odp] [PATCHv2 3/3] linux-generic: pktio: add test for tap pktio

On Wed, Dec 02, 2015 at 04:13:25PM +0300, Ilya Maximets wrote: > Signed-off-by: Ilya Maximets > --- > platform/linux-generic/test/Makefile.am | 1 + > platform/linux-generic/test/pktio/Makefile.am | 3 +- > platform/linux-generic/test/pktio/pktio_run_tap | 111 > +++

Re: [lng-odp] [API-NEXT/PATCHv4 1/4] api: classification: add odp_cls_cos_pool_set() api

Merged. Maxim. On 12/04/2015 06:29, Bill Fischofer wrote: On Thu, Dec 3, 2015 at 5:22 AM, Savolainen, Petri (Nokia - FI/Espoo) mailto:petri.savolai...@nokia.com>> wrote: Couple of small things still, with those fixed: Reviewed-by: Petri Savolainen mailto:petri.savolai...@nokia.com

Re: [lng-odp] [PATCH] doc: build users and implementers guide in the build tree instead of the source tree

You're right. I have a custom "make install" build above that that packages everything. I'll post an updated patch soon. Nicolas On 12/04/2015 03:11 PM, Mike Holmes wrote: > git clean -xdf && ./bootstrap && mkdir doctest && cd doctest && ../configure > --enable-user-guides && make -C doc > > I

Re: [lng-odp] Fwd: [lng-ci] Build failed in Jenkins: ODP tool check » api-next,m32_on_64,docker-utopic #263

        opendataplane 1.4.1.0.git208.g9823032         Library version:        104:1:0         arch                    x86         with_platform:          linux-generic         prefix: