Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

On 12/17/2015 08:56, HePeng wrote: Hi, Maxim I will present a quick patch that will not pass the kernel style check as this one is just for evaluation. ok, in that case you can add RFC to patch tag. Maxim. 在 2015年12月16日，下午8:22，Maxim Uvarov 写道： From meeting we

Re: [lng-odp] [API-NEXT PATCH 05/19] linux-generic: netmap: add initial multi queue support

> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Wednesday, December 16, 2015 6:42 PM > To: Savolainen, Petri (Nokia - FI/Espoo) ; lng- > o...@lists.linaro.org; Elo, Matias (Nokia - FI/Espoo) ; > Elo, >

Re: [lng-odp] Pool DMA mapping

It’s better to allow packet output from any packet type pool, no matter when the pool was created. Implementation controls packet pool memory mapping and can e.g. arrange all packet pool memory to be contiguous (in global init time). Each packet pool create could update IOMMU or if entries are

Re: [lng-odp] [PATCH] api: packet: add detailed packet error api

Petri, Please also review API change. On 11/17/2015 10:06, Balasubramanian Manoharan wrote: Adds api to get packet error flags for L2, L3 and L4 errors. Signed-off-by: Balasubramanian Manoharan --- include/odp/api/packet_flags.h| 33

Re: [lng-odp] [API-NEXT PATCH v5 2/7] api: pktio: added multiple pktio input queues

> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Wednesday, December 16, 2015 4:58 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v5 2/7] api: pktio: added multiple > pktio input queues

Re: [lng-odp] [PATCH] linux-generic: timer: include event_types instead of buffer_types

Merged, Maxim. On 12/08/2015 17:21, Ola Liljedahl wrote: On 3 December 2015 at 12:37, Ivan Khoronzhuk > wrote: Timer API requires event types instead of buffer types. Nit: this changes the linux-generic implementation, not

Re: [lng-odp] [API-NEXT PATCH v5 2/7] api: pktio: added multiple pktio input queues

> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Wednesday, December 16, 2015 5:48 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v5 2/7] api: pktio: added multiple > pktio input queues

[lng-odp] [PATCH v3] Test program to measure crypto operation performance.

From: Alexandru Badicioiu Measures the time required to launch and get the result of ODP crypto operations in async and sync API mode with configurable payload size, crypto algorithms and iteration number. Both asynchronous scheduled and polled are supported. In scheduled mode a separate worker

Re: [lng-odp] [API-NEXT/PATCHv2 3/6] validation: classification: add class of service create api

Hi, Bala Just pay attention, see below. On 16.12.15 11:28, Balasubramanian Manoharan wrote: Replaces odp_cos_create() function with odp_cls_cos_create() function Signed-off-by: Balasubramanian Manoharan --- test/validation/classification/classification.h| 1

[lng-odp] [API-NEXT PATCH 2/2] validation: removing synchronizers tests

Now redundant with atomic, barrier and lock tests. Signed-off-by: Christophe Milard --- configure.ac |1 - platform/linux-generic/test/Makefile.am|1 - test/validation/Makefile.am|

Re: [lng-odp] [API-NEXT/PATCHv2 3/6] validation: classification: add class of service create api

I will correct this as a separate patch. Regards, Bala On 17 December 2015 at 15:48, Ivan Khoronzhuk wrote: > . > >>> + >>> +pkt = receive_packet(, ODP_TIME_SEC_IN_NS); >> >> here has to be time of scheduler, ns should be converted to with >>

[lng-odp] [Bug 1921] sched_local.pool not set

https://bugs.linaro.org/show_bug.cgi?id=1921 --- Comment #2 from Bill Fischofer --- Merged. Commit ID 7afa127e124b298dad557f192e02468cd9bcc5cc -- You are receiving this mail because: You are on the CC list for the bug.___

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

[API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api ^^^ typo can be fixed during merge: serivce -> service Reviewed-by: Petri Savolainen > -Original Message- > From:

Re: [lng-odp] [API-NEXT PATCH v2 1/6] api: time: add resolution and wait API calls

On 17.12.15 15:52, Savolainen, Petri (Nokia - FI/Espoo) wrote: On Tuesday call, there were suggestions for another type of wait calls /* * Wait the specified number of nanoseconds */ void odp_time_wait_ns(uint64_t nsec); /* * Wait until the specified (wall clock) time has been

[lng-odp] [API-NEXT PATCH 1/2] validation: synchro tests split into 3 groups

No functionnal changes: just code reordering to match the ODP modules. Signed-off-by: Christophe Milard --- configure.ac|3 + platform/linux-generic/test/Makefile.am |3 + test/validation/Makefile.am |5 +-

[lng-odp] [ODP-Netmap] Have ODP-Netmap been merged with ODP-Linux-generic ?

Hi Before, we could find the implementation of odp-netmap on the opendataplane.org but now I noticed there is only "linux-generic (netmap)", so I guess odp-netmap has merged with linux-generic ? The git of odp-netmap seems not be uptated for a while, the same for odp-keystone2. Does somebody

[lng-odp] [Bug 1830] Untested internal API verify_pmr_ipv4_daddr

https://bugs.linaro.org/show_bug.cgi?id=1830 --- Comment #3 from Bala Manoharan --- V2 needs to be merged after the following patch for class of service create gets merged to API-NEXT https://patches.linaro.org/58539/ -- You are receiving this mail because: You are

Re: [lng-odp] Pool DMA mapping

The question is related to the DMA mapping: The driver needs to perform the DMA mapping, and we don't want to set up a new DMA mapping at TX time for each individual packet: We want to set-up the DMA at pktio_open() time, I guess, so that the NIC DMA can fetch any TX packet to be transmitted in

Re: [lng-odp] [API-NEXT PATCH v2 1/6] api: time: add resolution and wait API calls

On Tuesday call, there were suggestions for another type of wait calls /* * Wait the specified number of nanoseconds */ void odp_time_wait_ns(uint64_t nsec); /* * Wait until the specified (wall clock) time has been reached */ void odp_time_wait_until(odp_time_t time); These two could

Re: [lng-odp] [API-NEXT PATCH 00/19] Multi-queue pktio scheduler support

Merged, Maxim. On 12/17/2015 02:49, Bill Fischofer wrote: For this series: Reviewed-and-Tested-by: Bill Fischofer > On Wed, Dec 16, 2015 at 7:45 AM, Petri Savolainen

Re: [lng-odp] Pool DMA mapping

isn't it defeating the purpose of the iommu to DMA map all possible mem that could be used in a pool?... And as long as the memory is not mapped in the user virtual space, vfio won't let me do that... On 17 December 2015 at 14:24, Alexandru Badicioiu < alexandru.badici...@linaro.org> wrote: >

[lng-odp] [Bug 1937] CID 155811: Error handling issues odp_classification_common.c

https://bugs.linaro.org/show_bug.cgi?id=1937 Bala Manoharan changed: What|Removed |Added Resolution|--- |FIXED

Re: [lng-odp] Pool DMA mapping

Why the driver must map pools one by one? Is this a (legacy) kernel driver? The driver can map one or more DMA-ble memory regions at initialization time and this memory region should be used for all PACKET type pools. Alex On 17 December 2015 at 15:15, Christophe Milard <

Re: [lng-odp] [ODP-Netmap] Have ODP-Netmap been merged with ODP-Linux-generic ?

Yes, linux-generic has now a days Netmap support. You can activate netmap pktio with ./configure script ./configure --with-netmap-path= See DEPENDENCIES file for details. -Petri From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Kury Nicolas Sent: Thursday, December

[lng-odp] [API-NEXT PATCH v3 0/6] api: time: add rate and delay APIs

This series adds odp_time_local_res() and odp_time_wait_ns(), odp_time_wait_until() calls to time API and it's validation tests and usage. Since v2: - replaced odp_time_wait() on odp_time_wait_ns() and odp_time_wait_until() - corrected validation tests to validate new wait APIs Since v1: - used

[lng-odp] [API-NEXT PATCH v4 6/6] validation: time: add test for odp_time_wait_ns() and odp_time_wait_until()

This patch adds validation test for odp_time_wait_ns/until(). Also it visually demonstrates 5 second count. Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 53 + test/validation/time/time.h | 2 ++ 2 files

[lng-odp] [Bug 1946] make doxygen-html does not work for out of tree builds

https://bugs.linaro.org/show_bug.cgi?id=1946 Mike Holmes changed: What|Removed |Added CC||mike.hol...@linaro.org

[lng-odp] [API-NEXT PATCH v3 5/6] validation: time: add test for odp_time_local_res() and use resolution

This function is used to get resolution, test uses it to check other APIs. Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 46 ++--- test/validation/time/time.h | 1 + 2 files changed, 32 insertions(+), 15

[lng-odp] [API-NEXT PATCH v3 4/6] validation: time: add test convertsion on 0

Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 4 1 file changed, 4 insertions(+) diff --git a/test/validation/time/time.c b/test/validation/time/time.c index 4040b9f..cef 100644 --- a/test/validation/time/time.c +++

Re: [lng-odp] odp_cpumask_default_worker() calls from worker threads

On 17/12/15 00:24, Bill Fischofer wrote: On Tue, Dec 15, 2015 at 6:58 PM, Zoltan Kiss > wrote: Hi, I have a question: is it allowed to call these functions from worker threads? The current linux-generic implementation

Re: [lng-odp] [PATCHv7] helper : Fix UDP checksum computation

Ping -Original Message- From: ion.grig...@freescale.com [mailto:ion.grig...@freescale.com] Sent: Monday, December 14, 2015 12:52 PM To: lng-odp@lists.linaro.org Cc: Grigore Ion-B17953 Subject: [PATCHv7] helper : Fix UDP checksum computation From: Grigore Ion

[lng-odp] [Bug 1921] sched_local.pool not set

https://bugs.linaro.org/show_bug.cgi?id=1921 Mike Holmes changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

[lng-odp] [API-NEXT PATCH] validation: sched: Improve scheduler validation test to check sched time correctly

Test checks scheduler time correctness using time API. Signed-off-by: Ivan Khoronzhuk --- Patch is based on api-next, as it uses new time API. test/validation/scheduler/scheduler.c | 47 +-- 1 file changed, 45 insertions(+), 2

[lng-odp] [API-NEXT PATCH v4 2/6] performance: pktio_perf: use odp_time_wait_ns() function instead of looping

Now odp_time_wait_ns() can be used instead of own implementation. Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_pktio_perf.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/test/performance/odp_pktio_perf.c

[lng-odp] [API-NEXT PATCH v4 4/6] validation: time: add test convertsion on 0

Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 4 1 file changed, 4 insertions(+) diff --git a/test/validation/time/time.c b/test/validation/time/time.c index 4040b9f..cef 100644 --- a/test/validation/time/time.c +++

[lng-odp] [API-NEXT PATCH v4 3/6] validation: time: test time constants in ns

Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 10 ++ test/validation/time/time.h | 1 + 2 files changed, 11 insertions(+) diff --git a/test/validation/time/time.c b/test/validation/time/time.c index 50d9bdc..4040b9f 100644 ---

[lng-odp] [API-NEXT PATCH v4 1/6] api: time: add resolution and wait API calls

This patch adds odp_time_local_res() and odp_time_wait_until(), odp_time_wait_ns() APIs. Signed-off-by: Ivan Khoronzhuk --- include/odp/api/time.h| 21 platform/linux-generic/odp_time.c | 100 ++ 2 files

[lng-odp] [API-NEXT PATCH v3 3/6] validation: time: test time constants in ns

Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 10 ++ test/validation/time/time.h | 1 + 2 files changed, 11 insertions(+) diff --git a/test/validation/time/time.c b/test/validation/time/time.c index 50d9bdc..4040b9f 100644 ---

[lng-odp] [API-NEXT PATCH v3 2/6] performance: pktio_perf: use odp_time_wait_ns() function instead of looping

Now odp_time_wait_ns() can be used instead of own implementation. Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_pktio_perf.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/test/performance/odp_pktio_perf.c

[lng-odp] [API-NEXT PATCH v3 6/6] validation: time: add test for odp_time_wait_ns() and odp_time_wait_until()

This patch adds validation test for odp_time_wait_ns/until(). Also it visually demonstrates 5 second count. Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 52 + test/validation/time/time.h | 2 ++ 2 files

Re: [lng-odp] [API-NEXT PATCH v3 0/6] api: time: add rate and delay APIs

v4 is present On 17.12.15 17:29, Ivan Khoronzhuk wrote: This series adds odp_time_local_res() and odp_time_wait_ns(), odp_time_wait_until() calls to time API and it's validation tests and usage. Since v2: - replaced odp_time_wait() on odp_time_wait_ns() and odp_time_wait_until() - corrected

[lng-odp] [API-NEXT PATCH v2] validation: sched: Improve scheduler validation test to check sched time correctly

Test checks scheduler time correctness using time API. Signed-off-by: Ivan Khoronzhuk --- Based on api-next as it uses new time API. Since v1: - improved a little test/validation/scheduler/scheduler.c | 45 +-- 1 file changed, 43

Re: [lng-odp] [API-NEXT PATCH] validation: sched: Improve scheduler validation test to check sched time correctly

v2 is present On 17.12.15 18:20, Ivan Khoronzhuk wrote: Test checks scheduler time correctness using time API. Signed-off-by: Ivan Khoronzhuk --- Patch is based on api-next, as it uses new time API. test/validation/scheduler/scheduler.c | 47

[lng-odp] [API-NEXT PATCH v4 5/6] validation: time: add test for odp_time_local_res() and use resolution

This function is used to get resolution, test uses it to check other APIs. Signed-off-by: Ivan Khoronzhuk --- test/validation/time/time.c | 46 ++--- test/validation/time/time.h | 1 + 2 files changed, 32 insertions(+), 15

[lng-odp] [API-NEXT PATCH v3 1/6] api: time: add resolution and wait API calls

This patch adds odp_time_local_res() and odp_time_wait_until(), odp_time_wait_ns() APIs. Signed-off-by: Ivan Khoronzhuk --- include/odp/api/time.h| 21 platform/linux-generic/odp_time.c | 100 ++ 2 files

[lng-odp] [API-NEXT PATCH v4 0/6] api: time: add rate and delay APIs

This series adds odp_time_local_res() and odp_time_wait_ns(), odp_time_wait_until() calls to time API and it's validation tests and usage. Since v3: - improved validation test a little Since v2: - replaced odp_time_wait() on odp_time_wait_ns() and odp_time_wait_until() - corrected validation

Re: [lng-odp] [ODP-Netmap] Have ODP-Netmap been merged with ODP-Linux-generic ?

On 17 December 2015 at 09:53, Kury Nicolas wrote: > Hi > > > Before, we could find the implementation of odp-netmap on the > opendataplane.org but now I noticed there is only "linux-generic > (netmap)", so I guess odp-netmap has merged with linux-generic ? The git

Re: [lng-odp] [PATCHv2] validation: pktio: test batch receive

On Fri, Dec 11, 2015 at 05:10:51PM +, Stuart Haslam wrote: > Modify the tests that currently transmit packets in batches to also > receive packets in batches. This adds coverage of odp_queue_deq_multi() > and odp_schedule_multi() specifically against a packet input queue, > as this doesn't get

Re: [lng-odp] [API-NEXT PATCH 09/19] linux-generic: netmap: add netmap_link_status() function

On Wed, Dec 16, 2015 at 03:45:34PM +0200, Petri Savolainen wrote: > From: Matias Elo > > Added a separate function for determining if the netmap link > is up. > > Signed-off-by: Matias Elo > --- > platform/linux-generic/pktio/netmap.c | 48 >

Re: [lng-odp] [API-NEXT PATCH 05/19] linux-generic: netmap: add initial multi queue support

On 17/12/15 08:09, Elo, Matias (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] Sent: Wednesday, December 16, 2015 6:42 PM To: Savolainen, Petri (Nokia - FI/Espoo) ; lng- o...@lists.linaro.org; Elo, Matias

Re: [lng-odp] [API-NEXT PATCH v5 2/7] api: pktio: added multiple pktio input queues

On 17/12/15 08:54, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] Sent: Wednesday, December 16, 2015 5:48 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT

Re: [lng-odp] [API-NEXT PATCH v5 2/7] api: pktio: added multiple pktio input queues

On 17/12/15 08:21, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] Sent: Wednesday, December 16, 2015 4:58 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT

[lng-odp] [Bug 1946] make doxygen-html does not work for out of tree builds

https://bugs.linaro.org/show_bug.cgi?id=1946 --- Comment #1 from Bill Fischofer --- Maxim: Can you be a bit more specific about what the problem is and how to reproduce it? Thanks. -- You are receiving this mail because: You are on the CC list for the

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

Ok, then the patch should be reworked to do this. No point in dragging out the process through a series of disruptive changes. On Thu, Dec 17, 2015 at 5:56 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Yes, that’s the end goal of this process. All

Re: [lng-odp] [PATCH] api: packet: add detailed packet error api

[PATCH] -> [API-NEXT PATCH] > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Balasubramanian Manoharan > Sent: Tuesday, November 17, 2015 9:06 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH] api: packet: add detailed packet

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

On 17 December 2015 at 17:31, Bill Fischofer wrote: > Ok, then the patch should be reworked to do this. No point in dragging out > the process through a series of disruptive changes. Yes. The ultimate goal is to add this prefix to all existing APIs. This patch only

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

If we want to split this into multiple patches for review convenience that's fine. I'd just like to be sure that we don't have a series of API breaks for 1.6, 1.7, etc. Best to do that all at once on a release boundary. On Thu, Dec 17, 2015 at 6:25 AM, Bala Manoharan

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

BTW, subject to that caveat I did review and test this patch series so Reviewed-and-Tested-by: Bill Fischofer On Thu, Dec 17, 2015 at 6:26 AM, Bill Fischofer wrote: > If we want to split this into multiple patches for review convenience >

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

Agreed. But this odp_cls_cos_create() API change is not just a rename and it modifies the parameters to CoS create and hence it was better to do this in a separate review process. Regards, Bala On 17 December 2015 at 17:56, Bill Fischofer wrote: > If we want to split

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

Thanks Bill. @Petri: Can you please provide your reviewed-by to this API change. Regards, Bala On 17 December 2015 at 17:58, Bill Fischofer wrote: > BTW, subject to that caveat I did review and test this patch series so > > Reviewed-and-Tested-by: Bill Fischofer

[lng-odp] [PATCH API-NEXT 03/10] validation: system: remove validation of odp_cpu_hz_max()

From: Hongbo Zhang All CPU frequency APIs will be moved as linux-generic internal interfaces, this patch removes validation of odp_cpu_hz_max(). Signed-off-by: Hongbo Zhang --- test/validation/system/system.c | 9 -

[lng-odp] [PATCH API-NEXT 02/10] validation: system: remove validation of odp_cpu_hz_id()

From: Hongbo Zhang All CPU frequency APIs will be moved as linux-generic internal interfaces, this patch removes validation of odp_cpu_hz_id(). Signed-off-by: Hongbo Zhang --- test/validation/system/system.c | 17 -

[lng-odp] [PATCH API-NEXT 06/10] test: remove reference of odp_cpu_hz_max()

From: Hongbo Zhang All CPU frequency APIs will be moved as linux-generic internal interfaces, so they should not be referenced here. Signed-off-by: Hongbo Zhang --- test/api_test/odp_common.c| 1 - test/performance/odp_atomic.c | 1

[lng-odp] [PATCH API-NEXT 10/10] api: sysinfo: move odp_cpu_hz_max_id() for linux-generic internal

From: Hongbo Zhang All CPU frequency APIs are moved for linux-generic internal, this patch moves the declaration of odp_cpu_hz_max_id(). Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h| 11 ---

[lng-odp] [PATCH API-NEXT 09/10] api: sysinfo: move odp_cpu_hz_max() for linux-generic internal

From: Hongbo Zhang All CPU frequency APIs are moved for linux-generic internal, this patch moves the declaration of odp_cpu_hz_max(). Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h| 9 -

Re: [lng-odp] [PATCH API-NEXT 00/10] move CPU frequency APIs for linux-generic

Instead of removing these calls, we decided in an ARCH call this week that odp_cpu_hz*() calls can return 0 on failure (e.g. when could not read CPU hz on a platform). -Petri > -Original Message- > From: EXT hongbo.zh...@freescale.com [mailto:hongbo.zh...@freescale.com] > Sent:

Re: [lng-odp] [PATCH API-NEXT 00/10] move CPU frequency APIs for linux-generic

Hmm, there were changes of decision how to handle these APIs. Here it is mentioned to delete. https://collaborate.linaro.org/pages/viewpage.action?title=2015-12-16+ODP+ARCH=LNG Do you mean now the final official decision is to keep them, right? "return 0 on failure", this can be fixed soon, and

[lng-odp] [PATCH API-NEXT 01/10] validation: system: remove validation of odp_cpu_hz()

From: Hongbo Zhang All CPU frequency APIs will be moved as linux-generic internal interfaces, this patch removes validation of odp_cpu_hz(). Signed-off-by: Hongbo Zhang --- test/validation/system/system.c | 9 -

[lng-odp] [PATCH API-NEXT 05/10] example: remove reference of odp_cpu_hz_max()

From: Hongbo Zhang All CPU frequency APIs will be moved as linux-generic internal interfaces, so they should not be referenced here. Signed-off-by: Hongbo Zhang --- example/classifier/odp_classifier.c | 4 +---

[lng-odp] [PATCH API-NEXT 08/10] api: sysinfo: move odp_cpu_hz_id() for linux-generic internal

From: Hongbo Zhang All CPU frequency APIs are moved for linux-generic internal, this patch moves the declaration of odp_cpu_hz_id(). Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h| 11 ---

[lng-odp] [PATCH API-NEXT 07/10] api: sysinfo: move odp_cpu_hz() for linux-generic internal

From: Hongbo Zhang All CPU frequency APIs are moved for linux-generic internal, this patch moves the declaration of odp_cpu_hz(). Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h| 9 -

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

The rationale behind this is that classification API should follow the same, prefixed naming convention than other APIs. CoS is a generally used term and e.g. scheduler, TM, packet, etc APIs could define also APIs around Class of Service. Here odp_cos_t is essentially a node in a

Re: [lng-odp] [PATCH API-NEXT 00/10] move CPU frequency APIs for linux-generic

Yes, we'll keep them. I wasn't involved in the delete decision. You can add "@retval 0 on failure" to the API spec. /** * Current CPU frequency in Hz * * Returns current frequency of this CPU * * @return CPU frequency in Hz * @retval 0 on failure */ uint64_t odp_cpu_hz(void); -Petri >

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

I agree with that general convention, however a class of service is a first class entity (like a pool). It's why we have odp_pool_create() and parameterize that it's a buffer vs. packet pool instead of having separate odp_buffer_pool_create() and odp_packet_pool_create() APIs. Using that analogy

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

What e.g. scheduler or TM would do with a odp_cos_t which is associated with queue, pool and drop_policy? typedef struct odp_cls_cos_param { odp_queue_t queue; /**< Queue associated with CoS */ odp_pool_t pool;/**< Pool associated with CoS */ odp_drop_e

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

Fair enough, but then it seems we then need to add the odp_cls prefix to a lot more APIs and typedefs in the existing classification.h to be fully consistent. Right now there's a confusing mix of those that do and do not have this prefix. On Thu, Dec 17, 2015 at 5:49 AM, Savolainen, Petri (Nokia

Re: [lng-odp] [API-NEXT/PATCHv2 1/6] api: classification: add class of serivce create api

Yes, that’s the end goal of this process. All classification API calls, types, defines, … are prefixed with odp_cls_. -Petri From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Thursday, December 17, 2015 1:54 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: Bala Manoharan; LNG

[lng-odp] [API-NEXT RFC PATCH] cuckoo hash on buffer/pool

--- helper/Makefile.am | 2 + helper/cuckoo_hash.c| 728 ++ helper/include/odp/helper/cuckoo_hash.h | 434 ++ helper/include/odp/helper/ring.h| 43 ++ helper/ring.c | 28 ++