Re: [lng-odp] [API-NEXT RFC 02/31] api: introducing the driver api definition file

On 11 January 2016 at 03:54, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > CC’d the list again. > > > > > > *From:* EXT Christophe Milard [mailto:christophe.mil...@linaro.org] > *Sent:* Monday, January 11, 2016 10:29 AM > *To:* Savolainen, Petri (Nokia - FI/Espoo) >

Re: [lng-odp] Driver interface definition...

Hi, First thing to remember is that the number of applications/application-/implementation-developers will be 1000x to drivers/driver developers. So the ODP API must be really clean: application includes odp.h and everything seen through that is prefixed with odp_ and available for

Re: [lng-odp] [API-NEXT PATCH] Revert "api: pool: add packet user area initializer for pool creation parameters"

This seems to breaks build: odp_pool.c: In function 'packet_uarea_init': odp_pool.c:152:52: error: 'struct ' has no member named 'uarea_init' if (params->type == ODP_POOL_PACKET && params->pkt.uarea_init) { ^ odp_pool.c:155:14: error: 'struct

[lng-odp] [PATCH] example:ipsec: Tunnel mode fixes

From: Grigore Ion This patch fixes the following issues: 1. ETYPE field in the ETH header is not updated using the BE byte order (PKT_STATE_IPSEC_IN_FINISH status). 2. IP addresses, from the packet, are not converted to the CPU endianness, when the inbound policy is

Re: [lng-odp] [API-NEXT PATCH] Revert "api: pool: add packet user area initializer for pool creation parameters"

Ahh, sorry, I forgot the implementation was also in the repo. I'll send a patch to revert that too. On 12/01/16 13:06, Elo, Matias (Nokia - FI/Espoo) wrote: This seems to breaks build: odp_pool.c: In function 'packet_uarea_init': odp_pool.c:152:52: error: 'struct ' has no member named

Re: [lng-odp] [RFC API-NEXT PATCH] api: packet: add packet segment manipulation

Hi, On 11 January 2016 at 19:17, Petri Savolainen wrote: > Packet segments can be allocated/freed/multi-referenced. > Segments data pointer and length can be modified (push/pull). > Segments can be linked to packets when needed (can exist also > when not connected to

[lng-odp] [API-NEXT PATCH] Revert user area init implementation

This reverts commits: 2eb52b7277 "linux-generic: pool: implement user area init support" 9127b7408b "validation: packet: test if user area is properly set" Signed-off-by: Zoltan Kiss --- platform/linux-generic/odp_pool.c | 11 --- test/validation/packet/packet.c

[lng-odp] [PATCH 0/5] validation: cls: correct tests a little

This patch series corrects classification tests to be a little bit adoptive. Ivan Khoronzhuk (5): validation: cls: adopt for supported l3 PMR validation: cls: assign default CoS before creating chain validation: cls: test_pmr: don't create default input queue validation: cls: use correct

[lng-odp] [PATCH 2/5] validation: cls: assign default CoS before creating chain

There is no big difference when to assign default CoS to pktio, but in usual case it's done before creating any chain, if it's needed to be also checked it can be done in separate test. Signed-off-by: Ivan Khoronzhuk ---

[lng-odp] [PATCH 3/5] validation: cls: test_pmr: don't create default input queue

There is no need to create default input queue for pktio if default CoS is assigned. Signed-off-by: Ivan Khoronzhuk --- .../classification/odp_classification_test_pmr.c | 54 -- 1 file changed, 54 deletions(-) diff --git

[lng-odp] [PATCH 5/5] validation: cls: split pmr chain test

These tests are simple classification tests and better to see results for each of them separately. Signed-off-by: Ivan Khoronzhuk --- test/validation/classification/classification.h| 22 --- .../classification/odp_classification_tests.c | 72

[lng-odp] [PATCH] doc: identify asciidocs to search engines

Search engines are not currently indexing the documentation, add a title and description in addition to Google analytics to the documents. Signed-off-by: Mike Holmes --- doc/implementers-guide/implementers-guide.adoc | 22 ++

[lng-odp] [PATCH 1/5] validation: cls: adopt for supported l3 PMR

The classification tests should use supported l3 PMR where it's not important. For validating concrete PMRs the separate test exists. Signed-off-by: Ivan Khoronzhuk --- test/validation/classification/classification.h| 6 +--

[lng-odp] Maintain code copy-pasted from linux-generic in ODP-DPDK

Hi, We have a couple of places where the entire source file couldn't be copied from linux-generic, but some of the functions are. E.g. the loopback implementation from linux-generic's pktio code is something like that. It would be nice to somehow get the updates and fixes for this codebase,

Re: [lng-odp] Maintain code copy-pasted from linux-generic in ODP-DPDK

Hi, I have the same issue with our implementation. I usually either work from the git diff of linux generic before and post update and backport changed or to a diff of the diff of linux-generic vs mppa platform before and after the merge. Theoretically the diff you be clode to void (except line

Re: [lng-odp] [API-NEXT PATCH] Revert "api: pool: add packet user area initializer for pool creation parameters"

Merged, Maxim. On 01/08/2016 19:35, Zoltan Kiss wrote: This reverts commit 798c450fc41ee4195977a5af855dbc98d8aaec16. The use case is not strong enough for this feature. Signed-off-by: Zoltan Kiss --- include/odp/api/packet.h | 3 --- include/odp/api/pool.h | 26

Re: [lng-odp] [RFC API-NEXT PATCH] api: packet: add packet segment manipulation

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Tuesday, January 12, 2016 4:29 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [RFC API-NEXT PATCH] api: packet: add packet segment manipulation On Mon, Jan 11, 2016 at 7:47 AM,

Re: [lng-odp] [API-NEXT PATCH 1/2] api: classifier: align enum type naming

Ping. Bala and Bill have reviewed this set. > -Original Message- > From: EXT Bala Manoharan [mailto:bala.manoha...@linaro.org] > Sent: Thursday, January 07, 2016 2:34 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: LNG ODP Mailman List > Subject: Re: [lng-odp] [API-NEXT PATCH 1/2]

Re: [lng-odp] [API-NEXT PATCH 5/5] linux-generic: removed spin_internal

Ping. From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Thursday, January 07, 2016 2:30 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 5/5] linux-generic: removed spin_internal OK, thanks. For this Series:

Re: [lng-odp] [API-NEXT PATCH 1/2] api: cpumask: documented string format

Ping. From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Monday, January 04, 2016 6:43 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 1/2] api: cpumask: documented string format On Mon, Jan 4, 2016 at 7:07 AM, Petri

Re: [lng-odp] [PATCH] pool:support to create pool on user's own memory

Some quick comments: 1. This patch should be marked API-NEXT since it proposes an API change 2. In general I like the idea behind this patch, however I'd also like to see it incorporate NUMA considerations (perhaps that's why it's being proposed?) as that's one of the areas that we need to add

Re: [lng-odp] [API-NEXT PATCH] Revert user area init implementation

Ok, I just reverted that 2 patches to better see match between original patch and reverted. Added your sign-off there. Maxim. On 01/12/2016 16:54, Zoltan Kiss wrote: This reverts commits: 2eb52b7277 "linux-generic: pool: implement user area init support" 9127b7408b "validation: packet: test

Re: [lng-odp] ODP 1.5 - Crash while cleanup ODP/ODP timer pool

Bogdan CI sees instability in the timer also and Ivan is looking although he is on vacation this week, see https://bugs.linaro.org/show_bug.cgi?id=1940. If that is not the same is it possible for you to share a simple case that forces the issue and create a new bug ? Mike On 11 January 2016

[lng-odp] [PATCH] test: perf: l2fwd detect missing odp_generator

The script did not check that the odp_generator was present and worse it failed silently if it was not present. Signed-off-by: Mike Holmes --- test/performance/odp_l2fwd_run | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/performance/odp_l2fwd_run

[lng-odp] [PATCH 4/5] validation: cls: use correct MAC addresses

If pktion is in not promisc mode, a packet should contain correct MAC address. Signed-off-by: Ivan Khoronzhuk --- .../classification/odp_classification_test_pmr.c | 158 ++--- .../classification/odp_classification_tests.c | 30 +++- 2 files

[lng-odp] [PATCH v2] doc: process: add by-laws

The by-laws were only recorded as part of the website, move them to git where they can be tracked. Signed-off-by: Mike Holmes --- v2: Comments from Maxim doc/process-guide/Makefile.am | 6 +- doc/process-guide/bylaws-guide.adoc | 119

[lng-odp] 答复: [PATCH] pool:support to create pool on user's own memory

Hi Bill, Thanks for your advices. 1. Sorry for not being marked API-NEXT, as this is my first patch for LNG. 2. Generally, my intention for this mending of pool API is from most of our product requests. Sometimes, they just want to use the memory of themselves. Moreover, they even

[lng-odp] [PATCH] linux-generic: crypto: fix AES-GCM compatibility with old version of OpenSSL

Old version of OpenSSL require SET_TAG to be called before decrypting the data. New versions are compatible either way Signed-off-by: Nicolas Morey-Chaisemartin --- platform/linux-generic/odp_crypto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git