Re: [lng-odp] [API-NEXT PATCH v4 01/13] linux-generic: pktio: add separate functions for global and local init

> -Original Message- > From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Tuesday, February 16, 2016 9:06 AM > To: Zoltan Kiss ; Elo, Matias (Nokia - FI/Espoo) > ; lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH

Re: [lng-odp] [API-NEXT PATCH] doc: user-guide documentation for classification

On 16 February 2016 at 06:52, Bala Manoharan wrote: > Hi, > > On 15 February 2016 at 20:52, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> >> >> On 15 February 2016 at 15:12, Balasubramanian Manoharan < >> bala.manoha...@linaro.org> wrote: >> >>> Adds

Re: [lng-odp] [API-NEXT PATCH v4 01/13] linux-generic: pktio: add separate functions for global and local init

On 02/15/16 22:08, Zoltan Kiss wrote: --- a/platform/linux-generic/odp_packet_io.c +++ b/platform/linux-generic/odp_packet_io.c @@ -81,10 +81,12 @@ int odp_pktio_init_global(void) } for (pktio_if = 0; pktio_if_ops[pktio_if]; ++pktio_if) { -if (pktio_if_ops[pktio_if]->init) -

Re: [lng-odp] [API-NEXT PATCH] doc: user-guide documentation for classification

Hi, On 15 February 2016 at 20:52, Christophe Milard < christophe.mil...@linaro.org> wrote: > > > On 15 February 2016 at 15:12, Balasubramanian Manoharan < > bala.manoha...@linaro.org> wrote: > >> Adds user-guide documentation for classification module >> >> Signed-off-by: Balasubramanian

Re: [lng-odp] [PATCH 0/2] fix BUG 2027 - ODP cpumask creation issues

Oops! Sorry folks - thought I had already edited the subject lines of the actual patches but that must have been before finally getting a version thru check-odp resending :-\ On Mon, Feb 15, 2016 at 1:49 PM, Gary S. Robertson wrote: > Current versions of ODP

[lng-odp] [PATCH 2/2] Make cpu detection work with NO_HZ_FULL

sched_getaffinity() and pthread_getaffinity_np() do not return an accurate mask of all CPUs in the machine when the kernel is compiled with NO_HZ_FULL support. See Linaro BUG 2027 for details. Additionally, performance of tasks on isolated CPU cores may be compromised if other tasks are run on

[lng-odp] [PATCH 1/2] Correct worker count calculation in tests

During the process of addressing Linaro BUG 2027 which relates to inaccurate reporting of available CPUs by ODP linux-generic when running atop a kernel compiled with NO_HZ_FULL support, a number of instances were encountered in the validation and performance test software where incorrect methods

[lng-odp] [PATCH 0/2] fix BUG 2027 - ODP cpumask creation issues

Current versions of ODP linux-generic use sched_getaffinity() and / or pthread_getaffinity_np() to obtain counts and sets of CPUs for use by ODP tasks. This method returns inappropriate results when the underlying kernel is compiled with NO_HZ_FULL support, as are the current LNG kernels. (See

[lng-odp] [PATCH 2/2] Make cpu detection work with NO_HZ_FULL

sched_getaffinity() and pthread_getaffinity_np() do not return an accurate mask of all CPUs in the machine when the kernel is compiled with NO_HZ_FULL support. See Linaro BUG 2027 for details. Additionally, performance of tasks on isolated CPU cores may be compromised if other tasks are run on

[lng-odp] [PATCH 1/2] Correct worker count calculation in tests

During the process of addressing Linaro BUG 2027 which relates to inaccurate reporting of available CPUs by ODP linux-generic when running atop a kernel compiled with NO_HZ_FULL support, a number of instances were encountered in the validation and performance test software where incorrect methods

[lng-odp] [PATCH 0/2] fix BUG 2027 - ODP cpumask creation issues

Current versions of ODP linux-generic use sched_getaffinity() and / or pthread_getaffinity_np() to obtain counts and sets of CPUs for use by ODP tasks. This method returns inappropriate results when the underlying kernel is compiled with NO_HZ_FULL support, as are the current LNG kernels. (See

Re: [lng-odp] [API-NEXT PATCH v4 01/13] linux-generic: pktio: add separate functions for global and local init

On 15/02/16 10:49, Matias Elo wrote: Add separate functions for performing global and local pktio device initialization. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_io_internal.h | 3 ++- platform/linux-generic/odp_packet_io.c

[lng-odp] [Bug 2039] user input expected in implementers guide

https://bugs.linaro.org/show_bug.cgi?id=2039 Mike Holmes changed: What|Removed |Added CC||mike.hol...@linaro.org

[lng-odp] [Bug 2039] New: user input expected in implementers guide

https://bugs.linaro.org/show_bug.cgi?id=2039 Bug ID: 2039 Summary: user input expected in implementers guide Product: OpenDataPlane - linux- generic reference Version: next Hardware: Other OS: Linux Status:

Re: [lng-odp] [PATCH 2/4] doc: update to latest ax_prog_doxygen.m4

I see it, I did so many esoteric tests building in remote directories, installing etc, I have broken the basic case and did not do that one last time assuming it must be ok. On 15 February 2016 at 09:02, Bill Fischofer wrote: > Yes, I'm vanilla Ubuntu 15.10 > > On

Re: [lng-odp] [API-NEXT PATCH] doc: user-guide documentation for classification

On 15 February 2016 at 15:12, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > Adds user-guide documentation for classification module > > Signed-off-by: Balasubramanian Manoharan > --- > doc/users-guide/users-guide-cls.adoc | 220 >

Re: [lng-odp] [API-NEXT PATCH 0/9] Packet IO API clean up, part 1

Merged, Maxim. On 02/14/16 00:34, Bill Fischofer wrote: For this series: Reviewed-by: Bill Fischofer > On Fri, Feb 12, 2016 at 8:22 AM, Petri Savolainen > wrote:

[lng-odp] [API-NEXT PATCH] doc: user-guide documentation for classification

Adds user-guide documentation for classification module Signed-off-by: Balasubramanian Manoharan --- doc/users-guide/users-guide-cls.adoc | 220 +++ 1 file changed, 220 insertions(+) create mode 100644

Re: [lng-odp] [PATCH 2/4] doc: update to latest ax_prog_doxygen.m4

Yes, I'm vanilla Ubuntu 15.10 On Mon, Feb 15, 2016 at 7:12 AM, Mike Holmes wrote: > Thanks, let me see if I can get this same result, I did that same > procedure so many times - assume you are on 15.10 basic ubuntu box ? > > On 14 February 2016 at 15:49, Bill Fischofer

Re: [lng-odp] [PATCH 2/4] doc: update to latest ax_prog_doxygen.m4

Thanks, let me see if I can get this same result, I did that same procedure so many times - assume you are on 15.10 basic ubuntu box ? On 14 February 2016 at 15:49, Bill Fischofer wrote: > Applying this series to a fresh clone if I do: > > ./bootstrap > ./configure

Re: [lng-odp] [API-NEXT PATCHv2] test: l2fwd: add option to give destination MAC

Merged, Maxim. On 02/12/16 15:51, Juha-Matti Tilli wrote: Added option (--dst_addr or -r) to l2fwd that allows the user to specify what destination MAC addresses to use per port. The MAC addresses are separated by commas and the number of MAC addresses, if given, must be equal to the number of

[lng-odp] [API-NEXT PATCH v4 13/13] linux-generic: dpdk: close resources in odp_pktio_close()

Free/close open resources in odp_pktio_close(). Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_dpdk.h | 1 + platform/linux-generic/pktio/dpdk.c | 19 ++- 2

[lng-odp] [API-NEXT PATCH v4 11/13] linux-generic: dpdk: add odp_pktio_output_queues_config()

Implement odp_pktio_output_queues_config() function. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- platform/linux-generic/pktio/dpdk.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git

[lng-odp] [API-NEXT PATCH v4 09/13] linux-generic: dpdk: add functions for fetching packet input/output queues

Implement odp_pktio_in_queues(), odp_pktio_pktin_queues(), and odp_pktio_pktout_queues() functions. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- platform/linux-generic/pktio/dpdk.c | 48 ++--- 1

[lng-odp] [API-NEXT PATCH v4 12/13] linux-generic: dpdk: handle ixgbe_pmd minimum burst size

ixgbe_pmd has a minimum supported RX burst size of 4. If less than 4 packets are requested with odp_pktio_recv_queue(), rte_eth_rx_burst() is called with nb_pkts=4 and the possibly received extra packets are cached for the next dpdk_recv_queue() call to use. Reviewed-by: Petri Savolainen

[lng-odp] [API-NEXT PATCH v4 10/13] linux-generic: dpdk: add odp_pktio_input_queues_config()

Implement odp_pktio_input_queues_config() function and add helper rss_conf_to_hash_proto() for converting odp_pktin_hash_proto_t to struct rte_eth_rss_conf. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo ---

[lng-odp] [API-NEXT PATCH v4 04/13] linux-generic: pktio: initial dpdk pktio implementation

Initial implementation of the DPDK pktio type. Initialization code copied from the odp-dpdk branch. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_dpdk.h | 24 +

[lng-odp] [API-NEXT PATCH v4 07/13] linux-generic: dpdk: add odp_pktio_link_status()

Implement odp_pktio_link_status() for dpdk pktio. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- platform/linux-generic/pktio/dpdk.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[lng-odp] [API-NEXT PATCH v4 08/13] linux-generic: dpdk: add dpdk_setup_port()

Add helper function dpdk_setup_port() for configuring DPDK ports. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- platform/linux-generic/pktio/dpdk.c | 62 - 1 file changed, 41 insertions(+), 21

[lng-odp] [API-NEXT PATCH v4 03/13] linux-generic: pktio: add dpdk pktio build support

Add initial support for building ODP with DPDK pktio. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- DEPENDENCIES | 54 platform/linux-generic/Makefile.am | 2 +

[lng-odp] [API-NEXT PATCH v4 06/13] linux-generic: dpdk: add rx/tx locking

Add locking support to dpdk_recv_queue() and dpdk_send_queue(). Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_dpdk.h | 5 + platform/linux-generic/pktio/dpdk.c | 19

[lng-odp] [API-NEXT PATCH v4 05/13] linux-generic: dpdk: add get/set functions for mtu, promisc mode, and capability

Add dpdk_mtu_get(), dpdk_promisc_mode_set(), dpdk_promisc_mode_get(), and dpdk_capability() functions. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_dpdk.h | 1 +

[lng-odp] [API-NEXT PATCH v4 02/13] linux-generic: ipc: fix name clash with dpdk

DPDK 'struct rte_ring' (rte_ring.h) uses identical names which causes redefinition error. Signed-off-by: Matias Elo --- platform/linux-generic/include/odp_packet_io_ring_internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git