Re: [lng-odp] [API-NEXT PATCH v4 13/13] linux-generic: dpdk: close resources in odp_pktio_close()

2016-02-23 Thread Elo, Matias (Nokia - FI/Espoo)
> -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Friday, February 19, 2016 6:15 PM > To: Elo, Matias (Nokia - FI/Espoo) ; lng- > o...@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH v4 13/13] linux-generic: dpdk: close >

Re: [lng-odp] [PATCH V3 1/2] linux-generic: Correct worker count calculation in tests

2016-02-23 Thread Anders Roxell
shortlog should say something like: test: correct worker count calculation On 2016-02-22 16:46, Gary S. Robertson wrote: > During the process of addressing Linaro BUG 2027 which relates to Add a link to the bug in this changelog. > inaccurate reporting of available CPUs by ODP linux-generic

Re: [lng-odp] [PATCH V3 0/2] linux-generic: fix BUG 2027 - ODP cpumask creation issues

2016-02-23 Thread Bill Fischofer
For this series: Reviewed-by: Bill Fischofer On Mon, 22 Feb 2016 16:46:37 -0600 "Gary S. Robertson" wrote: > Current versions of ODP linux-generic use sched_getaffinity() and / or > pthread_getaffinity_np() to obtain counts and sets of

[lng-odp] [PATCHv2] linux-generic: shmem: odp scope in /dev/shmem

2016-02-23 Thread Christophe Milard
The name of the shared memory (created with linux shm_open() when the ODP_SHM_PROC flag is given) is now prefixed with "/odp--" so as to name scope ODP shared mem in /dev/shmem. Signed-off-by: Christophe Milard Reviewed-and-tested-by: Bill Fischofer

[lng-odp] ODP Public call Summary 2016-02-23

2016-02-23 Thread Mike Holmes
Weekly Meetings: Tuesdays @ 15:00 UTC+0 Goto meetings.opendataplane.org to join Topics covered: - 2 weeks until BKK16! - Call for reviewers and testers needed to help close Monarch RC1 in the next week! - TM CUnit tests patch v6

Re: [lng-odp] [PATCH] linux-generic: shmem: odp scope in /dev/shmem

2016-02-23 Thread Nikolay Nikolaev
On Tue, Feb 23, 2016 at 6:57 PM, Christophe Milard wrote: > > The name of the shared memory (created with linux shm_open() > when the ODP_SHM_PROC flag is given) is now prefixed with > "/opd--" so as to name scope ODP shared mem in /dev/shmem. ^^ A typo here -

[lng-odp] [PATCH] example: time: use PRIu32 where needed

2016-02-23 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- example/time/time_global_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/example/time/time_global_test.c b/example/time/time_global_test.c index 7cfd969..0c08f2c 100644 ---

Re: [lng-odp] [PATCH] linux-generic: shmem: odp scope in /dev/shmem

2016-02-23 Thread Bill Fischofer
On Tue, Feb 23, 2016 at 10:57 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > The name of the shared memory (created with linux shm_open() > when the ODP_SHM_PROC flag is given) is now prefixed with > "/opd--" so as to name scope ODP shared mem in /dev/shmem. > > Signed-off-by:

[lng-odp] [PATCH] linux-generic: pktio: do not include net/if.h and linux/if.h

2016-02-23 Thread Nicolas Morey-Chaisemartin
Both are incompatible: In file included from platform/linux-generic/pktio/ethtool.c:13:0: /usr/include/net/if.h:44:5: error: redeclaration of enumerator ‘IFF_UP’ IFF_UP = 0x1, /* Interface is up. */ ^ In file included from platform/linux-generic/pktio/ethtool.c:10:0:

[lng-odp] [PATCH] linux-generic: shmem: odp scope in /dev/shmem

2016-02-23 Thread Christophe Milard
The name of the shared memory (created with linux shm_open() when the ODP_SHM_PROC flag is given) is now prefixed with "/opd--" so as to name scope ODP shared mem in /dev/shmem. Signed-off-by: Christophe Milard --- platform/linux-generic/include/odp_internal.h | 2

[lng-odp] [PATCH] validation: timer: replace %d by PRIu32

2016-02-23 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- test/validation/timer/timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/validation/timer/timer.c b/test/validation/timer/timer.c index 004670a..8d3ba47 100644 --- a/test/validation/timer/timer.c

[lng-odp] [PATCH] scripts: git_hash: support gitfiles

2016-02-23 Thread Nicolas Morey-Chaisemartin
With recent git releases, the .git at the top of a repo is not necessary a directory but can be a gitfile pointing to a remote git directory. This is commonly used by git-worktree and git-submodule. This patch changes the check for .git to allow for any file (symlinks too) Signed-off-by: Nicolas

[lng-odp] [API-NEXT PATCH v3 7/9] api: pktio: changed odp_pktio_mtu() return value to uint32_t

2016-02-23 Thread Matias Elo
C specification defines minimum int size to be 16 bits, which would lead to maximum MTU value of 32767. This may not be enough for some link layers (e.g. ATM, virtual interfaces). Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo ---

[lng-odp] [API-NEXT PATCH v3 9/9] linux-generic: validation: add netmap test

2016-02-23 Thread Matias Elo
From: Stuart Haslam Add a test for the netmap pktio type. This test will only run as root and if the netmap kernel module is loaded, otherwise it will be skipped. There are three different interface types tested by default, VALE ports, pipe ports and veth (veth only if

[lng-odp] [API-NEXT PATCH v3 8/9] validation: pktio: replace pktio_test_jumbo() with pktio_test_recv_mtu()

2016-02-23 Thread Matias Elo
One should not try to send larger than MTU sized packets and expect the operation to succeed. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- test/validation/pktio/pktio.c | 24 +++- test/validation/pktio/pktio.h

[lng-odp] [API-NEXT PATCH v3 2/9] linux-generic: netmap: add support for VALE and pipe virtual ports

2016-02-23 Thread Matias Elo
As well as connections to a physical network interface the netmap API also supports connections to two different types for virtual ports, VALE switch ports and netmap pipe ports. VALE is a virtual switch implemented in the netmap kernel module, it works as a learning bridge and is designed to be

[lng-odp] [API-NEXT PATCH v3 6/9] validation: pktio: set packet mac addresses and checksum in statistics test

2016-02-23 Thread Matias Elo
Set test packets' mac addresses and checksums in pktio_test_statistics_counters() to enable testing with real world interfaces. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- test/validation/pktio/pktio.c | 22

[lng-odp] [API-NEXT PATCH v3 3/9] api: pktio: added supported set operations bit mask to pktio capability

2016-02-23 Thread Matias Elo
Added a new supported set operations bit mask to pktio capability. This can be used to avoid calling unsupported set operations, e.g. configuring promisc mode in validation tests with virtual interfaces. For now setting promiscuous mode is the only such operation, but others can be added later on.

[lng-odp] [API-NEXT PATCH v3 4/9] linux-generic: pktio: set pktio capability supported set operations flags

2016-02-23 Thread Matias Elo
Set new pktio capability supported set operations flags (promisc_mode) for pktio devices. Configuring promiscuous mode is not supported for virtual netmap VALE/pipe devices. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo ---

[lng-odp] [API-NEXT PATCH v3 5/9] validation: pktio: check if configuring promisc mode is supported before testing

2016-02-23 Thread Matias Elo
Test if configuring promisc mode is supported by the interface before running tests. Reviewed-by: Petri Savolainen Signed-off-by: Matias Elo --- test/validation/pktio/pktio.c | 12 1 file changed, 12 insertions(+) diff --git

[lng-odp] [API-NEXT PATCH v3 1/9] linux-generic: netmap: support 'netmap:' interface name prefix

2016-02-23 Thread Matias Elo
The netmap API requires interface names to be prefixed with "netmap:", the pktio code will do that automatically, e.g. odp_pktio_open("eth0") becomes nm_open("netmap:eth0"). But it will append the netmap: even if the original name already has that prefix, so odp_pktio_open("netmap:eth0") fails.

[lng-odp] [API-NEXT PATCH v3 0/9] netmap VALE/pipe interface support

2016-02-23 Thread Matias Elo
V3: - Added pktio_run_netmap script for running validation tests (Maxim Uvarov) - Replaced pktio_test_jumbo() with pktio_test_recv_mtu() - Added documentation on how to use netmap virtual interfaces (Maxim Uvarov) - Changed odp_pktio_mtu() return value from int to uint32_t V2: - Added supported

[lng-odp] [PATCHv2 2/2] validation: init: add test for init with platform parameters

2016-02-23 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- Reposted due to mail issues test/validation/init/init.c | 16 test/validation/init/init.h | 1 + 2 files changed, 17 insertions(+) diff --git a/test/validation/init/init.c b/test/validation/init/init.c index

[lng-odp] [PATCHv2 1/2] api: init: add initializer function for odp_platform_init_t

2016-02-23 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin --- Reposted due to mail issues include/odp/api/spec/init.h | 8 platform/linux-generic/odp_init.c | 4 2 files changed, 12 insertions(+) diff --git a/include/odp/api/spec/init.h b/include/odp/api/spec/init.h

[lng-odp] Mailman Test

2016-02-23 Thread Nicolas Morey-Chaisemartin
Test to make sure Mailman is not breaking DKIM anymore. ___ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH v4 0/8] separate ODP_CACHE_LINE_SIZE to arch files and clean-up

2016-02-23 Thread Hongbo Zhang
There are checkpatch warnings, but they should be acceptable, because chechpatch rules don't apply some changes for example the edit in configure.ac. On 23 February 2016 at 16:12, wrote: > From: Hongbo Zhang > > v3-v4 changes: > - merge

[lng-odp] [PATCH] linux-generic: fix usage of function strncpy

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang This is for https://bugs.linaro.org/show_bug.cgi?id=2030: "Memory - illegal accesses (BUFFER_SIZE_WARNING) Calling strncpy with a maximum size argument of 128 bytes on destination array "sysinfo->model_str[id]" of size 128 bytes might leave the

[lng-odp] [PATCH v4 8/8] linux-generic: sysinfo clean up for ARM

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang The arch/arm/odp_sysinfo_parse.c is currently a symlink to arch/linux/odp_sysinfo_parse.c, but in fact there should be defferences between them. A separated real arch/arm/odp_sysinfo_parse.c is created for ARM, and the model_str is set to a general

[lng-odp] [PATCH v4 7/8] linux-generic: use one uniform call systemcpu()

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang Currently there are two systemcpu() functions, one is for some specific platforms and the other is for default dummy, but most of the contents are same except for sysinfo->cache_line_size: one is true data from calling systemcpu_cache_line_size() and

[lng-odp] [PATCH v4 5/8] linux-generic: move CPU info dummy data to generic default file

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang The dummy data of cpu_hz_max and model_str are used when platform is unknown or data cannot be acquired, but these variables should be set in function odp_cpuinfo_parser() instead of the systemcpu() which should cover only the cpu_count, huge_page_size

[lng-odp] [PATCH v4 6/8] linux-generic: systemcpu(): use input parameter instead of global data

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang In the systemcpu() function, odp_global_data.system_info.huge_page_size should be sysinfo->huge_page_size instead, because when systemcpu() is called, the _global_data.system_info is passed as parameter, we should operate the parameter instead of the

[lng-odp] [PATCH v4 4/8] linux-generic: create ARM files and move ARM ODP_CACHE_LINE_SIZE in it

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. And in the legacy codes there was no ARM architecture directory, so this patch create it, the odp_cpu_arch.c

[lng-odp] [PATCH v4 2/8] linux-generic: separate MIPS ODP_CACHE_LINE_SIZE to its arch file

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for MIPS. Signed-off-by: Hongbo Zhang

[lng-odp] [PATCH v4 3/8] linux-generic: separate PowerPC ODP_CACHE_LINE_SIZE to its arch file

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for PowerPC. The previous arch/powerpc/odp/cpu_arch.h was a symlink to

[lng-odp] [PATCH v4 1/8] linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang Currently all ODP_CACHE_LINE_SIZE macros for different architectures are held in one header file, they should be moved to their own arch file. This patch moves ODP_CACHE_LINE_SIZE for x86. Signed-off-by: Mike Holmes

[lng-odp] [PATCH v4 0/8] separate ODP_CACHE_LINE_SIZE to arch files and clean-up

2016-02-23 Thread hongbo . zhang
From: Hongbo Zhang v3-v4 changes: - merge previous two patch sets into one: "[PATCH v3 API-NEXT 0/4] separate ODP_CACHE_LINE_SIZE to arch files" and "[PATCH API-NEXT 0/4] linux-generic sysinfo codes clean-ups" then this patch set contains 8 patches, this is for easier