Re: [lng-odp] [API-NEXT PATCHv1] linux-generic:pktio:add an interface to support multi pool

2016-03-03 Thread huanggaoyang
I don't think the PMR1~3 in your example will work like you said. If the incoming packet len is 0x1200: 0x1200 & 0x00FF(PMR1's mask)==0x, so the packet matchs PMR1... 0x1200 & 0x02FF(PMR3's mask)==0x0200, also matchs PMR3... But actually I want this 0x1200 packet match the Default Cos's PMR

Re: [lng-odp] [API-NEXT PATCHv2 3/3] doc: userguide: add PktIO chapter to ODP User Guide

2016-03-03 Thread Bill Fischofer
I've posted a v3 that incorporates your review comments. We can discuss with Petri any proposed changes to the doxygen on the APIs while at BKK. Thanks. On Thu, Mar 3, 2016 at 11:44 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > I know the comments are copied from the source,

[lng-odp] [API-NEXT PATCHv2 3/3] validation: rwlock: add tests for new trylock rwlock and rwlock_recursive apis

2016-03-03 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- test/validation/lock/lock.c | 28 1 file changed, 28 insertions(+) diff --git a/test/validation/lock/lock.c b/test/validation/lock/lock.c index f1f6d69..071d5b6 100644 --- a/test/validation/lock/lock.c +++

[lng-odp] [API-NEXT PATCHv2 2/3] linux-generic: rwlock: implement trylock variants of rwlock and rwlock_recursive

2016-03-03 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_rwlock.c | 14 ++ platform/linux-generic/odp_rwlock_recursive.c | 37 +++ 2 files changed, 51 insertions(+) diff --git a/platform/linux-generic/odp_rwlock.c

[lng-odp] [API-NEXT PATCHv2 1/3] api: rwlock: add trylock variants for rwlock and rwlock_recursive

2016-03-03 Thread Bill Fischofer
Add the following APIs: - odp_rwlock_read_trylock() - odp_rwlock_write_trylock() - odp_rwlock_recursive_read_trylock() - odp_rwlock_recursive_write_trylock() Suggested-by: Sorin Vultureanu Signed-off-by: Bill Fischofer ---

[lng-odp] [API-NEXT PATCH 3/3] validation: rwlock: add tests for new trylock rwlock and rwlock_recursive apis

2016-03-03 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- test/validation/lock/lock.c | 28 1 file changed, 28 insertions(+) diff --git a/test/validation/lock/lock.c b/test/validation/lock/lock.c index f1f6d69..071d5b6 100644 --- a/test/validation/lock/lock.c +++

[lng-odp] [API-NEXT PATCH 2/3] linux-generic: rwlock: implement trylock variants of rwlock and rwlock_recursive

2016-03-03 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_rwlock.c | 14 ++ platform/linux-generic/odp_rwlock_recursive.c | 37 +++ 2 files changed, 51 insertions(+) diff --git a/platform/linux-generic/odp_rwlock.c

[lng-odp] [API-NEXT PATCH 1/3] api: rwlock: add trylock variants for rwlock and rwlock_recursive

2016-03-03 Thread Bill Fischofer
Add the following APIs: - odp_rwlock_read_trylock() - odp_rwlock_write_trylock() - odp_rwlock_recursive_read_trylock() - odp_rwlock_recursive_write_trylock() Suggested-by: Sorin Vultureanu @ s 1 Signed-off-by: Bill Fischofer ---

[lng-odp] [Bug 2108] New: lock_main: valgrind

2016-03-03 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2108 Bug ID: 2108 Summary: lock_main: valgrind Product: OpenDataPlane - linux- generic reference Version: 1.7 Hardware: Other OS: Linux Status: UNCONFIRMED

[lng-odp] [API-NEXT PATCHv3 3/3] doc: userguide: add PktIO chapter to ODP User Guide

2016-03-03 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- doc/users-guide/users-guide-pktio.adoc | 645 + doc/users-guide/users-guide.adoc | 2 + 2 files changed, 647 insertions(+) create mode 100644 doc/users-guide/users-guide-pktio.adoc diff --git

[lng-odp] [API-NEXT PATCHv3 1/3] doc: images: add gv file for pktio state machine

2016-03-03 Thread Bill Fischofer
The PktIO FSM state diagram is built using GraphVis. Add the files and associated Makefile and .gitignore changes needed to support this new file. Signed-off-by: Bill Fischofer --- doc/Makefile.inc| 3 +++ doc/images/.gitignore | 1 +

Re: [lng-odp] [PATCHv2] linux-generic: shmem: odp scope in /dev/shmem

2016-03-03 Thread Maxim Uvarov
On 03/03/16 17:26, Anders Roxell wrote: On 3 March 2016 at 14:55, Maxim Uvarov wrote: I merged that patch to next, will be in rc1. Nothing ever goes into next, see our release-guide [1]. Cheers, Anders [1]

Re: [lng-odp] [API-NEXT PATCHv2 3/3] doc: userguide: add PktIO chapter to ODP User Guide

2016-03-03 Thread Christophe Milard
I know the comments are copied from the source, but thy are just copied (not referenced), right? I mean, if it does not get fixed here, there will be 2 places to fix... If you have the courage, maybe the source comment can be fixed in a earlyer patch. These comments are relatively minor details.

Re: [lng-odp] [API-NEXT PATCHv2 3/3] doc: userguide: add PktIO chapter to ODP User Guide

2016-03-03 Thread Bill Fischofer
On Thu, Mar 3, 2016 at 4:00 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > On 2016-03-02 04:35, Bill Fischofer wrote: > > Signed-off-by: Bill Fischofer > > --- > > doc/users-guide/users-guide-pktio.adoc | 605 > + > >

Re: [lng-odp] [PATCHv2] linux-generic: shmem: odp scope in /dev/shmem

2016-03-03 Thread Anders Roxell
On 3 March 2016 at 14:55, Maxim Uvarov wrote: > I merged that patch to next, will be in rc1. Nothing ever goes into next, see our release-guide [1]. Cheers, Anders [1] http://docs.opendataplane.org/master/linux-generic/output/release-guide.html > > Maxim. > > On

Re: [lng-odp] [PATCHv2] linux-generic: shmem: odp scope in /dev/shmem

2016-03-03 Thread Maxim Uvarov
I merged that patch to next, will be in rc1. Maxim. On 02/23/16 21:14, Christophe Milard wrote: The name of the shared memory (created with linux shm_open() when the ODP_SHM_PROC flag is given) is now prefixed with "/odp--" so as to name scope ODP shared mem in /dev/shmem. Signed-off-by:

Re: [lng-odp] [API-NEXT PATCHv1] linux-generic:pktio:add an interface to support multi pool

2016-03-03 Thread Bala Manoharan
The concept of range for Packet matching terms was initially proposed in classification and was removed since most HW implement packet classifier using TCAM and TCAMs only support matching and mask. The range can be configured using the existing PMR by intelligently configuring the system by

Re: [lng-odp] [PATCH v5 0/8] Put ODP_CACHE_LINE_SIZE in ARCH file

2016-03-03 Thread Maxim Uvarov
That is in api-next and next, so will me merged to rc1, no need to rebase it. Maxim. On 03/02/16 22:29, Mike Holmes wrote: Rebased Hongbo Zhang (8): linux-generic: separate x86 ODP_CACHE_LINE_SIZE to its arch file linux-generic: separate MIPS ODP_CACHE_LINE_SIZE to its arch file

Re: [lng-odp] [API-NEXT PATCHv2 1/3] linux-generic: pktio: add link_status handler for loop interfaces

2016-03-03 Thread Maxim Uvarov
Merged, Maxim. On 03/02/16 23:54, Mike Holmes wrote: For the series Reviewed-by: Mike Holmes > On 1 March 2016 at 14:56, Bill Fischofer > wrote: ODP loopback interfaces

Re: [lng-odp] [API-NEXT PATCHv2 3/3] doc: userguide: add PktIO chapter to ODP User Guide

2016-03-03 Thread Christophe Milard
On 2016-03-02 04:35, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > --- > doc/users-guide/users-guide-pktio.adoc | 605 > + > doc/users-guide/users-guide.adoc | 2 + > 2 files changed, 607 insertions(+) > create mode