Re: [lng-odp] [API-NEXT PATCHv2 1/4] api: rwlock: add trylock variants for rwlock and rwlock_recursive

2016-03-19 Thread Maxim Uvarov
Petri, ok? Maxim. On 03/05/16 23:10, Bill Fischofer wrote: Add the following APIs: - odp_rwlock_read_trylock() - odp_rwlock_write_trylock() - odp_rwlock_recursive_read_trylock() - odp_rwlock_recursive_write_trylock() Suggested-by: Sorin Vultureanu Signed-off-by: Bill Fischofer --- include/

Re: [lng-odp] Accesing hardware time stamps

2016-03-19 Thread Maxim Uvarov
As I understand main target is support RTP traffic. Here is interesting background with tests and not that at a least TI chips can support that: http://processors.wiki.ti.com/index.php/TI81XX_PSP_ETHERNET_Switch_User_Guide#IEEE_1588.2F802.1AS_PTP_Support Other SoC hardware has programmable cl

[lng-odp] [PATCH 00/11] cleanup debian builds

2016-03-19 Thread Anders Roxell
Hi, A few patches to cleanup the debian package build. Cheers, Anders Anders Roxell (11): pkg/debian/control: add graphviz to Build-Depends configure: default test-helper to disabled rename libodp to libodp-linux rename libodphelper to libodphelper-linux scripts/builddeb: remove SO-ver

Re: [lng-odp] [PATCH 2/3] DEPENDENCIES: improve netmap installation instructions

2016-03-19 Thread Maxim Uvarov
On 03/18/16 14:42, Elo, Matias (Nokia - FI/Espoo) wrote: -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim Uvarov Sent: Friday, March 18, 2016 12:26 PM To: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH 2/3] DEPENDENCIES: improve net

Re: [lng-odp] [PATCH] scripts: add builddpdk

2016-03-19 Thread Nikolay Nikolaev
On Fri, Mar 18, 2016 at 1:59 PM, Maxim Uvarov wrote: > Add script to quickly build odp with dpdk pktio support. > > Signed-off-by: Maxim Uvarov > --- > .gitignore| 1 + > scripts/builddpdk | 26 ++ > 2 files changed, 27 insertions(+) > create mode 100755 scripts

Re: [lng-odp] [API-NEXT PATCH] api: pktio: add odp_pktin_recv_tmo

2016-03-19 Thread Bala Manoharan
Hi, odp_pktin_recv_tmo() function called with wait value equal to ODP_PKTIN_NO_WAIT is similar to odp_pktin_recv() function. Hence why cant we simply merge these two functions as a single one. odp_pktin_recv() functions looks redundant. Regards, Bala On 17 March 2016 at 19:37, Petri Savolainen

[lng-odp] [PATCH v2 2/2] linux-generic: packet: don't look for L2 header if there isn't any

2016-03-19 Thread Zoltan Kiss
The L2 offset functions should consider the L2 flag: return negative answer if there isn't any, and implicitly set it when offset is set. E.g. user created packets don't have L2 headers immediately. Signed-off-by: Zoltan Kiss --- platform/linux-generic/include/odp_packet_internal.h | 5 + pl

Re: [lng-odp] [PATCH 2/3] DEPENDENCIES: improve netmap installation instructions

2016-03-19 Thread Maxim Uvarov
On 03/09/16 09:37, Matias Elo wrote: The latest netmap release version is getting old and no new releases are planned in the near future. Modify netmap installation instructions to prefer the latest netmap master branch commit for the best performance and bug fixes. Signed-off-by: Matias Elo --

Re: [lng-odp] [PATCH v2 5/6] linux-generic: dpdk: pass ODP_PLATFORM_PARAMS environment variable to dpdk init

2016-03-19 Thread Elo, Matias (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim > Uvarov > Sent: Wednesday, March 16, 2016 3:12 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH v2 5/6] linux-generic: dpdk: pass > ODP_PLATFORM_PARAMS environment varia

[lng-odp] [PATCH 05/11] scripts/builddeb: remove SO-version from -dev and -bin pkg

2016-03-19 Thread Anders Roxell
Signed-off-by: Anders Roxell --- scripts/builddeb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/builddeb b/scripts/builddeb index 0fa8754..988cb5d 100755 --- a/scripts/builddeb +++ b/scripts/builddeb @@ -23,7 +23,7 @@ cp -r ${ROOT_DIR}/pkg/debian . current=$(echo ${

[lng-odp] [API-NEXT PATCH] api: init: add instance handle

2016-03-19 Thread Petri Savolainen
Added opaque odp_instance_t handle for storing ODP instance ID. Global init generates instance ID which is used to identify an ODP instance in the system. Instance ID allows to launch multiple separate ODP applications (without name space clash). Application threads define in odp_init_local() call

Re: [lng-odp] [PATCH 1/3] linux-generic: netmap: handle case where all rx/tx rings cannot be stored

2016-03-19 Thread Maxim Uvarov
Merged patches 1 and 3. Left comment for patch 2. Maxim. On 03/09/16 09:37, Matias Elo wrote: Don't fail netmap_open() if all netmap rx/tx rings cannot be stored. Instead, adjust capa.max_intput_queues / capa.max_output_values accordingly. Signed-off-by: Matias Elo --- platform/linux-gener

[lng-odp] [PATCH 07/11] dbg/debian: add libodphelper-linux* packages

2016-03-19 Thread Anders Roxell
Signed-off-by: Anders Roxell --- pkg/debian/control | 27 ++- pkg/debian/rules | 3 ++- scripts/builddeb | 4 ++-- 3 files changed, 30 insertions(+), 4 deletions(-) diff --git a/pkg/debian/control b/pkg/debian/control index 8a1f679..0c5821b 100644 --- a/pkg/debian/c

Re: [lng-odp] Accesing hardware time stamps

2016-03-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, Not yet, but going to do that soon. Do you need also an API for reading (sampling) the packet input HW timestamp from the interface? For example, rte_eth_timesync_read_rx_timestamp does that. I was going to add (first) only ability to the read timestamp stored in the received packet, times

Re: [lng-odp] [PATCH 2/2] linux-generic: packet: don't look for L2 header if there isn't any

2016-03-19 Thread Zoltan Kiss
My bad, I read those comments made for the other patch but I haven't applied them on this one. On 18/03/16 12:07, Maxim Uvarov wrote: On 03/18/16 14:39, Zoltan Kiss wrote: Ping, added Bill ping for what? There are comments to rename functions. Maxim. On 11/03/16 07:03, Zoltan Kiss wrote

[lng-odp] [PATCH 09/11] pkg/debian/control: fix bin package section name

2016-03-19 Thread Anders Roxell
Signed-off-by: Anders Roxell --- pkg/debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/debian/control b/pkg/debian/control index 0c5821b..1345770 100644 --- a/pkg/debian/control +++ b/pkg/debian/control @@ -11,7 +11,7 @@ Vcs-Git: git://git.linaro.org/lng/odp.g

[lng-odp] [PATCH 01/11] pkg/debian/control: add graphviz to Build-Depends

2016-03-19 Thread Anders Roxell
Signed-off-by: Anders Roxell --- pkg/debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/debian/control b/pkg/debian/control index 873070a..40b3842 100644 --- a/pkg/debian/control +++ b/pkg/debian/control @@ -3,7 +3,7 @@ Priority: optional Maintainer: Anders Ro

[lng-odp] [API-NEXT PATCH 3/3] example: l2fwd_simple: use pktin_recv_tmo

2016-03-19 Thread Petri Savolainen
Use timeout version of the pktin recv call to reduce CPU load when there are no packets available. Signed-off-by: Petri Savolainen --- example/l2fwd_simple/odp_l2fwd_simple.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/example/l2fwd_simple/odp_l2fwd_simple.c b/example

Re: [lng-odp] [PATCH] linux-generic: dpdk: add packet classification support

2016-03-19 Thread Maxim Uvarov
Merged, Maxim. On 03/18/16 13:44, Elo, Matias (Nokia - FI/Espoo) wrote: Thanks, Matias *From:*EXT Bala Manoharan [mailto:bala.manoha...@linaro.org] *Sent:* Friday, March 18, 2016 12:37 PM *To:* Elo, Matias (Nokia - FI/Espoo) *Cc:* lng-odp@lists.linaro.org *Subject:* Re: [lng-odp] [PATCH] lin

Re: [lng-odp] [API-NEXT PATCH 1/2] api: sched: add schedule group info struct

2016-03-19 Thread Maxim Uvarov
Merged, Maxim. On 03/17/16 11:05, Savolainen, Petri (Nokia - FI/Espoo) wrote: Ping. *From:*EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] *Sent:* Wednesday, March 02, 2016 1:59 PM *To:* Savolainen, Petri (Nokia - FI/Espoo) *Cc:* LNG ODP Mailman List *Subject:* Re: [lng-odp] [API-NEXT

Re: [lng-odp] [API-NEXT PATCH] api: pktio: add odp_pktin_recv_tmo

2016-03-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Usage and implementation are simpler without the wait parameter. I think it’s better to keep these two versions separate: one that never calls any system calls, and one that may use system calls to check time and sleep. The no_wait option is handy if application needs to swap between wait X nsec

[lng-odp] [Bug 2129] New: CID 158774 CID 158775: Error handling issues: odp_system_info.c:

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2129 Bug ID: 2129 Summary: CID 158774 CID 158775: Error handling issues: odp_system_info.c: Product: OpenDataPlane - linux- generic reference Version: 1.8 Hardware: Other

Re: [lng-odp] [PATCHv3] linux-generic:release memory during session destory

2016-03-19 Thread Maxim Uvarov
changes are ok, but patch should match code style. Please fix and add Bala's review to next version. perl ./scripts/checkpatch.pl 0001-linux-generic-release-memory-during-session-destory.patch WARNING: 'destory' may be misspelled - perhaps 'destroy'? #4: Subject: [PATCH] linux-generic:release

[lng-odp] [Bug 1547] Untested API copy_md_to_packet

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1547 Mike Holmes changed: What|Removed |Added Assignee|alexandru.badicioiu@linaro. |balakrishna.garapati@linaro |o

[lng-odp] [PATCH] test: l2fwd: change destination mac addresses by default

2016-03-19 Thread Matias Elo
With the previous default settings only the source addresses of forwarded packets were changed. This caused forwarded packets' destination and source addresses being the same when only one interface was used. Fix this by changing the destination mac addresses by default. This change has negligible

[lng-odp] [Bug 2090] example/timer/odp_timer_test.c

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2090 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

[lng-odp] [API-NEXT PATCH 2/3] linux-generic: pktio: fix pktin_recv_mq_tmo wait time drift

2016-03-19 Thread Petri Savolainen
Aligned pktin_recv_mq_tmo and pktin_recv_tmo implementations. Original mq_tmo implementation drifts wait time since the nanosleep takes longer than one microsecond. Signed-off-by: Petri Savolainen Suggested-by: Juha-Matti Tilli --- platform/linux-generic/odp_packet_io.c | 30 +++

[lng-odp] [API-NEXT PATCH] api: pktio: add odp_pktin_recv_tmo

2016-03-19 Thread Petri Savolainen
Added single queue recv function with timeout. In a simple configuration each thread polls a single input queue. Timeout version of single queue receive allows thread to sleep when there are no packets. odp_pktin_recv_mq_tmo would be unnecessary complex to use for single input queue. Signed-off-by

[lng-odp] [PATCH v2 1/2] linux-generic: packet_flags: use accessors to modify eth and l2 flag

2016-03-19 Thread Zoltan Kiss
This makes it possible for other implementations like ODP-DPDK to reuse classification code while using a different packet API. Signed-off-by: Zoltan Kiss --- platform/linux-generic/include/odp_classification_inlines.h | 2 +- platform/linux-generic/include/odp_packet_internal.h| 10 +++

Re: [lng-odp] [API-NEXT PATCH 1/2] api: sched: add schedule group info struct

2016-03-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Wednesday, March 02, 2016 1:59 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 1/2] api: sched: add schedule group info struct For this series: Reviewed-and-te

Re: [lng-odp] [PATCH 1/3] linux-generic: netmap: handle case where all rx/tx rings cannot be stored

2016-03-19 Thread Elo, Matias (Nokia - FI/Espoo)
Ping. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Matias > Elo > Sent: Wednesday, March 09, 2016 8:38 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH 1/3] linux-generic: netmap: handle case where all > rx/tx > rings cann

Re: [lng-odp] [PATCH] test: l2fwd: change destination mac addresses by default

2016-03-19 Thread Maxim Uvarov
Merged, Maxim. On 03/17/16 11:18, Savolainen, Petri (Nokia - FI/Espoo) wrote: Reviewed-by: Petri Savolainen We saw a NIC to drop all outgoing packets which have the NIC MAC address as the destination address (which is the right thing to do). This change avoids that to happen (by default). -

[lng-odp] [Bug 2120] CID 158534: Memory - illegal accesses odp_traffic_mngr.c

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2120 Mike Holmes changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org|bill.fischo...@linaro.org -- You are receiving

[lng-odp] [PATCHv2] scripts: add builddpdk

2016-03-19 Thread Maxim Uvarov
Add script to quickly build odp with dpdk pktio support. Signed-off-by: Maxim Uvarov --- v2: - make target pass thought env; - use vars in 2 more palaces - use pushd/popd .gitignore| 1 + scripts/builddpdk | 26 ++ 2 files changed, 27 insertions(+) c

Re: [lng-odp] Questions about ODP installation

2016-03-19 Thread Mike Holmes
On 15 March 2016 at 11:41, Tilli, Juha-Matti (Nokia - FI/Espoo) < juha-matti.ti...@nokia.com> wrote: > Hello, > > Now that ODP contains most of the previously missing features I’ve wanted > and I’ve learned how to use it, I’m about to take ODP into use in my > application. I installed it to a cust

Re: [lng-odp] Accesing hardware time stamps

2016-03-19 Thread Ivan Khoronzhuk
On 18.03.16 10:50, Savolainen, Petri (Nokia - FI/Espoo) wrote: Hi, Not yet, but going to do that soon. Do you need also an API for reading (sampling) the packet input HW timestamp from the interface? For example, rte_eth_timesync_read_rx_timestamp does that. I was going to add (first) only

[lng-odp] Change in lng/odp[master]: validation: timer: don't access non-existing timers

2016-03-19 Thread lava-bot (Code Review)
lava-bot has posted comments on this change. Change subject: validation: timer: don't access non-existing timers .. Patch Set 1: Code-Review-1 "Build Failed https://ci.linaro.org/jenkins/job/odp-api-check-gerrit/3/ : [OUTPUT]

[lng-odp] [Bug 2102] make distcheck does not inherit original options

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2102 Mike Holmes changed: What|Removed |Added CC||mike.hol...@linaro.org Status|UNCONF

Re: [lng-odp] [API-NEXT PATCHv2 4/4] api: spinlock: change rc for spinlock_trylock to match other trylock APIs

2016-03-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Bill Fischofer > Sent: Saturday, March 05, 2016 10:11 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCHv2 4/4] api: spinlock: change rc for

Re: [lng-odp] [PATCHv4] linux-generic:release memory during session destroy

2016-03-19 Thread Maxim Uvarov
Merged On 03/18/16 12:33, balakrishna.garapati wrote: v2:Added the whitespace after if. v3:link to the bug that this patch resolves. https://bugs.linaro.org/show_bug.cgi?id=2127 v4:formating fixes this changes has to be Signed-off-by: balakrishna.garapati Reviewed-by: Balasubramanian Ma

Re: [lng-odp] [PATCHv2] scripts: add builddpdk

2016-03-19 Thread Mike Holmes
On 18 March 2016 at 10:47, Maxim Uvarov wrote: > On 03/18/16 17:25, Mike Holmes wrote: > >> >> >> On 18 March 2016 at 10:16, Maxim Uvarov > maxim.uva...@linaro.org>> wrote: >> >> Add script to quickly build odp with dpdk pktio support. >> >> Signed-off-by: Maxim Uvarov >

Re: [lng-odp] [PATCH] test: l2fwd: change destination mac addresses by default

2016-03-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen We saw a NIC to drop all outgoing packets which have the NIC MAC address as the destination address (which is the right thing to do). This change avoids that to happen (by default). -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@list

Re: [lng-odp] [PATCH] scripts: add builddpdk

2016-03-19 Thread Maxim Uvarov
On 03/18/16 16:38, Nikolay Nikolaev wrote: On Fri, Mar 18, 2016 at 1:59 PM, Maxim Uvarov wrote: Add script to quickly build odp with dpdk pktio support. Signed-off-by: Maxim Uvarov --- .gitignore| 1 + scripts/builddpdk | 26 ++ 2 files changed, 27 inserti

Re: [lng-odp] [PATCH v2 5/6] linux-generic: dpdk: pass ODP_PLATFORM_PARAMS environment variable to dpdk init

2016-03-19 Thread Maxim Uvarov
On 03/09/16 16:34, Matias Elo wrote: Pass ODP_PLATFORM_PARAMS environment variable to rte_eal_init(). This can be used to pass DPDK only configuration options from command line. E.g. configuring vdev interfaces. Signed-off-by: Matias Elo --- platform/linux-generic/pktio/dpdk.c | 11 --

[lng-odp] [Bug 2129] CID 158774 CID 158775: Error handling issues: odp_system_info.c:

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2129 Mike Holmes changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org|maxim.uva...@linaro.org -- You are receiving th

Re: [lng-odp] [PATCH] linux-generic: dpdk: add packet classification support

2016-03-19 Thread Elo, Matias (Nokia - FI/Espoo)
Ping. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Matias > Elo > Sent: Friday, March 11, 2016 2:48 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH] linux-generic: dpdk: add packet classification > support > > Add packet

Re: [lng-odp] [API-NEXT PATCH] api: pktio: add odp_pktin_recv_tmo

2016-03-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Oops... sent out this too early. I'm going to add couple of patches into this set in a while. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Petri Savolainen > Sent: Thursday, March 17, 2016 4:07 PM > To: lng-odp@lists.linaro.org > Subj

Re: [lng-odp] [PATCH] validation: timer: replace %d by PRIu32

2016-03-19 Thread Maxim Uvarov
Merged, Maxim. On 03/02/16 16:20, Mike Holmes wrote: On 25 February 2016 at 05:31, Maxim Uvarov > wrote: On 02/23/16 18:47, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin mailto:nmo...@kalray.eu>> Reviewed-by: Mike H

Re: [lng-odp] [PATCHv2 0/2] cleanly destroy resources

2016-03-19 Thread Maxim Uvarov
Merged, Maxim. On 03/02/16 16:13, Bill Fischofer wrote: For this series: Reviewed-by: Bill Fischofer > On Tue, Mar 1, 2016 at 9:52 AM, Maxim Uvarov > wrote: ping. Please review. (Should be simple run and see that the

[lng-odp] Change in lng/odp[master]: validation: timer: don't access non-existing timers

2016-03-19 Thread Maxim Uvarov (Code Review)
Maxim Uvarov has uploaded a new change for review. https://review.linaro.org/10969 Change subject: validation: timer: don't access non-existing timers .. validation: timer: don't access non-existing timers Since e5c85d3f "val

[lng-odp] [PATCH] Provide a path to retrieves the output queues from its odp_pktout_queue_t.

2016-03-19 Thread José Pekkarinen
This change propose a path to retrieve the list of out queues associated to an odp_pktout_queue_t. This enables ofp to retrieve the context of the queues associated to the odp_pktout_queue_t in question, being able to store and retrieve the interface structures on it to use it on demand. Signed-of

[lng-odp] [Bug 2133] New: linux-generic dpdk pktio clang warnings

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2133 Bug ID: 2133 Summary: linux-generic dpdk pktio clang warnings Product: OpenDataPlane - linux- generic reference Version: 1.8 Hardware: Other OS: Linux Status: UNCONFIRMED

[lng-odp] [API-NEXT PATCH 1/3] api: pktio: add odp_pktin_recv_tmo

2016-03-19 Thread Petri Savolainen
Added single queue recv function with timeout. In a simple configuration each thread polls a single input queue. Timeout version of single queue receive allows thread to sleep when there are no packets. odp_pktin_recv_mq_tmo would be unnecessary complex to use for single input queue. Signed-off-by

Re: [lng-odp] [PATCH v1 0/2] Build ODP-DPDK on arm/arm64

2016-03-19 Thread Mike Holmes
Hi Nikolay, you need to send these to lng-odp-dpdk. Thanks Mike On 16 March 2016 at 01:44, Nikolay Nikolaev < n.nikol...@virtualopensystems.com> wrote: > This series enable the compilation of the ODP-DPDK on > the arm platforms. There are two problems fixed: > - deciding when to use -msse4.2 >

Re: [lng-odp] [PATCHv3] linux-generic:release memory during session destory

2016-03-19 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 15 March 2016 at 18:39, balakrishna.garapati < balakrishna.garap...@linaro.org> wrote: > Signed-off-by: balakrishna.garapati > --- > platform/linux-generic/odp_crypto.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/platform/linux-generic/o

Re: [lng-odp] [PATCH] linux-generic: dpdk: add packet classification support

2016-03-19 Thread Elo, Matias (Nokia - FI/Espoo)
Thanks, Matias From: EXT Bala Manoharan [mailto:bala.manoha...@linaro.org] Sent: Friday, March 18, 2016 12:37 PM To: Elo, Matias (Nokia - FI/Espoo) Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH] linux-generic: dpdk: add packet classification support Reviewed-by: Balasubramanian Man

[lng-odp] [PATCH 03/11] rename libodp to libodp-linux

2016-03-19 Thread Anders Roxell
Signed-off-by: Anders Roxell --- configure.ac | 2 +- example/Makefile.inc | 2 +- helper/test/Makefile.am | 4 ++-- pkg/debian/control| 14 +++---

Re: [lng-odp] [PATCH 1/2] linux-generic: packet_flags: use accessors to modify eth and l2 flag

2016-03-19 Thread Savolainen, Petri (Nokia - FI/Espoo)
Agree, it's confusing if internal functions have odp_ prefix. You could name those packet_hdr_has_l2(), etc which is intuitive since input is odp_packet_hdr_t. odp_packet_internal.h has also other packet_ or packet_hdr_ prefixed functions. -Petri > -Original Message- > From: lng-odp

Re: [lng-odp] [PATCHv2] scripts: add builddpdk

2016-03-19 Thread Maxim Uvarov
On 03/18/16 17:25, Mike Holmes wrote: On 18 March 2016 at 10:16, Maxim Uvarov > wrote: Add script to quickly build odp with dpdk pktio support. Signed-off-by: Maxim Uvarov mailto:maxim.uva...@linaro.org>> --- v2: - make target pass thought env

[lng-odp] Change in lng/odp[master]: validation: timer: don't access non-existing timers

2016-03-19 Thread lava-bot (Code Review)
lava-bot has posted comments on this change. Change subject: validation: timer: don't access non-existing timers .. Patch Set 1: "Build Started https://ci.linaro.org/jenkins/job/odp-api-check-gerrit/3/ " -- To view, visit htt

Re: [lng-odp] [PATCH] validation: timer: don't access non-existing timers

2016-03-19 Thread Zoltan Kiss
Note, this is just a resend with a different set of CC recipients On 18/03/16 17:25, Zoltan Kiss wrote: Since e5c85d3f "validation: timer: handle early exhaustion of pool" the workers can handle if object caches retain packets, but with enough threads it can happen that a late starting thread wo

[lng-odp] [Bug 2131] New: Traffic Manager introduced valgrind failures

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2131 Bug ID: 2131 Summary: Traffic Manager introduced valgrind failures Product: OpenDataPlane - linux- generic reference Version: 1.8 Hardware: Other OS: Linux Status: UNCONF

[lng-odp] [Bug 2122] CID 158533: Integer handling issues odp_timer_wheel.c

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2122 Mike Holmes changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org|bala.manoha...@linaro.org -- You are receiving

Re: [lng-odp] [PATCH 2/2] linux-generic: packet: don't look for L2 header if there isn't any

2016-03-19 Thread Zoltan Kiss
Ping, added Bill On 11/03/16 07:03, Zoltan Kiss wrote: Ping On 03/03/16 03:05, Zoltan Kiss wrote: The L2 offset functions should consider the L2 flag: return negative answer if there isn't any, and implicitly set it when offset is set. E.g. user created packets don't have L2 headers immediatel

[lng-odp] [Bug 2103] netmap is not tested under CI

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2103 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[lng-odp] [PATCH 02/11] configure: default test-helper to disabled

2016-03-19 Thread Anders Roxell
Make all checking conform to the principle that it is off by default Signed-off-by: Anders Roxell --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6ad1bfc..989ef13 100644 --- a/configure.ac +++ b/configure.ac @@ -172,7 +172,7

[lng-odp] [PATCH] validation: timer: don't access non-existing timers

2016-03-19 Thread Zoltan Kiss
Since e5c85d3f "validation: timer: handle early exhaustion of pool" the workers can handle if object caches retain packets, but with enough threads it can happen that a late starting thread won't be able to allocate any. This for loop should take that into account and not trying to access tt[0].ev.

[lng-odp] [PATCH 08/11] pkg/debian/rules: make sure every package is stripped by default

2016-03-19 Thread Anders Roxell
Signed-off-by: Anders Roxell --- pkg/debian/rules | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/debian/rules b/pkg/debian/rules index 4f7a057..663bcdd 100755 --- a/pkg/debian/rules +++ b/pkg/debian/rules @@ -20,3 +20,4 @@ override_dh_auto_configure: override_dh_strip: dh_strip

[lng-odp] [Bug 2127] memory leak in odp_crypto

2016-03-19 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2127 --- Comment #1 from Krishna Garapati --- The fallowing patch has been sent for this and been reviewed, http://patches.opendataplane.org/patch/5283/ -- You are receiving this mail because: You are the assignee for the bug.

[lng-odp] [PATCH] validation: pktio: add more debug log to pktio_pkt_seq()

2016-03-19 Thread Zoltan Kiss
Signed-off-by: Zoltan Kiss --- test/validation/pktio/pktio.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index 9443cd2..cb403a6 100644 --- a/test/validation/pktio/pktio.c +++ b/test/v

[lng-odp] [PATCHv4] linux-generic:release memory during session destroy

2016-03-19 Thread balakrishna.garapati
v2:Added the whitespace after if. v3:link to the bug that this patch resolves. https://bugs.linaro.org/show_bug.cgi?id=2127 v4:formating fixes Signed-off-by: balakrishna.garapati Reviewed-by: Balasubramanian Manoharan --- platform/linux-generic/odp_crypto.c | 2 ++ 1 file changed, 2 insertio