[lng-odp] [PATCHv5 1/2] scripts: add builddpdk

Add script to quickly build odp with dpdk pktio support. Signed-off-by: Maxim Uvarov --- .gitignore | 1 + scripts/build-pktio-dpdk | 34 ++ 2 files changed, 35 insertions(+) create mode 100755 scripts/build-pktio-dpdk diff --git a/.gitignore b/.g

[lng-odp] [PATCHv5 2/2] DEPENDENCIES: take a note about scripts/build-pktio-dpdk

Signed-off-by: Maxim Uvarov --- DEPENDENCIES | 35 +-- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/DEPENDENCIES b/DEPENDENCIES index 9fee177..e2eae38 100644 --- a/DEPENDENCIES +++ b/DEPENDENCIES @@ -76,7 +76,7 @@ Prerequisites for building the Op

[lng-odp] [PATCHv5 0/2] scripts: add builddpdk

v5: - in one more place changed x86-... to ${TARGET}. v4: - make it possible to run sript from different locations; - add check for installed pcap; Maxim Uvarov (2): scripts: add builddpdk DEPENDENCIES: take a note about scripts/build-pktio-dpdk .gitignore | 1 + DEPENDENC

Re: [lng-odp] [API-NEXT PATCHv2 2/4] api: cpu: add routines for obtaining socket ids

Can you suggest a reasonable terminology to use for Monarch? The consensus at BKK was that while we won't have a complete NUMA story until Tiger Moth, we did want to have some basic vocabulary in place for Monarch that we can build on. Remaining completely silent on NUMA would seem to put ODP imple

Re: [lng-odp] [API-NEXT PATCH 1/6] api: pktio: add config options for pktin timestamping

Similar to the previous PktIO patches, these new APIs also need CUnit tests. With that caveat, for this series: Reviewed-and-tested-by: Bill Fischofer On Thu, Mar 24, 2016 at 9:49 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Added API calls and definitions for pktio interface le

Re: [lng-odp] [API-NEXT PATCHv2 4/4] validation: thread: add numa validation funciton tests

These tests were modeled after some of the other tests for CPU APIs which basically just confirm that an implementation for them exists. Since ODP doesn't stipulate what these must return I'm not sure what more we can do. I suppose an identify test for odp_cpu_socket_id() == odp_cpu_socket_id_cpu(

Re: [lng-odp] [API-NEXT PATCHv2 4/4] validation: thread: add numa validation funciton tests

On 23 March 2016 at 18:19, Bill Fischofer wrote: > Add basic touch tests for odp_cpu_socket_id() and odp_cpu_socket_id_cpu() > Do we gain anything except loosing the reminder from LCOV that this needs testing if we apply this patch, it does not look like it makes many assertions on the behaviour

Re: [lng-odp] [PATCHv3 1/2] scripts: add builddpdk

On Thu, Mar 24, 2016 at 6:34 PM, Mike Holmes wrote: SNIP > > ... --- .gitignore | 1 + scripts/build-pktio-dpdk | 26 ++ 2 files changed, 27 insertions(+)

Re: [lng-odp] [PATCHv3 1/2] scripts: add builddpdk

> > SNIP >>> >> ... > --- >>> .gitignore | 1 + >>> scripts/build-pktio-dpdk | 26 ++ >>> 2 files changed, 27 insertions(+) >>> create mode 100755 scripts/build-pktio-dpdk >>> >>>

Re: [lng-odp] time test

It's also running too long time. The test should have one test case that runs about 5 sec (to test potential 32 bit nanosec counter wrap around ==> about 4 sec), all other test cases should be must shorter. Now the test halts 'make check' for a half a minute or so. -Petri > -Original Messa

[lng-odp] [API-NEXT PATCH 1/6] api: pktio: add config options for pktin timestamping

Added API calls and definitions for pktio interface level configuration options. Timestamping is one of those options. Added definitions to query and enable packet input timestamping. Packet timestamps are stored in odp_time_t, direct nanoseconds calls can be added later if needed. Timestamp HW res

[lng-odp] [API-NEXT PATCH 4/6] api: pktio: add classifier enable pktin_queue_param

Added explicit classifier enable option for pktin event queues. Hashing and classification cannot be enabled at the same time. Pktin_queue_config may create target queues for classification or application may create those later. Signed-off-by: Petri Savolainen --- include/odp/api/spec/packet_io.

[lng-odp] [API-NEXT PATCH 3/6] api: pktio: pktio_open accepts NULL as default parameters

Application is simplified as it does not have to call odp_pktio_param_init for default settings. Signed-off-by: Petri Savolainen --- include/odp/api/spec/packet_io.h | 5 - platform/linux-generic/odp_packet_io.c | 6 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a

Re: [lng-odp] [API-NEXT PATCHv2 2/4] api: cpu: add routines for obtaining socket ids

Hi, As I mentioned in BKK, I think we should not hurry to add a simple socket ID API. CPU/cache/accelerator topology inside SoCs may include already multiple hierarchy levels. CPUs may be clustered and each cluster may have its own set of accelerators. Instead, we should choose terminology fo

[lng-odp] [API-NEXT PATCH 5/6] api: pktio: add checksum offload options

Added options for selecting IP/UDP/TCP/SCTP checksum offload on packet input and output. Packets with input checksum failure are either dropped or reported with packet_has_l3/l4_error flags. Signed-off-by: Petri Savolainen --- include/odp/api/spec/packet_io.h | 66 +++

[lng-odp] [API-NEXT PATCH 6/6] linux-generic: pktio: add pktio_config implementation

Added dummy implementation, which does not support any config options. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_packet_io.c | 36 ++ 1 file changed, 36 insertions(+) diff --git a/platform/linux-generic/odp_packet_io.c b/platform/linux-gener

[lng-odp] [API-NEXT PATCH 2/6] api: pktio: include correct header files

Spec headers should include odp/api/xxx.h files and not other spec header, which contain partial definitions (miss platform specific definitions). Signed-off-by: Petri Savolainen --- include/odp/api/spec/packet_io.h | 4 ++-- platform/linux-generic/Makefile.am

[lng-odp] [Bug 2121] CID 158532: Integer handling issues odp_classification_basic.c

https://bugs.linaro.org/show_bug.cgi?id=2121 Bala Manoharan changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[lng-odp] [Bug 1547] Untested API copy_md_to_packet

https://bugs.linaro.org/show_bug.cgi?id=1547 Mike Holmes changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[lng-odp] [Bug 2026] ar: `u' modifier ignored since `D' is the default (see `U')

https://bugs.linaro.org/show_bug.cgi?id=2026 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0

[lng-odp] [Bug 2033] odp_cpuinfo_parser() causes segfault on systems where cpu speed info is missing in sysinfo->model_str

https://bugs.linaro.org/show_bug.cgi?id=2033 Mike Holmes changed: What|Removed |Added Resolution|--- |DUPLICATE Status|IN_PROGRESS

Re: [lng-odp] [PATCH] linux-generic: make x86 cpuinfo parser more robust

please review. Maxim. On 02/25/16 12:52, hongbo.zh...@linaro.org wrote: From: Hongbo Zhang This is for https://bugs.linaro.org/show_bug.cgi?id=2033 If the model string doesn't include speed info, segfault should be avoided. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/x86/

[lng-odp] [Bug 2076] Scheduler validation suite Fails in CI

https://bugs.linaro.org/show_bug.cgi?id=2076 Mike Holmes changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|---

[lng-odp] [Bug 2103] netmap is not tested under CI

https://bugs.linaro.org/show_bug.cgi?id=2103 --- Comment #2 from Mike Holmes --- Looks like it need netmap option to be enabled and run in check-odp -- You are receiving this mail because: You are the assignee for the bug.___ lng-odp mailing list lng-

[lng-odp] time test

I think that our time test case is buggy but it's not clear how it's better to fix it. CI just generated error, which I can not reproduce. Test: time_test_wait_ns ...1..2..3..4..5..FAILED 1. ../../../../test/validation/time/time.c:373 - odp_time_cmp(diff, upper_limit) <= 0 Looks like

Re: [lng-odp] [PATCHv3 1/2] scripts: add builddpdk

On 23 March 2016 at 15:10, Maxim Uvarov wrote: > On 03/23/16 21:39, Mike Holmes wrote: > >> >> >> On 23 March 2016 at 14:30, Mike Holmes > mike.hol...@linaro.org>> wrote: >> >> >> >> On 23 March 2016 at 13:22, Nikolay Nikolaev >> > > wrote: >>

Re: [lng-odp] [API-NEXT PATCHv2 2/4] api: cpu: add routines for obtaining socket ids

Thanks, Jerin. So is an odp_cpu_socket_id() function not interesting to you and odp_pktio_socket_id() is what's wanted/needed? Or are you saying we should have both? On Thu, Mar 24, 2016 at 2:32 AM, Jerin Jacob wrote: > On Thu, Mar 24, 2016 at 01:46:44AM +0200, Nikolay Nikolaev wrote: > > On T

Re: [lng-odp] [API-NEXT PATCHv2 3/4] linux-generic: pool: implement numa socket functions

#defines are untyped so it's just 0x. I picked -1 because that's the value DPDK uses. It can be changed if others would prefer that. On Thu, Mar 24, 2016 at 3:55 AM, Maxim Uvarov wrote: > On 03/24/16 01:19, Bill Fischofer wrote: > >> Add default numa socket support including the functio

[lng-odp] [PATCHv4 2/2] DEPENDENCIES: take a note about scripts/build-pktio-dpdk

Signed-off-by: Maxim Uvarov --- DEPENDENCIES | 35 +-- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/DEPENDENCIES b/DEPENDENCIES index 9fee177..e2eae38 100644 --- a/DEPENDENCIES +++ b/DEPENDENCIES @@ -76,7 +76,7 @@ Prerequisites for building the Op

[lng-odp] [PATCHv4 1/2] scripts: add builddpdk

Add script to quickly build odp with dpdk pktio support. Signed-off-by: Maxim Uvarov --- .gitignore | 1 + scripts/build-pktio-dpdk | 34 ++ 2 files changed, 35 insertions(+) create mode 100755 scripts/build-pktio-dpdk diff --git a/.gitignore b/.g

[lng-odp] [PATCHv4 0/2] scripts: add builddpdk

v4: - make it possible to run sript from different locations; - add check for installed pcap; Maxim Uvarov (2): scripts: add builddpdk DEPENDENCIES: take a note about scripts/build-pktio-dpdk .gitignore | 1 + DEPENDENCIES | 35 +

Re: [lng-odp] [API-NEXT PATCHv2 3/4] linux-generic: pool: implement numa socket functions

On 03/24/16 01:19, Bill Fischofer wrote: Add default numa socket support including the functions odp_cpu_socket_id() and odp_cpu_socket_id_cpu() Signed-off-by: Bill Fischofer --- platform/linux-generic/include/odp/api/plat/pool_types.h | 2 ++ platform/linux-generic/odp_pool.c

Re: [lng-odp] [API-NEXT PATCH v2 1/3] api: pktio: add odp_pktin_recv_tmo

Merged, Maxim. On 03/23/16 13:56, Bill Fischofer wrote: Just to amplify Mike's point about the validation tests. The way ODP implementations say they are Monarch compliant is if they pass the Monarch API validation tests. That's why these tests much validate every public API since without tha

Re: [lng-odp] [API-NEXT PATCHv2 2/4] api: cpu: add routines for obtaining socket ids

On Thu, Mar 24, 2016 at 01:46:44AM +0200, Nikolay Nikolaev wrote: > On Thu, Mar 24, 2016 at 12:19 AM, Bill Fischofer > wrote: > > > > Add odp_cpu_socket_id() and odp_cpu_socket_id_cpu() routines > > I wonder how those are going to be implemented on non-NUMA systems > like ThunderX? I think you m