[lng-odp] [PATCH] pkgconfig: use main ODP version

pkgconfig version string to follow the main odp version, instead of the git snapshot string since pkg-config/lib consumers are concerned with the real upstream version. Signed-off-by: Anders Roxell --- configure.ac | 2 ++ pkgconfig/libodp-linux.pc.in | 2 +- pkgconfi

Re: [lng-odp] [PATCH 00/11] cleanup debian builds

Merged, Maxim. On 03/23/16 22:55, Ricardo Salveti wrote: On Fri, Mar 18, 2016 at 9:59 AM, Anders Roxell wrote: Hi, A few patches to cleanup the debian package build. Cheers, Anders Anders Roxell (11): pkg/debian/control: add graphviz to Build-Depends configure: default test-helper to

Re: [lng-odp] [PATCH v3 5/6] linux-generic: dpdk: pass ODP_PKTIO_DPDK_PARAMS environment variable to dpdk init

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim > Uvarov > Sent: Friday, March 25, 2016 3:45 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH v3 5/6] linux-generic: dpdk: pass > ODP_PKTIO_DPDK_PARAMS environment variable

[lng-odp] [Bug 2137] CID 158531: Missing break in switch: odp_crypto.c

https://bugs.linaro.org/show_bug.cgi?id=2137 Krishna Garapati changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[lng-odp] [Bug 2141] test/performance/odp_crypto valgrind uninitialised value

https://bugs.linaro.org/show_bug.cgi?id=2141 Krishna Garapati changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [lng-odp] [API-NEXT PATCHv2 2/4] api: cpu: add routines for obtaining socket ids

We can discuss this during tomorrow's ODP call. Jerin, can you join us for that? 15:00 UTC. Thanks. On Mon, Mar 28, 2016 at 11:26 AM, Jerin Jacob < jerin.ja...@caviumnetworks.com> wrote: > On Mon, Mar 28, 2016 at 06:41:29PM +0300, Maxim Uvarov wrote: > > Jerin, do you thin that we need both?

Re: [lng-odp] [API-NEXT PATCH 5/6] api: pktio: add checksum offload options

On 28 March 2016 at 19:14, Bill Fischofer wrote: > > > On Mon, Mar 28, 2016 at 5:25 AM, Bala Manoharan > wrote: > >> >> >> Regards, >> Bala >> >> On 24 March 2016 at 20:19, Petri Savolainen >> wrote: >> >>> Added options for selecting IP/UDP/TCP/SCTP checksum offload on >>> packet input and out

Re: [lng-odp] [PATCH] test:performance:initialize undefined values

patch was merged, Maxim. On 03/25/16 18:53, Bill Fischofer wrote: On Fri, Mar 25, 2016 at 5:30 AM, Balakrishna Garapati > wrote: Signed-off-by: Balakrishna Garapati mailto:balakrishna.garap...@linaro.org>> Reviewed-by: Bill Fischofer

Re: [lng-odp] [PATCH 1/2] checkpatch.pl: do not require kstrtoint

Ok, Mike thanks, I merged that patch. Please consider only v2 for review. Maxim. On 03/28/16 19:17, Mike Holmes wrote: On 28 March 2016 at 11:23, Maxim Uvarov > wrote: For one line sscanf checkpatch requires kernels kstrtoint helper function. Comment

Re: [lng-odp] [PATCH 1/6] checkpatch.conf add SSCANF_TO_KSTRTO exception

Merged this patch with fix in the comment. Maxim. On 08/25/15 22:58, Mike Holmes wrote: On 25 August 2015 at 14:56, Maxim Uvarov > wrote: On 08/25/15 18:26, Mike Holmes wrote: This is not the kernel, ignore this recommendation Signed-off

Re: [lng-odp] [API-NEXT PATCHv2 2/4] api: cpu: add routines for obtaining socket ids

On Mon, Mar 28, 2016 at 06:41:29PM +0300, Maxim Uvarov wrote: > Jerin, do you thin that we need both? Both are requried. But not sure about invoking odp_pktio_socket_id() before odp_pktio_open is the correct approach or not ?(as mentioed earlier in the mail). How about other devices in the frame

Re: [lng-odp] [PATCH 1/2] checkpatch.pl: do not require kstrtoint

On 28 March 2016 at 11:23, Maxim Uvarov wrote: > For one line sscanf checkpatch requires kernels kstrtoint > helper function. Comment this check out. > I dont think we should patch check-patch, why is this not covered with the .checkpatch.conf ? I sent a patch for disabling this via the normal

[lng-odp] [PATCH 5/5] linux-generic: add support for initial cpumasks

These code changes depend on the addition of control and worker cpumask pointers to the ODP initialization parameters, and implement the change in behavior suggested with that patch. They serve as the 'glue' between the input of the new ODP API initial cpuset

[lng-odp] [PATCH 4/5] api: init: add control/worker cpumasks to init data

Adds pointers to externally supplied cpumasks for control and worker CPUs to the ODP global init data which is passed as an argument to odp_init_global. The intent is to allow an external entity to pass in lists of the CPU resources available to the current ODP application. It is assumed that thes

[lng-odp] [PATCH 3/5] linux-generic: Make cpu detection work with NO_HZ_FULL

sched_getaffinity() and pthread_getaffinity_np() do not return an accurate mask of all CPUs in the machine when the kernel is compiled with NO_HZ_FULL support. See Linaro BUG 2027 for details. https://bugs.linaro.org/show_bug.cgi?id=2027 This code replaces the 'getaffinity' based CPU disc

[lng-odp] [PATCH 1/5] test: correct worker count calculation

During the process of addressing Linaro BUG 2027 which relates to inaccurate reporting of available CPUs by ODP linux-generic when running atop a kernel compiled with NO_HZ_FULL support, a number of instances were encountered in the validation and performance test software where incorrect methods w

[lng-odp] [PATCH 2/5] test: allow more than one control cpu

A second issue was discovered in the validation test code after fixing bug 2027 and creating default cpumasks containing all installed CPUs. See Linaro BUG 2027 for details. https://bugs.linaro.org/show_bug.cgi?id=2027 The cpumask validation test expected exactly one control CPU and retur

[lng-odp] [API-NEXT PATCH V5 0/5] fix BUG 2027 & add init cpumasks

This patch series replaces the patches previously submitted with subjects: ODP API: add control/worker cpumasks to init data -and- linux-generic: add support for initial cpumasks The addition of the ability for ODP to accept control and worker cpumasks from external sources is impacted by the cod

Re: [lng-odp] [API-NEXT PATCHv2 2/4] api: cpu: add routines for obtaining socket ids

Jerin, do you thin that we need both? Maxim. On 03/24/16 14:10, Bill Fischofer wrote: Thanks, Jerin. So is an odp_cpu_socket_id() function not interesting to you and odp_pktio_socket_id() is what's wanted/needed? Or are you saying we should have both? On Thu, Mar 24, 2016 at 2:32 AM, Jeri

[lng-odp] [PATCH] example: packet: add odp_term_global

Add odp_term_global and comment that it will never be called. https://bugs.linaro.org/show_bug.cgi?id=1706 Signed-off-by: Maxim Uvarov --- example/packet/odp_pktio.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/example/packet/odp_pktio.c b/example/packet/odp_pktio.

[lng-odp] [PATCH 2/2] linux-generic: system info: check return codes for sscanf

Check return codes for Coverity issues: https://bugs.linaro.org/show_bug.cgi?id=2129 Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_system_info.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/odp_system_info.c b/platform/linux-ge

[lng-odp] [PATCH 1/2] checkpatch.pl: do not require kstrtoint

For one line sscanf checkpatch requires kernels kstrtoint helper function. Comment this check out. Signed-off-by: Maxim Uvarov --- scripts/checkpatch.pl | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/ch

Re: [lng-odp] [API-NEXT PATCHv2 4/4] validation: thread: add numa validation funciton tests

Ack On 24 March 2016 at 18:06, Bill Fischofer wrote: > These tests were modeled after some of the other tests for CPU APIs which > basically just confirm that an implementation for them exists. Since ODP > doesn't stipulate what these must return I'm not sure what more we can do. > I suppose an

Re: [lng-odp] [PATCH] linux-generic: traffic-manager: fix integer handling issue

+1 on Maxim's suggested changes. On Mon, Mar 28, 2016 at 9:37 AM, Maxim Uvarov wrote: > On 03/28/16 08:28, Balasubramanian Manoharan wrote: > >> Fixes: https://bugs.linaro.org/show_bug.cgi?id=2122 >> >> Signed-off-by: Balasubramanian Manoharan >> --- >> platform/linux-generic/odp_timer_wheel.

Re: [lng-odp] [PATCH] linux-generic: traffic-manager: fix integer handling issue

On 03/28/16 08:28, Balasubramanian Manoharan wrote: Fixes: https://bugs.linaro.org/show_bug.cgi?id=2122 Signed-off-by: Balasubramanian Manoharan --- platform/linux-generic/odp_timer_wheel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_timer

[lng-odp] [Bug 2058] odp_init_local user-doc does not describe the thread type

https://bugs.linaro.org/show_bug.cgi?id=2058 Maxim Uvarov changed: What|Removed |Added CC||maxim.uva...@linaro.org --- Comment #2 from Max

Re: [lng-odp] [PATCHv2] doc: userguide: add thread type description to odp_init_local() discussion

Looks good, Merged! Maxim. On 03/26/16 22:49, Bill Fischofer wrote: Ping. Needs review and merge to resolve bug https://bugs.linaro.org/show_bug.cgi?id=2058 On Tue, Mar 1, 2016 at 2:38 PM, Mike Holmes > wrote: On 1 March 2016 at 15:00, Bill Fischofer

Re: [lng-odp] [PATCH] linux-generic: traffic-manager: fix integer handling issue

On Mon, Mar 28, 2016 at 12:28 AM, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > Fixes: https://bugs.linaro.org/show_bug.cgi?id=2122 > > Signed-off-by: Balasubramanian Manoharan > Reviewed-by: Bill Fischofer > --- > platform/linux-generic/odp_timer_wheel.c | 3 ++- > 1 file

Re: [lng-odp] [API-NEXT PATCH 5/6] api: pktio: add checksum offload options

On Mon, Mar 28, 2016 at 5:25 AM, Bala Manoharan wrote: > > > Regards, > Bala > > On 24 March 2016 at 20:19, Petri Savolainen > wrote: > >> Added options for selecting IP/UDP/TCP/SCTP checksum offload on >> packet input and output. Packets with input checksum failure are >> either dropped or repo

Re: [lng-odp] [PATCH] test:performance:add break statement to switch(opt)

Merged, Maxim. On 03/25/16 20:14, Bill Fischofer wrote: On Fri, Mar 25, 2016 at 11:49 AM, Balakrishna Garapati > wrote: Signed-off-by: Balakrishna Garapati mailto:balakrishna.garap...@linaro.org>> Reviewed-by: Bill Fischofer

[lng-odp] [Bug 2146] CID 159395: Security best practices violations: shmem_linux.c

https://bugs.linaro.org/show_bug.cgi?id=2146 Mike Holmes changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org|christophe.mil...@linaro.or |

[lng-odp] [Bug 2147] CID 159394: Resource leaks: shmem_odp.c

https://bugs.linaro.org/show_bug.cgi?id=2147 Mike Holmes changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org|christophe.mil...@linaro.or |

[lng-odp] [Bug 2148] CID 159393: Error handling issues: shmem_linux.c

https://bugs.linaro.org/show_bug.cgi?id=2148 Mike Holmes changed: What|Removed |Added Summary|CID 159393: Error handling |CID 159393: Error handling |i

[lng-odp] [Bug 2149] CID 159392: Memory - illegal accesses: shmem_linux.c

https://bugs.linaro.org/show_bug.cgi?id=2149 Mike Holmes changed: What|Removed |Added Summary|CID 159392: Memory - |CID 159392: Memory - |illegal

[lng-odp] [Bug 2149] New: CID 159392: Memory - illegal accesses

https://bugs.linaro.org/show_bug.cgi?id=2149 Bug ID: 2149 Summary: CID 159392: Memory - illegal accesses Product: OpenDataPlane - linux- generic reference Version: 1.8 Hardware: Other OS: Linux Status: UNCONFIRMED

[lng-odp] [Bug 2148] New: CID 159393: Error handling issues

https://bugs.linaro.org/show_bug.cgi?id=2148 Bug ID: 2148 Summary: CID 159393: Error handling issues Product: OpenDataPlane - linux- generic reference Version: 1.8 Hardware: Other OS: Linux Status: UNCONFIRMED

[lng-odp] [Bug 2146] New: CID 159395: Security best practices violations: shmem_linux.c

https://bugs.linaro.org/show_bug.cgi?id=2146 Bug ID: 2146 Summary: CID 159395: Security best practices violations: shmem_linux.c Product: OpenDataPlane - linux- generic reference Version: 1.8 Hardware: Other

[lng-odp] [Bug 2147] New: CID 159394: Resource leaks: shmem_odp.c

https://bugs.linaro.org/show_bug.cgi?id=2147 Bug ID: 2147 Summary: CID 159394: Resource leaks: shmem_odp.c Product: OpenDataPlane - linux- generic reference Version: 1.8 Hardware: Other OS: Linux Status: UNCONFIRME

Re: [lng-odp] [API-NEXT PATCH 5/6] api: pktio: add checksum offload options

Regards, Bala On 24 March 2016 at 20:19, Petri Savolainen wrote: > Added options for selecting IP/UDP/TCP/SCTP checksum offload on > packet input and output. Packets with input checksum failure are > either dropped or reported with packet_has_l3/l4_error flags. > > Signed-off-by: Petri Savolaine

Re: [lng-odp] [API-NEXT PATCH 4/6] api: pktio: add classifier enable pktin_queue_param

On 24 March 2016 at 20:19, Petri Savolainen wrote: > Added explicit classifier enable option for pktin event > queues. Hashing and classification cannot be enabled at the > same time. Pktin_queue_config may create target queues for > classification or application may create those later. > > Signe

Re: [lng-odp] [PATCH] linux-generic: tm: reduce byte range to prevent array overflow

Merged, Maxim. On 03/28/16 10:58, Bala Manoharan wrote: Reviewed-by: Balasubramanian Manoharan > Regards, Bala On 27 March 2016 at 01:57, Bill Fischofer > wrote: Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2120 b

Re: [lng-odp] [PATCH] linux-generic: tm: reduce byte range to prevent array overflow

Reviewed-by: Balasubramanian Manoharan Regards, Bala On 27 March 2016 at 01:57, Bill Fischofer wrote: > Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2120 by reducing > the random array guard by one to ensure that at least two bytes of random > data remain before accessing them. > > Sign