Re: [lng-odp] [PATCH] configure: disconnect API version with SO version

2016-03-30 Thread Ricardo Salveti
On Wed, Mar 30, 2016 at 4:38 PM, Anders Roxell wrote: > On 30 March 2016 at 21:26, Ricardo Salveti wrote: >> On Wed, Mar 30, 2016 at 4:08 PM, Anders Roxell >> wrote: >>> We used to force applications to rebuild when a ODP released a new >>> version that changed one of the first two digits. That

Re: [lng-odp] [api-next][PATCH V6 3/5] linux-generic: Make cpu detection work with NO_HZ_FULL

2016-03-30 Thread Bill Fischofer
On Wed, 30 Mar 2016 17:09:54 -0500 "Gary S. Robertson" wrote: > sched_getaffinity() and pthread_getaffinity_np() do not return > an accurate mask of all CPUs in the machine when the kernel > is compiled with NO_HZ_FULL support. > > See Linaro BUG 2027 for details. > https://bugs.linaro.org

[lng-odp] [Bug 2058] odp_init_local user-doc does not describe the thread type

2016-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2058 Bill Fischofer changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[lng-odp] [api-next][PATCH V6 3/5] linux-generic: Make cpu detection work with NO_HZ_FULL

2016-03-30 Thread Gary S. Robertson
sched_getaffinity() and pthread_getaffinity_np() do not return an accurate mask of all CPUs in the machine when the kernel is compiled with NO_HZ_FULL support. See Linaro BUG 2027 for details. https://bugs.linaro.org/show_bug.cgi?id=2027 This code replaces the 'getaffinity' based CPU disc

[lng-odp] [api-next][PATCH V6 5/5] linux-generic: add support for initial cpumasks

2016-03-30 Thread Gary S. Robertson
These code changes depend on the addition of control and worker cpumask pointers to the ODP initialization parameters, and implement the change in behavior suggested with that patch. They serve as the 'glue' between the input of the new ODP API initial cpuset

[lng-odp] [api-next][PATCH V6 4/5] api: init: add control/worker cpumasks to init data

2016-03-30 Thread Gary S. Robertson
Adds pointers to externally supplied cpumasks for control and worker CPUs to the ODP global init data which is passed as an argument to odp_init_global. The intent is to allow an external entity to pass in lists of the CPU resources available to the current ODP application. It is assumed that thes

[lng-odp] [api-next][PATCH V6 2/5] test: allow more than one control cpu

2016-03-30 Thread Gary S. Robertson
A second issue was discovered in the validation test code after fixing bug 2027 and creating default cpumasks containing all installed CPUs. See Linaro BUG 2027 for details. https://bugs.linaro.org/show_bug.cgi?id=2027 The cpumask validation test expected exactly one control CPU and retur

[lng-odp] [api-next][PATCH V6 0/5] fix BUG 2027 & add init cpumasks

2016-03-30 Thread Gary S. Robertson
This patch series replaces the patches previously submitted with subjects: ODP API: add control/worker cpumasks to init data -and- linux-generic: add support for initial cpumasks The addition of the ability for ODP to accept control and worker cpumasks from external sources is impacted by the cod

[lng-odp] [api-next][PATCH V6 1/5] test: correct worker count calculation

2016-03-30 Thread Gary S. Robertson
During the process of addressing Linaro BUG 2027 which relates to inaccurate reporting of available CPUs by ODP linux-generic when running atop a kernel compiled with NO_HZ_FULL support, a number of instances were encountered in the validation and performance test software where incorrect methods w

Re: [lng-odp] [PATCH] linux-generic: sysinfo: handle missing @ sign in CPU model

2016-03-30 Thread Bill Fischofer
On Wed, Mar 30, 2016 at 1:06 AM, Juha-Matti Tilli < juha-matti.ti...@nokia.com> wrote: > Previously, the sysinfo cpuinfo parser assumed that every CPU model has > an @ sign, after which comes the maximum CPU frequency. However, many > environments such as virtualized KVM environments have CPU mode

Re: [lng-odp] [API-NEXT PATCH 3/3] doc: userguide: update pktio section for new modes and apis

2016-03-30 Thread Bill Fischofer
OK, I'll fold that into v2. Thanks. On Wed, Mar 30, 2016 at 2:05 PM, Mike Holmes wrote: > > > On 27 March 2016 at 20:08, Bill Fischofer > wrote: > >> Update the PktIO section of the ODP User Guide to reflect the >> latest changes in PktIO configuration options, modes, and new >> APIs such as t

Re: [lng-odp] [PATCH] configure: disconnect API version with SO version

2016-03-30 Thread Bill Fischofer
This would seem to have the same level of impact as the planned rename of linux-generic to odp-linux. Can we stage this so that it is effective with the official Monarch release since that's our first intended Long Term Stable (LTS) release? On Wed, Mar 30, 2016 at 2:38 PM, Anders Roxell wrote:

Re: [lng-odp] [PATCH] test: run only memcheck

2016-03-30 Thread Anders Roxell
On 30 March 2016 at 21:46, Mike Holmes wrote: > valgrind can run many tools, however they tend to result in the code > never passing currently, start out stabilizing the results for the memory > leek checking first and add more tools later. > > Signed-off-by: Mike Holmes Reviewed-by: Anders Roxe

[lng-odp] [PATCH] test: run only memcheck

2016-03-30 Thread Mike Holmes
valgrind can run many tools, however they tend to result in the code never passing currently, start out stabilizing the results for the memory leek checking first and add more tools later. Signed-off-by: Mike Holmes --- test/Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [lng-odp] [PATCH] configure: disconnect API version with SO version

2016-03-30 Thread Anders Roxell
On 30 March 2016 at 21:26, Ricardo Salveti wrote: > On Wed, Mar 30, 2016 at 4:08 PM, Anders Roxell > wrote: >> We used to force applications to rebuild when a ODP released a new >> version that changed one of the first two digits. That shouldn't be >> needed if we use the SO-verson as it is inte

Re: [lng-odp] [PATCH] configure: disconnect API version with SO version

2016-03-30 Thread Ricardo Salveti
On Wed, Mar 30, 2016 at 4:08 PM, Anders Roxell wrote: > We used to force applications to rebuild when a ODP released a new > version that changed one of the first two digits. That shouldn't be > needed if we use the SO-verson as it is intended to be used. Disconnecting the project version/release

[lng-odp] [PATCH] configure: disconnect API version with SO version

2016-03-30 Thread Anders Roxell
We used to force applications to rebuild when a ODP released a new version that changed one of the first two digits. That shouldn't be needed if we use the SO-verson as it is intended to be used. Signed-off-by: Anders Roxell --- .so_version | 1 + Makefile.am | 2 +- configure.ac |

Re: [lng-odp] [PATCH] pkgconfig: use main ODP version

2016-03-30 Thread Ricardo Salveti
On Tue, Mar 29, 2016 at 3:38 AM, Anders Roxell wrote: > pkgconfig version string to follow the main odp version, instead of the > git snapshot string since pkg-config/lib consumers are concerned with > the real upstream version. > > Signed-off-by: Anders Roxell > --- > configure.ac

[lng-odp] [Bug 2154] ODP fails to build with GCC 5.3 (__DATE__ and __TIME__ macros, preventing reproducible builds)

2016-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2154 --- Comment #1 from Ricardo Salveti --- Using ODP trunk (de4c3d6aba7b0fe2b842ef759a259f1bc74acfc9). -- You are receiving this mail because: You are on the CC list for the bug.___ lng-odp mailing list lng-od

[lng-odp] [Bug 2154] New: ODP fails to build with GCC 5.3 (__DATE__ and __TIME__ macros, preventing reproducible builds)

2016-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2154 Bug ID: 2154 Summary: ODP fails to build with GCC 5.3 (__DATE__ and __TIME__ macros, preventing reproducible builds) Product: OpenDataPlane - linux- generic reference Version: 1.8

Re: [lng-odp] [API-NEXT PATCH 3/3] doc: userguide: update pktio section for new modes and apis

2016-03-30 Thread Mike Holmes
On 27 March 2016 at 20:08, Bill Fischofer wrote: > Update the PktIO section of the ODP User Guide to reflect the > latest changes in PktIO configuration options, modes, and new > APIs such as timeout and multiqueue receive. > > Signed-off-by: Bill Fischofer > --- > doc/users-guide/users-guide-p

[lng-odp] [PATCH 2/2] doc: install docs

2016-03-30 Thread Mike Holmes
Signed-off-by: Mike Holmes --- doc/implementers-guide/Makefile.am | 1 + doc/process-guide/Makefile.am | 2 ++ doc/users-guide/Makefile.am| 1 + 3 files changed, 4 insertions(+) diff --git a/doc/implementers-guide/Makefile.am b/doc/implementers-guide/Makefile.am index ec9f924..4bdb

[lng-odp] [PATCH 1/2] doc: rebuild only when required

2016-03-30 Thread Mike Holmes
Signed-off-by: Mike Holmes --- doc/Makefile.inc | 3 +++ doc/implementers-guide/Makefile.am | 3 +-- doc/process-guide/Makefile.am | 2 -- doc/users-guide/Makefile.am| 3 +-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/Makefile.inc b/doc/Makef

[lng-odp] [Bug 2151] Packet pool runs out of blocks for irregular traffic patterns

2016-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2151 --- Comment #1 from Bill Fischofer --- Thanks, Oriol. I was aware of this exposure but thank you for surfacing it. Can you please post your patch to the ODP mailing list (lng-odp@lists.linaro.org) so that it can be reviewed? Please see http://www.ope

Re: [lng-odp] [PATCH 2/2] linux-generic: system info: check return codes for sscanf

2016-03-30 Thread Mike Holmes
On 28 March 2016 at 11:23, Maxim Uvarov wrote: > Check return codes for Coverity issues: > https://bugs.linaro.org/show_bug.cgi?id=2129 > > Signed-off-by: Maxim Uvarov > Reviewed-by: Mike Holmes > --- > platform/linux-generic/odp_system_info.c | 9 ++--- > 1 file changed, 6 insertions(+

Re: [lng-odp] [API-NEXT PATCHv2 1/2] drv: adding compiler.h

2016-03-30 Thread Maxim Uvarov
Merged, Maxim. On 03/30/16 11:37, Christophe Milard wrote: ping for merge... On 18 February 2016 at 02:25, Bill Fischofer mailto:bill.fischo...@linaro.org>> wrote: For this series: Reviewed-and-tested-by: Bill Fischofer mailto:bill.fischo...@linaro.org>> On Wed, Feb 17, 2016 at

Re: [lng-odp] [PATCHv2 00/10] cleanup configure.ac

2016-03-30 Thread Maxim Uvarov
Merged, Maxim. On 03/30/16 15:50, Mike Holmes wrote: There are a number of whitespace issues in the patches but as discussed they are not in lines of code changed by this work I would prefer that we fixed them so that over time patches get cleaner but this is a nit and does obfuscate the work

Re: [lng-odp] [PATCH] gitignore: add .deb is .tar.gz

2016-03-30 Thread Maxim Uvarov
Merged, Maxim. On 03/29/16 22:31, Bill Fischofer wrote: On Tue, Mar 29, 2016 at 9:52 AM, Maxim Uvarov > wrote: Add generated by builddeb script .deb and .tar.gz files. Signed-off-by: Maxim Uvarov mailto:maxim.uva...@linaro.org>> Reviewed-by: Bill Fi

Re: [lng-odp] [PATCH 2/2] linux-generic: system info: check return codes for sscanf

2016-03-30 Thread Maxim Uvarov
ping, this simple patch needs a review. Maxim. On 03/28/16 18:23, Maxim Uvarov wrote: Check return codes for Coverity issues: https://bugs.linaro.org/show_bug.cgi?id=2129 Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_system_info.c | 9 ++--- 1 file changed, 6 insertions(+)

Re: [lng-odp] [PATCHv2 00/10] cleanup configure.ac

2016-03-30 Thread Mike Holmes
There are a number of whitespace issues in the patches but as discussed they are not in lines of code changed by this work I would prefer that we fixed them so that over time patches get cleaner but this is a nit and does obfuscate the work done vs clean up in some cases For the series Tested-and

Re: [lng-odp] [API-NEXT PATCH 4/6] api: pktio: add classifier enable pktin_queue_param

2016-03-30 Thread Bala Manoharan
On 29 March 2016 at 18:11, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > > *From:* EXT Bala Manoharan [mailto:bala.manoha...@linaro.org] > *Sent:* Monday, March 28, 2016 12:34 PM > *To:* Savolainen, Petri (Nokia - FI/Espoo) > *Cc:* LNG ODP Mailman List > *Subj

[lng-odp] [Bug 2151] New: Packet pool runs out of blocks for irregular traffic patterns

2016-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2151 Bug ID: 2151 Summary: Packet pool runs out of blocks for irregular traffic patterns Product: OpenDataPlane - linux- generic reference Version: 1.8 Hardware: All O

Re: [lng-odp] [API-NEXT PATCH 5/6] api: pktio: add checksum offload options

2016-03-30 Thread Savolainen, Petri (Nokia - FI/Espoo)
/** + * Packet output configuration options bit field + * + * Packet output configuration options listed in a bit field structure. + */ +typedef union odp_pktout_config_opt_t { + /** Option flags */ + struct { + /** Insert IPv4 header checksum on packet output */ +

Re: [lng-odp] [API-NEXT PATCHv2 1/2] drv: adding compiler.h

2016-03-30 Thread Christophe Milard
ping for merge... On 18 February 2016 at 02:25, Bill Fischofer wrote: > For this series: > > Reviewed-and-tested-by: Bill Fischofer > > On Wed, Feb 17, 2016 at 3:32 AM, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> The file is, of course, largely inspired from its equivalent o

[lng-odp] [RFC - Using the existing ODP bulk crypto API for SSl/TLS]

2016-03-30 Thread Barry Spinney
On todays ODP External call, I mentioned a weakness of the existing ODP crypto API for handling SSL/TLS data, because of the lack of a way to specify the Seq Num - which is not in the packet - but must be the first 4 bytes included in the MAC computation. I just wanted to add that there is a p

Re: [lng-odp] [PATCH] linux-generic: dpdk: check hugepage availability before running validation tests

2016-03-30 Thread Elo, Matias (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim > Uvarov > Sent: Tuesday, March 29, 2016 5:11 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH] linux-generic: dpdk: check hugepage > availability > before running valid