Re: [lng-odp] [API-NEXT PATCHv4 00/11] add pktin timestamping support

clang should be more smart of datatypes then gcc: pktio.c:1765:15: error: implicit conversion from enumeration type 'enum odp_pktin_mode_t' to different enumeration type 'txrx_mode_e' [-Werror,-Wenum-conversion] 1, ODP_PKTIN_MODE_DIRECT,

Re: [lng-odp] [API-NEXT PATCH v3 00/11] add pktin timestamping support

Thanks for the rebase and review. The ~10 hour time difference seems to cause some slight synchronization issues. =) -Matias From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Thursday, April 21, 2016 3:17 AM To: Elo, Matias (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: R

[lng-odp] [API-NEXT 3/4] validation: classification: incorporates capability and PMR range

Adds validation suite for classification capability and PMR range functionality. Signed-off-by: Balasubramanian Manoharan --- test/validation/classification/classification.h| 2 - .../classification/odp_classification_basic.c | 24 ++-- .../classification/odp_classification_common.c

[lng-odp] [API-NEXT 4/4] example: classifier: incorporates capability and PMR range

Modifies the classifier example to support classification capability and PMR range funcionality. Signed-off-by: Balasubramanian Manoharan --- example/classifier/odp_classifier.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/example/classifier/odp_classifier

[lng-odp] [API-NEXT 2/4] linux-generic: classification: Implements capability and PMR range

Implements classification capability and PMR range functionality feature. Signed-off-by: Balasubramanian Manoharan --- .../include/odp_classification_datamodel.h | 17 +++- .../include/odp_classification_inlines.h | 24 +++--- platform/linux-generic/odp_classification.c

[lng-odp] [API-NEXT 1/4] api: classification: Adds capability and PMR range

Adds classification capability structure and PMR range functionality. odp_cls_capability_t structure defines system level classification capability. Signed-off-by: Balasubramanian Manoharan --- include/odp/api/spec/classification.h | 134 -- 1 file changed, 112 in

Re: [lng-odp] [API-NEXT PATCH] validation: pktio: add tests for odp_pktin_recv_tmo() and odp_pktin_recv_mq_tmo()

Note: This applies on top of my v4 rebase of Matias' 'add pktin timestamping support' patch set. On Tue, Apr 19, 2016 at 4:18 AM, Matias Elo wrote: > Add validation tests for odp_pktin_recv_tmo() and > odp_pktin_recv_mq_tmo() function. Adds also a new helper > function recv_packets_tmo() for tes

Re: [lng-odp] [API-NEXT PATCH v3 00/11] add pktin timestamping support

Since this was a trivial rebase (due to Maxim applying my odp_pktio_index() patch ahead of yours. I posted a rebased v4 with my Reviewed-and-tested-by add in the interest of time. Maxim: v4 should be OK to merge. Thanks, Matias. On Wed, Apr 20, 2016 at 1:20 AM, Matias Elo wrote: > This patch s

[lng-odp] [API-NEXT PATCHv4 11/11] linux-generic: pktio: add pktin timestamping support

From: Matias Elo Adds packet input timestamping support using odp global time. Also implements odp_pktio_capability() for pktio types still lacking it. Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- platform/linux-generic/pktio/dpdk.c| 49 +- plat

[lng-odp] [API-NEXT PATCHv4 10/11] linux-generic: pktio: add pktin timestamp argument to _odp_packet_cls_enq()

From: Matias Elo _odp_packet_cls_enq() allocates new odp packets internally. Add new packet timestamp argument to enable adding input timestamps to these packets. Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- .../linux-generic/include/odp_packet_io_internal.h | 3 +

[lng-odp] [API-NEXT PATCHv4 08/11] validation: pktio: add pktin timestamping test

From: Matias Elo Add validation test for packet input timestamping. Tests also odp_pktin_ts_res() and odp_pktin_ts_from_ns(). Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- test/validation/pktio/pktio.c | 123 ++ test/validation/pk

[lng-odp] [API-NEXT PATCHv4 09/11] linux-generic: packet: add inline helper function for setting packet timestamp

From: Matias Elo Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- platform/linux-generic/include/odp_packet_internal.h | 8 1 file changed, 8 insertions(+) diff --git a/platform/linux-generic/include/odp_packet_internal.h b/platform/linux-generic/include/odp_pack

[lng-odp] [API-NEXT PATCHv4 07/11] validation: pktio: add pktio config test

From: Matias Elo Add new validation test for odp_pktio_config(). Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- test/validation/pktio/pktio.c | 23 +++ test/validation/pktio/pktio.h | 1 + 2 files changed, 24 insertions(+) diff --git a/test/validati

[lng-odp] [API-NEXT PATCHv4 06/11] validation: pktio: add helper function for creating test packets

From: Matias Elo Add helper function for creating test packets to reduce duplicate code. Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- test/validation/pktio/pktio.c | 134 +++--- 1 file changed, 46 insertions(+), 88 deletions(-) diff

[lng-odp] [API-NEXT PATCHv4 05/11] linux-generic: pktio: implement odp_pktio_config()

From: Matias Elo Add default implementations for odp_pktio_config(). Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- .../linux-generic/include/odp_packet_io_internal.h | 3 +++ platform/linux-generic/odp_packet_io.c | 27 +- platform/linux

[lng-odp] [API-NEXT PATCHv4 04/11] linux-generic: pktio: implement odp_pktin_ts_from_ns()

From: Matias Elo Add default implementations for odp_pktin_ts_from_ns() using odp global time. Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- platform/linux-generic/include/odp_packet_io_internal.h | 1 + platform/linux-generic/odp_packet_io.c | 17

[lng-odp] [API-NEXT PATCHv4 02/11] linux-generic: packet: implement timestamp support

From: Matias Elo Implements support for packet timestamps and adds related validation tests. Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- platform/linux-generic/include/odp_packet_internal.h | 2 ++ platform/linux-generic/odp_packet.c | 15 +++

[lng-odp] [API-NEXT PATCHv4 03/11] linux-generic: pktio: implement odp_pktin_ts_res()

From: Matias Elo Add default implementations for odp_pktin_ts_res() using odp global time. Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- platform/linux-generic/include/odp_packet_io_internal.h | 1 + platform/linux-generic/odp_packet_io.c | 17

[lng-odp] [API-NEXT PATCHv4 01/11] linux-generic: packet: move flow_hash present flag to correct location

From: Matias Elo Move flow_hash present flag to the same location as all the other packet input and protocol flags. Signed-off-by: Matias Elo Reviewed-and-tested-by: Bill Fischofer --- platform/linux-generic/include/odp_packet_internal.h | 3 ++- platform/linux-generic/odp_packet.c

[lng-odp] [API-NEXT PATCHv4 00/11] add pktin timestamping support

This patch set adds initial support for packet input timestamping using odp global time. Set adds also related validation tests. Implemented functions: - odp_packet_ts() - odp_packet_ts_set() - odp_packet_has_ts() - odp_packet_has_ts_clr() - odp_pktin_ts_res

Re: [lng-odp] [API-NEXT PATCH v3 07/11] validation: pktio: add pktio config test

This part also fails to apply: bill@Ubuntu15:~/linaro/matias$ git am --reject ~/Mail/Incoming/Matias/21 Applying: validation: pktio: add pktio config test Checking patch test/validation/pktio/pktio.c... Hunk #1 succeeded at 978 (offset 20 lines). error: while searching for: ODP_TEST_INFO(pktio_tes

Re: [lng-odp] [API-NEXT PATCH v3 03/11] linux-generic: pktio: implement odp_pktin_ts_res()

I'm afraid v3 is still failing to apply. For Part 3 I get this: bill@Ubuntu15:~/linaro/matias$ git am --reject ~/Mail/Incoming/Matias/17 Applying: linux-generic: pktio: implement odp_pktin_ts_res() Checking patch platform/linux-generic/include/odp_packet_io_internal.h... Checking patch platform/l

Re: [lng-odp] [PATCH] configure: default ODP_DEBUG to false

Merged, Maxim. On 04/20/16 18:48, Mike Holmes wrote: Ping to merge On 15 April 2016 at 14:19, Ricardo Salveti > wrote: On Fri, Apr 15, 2016 at 12:55 PM, Mike Holmes mailto:mike.hol...@linaro.org>> wrote: > As we approach a production stable relea

Re: [lng-odp] [API-NEXT PATCHv8] api: make only the API visible

Merged, Maxim. On 04/20/16 19:37, Bill Fischofer wrote: Maxim: can you correct that on merge or would you prefer I sent a v9? On Wed, Apr 20, 2016 at 10:18 AM, Savolainen, Petri (Nokia - FI/Espoo) mailto:petri.savolai...@nokia.com>> wrote: Reviewed-by: Petri Savolainen mailto:petri.savo

Re: [lng-odp] [API-NEXT PATCHv8] api: make only the API visible

On 04/20/16 19:37, Bill Fischofer wrote: Maxim: can you correct that on merge or would you prefer I sent a v9? I will fix. Maxim. On Wed, Apr 20, 2016 at 10:18 AM, Savolainen, Petri (Nokia - FI/Espoo) mailto:petri.savolai...@nokia.com>> wrote: Reviewed-by: Petri Savolainen mailto:petr

Re: [lng-odp] [API-NEXT PATCHv3 1/6] api: pktio: add pktio index conversion API

Merged, Maxim. On 04/16/16 20:55, Bill Fischofer wrote: Add the odp_pktio_index() API to enable applications to convert packet I/O handles to indices for managing user contexts and related associated data. Signed-off-by: Bill Fischofer Reviewed-by: Bogdan Pricope --- include/odp/api/spec/pa

Re: [lng-odp] [API-NEXT PATCH v2 4/4] api: packet: update add_data and rem_data definition

For this part only: On Wed, Apr 20, 2016 at 10:12 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Updated odp_packet_add_data and _rem_data definitions to match > other calls that may or may not move data. The new packet > handle is output through packet handle pointer parameter and >

Re: [lng-odp] [API-NEXT PATCH v2 2/4] api: packet: rename and add copy functions

It would be better if this were in two parts: the first that does the renames to the existing APIs and the second that introduces the new APIs since these are orthogonal changes. On Wed, Apr 20, 2016 at 10:12 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Added packet copy functions:

Re: [lng-odp] [API-NEXT PATCH v2 1/4] api: packet: add packet concat and split

For this part only. On Wed, Apr 20, 2016 at 10:12 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Added odp_packet_concat() and _split(). Two packets may be > concatenated one after another, and split at any offset. This > suites the common use cases of packet reassembly and > fragmen

Re: [lng-odp] [API-NEXT PATCH v2 3/4] api: packet: add data align

On Wed, Apr 20, 2016 at 10:12 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Align an area of packet data (e.g. IP/UDP headers) so that > it is contiguous in memory and starts in a specified > minimum alignment. > > Signed-off-by: Petri Savolainen > --- > include/odp/api/spec/packet

Re: [lng-odp] [API-NEXT PATCHv8] api: make only the API visible

Maxim: can you correct that on merge or would you prefer I sent a v9? On Wed, Apr 20, 2016 at 10:18 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > Reviewed-by: Petri Savolainen > > Couple of "visibiity" typos. > > > > odpapiplatincludedir= $(includedir)/odp/ap

Re: [lng-odp] [PATCH] example: switch: depend test run on configure option

See submitted Fix broken conditional example execution On 20 April 2016 at 12:07, Maxim Uvarov wrote: > If --enable-test-example was not provided 'make check' > should not run this test. > > Signed-off-by: Maxim Uvarov > --- > example/switch/Makefile.am | 2 ++ > 1 file changed, 2 insertions(

[lng-odp] [PATCH] example: switch: depend test run on configure option

If --enable-test-example was not provided 'make check' should not run this test. Signed-off-by: Maxim Uvarov --- example/switch/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/example/switch/Makefile.am b/example/switch/Makefile.am index e18c681..4134bcf 100644 --- a/example/sw

Re: [lng-odp] [PATCH] validation: time: shorten test duration

that patch is not part of current series, please skip it. Other 2 paches are good for review. Maxim. On 04/20/16 19:02, Maxim Uvarov wrote: From: Petri Savolainen Time test duration was almost a minute on a 2.6GHz CPU. Combined local and global time monotonity tests, so that the there is on

[lng-odp] [PATCHv2 2/2] example: packet make check tests

Signed-off-by: Maxim Uvarov --- example/packet/.gitignore | 3 +++ example/packet/Makefile.am | 7 +++ example/packet/pktio_run.sh | 48 example/packet/udp64.pcap | Bin 0 -> 7624 bytes 4 files changed, 58 insertions(+) create mode 10075

[lng-odp] [PATCH] validation: time: shorten test duration

From: Petri Savolainen Time test duration was almost a minute on a 2.6GHz CPU. Combined local and global time monotonity tests, so that the there is only single run of the long wait loop. Shortened wait test time to 3 seconds and long loop into roughly 14 seconds on a 2.6GHz CPU. There should be

[lng-odp] [PATCHv2 1/2] example: packet: add odp_term_global

Add odp_term_global and comment that it will never be called. https://bugs.linaro.org/show_bug.cgi?id=1706 Signed-off-by: Maxim Uvarov --- example/packet/odp_pktio.c | 56 ++ 1 file changed, 42 insertions(+), 14 deletions(-) diff --git a/example/packe

[lng-odp] [PATCHv2 0/2] example: packet: add termination path

v2: - add time to run option and clear termination path; - add make check script to test all example cmd line options; Maxim Uvarov (2): example: packet: add odp_term_global example: packet make check tests example/packet/.gitignore | 3 +++ example/packet/Makefile.am | 7 ++

Re: [lng-odp] [PATCH] configure: default ODP_DEBUG to false

Ping to merge On 15 April 2016 at 14:19, Ricardo Salveti wrote: > On Fri, Apr 15, 2016 at 12:55 PM, Mike Holmes > wrote: > > As we approach a production stable release and we package for > > distribution inclusion, the default debug should be for the majority of > > users to build a performance

Re: [lng-odp] [PATCH v2] configure: Fix broken conditional example execution

Hi Ricardo, is this good for you now, any other reviews ? On 15 April 2016 at 14:36, Mike Holmes wrote: > The configure environment was incorrect and the examples always run with > make check > > Signed-off-by: Mike Holmes > --- > v2 >spelling correction - Ricardo > > configure.ac

Re: [lng-odp] [PATCH] doc: api: do not publish helper apis

Any objections, I will work on having the helpers build their own doc if we agree that the helpers are not part of the ODP API. On 18 April 2016 at 19:29, Mike Holmes wrote: > The helper apis are not part of the odp specification, don't publish them > in > the application user guide for the odp

Re: [lng-odp] [API-NEXT PATCHv8] api: make only the API visible

Reviewed-by: Petri Savolainen Couple of "visibiity" typos. > odpapiplatincludedir= $(includedir)/odp/api/plat > diff --git a/platform/linux-generic/include/odp/api/visibility_begin.h > b/platform/linux-generic/include/odp/api/visibility_begin.h > new file mode 100644 > index 000..9f45948

[lng-odp] [API-NEXT PATCH v2 4/4] api: packet: update add_data and rem_data definition

Updated odp_packet_add_data and _rem_data definitions to match other calls that may or may not move data. The new packet handle is output through packet handle pointer parameter and return codes indicate if old data was moved or not, or if the operation failed. Signed-off-by: Petri Savolainen ---

[lng-odp] [API-NEXT PATCH v2 3/4] api: packet: add data align

Align an area of packet data (e.g. IP/UDP headers) so that it is contiguous in memory and starts in a specified minimum alignment. Signed-off-by: Petri Savolainen --- include/odp/api/spec/packet.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/include/odp

[lng-odp] [API-NEXT PATCH v2 2/4] api: packet: rename and add copy functions

Added packet copy functions: * partial packet copy * data copy data from another packet * data copy within packet * data move within packet (allow overlap) Renamed copydata_in and _out functions, so that "to/from memory" functions are clearly distinctive from the new packet copy functions. Si

[lng-odp] [API-NEXT PATCH v2 1/4] api: packet: add packet concat and split

Added odp_packet_concat() and _split(). Two packets may be concatenated one after another, and split at any offset. This suites the common use cases of packet reassembly and fragmentation. Reassembly is done on complete packets, while fragmentation may be needed on any offset. Signed-off-by: Petri

Re: [lng-odp] [PATCH v2] validation: time: shorten test duration

Merged, Maxim. On 04/19/16 17:44, Ivan Khoronzhuk wrote: On 19.04.16 17:13, Petri Savolainen wrote: Time test duration was almost a minute on a 2.6GHz CPU. Combined local and global time monotonity tests, so that the there is only single run of the long wait loop. Shortened wait test time to 3

Re: [lng-odp] [API-NEXT PATCH 2/3] api: packet: add segment level head and tailroom

On Wed, Apr 20, 2016 at 5:45 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > > *From:* EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] > *Sent:* Tuesday, April 19, 2016 7:55 PM > *To:* Savolainen, Petri (Nokia - FI/Espoo) > *Cc:* LNG ODP Mailman List >

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto capability

ping. Maxim, are you still waiting for any response for the comments on this patch other than petri's explanation provided yesterday ? /Krishna On 18 April 2016 at 14:52, Maxim Uvarov wrote: > On 04/15/16 12:36, Petri Savolainen wrote: > >> Added crypto capability structure and cipher/authentic

Re: [lng-odp] [API-NEXT PATCH 3/3] api: packet: rename and add copy functions

On Wed, Apr 20, 2016 at 6:58 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > > We still need to be very precise about how this operation works when > overlap is present to ensure implementation interoperability. The man page > for memmove() states: > > The me

Re: [lng-odp] [API-NEXT PATCH 3/3] api: packet: rename and add copy functions

We still need to be very precise about how this operation works when overlap is present to ensure implementation interoperability. The man page for memmove() states: The memory areas may overlap: copying takes place as though the bytes in src are first copied into a temporary array that doe

Re: [lng-odp] [API-NEXT PATCH 3/3] api: packet: rename and add copy functions

On Wed, Apr 20, 2016 at 3:15 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > > *From:* EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] > *Sent:* Tuesday, April 19, 2016 9:37 PM > *To:* Savolainen, Petri (Nokia - FI/Espoo) > *Cc:* LNG ODP Mailman List >

Re: [lng-odp] [API-NEXT PATCH 1/3] api: packet: add packet concat and split

I'd still prefer the 2nd parameter of split to be called offset rather than len for consistency, but that has no change on the semantics. On Tue, Apr 19, 2016 at 8:07 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Added odp_packet_concat() and _split(). Two packets may be > concatena

Re: [lng-odp] [API-NEXT PATCHv3 4/6] api: packet: add odp_packet_input_index() api

Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Bill Fischofer > Sent: Saturday, April 16, 2016 8:56 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCHv3 4/6] api: packet: add > odp_packe

Re: [lng-odp] [API-NEXT PATCHv3 1/6] api: pktio: add pktio index conversion API

Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Bill Fischofer > Sent: Saturday, April 16, 2016 8:56 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCHv3 1/6] api: pktio: add pktio index >

Re: [lng-odp] [API-NEXT PATCH 2/3] api: packet: add segment level head and tailroom

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Tuesday, April 19, 2016 7:55 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 2/3] api: packet: add segment level head and tailroom On Tue, Apr 19, 2016 at 10:00 AM,

Re: [lng-odp] [API-NEXT PATCH 3/3] api: packet: rename and add copy functions

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Tuesday, April 19, 2016 9:37 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 3/3] api: packet: rename and add copy functions General comment: These are a lot of new AP

Re: [lng-odp] [API-NEXT PATCH 1/3] api: packet: add packet concat and split

From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Tuesday, April 19, 2016 9:20 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH 1/3] api: packet: add packet concat and split On Tue, Apr 19, 2016 at 8:07 AM, Petri Sav

Re: [lng-odp] odp_cpumask_default_worker() and availability of the returned CPU's

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Ivan Khoronzhuk > Sent: Tuesday, April 19, 2016 6:49 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] odp_cpumask_default_worker() and availability of > the returned CPU's > > >