Re: [lng-odp] [API-NEXT PATCHv5 1/5] linux-generic: packet: Fix number of parsing bugs, some vlan_hdr_t related

2016-04-29 Thread Maxim Uvarov
Merged, Maxim. On 04/29/16 06:35, Bill Fischofer wrote: From: Barry Spinney This patch fixes a bug in parse_ipv6 caused because the IPv6 payload length does not include the IPv6 header and a bug in parse_udp where l4_offset was subtracted from l3_offset instead of the other way around. Also fi

Re: [lng-odp] [API-NEXT PATCHv5 1/5] linux-generic: packet: Fix number of parsing bugs, some vlan_hdr_t related

2016-04-29 Thread Bill Fischofer
Good news. Special thanks to Barry, Mike, and Maxim. On Fri, Apr 29, 2016 at 4:18 AM, Maxim Uvarov wrote: > Merged, > Maxim. > > On 04/29/16 06:35, Bill Fischofer wrote: > >> From: Barry Spinney >> >> This patch fixes a bug in parse_ipv6 caused because the IPv6 payload >> length does not inclu

Re: [lng-odp] [GIT PULL ODPv4] running things in process mode

2016-04-29 Thread Christophe Milard
On 29 April 2016 at 00:48, Brian Brooks wrote: > On 04/28 17:18:36, Christophe Milard wrote: > > Since v3: > > -fixed rebase error (Christophe) > > -rebased > > Thanks for the rebase. test_in_process_mode_v4 merged cleanly into > origin/master and build and tests PASS. > > I've given this a look,

Re: [lng-odp] [PATCH 1/3] linux-generic: classification: release the packet as soon as an error happens

2016-04-29 Thread Zoltan Kiss
On 28/04/16 18:08, Bala Manoharan wrote: On 28 April 2016 at 21:50, Zoltan Kiss mailto:zoltan.k...@linaro.org>> wrote: On 28/04/16 10:29, Bala Manoharan wrote: On 27 April 2016 at 21:43, Zoltan Kiss mailto:zoltan.k...@linaro.org>

[lng-odp] [API-NEXT PATCH] linux-generic: tm: clean up name table during global term processing

2016-04-29 Thread Bill Fischofer
Free all entries in name table during odp_term_global() to avoid memory leaks. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_name_table.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/platform/linux-generic/odp_name_table.c b/platform/linux-generic/odp_name_table.c in

[lng-odp] [Bug 2212] New: Valgrind failure running traffic manager test

2016-04-29 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2212 Bug ID: 2212 Summary: Valgrind failure running traffic manager test Product: OpenDataPlane - linux- generic reference Version: api-next Hardware: Other OS: Linux Status:

[lng-odp] [Bug 2212] Valgrind failure running traffic manager test

2016-04-29 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2212 Bill Fischofer changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org|bill.fischo...@linaro.org -- You are receivi

[lng-odp] [PATCH] configure.ac: remove duplicated line

2016-04-29 Thread Christophe Milard
Removed an instance AM_CONDITIONAL for test_example, as this line was twice in the file. Signed-off-by: Christophe Milard --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index f88c36b..f138031 100644 --- a/configure.ac +++ b/configure.ac @@ -134,7

Re: [lng-odp] [PATCH] configure.ac: remove duplicated line

2016-04-29 Thread Mike Holmes
On 29 April 2016 at 12:12, Christophe Milard wrote: > Removed an instance AM_CONDITIONAL for test_example, as this line was > twice in the file. > > Signed-off-by: Christophe Milard > Assuming Maxim can improve the subject line without a v2 configure.ac: remove duplicated test example configur

Re: [lng-odp] [PATCH] configure.ac: remove duplicated line

2016-04-29 Thread Maxim Uvarov
Merged, Maxim. On 04/29/16 18:24, Mike Holmes wrote: On 29 April 2016 at 12:12, Christophe Milard mailto:christophe.mil...@linaro.org>> wrote: Removed an instance AM_CONDITIONAL for test_example, as this line was twice in the file. Signed-off-by: Christophe Milard mailto:chris

[lng-odp] [PATCH] linux-generic: timer fix odp_timer_pool_create return code

2016-04-29 Thread Maxim Uvarov
Accodring to API return code for fail case is ODP_TIMER_POOL_INVALID and errno set. https://bugs.linaro.org/show_bug.cgi?id=2139 Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_timer

[lng-odp] [PATCHv2] linux-generic: timer fix odp_timer_pool_create return code

2016-04-29 Thread Maxim Uvarov
Accodring to API return code for fail case is ODP_TIMER_POOL_INVALID and errno set event if it's defined to NULL. Also add check on pool alloc that input parameter is not invalid. https://bugs.linaro.org/show_bug.cgi?id=2139 Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_timer.c | 24

[lng-odp] [Bug 2083] Helper tests are missing

2016-04-29 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2083 Mike Holmes changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

[lng-odp] [API-NEXT PATCHv2] helper: chksum add ipv3 and udp fields

2016-04-29 Thread Maxim Uvarov
Chksum routines updated to serarch l4 and udp flags set in the packets. Because there is syntetic allocated packet we need also set required bits. Signed-off-by: Maxim Uvarov --- helper/test/chksum.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/helper/test/chksum.c b/helper/test/chksum.

Re: [lng-odp] [API-NEXT PATCHv2] helper: chksum add ipv3 and udp fields

2016-04-29 Thread Bill Fischofer
On Fri, Apr 29, 2016 at 1:23 PM, Maxim Uvarov wrote: > Chksum routines updated to serarch l4 and udp flags > set in the packets. Because there is syntetic allocated > packet we need also set required bits. > > Signed-off-by: Maxim Uvarov > Reviewed-by: Bill Fischofer > --- > helper/test/chk

Re: [lng-odp] [API-NEXT PATCHv2] helper: chksum add ipv3 and udp fields

2016-04-29 Thread Maxim Uvarov
Merged, Maxim. On 04/29/16 21:25, Bill Fischofer wrote: On Fri, Apr 29, 2016 at 1:23 PM, Maxim Uvarov > wrote: Chksum routines updated to serarch l4 and udp flags set in the packets. Because there is syntetic allocated packet we need also set requi

Re: [lng-odp] [API-NEXT PATCH] linux-generic: tm: clean up name table during global term processing

2016-04-29 Thread Mike Holmes
On 29 April 2016 at 09:36, Bill Fischofer wrote: > Free all entries in name table during odp_term_global() to avoid > memory leaks. > > Signed-off-by: Bill Fischofer > Reviewed-and-tested-by Mike Holmes > --- > platform/linux-generic/odp_name_table.c | 6 ++ > 1 file changed, 6 insertio

Re: [lng-odp] [API-NEXT PATCH] linux-generic: tm: clean up name table during global term processing

2016-04-29 Thread Maxim Uvarov
Merged, Maxim. On 04/29/16 21:29, Mike Holmes wrote: On 29 April 2016 at 09:36, Bill Fischofer > wrote: Free all entries in name table during odp_term_global() to avoid memory leaks. Signed-off-by: Bill Fischofer mailto:bill.fischo...@linaro.org

Re: [lng-odp] [API-NEXT PATCH 2/2] doc: reference odp_pktio_open and don't copy it

2016-04-29 Thread Mike Holmes
On 29 April 2016 at 17:58, Bill Fischofer wrote: > I would be OK with allowing // style comments throughout ODP. It has the > advantage of being able to highlight things > differently that catch the eye. Just have to mix things judiciously. But > it's something we'd have to get agreement on. P

Re: [lng-odp] [API-NEXT PATCH 2/2] doc: reference odp_pktio_open and don't copy it

2016-04-29 Thread Bill Fischofer
I would be OK with allowing // style comments throughout ODP. It has the advantage of being able to highlight things differently that catch the eye. Just have to mix things judiciously. But it's something we'd have to get agreement on. Perhaps this is a sufficient justification for changing our

[lng-odp] [RFC] CHANGELOG FOR v1.10.0.0

2016-04-29 Thread Mike Holmes
All, I took a shot at adding human readable information about the release but not being an area expert there is not that much detail. Please review this patch so that it contains better descriptions. Remember, the automated tools will add full coverage in high detail in addition to this text, for

[lng-odp] [RFC] CHANGELOG: Update for v1.10.0.0

2016-04-29 Thread Mike Holmes
Signed-off-by: Mike Holmes --- CHANGELOG | 49 + 1 file changed, 45 insertions(+), 4 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index d402047..2d772b0 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,10 +1,50 @@ +== OpenDataPlane (1.10.0.0) -

Re: [lng-odp] [GIT PULL ODPv4] running things in process mode

2016-04-29 Thread Brian Brooks
On 04/29 13:29:03, Christophe Milard wrote: > On 29 April 2016 at 00:48, Brian Brooks wrote: > > > On 04/28 17:18:36, Christophe Milard wrote: > > > Since v3: > > > -fixed rebase error (Christophe) > > > -rebased > > > > Thanks for the rebase. test_in_process_mode_v4 merged cleanly into > > origi

Re: [lng-odp] [RFC] CHANGELOG: Update for v1.10.0.0

2016-04-29 Thread Bill Fischofer
This patch doesn't apply to the repo: bill@Ubuntu15:~/linaro/odp-release-notes$ git am --reject ~/Mail/Incoming/Mike/1 Applying: CHANGELOG: Update for v1.10.0.0 Checking patch CHANGELOG... error: CHANGELOG: does not exist in index Patch failed at 0001 CHANGELOG: Update for v1.10.0.0 On Fri, Apr