Re: [lng-odp] [PATCH] doc: userguide: change plus to backtick for asciidoctor

2016-05-05 Thread Mike Holmes
merged On 5 May 2016 at 12:15, Mike Holmes wrote: > > > On 3 May 2016 at 15:28, Bill Fischofer wrote: > >> In asciidoc monospace characters may be indicated by enclosure >> in either backticks or plus signs, however asciidoctor requires >> the use of backticks to indicate monospace. Change all

Re: [lng-odp] [PATCH 1/2] configure: detect ARCH correctly for 32-bit x86 hosts

2016-05-05 Thread Mike Holmes
merged On 4 May 2016 at 12:19, Bill Fischofer wrote: > For this series: > > Reviewed-by: Bill Fischofer > > On Wed, May 4, 2016 at 8:01 AM, Matias Elo wrote: > >> Currently, 32-bit x86 host may end up using linux ARCH as >> the host identifier is not recognized. Fix this by mapping >> i686* to

Re: [lng-odp] [PATCH] doc: userguide: change plus to backtick for asciidoctor

2016-05-05 Thread Mike Holmes
On 3 May 2016 at 15:28, Bill Fischofer wrote: > In asciidoc monospace characters may be indicated by enclosure > in either backticks or plus signs, however asciidoctor requires > the use of backticks to indicate monospace. Change all uses of > plus signs to backticks so that user guide docs can f

[lng-odp] [Bug 2230] New: pktio_run_pcap: fails make check when run with valgrind

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2230 Bug ID: 2230 Summary: pktio_run_pcap: fails make check when run with valgrind Product: OpenDataPlane - linux- generic reference Version: v1.10 Hardware: Other OS

[lng-odp] [Bug 2229] New: pktio_run: blocks are definitely lost

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2229 Bug ID: 2229 Summary: pktio_run: blocks are definitely lost Product: OpenDataPlane - linux- generic reference Version: v1.10 Hardware: Other OS: Linux Status: UNCONFIRME

[lng-odp] [Bug 2227] New: classification_main: Conditional jump or move depends on uninitialised value

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2227 Bug ID: 2227 Summary: classification_main: Conditional jump or move depends on uninitialised value Product: OpenDataPlane - linux- generic reference Version: v1.10 Hardware: Othe

[lng-odp] [Bug 2228] New: ringtest: Conditional jump or move depends on uninitialised value

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2228 Bug ID: 2228 Summary: ringtest: Conditional jump or move depends on uninitialised value Product: OpenDataPlane - linux- generic reference Version: v1.10 Hardware: Other

[lng-odp] [PATCH v2 3/3] linux-generic: pktio: don't return packet after failed enqueue

2016-05-05 Thread Zoltan Kiss
If queue_enq() fails, there is a serious internal error, the packet should be released instead of passing it back to pktin_poll() for enqueueing on an another one. Also return the error if there is any, not just the queue_enq() ones. If CoS drops the packet, doesn't report it as an error Signed-of

[lng-odp] [PATCH v2 2/3] linux-generic: pktio: classification error handling fixes for loop

2016-05-05 Thread Zoltan Kiss
Several minor changes: - remove 'int j' as it no longer has function - add 'int failed' to count errors, and return it (or 0 if no failure) - in_errors counts the packet numbers, not the octets - in_discards the same, count it with 'discarded' - in_ucast_pkts should not count these packets - as a

[lng-odp] [PATCH v2 1/3] linux-generic: classification: release the packet as soon as an error happens

2016-05-05 Thread Zoltan Kiss
Move release to _odp_packet_classifier(), because caller has no way to know if new_pkt were allocated. In that case there would be a double free on pkt, and new_pkt would be leaked. The only exception is when cos == NULL or odp_packet_copy() fails, in that case the packet is reenqued. Signed-off-b

[lng-odp] [PATCH v2 0/3] Fix pktio classification error handling

2016-05-05 Thread Zoltan Kiss
Fixing up things in error handling, and harmonizing different codebases. Zoltan Kiss (3): linux-generic: classification: release the packet as soon as an error happens linux-generic: pktio: classification error handling fixes for loop linux-generic: pktio: don't return packet after faile

Re: [lng-odp] [PATCH] test: packet: remove unused values to address coverity scan issue

2016-05-05 Thread Mike Holmes
We shouldn't mention the tool that found the issue in the subject, future readers of git only want to know what happened. It can be changed on merge to test: packet: remove unused values On 4 May 2016 at 20:21, Bill Fischofer wrote: > Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2220 by

Re: [lng-odp] [PATCHv2] linux-generic: queue: avoid leakage on queue create

2016-05-05 Thread Bill Fischofer
I believe Maxim reviewed it, however perhaps not in this thread. On Thu, May 5, 2016 at 8:02 AM, Mike Holmes wrote: > Does this need a review ? > > On 16 April 2016 at 14:21, Bill Fischofer > wrote: > >> If a scheduled queue is created via odp_queue_create() but is unable >> to be added to the

Re: [lng-odp] [PATCH] linux-generic: init: comment out last local stage to avoid scan issues

2016-05-05 Thread Mike Holmes
merged On 5 May 2016 at 09:03, Mike Holmes wrote: > > > On 7 April 2016 at 08:44, Bill Fischofer > wrote: > >> Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2168 by commenting >> out >> last stage setting in odp_init_local(). This will need to be uncommented >> if further stages are added

Re: [lng-odp] [PATCH] linux-generic: init: comment out last local stage to avoid scan issues

2016-05-05 Thread Mike Holmes
On 7 April 2016 at 08:44, Bill Fischofer wrote: > Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2168 by commenting out > last stage setting in odp_init_local(). This will need to be uncommented > if further stages are added in subsequent updates. > > Signed-off-by: Bill Fischofer > Review

Re: [lng-odp] [PATCHv2] linux-generic: queue: avoid leakage on queue create

2016-05-05 Thread Mike Holmes
Does this need a review ? On 16 April 2016 at 14:21, Bill Fischofer wrote: > If a scheduled queue is created via odp_queue_create() but is unable > to be added to the scheduler queues, free it rather than leaking > resources. > > This resolves Bug https://bugs.linaro.org/show_bug.cgi?id=2186 > >

Re: [lng-odp] [API-NEXT, RFC, 1/1] api: cpu: performance profiling start/stop

2016-05-05 Thread Yi He
Hi, thanks Bill I understand more deeply of ODP thread concept and in embedded app developers are involved in target platform tuning/optimization. Can I have a little example: say we have a data-plane app which includes 3 ODP threads. And would like to install and run it upon 2 platforms. - P

[lng-odp] [Bug 2031] CID 157958: Integer handling issues: timer.c

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2031 Mike Holmes changed: What|Removed |Added Assignee|ivan.khoronz...@linaro.org |bill.fischo...@linaro.org -- You are receiving

[lng-odp] [Bug 2131] Traffic Manager introduced valgrind failures

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2131 Mike Holmes changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|---

[lng-odp] [Bug 2135] CID 158537: : Unused value: odp_crypto.c

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2135 Mike Holmes changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

[lng-odp] [Bug 2212] Valgrind failure running traffic manager test

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2212 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[lng-odp] [Bug 2217] Traffic manager validation tests fail on a 32-bit x86 host

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2217 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Assignee|lng-odp@lists.linaro.org

[lng-odp] [Bug 2220] Coverity: Unused values in packet test

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2220 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[lng-odp] [Bug 2221] IPC maintainability issues identified by coverity

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2221 Mike Holmes changed: What|Removed |Added Ever confirmed|0 |1 CC|

[lng-odp] [Bug 2223] Coverity issues with Monarch RC2 Traffic Manager

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2223 Mike Holmes changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org|bill.fischo...@linaro.org -- You are receiving

[lng-odp] [Bug 2222] Coverity: uninitialized variables

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id= Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC|

[lng-odp] [Bug 2223] Coverity issues with Monarch RC2 Traffic Manager

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2223 Mike Holmes changed: What|Removed |Added CC||mike.hol...@linaro.org Status|UNCONF

[lng-odp] [Bug 2224] Coverity: Negative return

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2224 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC|

[lng-odp] [Bug 2225] Coverity ring test issues

2016-05-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2225 Mike Holmes changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Assignee|lng-odp@lists.linar

Re: [lng-odp] [API-NEXT, RFC, 1/1] api: cpu: performance profiling start/stop

2016-05-05 Thread Bill Fischofer
I've added this to the agenda for Monday's call, however I suggest we continue the dialog here as well as background. Regarding thread pinning, there's always been a tradeoff on that. On the one hand dedicating cores to threads is ideal for scale out in many core systems, however ODP does not req