Re: [lng-odp] [PATCH] doc: user-guide: Improve Crypto section.

On 11 May 2016 at 20:15, Nikhil Agarwal wrote: > From: Nikhil Agarwal > > Signed-off-by: Nikhil Agarwal > --- > doc/users-guide/users-guide.adoc | 81 > +++- > 1 file changed,

[lng-odp] [Bug 2031] CID 157958: Integer handling issues: timer.c

https://bugs.linaro.org/show_bug.cgi?id=2031 --- Comment #3 from Bill Fischofer --- Patch http://patches.opendataplane.org/patch/5992/ posted to address this. -- You are receiving this mail because: You are on the CC list for the

Re: [lng-odp] [PATCH 1/3] test: scheduling: simplify code structure

For this series: Reviewed-and-tested-by: Bill Fischofer On Wed, May 11, 2016 at 7:38 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Recorded queue and pool handles into shared data, so that > multiple lookups (and related name generation code) can be >

Re: [lng-odp] [PATCH] doc: user-guide: Improve Crypto section.

A number of grammatical corrections and suggestions for improvement. On Wed, May 11, 2016 at 9:45 AM, Nikhil Agarwal wrote: > From: Nikhil Agarwal > > Signed-off-by: Nikhil Agarwal > --- >

[lng-odp] [PATCHv3 1/3] doc: images: add packet flow overview image

From: Mike Holmes Signed-off-by: Mike Holmes Signed-off-by: Bill Fischofer --- doc/images/packet_flow.svg | 532 + 1 file changed, 532 insertions(+) create mode 100644

[lng-odp] [PATCHv3 3/3] doc: users-guide: add packet flow overview

From: Mike Holmes Signed-off-by: Mike Holmes Signed-off-by: Bill Fischofer --- doc/users-guide/Makefile.am | 1 + doc/users-guide/users-guide.adoc | 37 ++--- 2 files changed, 31

[lng-odp] [PATCHv3 2/3] doc: users-guide: depend on the images

From: Mike Holmes Signed-off-by: Mike Holmes Signed-off-by: Bill Fischofer --- doc/users-guide/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/users-guide/Makefile.am

Re: [lng-odp] [PATCHv6 00/38] running things in process mode

Reviewed-by: Brian Brooks for the series. On 05/11 18:41:44, Christophe Milard wrote: > Pull can be performed from the URL at the end of this cover letter > All patches sent to the list following Maxim's request. `git merge --squash remote_branch' may be helpful to

[lng-odp] Fedora repo changes

Hi Guys Thought I would use some down time to have a play with ODP. On a vanilla Fedora 23 Server install, there is an issue with the current odp.repo in that the default behaviour of 'def' is to gpg check the downloads. So, following the instructions on the site fails on 'dnf update' as it

Re: [lng-odp] [PATCH] linux-generic: timer: change assert to account for padding

On Wed, May 11, 2016 at 10:21 AM, Maxim Uvarov wrote: > On 05/11/16 00:50, Bill Fischofer wrote: > > >> >> On Tue, May 10, 2016 at 11:19 AM, Maxim Uvarov > > wrote: >> >> Ola, can you please review this patch?

[lng-odp] examples howto

HI, I have been able to successfully install odp on my machine. I wanted to know if you have a any kind of documentation available for the examples directory so that i can understand the use case. i get this error, now sure how to get around this.. use sudo... but then what are the arguments to

[lng-odp] [Bug 2102] make distcheck does not inherit original options

https://bugs.linaro.org/show_bug.cgi?id=2102 Ricardo Salveti changed: What|Removed |Added CC|

[lng-odp] [PATCHv6 32/38] example: timer: using agnostic function for ODP threads

timer_test is changed to use the implementation agnostic ODP thread create and join functions, from helpers. timer_test is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/timer/odp_timer_test.c | 14

Re: [lng-odp] [PATCH v2 2/2] linux-generic: timer: add missing odp_time*_to_u64() functions

patch splitting is also wrong, patch 1 did not build w/o patch 2 Maxim On 05/04/16 18:02, Matias Elo wrote: Add missing odp_timer_pool_to_u64(), odp_timer_to_u64(), and odp_timeout_to_u64() functions. Use the functions in timer validation tests. Signed-off-by: Matias Elo

Re: [lng-odp] [PATCH 1/2] linux-generic: test: improve locating pktio_env

On 11 May 2016 at 10:50, Maxim Uvarov wrote: > On 05/11/16 04:07, Mike Holmes wrote: > >> Rather than limit pktio_env to the current directory, find it on the >> path just as is done with pktio_main >> >> Signed-off-by: Mike Holmes >> --- >>

[lng-odp] [Bug 2102] make distcheck does not inherit original options

https://bugs.linaro.org/show_bug.cgi?id=2102 Maxim Uvarov changed: What|Removed |Added Resolution|FIXED |---

[lng-odp] [PATCHv6 37/38] linux-generic: test: ringtest: adding helper cmd line parsing

ringtests.c now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- platform/linux-generic/test/ring/ringtest.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[lng-odp] [PATCHv6 38/38] doc: implementers-guide: adding helper recommendations

The implementation guide is updated with recommendations regarding the usage of helpers and some of its functions. Signed-off-by: Christophe Milard --- doc/implementers-guide/implementers-guide.adoc | 32 ++ 1 file changed, 32 insertions(+)

[lng-odp] [PATCHv6 36/38] linux-generic: test: ringtest: using agnostic function for ODP threads

ringtest.c is changed to use the implementation agnostic ODP thread create and join functions, from helpers. ringtest is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- platform/linux-generic/test/ring/ringtest.c | 19

[lng-odp] [PATCHv6 34/38] example: switch: using agnostic function for ODP threads

odp_switch is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_switch is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/switch/odp_switch.c | 14

[lng-odp] [PATCHv6 35/38] example: switch: adding helper cmd line parsing

odp_switch now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/switch/odp_switch.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[lng-odp] [PATCHv6 33/38] example: timer: adding helper cmd line parsing

timer_test now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/timer/odp_timer_test.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)

[lng-odp] [PATCHv6 31/38] example: time: adding helper cmd line parsing

time now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/time/time_global_test.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[lng-odp] [PATCHv6 30/38] example: time: using agnostic function for ODP threads

time is changed to use the implementation agnostic ODP thread create and join functions, from helpers. time is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/time/time_global_test.c | 12 ++-- 1 file

[lng-odp] [PATCHv6 29/38] example: pktio: adding helper cmd line parsing

pktio now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/packet/odp_pktio.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[lng-odp] [PATCHv6 28/38] example: pktio: using agnostic function for ODP threads

pktio is changed to use the implementation agnostic ODP thread create and join functions, from helpers. pktio is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/packet/odp_pktio.c | 32

[lng-odp] [PATCHv6 27/38] example: l2fwd_simple: adding helper cmd line parsing

l2fwd_simple now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/l2fwd_simple/odp_l2fwd_simple.c | 32 +++- 1 file changed, 27

[lng-odp] [PATCHv6 26/38] example: l2fwd_simple: using agnostic function for ODP threads

l2fwd_simple is changed to use the implementation agnostic ODP thread create and join functions, from helpers. l2fwd_simple is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/l2fwd_simple/odp_l2fwd_simple.c |

[lng-odp] [PATCHv6 24/38] example: ipsec: using agnostic function for ODP threads

odp_ipsec is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_ipsec is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/ipsec/odp_ipsec.c | 15 +++

[lng-odp] [PATCHv6 25/38] example: ipsec: adding helper cmd line parsing

odp_ipsec now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/ipsec/odp_ipsec.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[lng-odp] [PATCHv6 23/38] example: generator: adding helper cmd line parsing

odp_generator now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/generator/odp_generator.c | 12 +--- 1 file changed, 9 insertions(+), 3

[lng-odp] [PATCHv6 22/38] example: generator: using agnostic function for ODP threads

odp_generator is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_generator is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/generator/odp_generator.c | 33

[lng-odp] [PATCHv6 21/38] example: classifier: adding helper cmd line parsing

odp_classifier now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- example/classifier/odp_classifier.c | 12 +--- 1 file changed, 9 insertions(+), 3

[lng-odp] [PATCHv6 20/38] example: classifier: using agnostic function for ODP threads

odp_classifier is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_classifier is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- example/classifier/odp_classifier.c |

[lng-odp] [PATCHv6 19/38] performance: crypto: adding helper cmd line parsing

odp_crypto now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- test/performance/odp_crypto.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[lng-odp] [PATCHv6 18/38] performance: crypto: using agnostic function for ODP threads

odp_crypto is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_crypto is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- test/performance/odp_crypto.c | 12

[lng-odp] [PATCHv6 17/38] performance: odp_l2fwd: adding helper cmd line parsing

odp_l2fwd now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- test/performance/odp_l2fwd.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[lng-odp] [PATCHv6 16/38] performance: odp_l2fwd: using agnostic function for ODP threads

odp_l2fwd is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_l2fwd is hence no longer aware on how the odpthread is implemented. Signed-off-by: Christophe Milard --- test/performance/odp_l2fwd.c | 25

[lng-odp] [PATCHv6 15/38] performance: odp_pktio_perf: adding helper cmd line parsing

odp_pktio_perf now calls the helper command line parsing so that helper can collect its options. Hence enabling process mode run. Signed-off-by: Christophe Milard --- test/performance/odp_pktio_perf.c | 11 +-- 1 file changed, 9 insertions(+), 2

[lng-odp] [PATCHv6 14/38] performance: odp_pktio_perf: using agnostic function for ODP threads

odp_pktio_perf is changed to use the implementation agnostic ODP thread create and join functions, from helpers. odp_pktio_perf is no longer aware on how the odpthread is implemented any longer. Signed-off-by: Christophe Milard --- test/performance/odp_pktio_perf.c

[lng-odp] [PATCHv6 12/38] helper: parsing the complete set of options

The odph_parse_options() function is given the ability to receive getopt command line description parameter from it caller, hence allowing the caller to have some command line parameter(s). The caller shall first call odph_parse_options() with its own parameter description as parameter.

[lng-odp] [PATCHv6 13/38] performance: odp_scheduling: proc mode done by helper

Remove the --proc option from odp_scheduling.c and use the helper functions (odph_odpthreads_create, odph_odpthreads_join) to handle odp threads. Let helper parse its command line args, hence recognising the --odph_proc option doing what --proc did. Signed-off-by: Christophe Milard

[lng-odp] [PATCHv6 11/38] helper: adding a function to merge getopt parameters

A function merging two sets to getopt parmameters (command line argument description) into one single set is added Signed-off-by: Christophe Milard --- helper/include/odp/helper/linux.h | 42 ++ helper/linux.c| 74

[lng-odp] [PATCHv6 10/38] validation: pktio: adding command line argument parsing

As the test itself does not have specific args, it just calls the cunit_common parsing function to pick up cunit_common and helpers arguments. Signed-off-by: Christophe Milard --- platform/linux-generic/test/pktio/pktio_run| 21 ++---

[lng-odp] [PATCHv6 08/38] validation: most tests: adding command line argument parsing

As the tests themselves do not have specific args, they just call the cunit_common parsing function to pick up cunit_common and helpers arguments. This was originally many patches, now squashed on maintener's request. init and pktio tests are still separated as they have specificities

[lng-odp] [PATCHv6 07/38] validation: using implementation agnostic function for ODP threads

cunit_common is changed to use the implementation agnostic ODP thread create and join functions, from helpers. Tests are no longer aware if an odp thread is a linux process or linux thread under the hood. The helper decides. The function pointer which is passed when creating the odp threads now

[lng-odp] [PATCHv6 06/38] helper: test: adding odpthread functions tests

Simple tests testing odph_odpthreads_create() and odph_odpthreads_join() are added. A single test binary, odpthreads, is added. This program creates odp threads as pthreads or linux processes, dependng on its calling args. Three calling scripts are added to create ODP threads as either processes,

[lng-odp] [PATCHv6 05/38] helpers: linux: creating functions to handle odpthreads

Two functions, odph_odpthreads_create and odph_odpthreads_join are created to create and termindate odp threads. These function will create the odp threads either as linux processes or as linux threads, depending on the command line arguments (flag odph_proc or odph_thread). If both flags are

[lng-odp] [PATCHv6 02/38] validation: common: adding command line argument parsing

A function to parse the command line args is added. This function is meant to parse only arguments altering the behaviour of cunit_common (this includes the helpers args as cunit_common uses the helpers) As at this stage only helper args fall into that category, this function simply calls the

[lng-odp] [PATCHv6 03/38] validation: shmem: adding command line argument parsing

As the test itself does not have specific args, it just calls the cunit_common parsing function to pick up cunit_common and helpers arguments. Signed-off-by: Christophe Milard --- test/validation/shmem/shmem.c | 10 -- test/validation/shmem/shmem.h

[lng-odp] [PATCHv6 01/38] helpers: adding command line argument parsing

A function to parse options meant for the helpers out of a the command line is added. This parse function picks up options altering the behaviour of the helpers out of the command line. Other options are reject. No helper options are definied (yet). Signed-off-by: Christophe Milard

[lng-odp] [PATCHv6 00/38] running things in process mode

Pull can be performed from the URL at the end of this cover letter All patches sent to the list following Maxim's request. Since v5 -rebased -patch removing old unused helper code dropped. (Petri) -Doc update to discourage usage of the old functions. (Petri, Mike) Since v4: -updates following

Re: [lng-odp] [PATCH v2 1/2] linux-generic: timer: use strong typing

this can be simple split on 2 lines: WARNING: line over 80 characters #29: FILE: example/timer/odp_timer_test.c:168: +EXAMPLE_ABORT("Unexpected timeout received (timer %" PRIu64 ", tick %" PRIu64 ")\n", WARNING: line over 80 characters #39: FILE:

Re: [lng-odp] [PATCH] linux-generic: timer: change assert to account for padding

On 05/11/16 00:50, Bill Fischofer wrote: On Tue, May 10, 2016 at 11:19 AM, Maxim Uvarov > wrote: Ola, can you please review this patch? Bill, Bala, I am not sure that this change is correct. There is 2 things:

Re: [lng-odp] [PATCH 1/2] linux-generic: test: improve locating pktio_env

On 05/11/16 04:07, Mike Holmes wrote: Rather than limit pktio_env to the current directory, find it on the path just as is done with pktio_main Signed-off-by: Mike Holmes --- platform/linux-generic/test/pktio/pktio_run | 9 ++--- 1 file changed, 6 insertions(+),

Re: [lng-odp] [API-NEXT PATCH] api: system: specify default huge page size

Merged, Maxim. On 05/11/16 10:41, Savolainen, Petri (Nokia - FI/Espoo) wrote: Reviewed-by: Petri Savolainen > *From:*lng-odp [mailto:lng-odp-boun...@lists.linaro.org] *On Behalf Of *Bill Fischofer *Sent:* Wednesday, May 11,

[lng-odp] [PATCH] doc: user-guide: Improve Crypto section.

From: Nikhil Agarwal Signed-off-by: Nikhil Agarwal --- doc/users-guide/users-guide.adoc | 81 +++- 1 file changed, 63 insertions(+), 18 deletions(-) diff --git a/doc/users-guide/users-guide.adoc

[lng-odp] [PATCHv3 2/2] linux-generic: drop odp_ prefix for internal cpuinfo

A little bit code clean up to drop odp_ prefix from internal things and rename huge_pages to default_huge_pages internal struct. Signed-off-by: Maxim Uvarov --- platform/linux-generic/arch/default/odp_sysinfo_parse.c | 2 +-

[lng-odp] [PATCHv3 0/2] linux-generic: use default huge page size

v3: return uint64_t, fix parser and add debug prints. Maxim Uvarov (2): linux-generic: use default huge page size linux-generic: drop odp_ prefix for internal cpuinfo .../linux-generic/arch/default/odp_sysinfo_parse.c | 2 +- .../linux-generic/arch/mips64/odp_sysinfo_parse.c | 2 +-

[lng-odp] [PATCHv3 1/2] linux-generic: use default huge page size

odp_shm_reserve() relays on huge page size to round up requested size. If 1 Gb pages present than parser takes it first as first alphabetical file name in sysfs. That lead to issue where all allocations wants 1 GB HP. This patch takes system default huge pages which are usually 2Mb, and has to be

[lng-odp] [PATCH 1/3] test: scheduling: simplify code structure

Recorded queue and pool handles into shared data, so that multiple lookups (and related name generation code) can be avoided. Use single function (enqueue_events()) to enqueue events into queues on all test cases. Signed-off-by: Petri Savolainen ---

[lng-odp] [PATCH 3/3] linux-generic: scheduler: avoid starvation

For performance reasons, each thread prefer a set of queues on each priority level, which caused starvation if preferred queues have always some events. Added an offset to priority queue selection which forces threads to look into other priority queues every now and then. Signed-off-by: Petri

[lng-odp] [PATCH 2/3] test: scheduling: add scheduler fairness check

Added fairness check option. When enabled, event count per queue is calculated and printed after test. Signed-off-by: Petri Savolainen --- test/performance/odp_scheduling.c | 103 +++--- 1 file changed, 96 insertions(+), 7 deletions(-)

Re: [lng-odp] Fwd: No huge pages, fall back to normal pages

Hi Maxim, plese make correction in patch, check sscanf with "!= 1" instead "== 1'. if (pos) { *(pos - 1) = '\0'; + if (sscanf(pos, "@ %ld kB", ) != 1) { printf("%s %ld\n", __func__, sz);

Re: [lng-odp] Fwd: No huge pages, fall back to normal pages

please have a look at the log messages of classification example. am seeing huge_size as zero, is it correct ? in "/proc/meminfo" Hugepagesize is 2048 kB. root@ubuntu-15-10:/home/linaro/linaro/odp/example/classifier# ./odp_classifier -i eno1 -m 0 -p

Re: [lng-odp] ODP Addressing Model

On 11 May 2016 at 05:06, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > > *From:* EXT Mike Holmes [mailto:mike.hol...@linaro.org] > *Sent:* Wednesday, May 11, 2016 4:54 AM > *To:* Bill Fischofer > *Cc:* Savolainen, Petri (Nokia -

Re: [lng-odp] [PATCH] linux-generic: use default huge page size

From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim Uvarov Sent: Wednesday, May 11, 2016 11:44 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH] linux-generic: use default huge page size

Re: [lng-odp] ODP Addressing Model

From: EXT Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Wednesday, May 11, 2016 4:54 AM To: Bill Fischofer Cc: Savolainen, Petri (Nokia - FI/Espoo) ; LNG ODP Mailman List Subject: Re: [lng-odp] ODP Addressing

Re: [lng-odp] [PATCH] linux-generic: use default huge page size

On 11 May 2016 at 11:43, Maxim Uvarov wrote: > > > On 11 May 2016 at 10:37, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolai...@nokia.com> wrote: > >> Other option would be to loop though the /sys/kernel/mm/hugepages >> directory and see which size are available

Re: [lng-odp] [PATCH] linux-generic: use default huge page size

On 11 May 2016 at 10:37, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Other option would be to loop though the /sys/kernel/mm/hugepages > directory and see which size are available (nr_hugepages > 0). available 1 Gb page and 1000 2Mb page what is your decision

Re: [lng-odp] [API-NEXT PATCH] api: system: specify default huge page size

Reviewed-by: Petri Savolainen > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill Fischofer Sent: Wednesday, May 11, 2016 1:39 AM To: Maxim Uvarov Cc: LNG ODP Mailman List

Re: [lng-odp] [PATCH] linux-generic: use default huge page size

Other option would be to loop though the /sys/kernel/mm/hugepages directory and see which size are available (nr_hugepages > 0). I'd expect that /sys/kernel/mm/... content is better "standardized" than proc file content. Does all platforms (x86, arm, mips, power, ...) have the same content in

Re: [lng-odp] Fwd: No huge pages, fall back to normal pages

Hi Maxim, To return 2MB we need to change the logic in huge_page_size() (odP-system_info.c)function as below. Do not know about old logic. I do not see huge page allocation error if I change the logic as below. diff --git a/platform/linux-generic/odp_system_info.c